Re: [Wireshark-dev] Remove hf_ variables

2013-08-07 Thread Jakub Zawadzki
On Tue, Jul 30, 2013 at 07:40:21AM +0200, Joerg Mayer wrote: > Can you give a sample diff how a dissector would need to be changed? > Also: What would be the migration plan: All at once or incremental? I wrote some ugly gawk program for hf_ variables. Here is one + some patch for epan: http://www

Re: [Wireshark-dev] Remove hf_ variables

2013-08-07 Thread Jakub Zawadzki
Hi, On Wed, Aug 07, 2013 at 09:57:36AM -0400, Jeff Morriss wrote: > On 07/29/13 16:12, Jakub Zawadzki wrote: > > There's no real need of them, and we can just replace them with > > header_field_info structure. > > Just for completeness one should mention that replacing the hf_ > variables with p

Re: [Wireshark-dev] [Wireshark-commits] rev 51119: /trunk/ /trunk/epan/: addr_resolv.c addr_resolv.h /trunk/ui/gtk/: addr_resolution_dlg.c

2013-08-07 Thread Jeff Morriss
On 08/05/13 11:17, Anders Broman wrote: -Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Jeff Morriss Sent: den 5 augusti 2013 17:14 To: wireshark-dev@wireshark.org Subject: Re: [Wireshark-dev] [Wireshark-commits] re

Re: [Wireshark-dev] rev 50749: /trunk/ /trunk/: CMakeLists.txt

2013-08-07 Thread Alexis La Goutte
On Tue, Jul 23, 2013 at 8:57 PM, Guy Harris wrote: > > On Jul 22, 2013, at 7:00 AM, Alexis La Goutte > wrote: > > > I try also in my Ubunux box (12.04) with clang 3.0 ( Ubuntu clang > version 3.0-6ubuntu3 (tags/RELEASE_30/final) (based on LLVM 3.0) Target: > x86_64-pc-linux-gnu Thread model: pos

Re: [Wireshark-dev] Gently migrating to Git + Gerrit

2013-08-07 Thread Alexis La Goutte
On Tue, Aug 6, 2013 at 2:57 AM, Gerald Combs wrote: > I finally have some time set aside to do more work on the Git migration. > I'm hoping to do the following in the near future: > > Switch code.wireshark.org from gitweb to cgit. > > This isn't strictly necessary but IMHO cgit has a slightly nic

Re: [Wireshark-dev] Remove hf_ variables

2013-08-07 Thread Jeff Morriss
On 07/29/13 16:12, Jakub Zawadzki wrote: Hi, Is anyone attached to hf_ variables? ;) There's no real need of them, and we can just replace them with header_field_info structure. Just for completeness one should mention that replacing the hf_ variables with pointers means that each proto_tree

Re: [Wireshark-dev] addr_resolv.c, transport name resolution appalingly slow.

2013-08-07 Thread Anders Broman
Hi, Another fix needed: Index: epan/addr_resolv.c === --- epan/addr_resolv.c (revision 2122) +++ epan/addr_resolv.c (working copy) @@ -1763,7 +1763,9 @@ if( tp == NULL ) { tp = eth_hash_new_entry(addr, resolve); } else { -

Re: [Wireshark-dev] Fwd: [Wireshark-commits] rev 51173: /trunk/epan/ /trunk/epan/: proto.c -> Use __builtin_ctz for GCC/clang

2013-08-07 Thread Graham Bloice
On 6 August 2013 23:42, Jakub Zawadzki wrote: > On Tue, Aug 06, 2013 at 11:39:11PM +0200, Anders Broman wrote: > > Should we use *_BitScanForward* on Windows? > > http://msdn.microsoft.com/en-us/library/wfd9z0bb%28VS.80%29.aspx > > Sure, if you know how to do it, why not. > Slight caution requi

Re: [Wireshark-dev] Gently migrating to Git + Gerrit

2013-08-07 Thread Graham Bloice
On 6 August 2013 19:11, Gerald Combs wrote: > On 8/6/13 4:18 AM, Bálint Réczey wrote: > > > Currently all the library archives are stored in SVN and if we simply > convert it > > to Git anyone cloning the repository would have to download all the libs > ever > > checked in (unless using git clone