[Wireshark-dev] Handling address resolution

2013-03-25 Thread Anders Broman
Extracted info, and started a new thread as the subject changed. (...) This is partly my fault, resulting from switching to seasonal memory for name resolution in r45511. We call se_free_all() a lot, which means calling host_name_lookup_init() a lot. It might be better to use a different allocato

Re: [Wireshark-dev] BASE_CUSTOM and 64-bit values

2013-03-25 Thread Jeff Morriss
On 03/17/13 11:58, David Arnold wrote: On 14/03/2013, at 10:36 PM, Guy Harris wrote: You could use proto_tree_add_uint64_format_value(). I ended up writing a static void foo_tree_add_timestamp( proto_tree *tree, const int hf, tvbuff_t *tvb, gint

Re: [Wireshark-dev] cleanup_dissection() called both on cf_close and cf_open()

2013-03-25 Thread Evan Huus
On Mon, Mar 25, 2013 at 3:37 PM, Gerald Combs wrote: > On 3/24/13 7:37 AM, Anders Broman wrote: >> Hi, >> Looking into address resolution I found that the hosts file is read >> multiple times partly >> because it's part of cleanup_dissection() which is called both on >> cf_open() and cf_close(). >

Re: [Wireshark-dev] Question for data argument of dissector_try_heuristic

2013-03-25 Thread Guy Harris
On Mar 25, 2013, at 1:57 PM, Roland Knall wrote: > Under Mac OS X some warnings came up, and among them is a repeated > warning about an unused *data parameter for every call to a heuristic > dissector. Or, rather, a repeated warning about an unused *data parameter in every *definition* of a h

[Wireshark-dev] Question for data argument of dissector_try_heuristic

2013-03-25 Thread Roland Knall
Hi Under Mac OS X some warnings came up, and among them is a repeated warning about an unused *data parameter for every call to a heuristic dissector. As I do use the heuristic dissector, but do not use the data argument, I looked up every occurence, where dissection is passed to a heuristic disse

Re: [Wireshark-dev] cleanup_dissection() called both on cf_close and cf_open()

2013-03-25 Thread Gerald Combs
On 3/24/13 7:37 AM, Anders Broman wrote: > Hi, > Looking into address resolution I found that the hosts file is read > multiple times partly > because it's part of cleanup_dissection() which is called both on > cf_open() and cf_close(). > > Should cleanup_dissection() take an argument showing whet