Re: [Wireshark-dev] Editcap link warnings

2013-03-07 Thread Gerald Combs
This didn't work because prior includes (wsgetopt.h in editcap.c and privileges.h in capinfos.c) lock in the export behavior. I checked in your changes in r48170 along with a workaround to reset the export definitions. It's clunkier than I would like but Visual C++ is happier now. On 3/7/13 8:23 A

Re: [Wireshark-dev] Editcap link warnings

2013-03-07 Thread Pascal Quantin
2013/3/7 Gerald Combs > This didn't work because prior includes (wsgetopt.h in editcap.c and > privileges.h in capinfos.c) lock in the export behavior. I checked in > your changes in r48170 along with a workaround to reset the export > definitions. It's clunkier than I would like but Visual C++ i

Re: [Wireshark-dev] Idle Thought - Compiling with C++

2013-03-07 Thread Evan Huus
On Tue, Feb 12, 2013 at 12:01 PM, Evan Huus wrote: > On Mon, Feb 11, 2013 at 12:26 PM, Evan Huus wrote: >> On Mon, Feb 11, 2013 at 11:01 AM, Dirk Jagdmann wrote: >>> To me the biggest advantage of transitioning to a C++ compiler is the >>> availability of std::string and std::list, std::set, std

Re: [Wireshark-dev] Editcap link warnings

2013-03-07 Thread Bálint Réczey
If no one objects I commit those tomorrow. Cheers, Balint 2013/3/7 Bálint Réczey : > I think the attached patches would make it be a bit less hack-ish. > > Cheers, > Balint > > 2013/3/7 Gerald Combs : >> -DENABLE_STATIC instead of -DWS_BUILD_DLL worked on my machine. Checked >> in in r48158. >> >

Re: [Wireshark-dev] Editcap link warnings

2013-03-07 Thread Bálint Réczey
I think the attached patches would make it be a bit less hack-ish. Cheers, Balint 2013/3/7 Gerald Combs : > -DENABLE_STATIC instead of -DWS_BUILD_DLL worked on my machine. Checked > in in r48158. > > On 3/6/13 8:52 AM, Christopher Maynard wrote: >> Pascal Quantin writes: >> >>> Hi all,I added th