Re: [Wireshark-dev] Problems in capture_win_ifnames.c

2012-11-23 Thread Bill Meier
On 11/23/2012 8:16 AM, Gisle Vanem wrote: "Guy Harris" wrote: Checked in (with the checks and #defines moved up a little earlier). Thanks. Works fine now. But I'm curious about why this: #if 0 /* XXX: including config.h causes compilation errors; TBD: why */ #include "config.h" is need

Re: [Wireshark-dev] Problems in capture_win_ifnames.c

2012-11-23 Thread Gisle Vanem
"Guy Harris" wrote: Checked in (with the checks and #defines moved up a little earlier). Thanks. Works fine now. But I'm curious about why this: #if 0 /* XXX: including config.h causes compilation errors; TBD: why */ #include "config.h" is needed. "config.h" should be able to live up ther

Re: [Wireshark-dev] Problems in capture_win_ifnames.c

2012-11-23 Thread Guy Harris
On Nov 22, 2012, at 7:10 PM, Guy Harris wrote: > On Nov 22, 2012, at 1:59 PM, Gisle Vanem wrote: > >> Can this text go somewhere else? > > Can this *code* just parse the stuff inside {} in its existing encoding and > convert it to a GUID without converting to UTF-16 and calling a fancy Windo

Re: [Wireshark-dev] Problems in capture_win_ifnames.c

2012-11-23 Thread Guy Harris
On Nov 22, 2012, at 9:20 AM, Gisle Vanem wrote: > Besides the code seems to need a Vista SDK since 'NETIO_STATUS' here > (Win-XP SP3) is only defined in . Which is not included AFAICS. It is... ...but only if NTDDI_VERSION >= NTDDI_VISTA. > A small fix: Checked in (with the checks and #defi