[Wireshark-dev] Passing NULL to %s format specifiers

2012-08-14 Thread Evan Huus
On Linux and most other operating systems I know of, passing a NULL to a %s format specifier is safe. On Solaris, as it turns out, it isn't [1]. The case in the filed bug is fairly trivial to fix, but I'm wondering if this is something that should be added to the Code Style / Portability section o

Re: [Wireshark-dev] [PATCH] Decode Bluetooth HS 4-way handshake over 802.11 media

2012-08-14 Thread Guy Harris
On Aug 14, 2012, at 12:49 AM, Andrei Emeltchenko wrote: > Hi Joerg, > > On Mon, Aug 06, 2012 at 05:37:35PM +0200, Joerg Mayer wrote: >> Hello, >> >> can you please open a bug at bugs.wireshark.org and attach the patch there? > > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7633 > >> Do

[Wireshark-dev] [Wireshark-commits] rev 44496, 44491, 44490, 44488

2012-08-14 Thread mmann78
I did some "grepping" and converted a bunch of g_ calls to use ep_ and se_ memory. The only true memory leaks were in rev 44491, the rest just had potential (or philosophically shouldn't be using g_ calls), mostly through possible exception handling. Because of this, I'm only scheduling rev 44

Re: [Wireshark-dev] [Wireshark-commits] rev 44485: /trunk/epan/ /trunk/epan/: libwireshark.def

2012-08-14 Thread Guy Harris
On Aug 14, 2012, at 9:32 AM, Graham Bloice wrote: > I did wonder, but someone asked for it. OK, I've asked him in his ask.wireshark.org question why he wants to do that. ___ Sent via:Wireshark-dev mailing list Archives:

Re: [Wireshark-dev] [Wireshark-commits] rev 44485: /trunk/epan/ /trunk/epan/: libwireshark.def

2012-08-14 Thread Graham Bloice
> -Original Message- > From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev- > boun...@wireshark.org] On Behalf Of Guy Harris > Sent: 14 August 2012 17:27 > To: wireshark-dev@wireshark.org > Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 44485: /trunk/epan/ > /trunk/epan/:

Re: [Wireshark-dev] [Wireshark-commits] rev 44485: /trunk/epan/ /trunk/epan/: libwireshark.def

2012-08-14 Thread Guy Harris
On Aug 14, 2012, at 4:24 AM, grah...@wireshark.org wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44485 > > User: grahamb > Date: 2012/08/14 04:24 AM > > Log: > Added proto_tree_free to the libwireshark expoert definitions for use in > plugins What plugin would have

Re: [Wireshark-dev] g_convert_with_iconv as ep_ or se_ function

2012-08-14 Thread Guy Harris
On Aug 14, 2012, at 7:17 AM, mman...@netscape.net wrote: > Would it be possible to make g_convert_with_iconv an ep_ or se_ type function All the protocol string encodings we intend to handle should be given ENC_ values in epan/proto.h and given implementations in tvb_get_ephemeral_string_enc()

Re: [Wireshark-dev] [Wireshark-commits] rev 44480: /trunk/ui/gtk/ /trunk/ui/gtk/: CMakeLists.txt

2012-08-14 Thread Gerald Combs
On 8/14/12 4:30 AM, Joerg Mayer wrote: > On Tue, Aug 14, 2012 at 12:21:55AM +, ger...@wireshark.org wrote: >> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44480 >> >> User: gerald >> Date: 2012/08/13 05:21 PM >> >> Log: >> Comment out -DGDK_DISABLE_DEPRECATED to match confi

[Wireshark-dev] g_convert_with_iconv as ep_ or se_ function

2012-08-14 Thread mmann78
Would it be possible to make g_convert_with_iconv an ep_ or se_ type function or is there something obvious I'm missing if I turned this into an official enhancement request in bugzilla? Could/Would this be related to Wireshark providing better UTF8 support?_

Re: [Wireshark-dev] [Wireshark-commits] rev 44480: /trunk/ui/gtk/ /trunk/ui/gtk/: CMakeLists.txt

2012-08-14 Thread Joerg Mayer
On Tue, Aug 14, 2012 at 12:21:55AM +, ger...@wireshark.org wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44480 > > User: gerald > Date: 2012/08/13 05:21 PM > > Log: > Comment out -DGDK_DISABLE_DEPRECATED to match configure.in. > > Directory: /trunk/ui/gtk/ > Ch

Re: [Wireshark-dev] [PATCH] Decode Bluetooth HS 4-way handshake over 802.11 media

2012-08-14 Thread Andrei Emeltchenko
Hi Joerg, On Mon, Aug 06, 2012 at 05:37:35PM +0200, Joerg Mayer wrote: > Hello, > > can you please open a bug at bugs.wireshark.org and attach the patch there? https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7633 > Does your patch distinguish between an 802.3/LLC/SNAP encapsulated frame > o