Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

On Oct 12, 2011, at 1:16 PM, Guy Harris wrote: > [...elided...] I *might* be inclined to go with ENC_ASCII as the first step > even though it'd require more changes (e.g., to protocols where the encoding > is UTF-8). Or, to put it another way: going with ENC_ASCII is the conservative solution,

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

On Oct 12, 2011, at 12:30 PM, Bill Meier wrote: > I propose to do the following for > the FT_STRING, FT_STRINGZ, FT_UINT_STRING "encoding" parameter: > > Essentially: Specify a character encoding but specify endianness only where > relevant. > > Conversions: > 1. For other than FT_UINT_STRING

Re: [Wireshark-dev] updated patch file for bug 5531

On Oct 7, 2011, at 9:48 AM, Ed Beroset wrote: > Based on the current discussion about the use of the format field for > proto_tree_add_item(), I have once again revised the patch file for Bug 5531 > ( https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5531 ). It has gotten > a lot of votes a

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

On 10/10/2011 2:44 PM, Bill Meier wrote: For FT_STRING..., rather than cluttering up the encoding arg with ENC_NA, I would be sightly inclined to specify endianness only where relevant. For FT_UINT_STRING obviously ENC_[BIG|LITTLE]_... would be needed for all. However, I can understand the app

Re: [Wireshark-dev] [Wireshark-commits] rev 39384: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-pdcp-lte.c

On 10/12/2011 2:20 PM, Bill Meier wrote: On 10/12/2011 1:42 PM, Guy Harris wrote: (Paging LTE experts here) On Oct 12, 2011, at 8:02 AM, wme...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=39384 User: wmeier Date: 2011/10/12 08:02 AM Log: Fix a b

Re: [Wireshark-dev] [Wireshark-commits] rev 39384: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-pdcp-lte.c

On Oct 12, 2011, at 11:22 AM, Martin Mathieson wrote: > Guy, I'm sure to be missing something, No, I am - I missed the offset++. Sorry about that. (I also missed the 0x40 mask in the hf[] item for hf_pdcp_lte_rohc_m.) New code is OK, old code was definitely wrong. __

Re: [Wireshark-dev] [Wireshark-commits] rev 39384: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-pdcp-lte.c

Martin Mathieson skrev 2011-10-12 20:22: On Wed, Oct 12, 2011 at 6:42 PM, Guy Harris > wrote: (Paging LTE experts here) On Oct 12, 2011, at 8:02 AM, wme...@wireshark.org wrote: > http://anonsvn.wireshark.org/vie

Re: [Wireshark-dev] [Wireshark-commits] rev 39384: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-pdcp-lte.c

On Wed, Oct 12, 2011 at 6:42 PM, Guy Harris wrote: > (Paging LTE experts here) > > On Oct 12, 2011, at 8:02 AM, wme...@wireshark.org wrote: > > > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=39384 > > > > User: wmeier > > Date: 2011/10/12 08:02 AM > > > > Log: > > Fix a be

Re: [Wireshark-dev] [Wireshark-commits] rev 39384: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-pdcp-lte.c

On 10/12/2011 1:42 PM, Guy Harris wrote: (Paging LTE experts here) On Oct 12, 2011, at 8:02 AM, wme...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=39384 User: wmeier Date: 2011/10/12 08:02 AM Log: Fix a benign bug: Use correct proto_tree_add_item

Re: [Wireshark-dev] [Wireshark-commits] rev 39384: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-pdcp-lte.c

(Paging LTE experts here) On Oct 12, 2011, at 8:02 AM, wme...@wireshark.org wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=39384 > > User: wmeier > Date: 2011/10/12 08:02 AM > > Log: > Fix a benign bug: Use correct proto_tree_add_item() encoding arg. At least as

Re: [Wireshark-dev] include "tvbuff.h" failed

On Tue, 11 Oct 2011 11:33:56 -0600, Stephen Fisher wrote: On Tue, Oct 11, 2011 at 02:02:48PM +0200, Marcel Haas wrote: > i want to include the tvbuff.h to my code so i can make own tvbs > with tvbuff_t* my code lies at wireshark/epan so as tvbuff.h. > except.h:97: error: expected ‘=’, ‘,’, ‘