Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

On 10/4/2011 2:49 PM, David Young wrote: On Tue, Oct 04, 2011 at 11:38:48AM -0700, Dirk Jagdmann wrote: Sounds like a perfect job for Coccinelle,. Looks like an interesting tool; I'll have to spend a little time reading the documentation. Thanks for the reference

Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c

On 10/4/11 1:11 PM, Jeff Morriss wrote: > Balint Reczey wrote: >> Let's make Python a requirement now. >> I fully support the idea of not keeping generated files in SVN and in >> the release tarball. > > I know it's been a while, but... Any other thoughts/votes on this topic? It's fine with me.

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

On 10/4/2011 4:48 PM, Guy Harris wrote: On Oct 4, 2011, at 10:53 AM, Bill Meier wrote: I propose to use a perl script to automate as much as reasonable the replacement of TRUE/FALSE in the encoding parameter of the proto_tree_add_item() calls in dissectors as follows: First step: For hf[] e

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

On Oct 4, 2011, at 10:53 AM, Bill Meier wrote: > I propose to use a perl script to automate as much as reasonable the > replacement of TRUE/FALSE in the encoding parameter of the > proto_tree_add_item() calls in dissectors as follows: > > First step: > For hf[] entries with type > FT_NONE >

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

On 10/4/2011 1:53 PM, Bill Meier wrote: I propose to use a perl script to automate as much as reasonable the replacement of TRUE/FALSE in the encoding parameter of the proto_tree_add_item() calls in dissectors as follows: First step: For hf[] entries with type FT_NONE FT_BYTES FT_IPV6 FT_IPXNET

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

On 10/4/2011 4:08 PM, Jeff Morriss wrote: I had a fair amount of luck with the (currently not run) checkAPIsCalledWithTvbGetPtr() function in checkAPIs.pl . It definitely is not 100%, but it served my purposes well. It avoids dealing with parenthesis by assuming the only semi-colon it will find

Re: [Wireshark-dev] [Wireshark-commits] rev 38304: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-snmp.c

Balint Reczey wrote: Hi, On 08/05/2011 04:01 AM, Jeff Morriss wrote: On 08/04/2011 07:35 PM, Tony Trinh wrote: Isn't Python also necessary for the Wireshark Python API? (It's disabled by default, unlike the Lua API.) Yes, but here we're talking about whether we have/should have a (hard) requ

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

Dirk Jagdmann wrote: I propose to use a perl script to automate as much as reasonable the replacement of TRUE/FALSE in the encoding parameter of the proto_tree_add_item() calls in dissectors as follows: sounds good, but may be difficult to write. Because you would need to write a parser for C

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

On Oct 4, 2011, at 12:07 PM, Tony Trinh wrote: > In any case, I don't think it ever makes sense to specify "ENC_NA" with an > encoding (e.g., ENC_ASCII | ENC_NA = "Use ASCII encoding" and "Encoding > doesn't apply here"). I would only expect to see ENC_NA on its own, but I > could be wrong.

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

> > One thing I don't quite understand: In a number of the dissectors why do > proto_tree_add_item() encoding parameters for hf items with type FT_STRING > have ENC_ASCII *and* ENC_LITTLE_ENDIAN|ENC_BIG_**ENDIAN ? > Shouldn't this be ENC_ASCII | ENC_NA in this case ? The comment for ENC_NA: /*

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

On 10/4/2011 1:53 PM, Bill Meier wrote: I propose to use a perl script to automate as much as reasonable the replacement of TRUE/FALSE in the encoding parameter of the proto_tree_add_item() calls in dissectors as follows: First step: For hf[] entries with type FT_NONE FT_BYTES FT_IPV6 FT_IPXNET

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

On Tue, Oct 04, 2011 at 11:38:48AM -0700, Dirk Jagdmann wrote: > >I propose to use a perl script to automate as much as reasonable the > >replacement of TRUE/FALSE in the encoding parameter of the > >proto_tree_add_item() calls in dissectors as follows: > > sounds good, but may be difficult to wri

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

On Oct 4, 2011, at 10:53 AM, Bill Meier wrote: > For the next step is it simply a case of replacing the remaining TRUE/FALSE > encoding parameter by ENC_LITTLE_ENDIAN/ENC_BIG_ENDIAN ? Except for FT_STRING, FT_STRINGZ, and FT_UINT_STRING, for which an encoding should also be supplied. Presumab

Re: [Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

I propose to use a perl script to automate as much as reasonable the replacement of TRUE/FALSE in the encoding parameter of the proto_tree_add_item() calls in dissectors as follows: sounds good, but may be difficult to write. Because you would need to write a parser for C function calls in perl

[Wireshark-dev] Replace TRUE/FALSE with proper ENC_* in proto_tree_add_item() using a script.

I propose to use a perl script to automate as much as reasonable the replacement of TRUE/FALSE in the encoding parameter of the proto_tree_add_item() calls in dissectors as follows: First step: For hf[] entries with type FT_NONE FT_BYTES FT_IPV6 FT_IPXNET FT_UID convert the

[Wireshark-dev] Fwd: [Bug 6382] Extensions to Wireshark to support TRILL payloads

niki -- Forwarded message -- From: nikitha m Date: Mon, Oct 3, 2011 at 12:20 PM Subject: Re: [Bug 6382] Extensions to Wireshark to support TRILL payloads To: bugzilla-dae...@wireshark.org Hi all, Sorry for the inconvinience.All these are diff files and not patches. We have at

Re: [Wireshark-dev] Building with libtool /epan

Marcel Haas wrote: Hmm Nope.. the makefile will work without any error but at libwireshark.la "libdir=" is no entry and i guess thats the library so i can not use my functions and now i havent an entry at the .deps file folder I changed it like it was before what i have done is at Makefile.com

Re: [Wireshark-dev] Building with libtool /epan

Hmm Nope.. the makefile will work without any error but at libwireshark.la "libdir=" is no entry and i guess thats the library so i can not use my functions and now i havent an entry at the .deps file folder I changed it like it was before what i have done is at Makefile.common

Re: [Wireshark-dev] Building with libtool /epan

-Original Message- From: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Marcel Haas Sent: den 4 oktober 2011 12:53 To: wireshark-dev@wireshark.org Subject: [Wireshark-dev] Building with libtool /epan > Hey guys.. > > I have written, my own

[Wireshark-dev] Building with libtool /epan

Hey guys.. I have written, my own functions to reassemble split packets. Now I want to include that to wireshark more precisely wireshark/epan. I updated the Makefile.in common .am. If i run ./configure it works. He built me a Makefile and the ./deps file folder. I get a xxx.Plo File with conten