Roland Knall writes:
>
> The fix is correct. Are there any other Coverty hits for openSafety,
> or just the one?
Hi Roland,
There are 6 in total. Besides 1204, there are these 5 more reported:
CID 1215: NULL RETURNS:
In stringToBytes(), strtok() could return NULL at line 418, but the return v
The fix is correct. Are there any other Coverty hits for openSafety,
or just the one?
Regards, Roland
Am 20.09.2011 um 15:53 schrieb Chris Maynard :
> Coverity reports the following in CID 1204 against the OpenSafety dissector:
>
> 1466firstByte = ( tvb_get_guint8(message_tvb, 0) <
Coverity reports the following in CID 1204 against the OpenSafety dissector:
1466firstByte = ( tvb_get_guint8(message_tvb, 0) << 1 );
Event missing_parentheses: !firstByte & 0x40 is always 0 regardless of the
values of its operands (non-specific value). Did you intend to apply '&' to
f
Hello,
im just writeing my first dissector and i have some problems with the
reassembling
My prtocoll contain some fields for Snode =ID ,Packetnumber and total
packets
i get them with
snode =tvb_get_guint8(tvb,offset);offset +=1;
pnum =tvb_get_guint8(tvb,offset);offset +=1;
totalp =tvb_get_gui
