Re: [Wireshark-dev] CaveBear's Ethernet link is dead

2011-08-06 Thread Chris Maynard
Ed Beroset writes: > Joerg Mayer wrote: > http://www.cavebear.com/archive/cavebear/Ethernet/Ethernet.txt > > > > If this file has been static for so long, how about integrating its content > > into our template file? > > That's probably the best idea, and then just have the link as > docum

Re: [Wireshark-dev] CaveBear's Ethernet link is dead

2011-08-06 Thread Ed Beroset
Joerg Mayer wrote: http://www.cavebear.com/archive/cavebear/Ethernet/Ethernet.txt If this file has been static for so long, how about integrating its content into our template file? That's probably the best idea, and then just have the link as documentation. In fact, if anybody's interested

Re: [Wireshark-dev] HAVE_PCAP symbols by build type

2011-08-06 Thread Jaap Keuter
On 6 aug. 2011, at 23:41, Guy Harris wrote: > > On Aug 6, 2011, at 1:50 PM, Joerg Mayer wrote: > >> On Sat, Aug 06, 2011 at 02:37:48AM -0700, Guy Harris wrote: >> >>> The only calls to pcap_findalldevs_ex() are protected by HAVE_PCAP_REMOTE. >>> This may have to be redone when remote capture

Re: [Wireshark-dev] HAVE_PCAP symbols by build type

2011-08-06 Thread Joerg Mayer
On Sat, Aug 06, 2011 at 10:50:04PM +0200, Joerg Mayer wrote: > HAVE_PCAP_OPEN also exists on my system, due to the pcap-remote patches. I set up a git repo that contains the patches for the pcap-remote stuff at git://github.com/jmayer/libpcap.git Ciao Joerg -- Joerg Mayer

Re: [Wireshark-dev] HAVE_PCAP symbols by build type

2011-08-06 Thread Guy Harris
On Aug 6, 2011, at 2:41 PM, Guy Harris wrote: >> dumpcap.c: >> /home/jmayer/work/wireshark/svn/trunk/dumpcap.c: In function >> ‘get_if_capabilities’: >> /home/jmayer/work/wireshark/svn/trunk/dumpcap.c:1015:9: error: unused >> variable ‘status’ >> /home/jmayer/work/wireshark/svn/trunk/du

Re: [Wireshark-dev] HAVE_PCAP symbols by build type

2011-08-06 Thread Guy Harris
On Aug 6, 2011, at 1:50 PM, Joerg Mayer wrote: > On Sat, Aug 06, 2011 at 02:37:48AM -0700, Guy Harris wrote: > >> The only calls to pcap_findalldevs_ex() are protected by HAVE_PCAP_REMOTE. >> This may have to be redone when remote capture support is added to libpcap. > > Yes, and that's why i

Re: [Wireshark-dev] HAVE_PCAP symbols by build type

2011-08-06 Thread Joerg Mayer
Hello Guy, On Sat, Aug 06, 2011 at 02:37:48AM -0700, Guy Harris wrote: > The only calls to pcap_findalldevs_ex() are protected by HAVE_PCAP_REMOTE. > This may have to be redone when remote capture support is added to libpcap. Yes, and that's why it is set on my system, I just didn't add it to c

Re: [Wireshark-dev] Still compile problems with capture_dlg.c

2011-08-06 Thread Michael Tuexen
On Aug 6, 2011, at 9:48 PM, Joerg Mayer wrote: > Hello Michael, > > On Sat, Aug 06, 2011 at 07:39:57PM +0200, Michael Tuexen wrote: >> from what I could see is that the functions (I #if 0 out) are never called. >> I just wanted to keep the code if it turns out that it is needed when >> Irene is w

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-PowerPC

2011-08-06 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.5-PowerPC on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-PowerPC/builds/3391 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-ppc Build Reas

Re: [Wireshark-dev] Still compile problems with capture_dlg.c

2011-08-06 Thread Joerg Mayer
Hello Michael, On Sat, Aug 06, 2011 at 07:39:57PM +0200, Michael Tuexen wrote: > from what I could see is that the functions (I #if 0 out) are never called. > I just wanted to keep the code if it turns out that it is needed when > Irene is working on implementing the suggestions. > I've put an ite

Re: [Wireshark-dev] HAVE_PCAP symbols by build type

2011-08-06 Thread Guy Harris
On Aug 6, 2011, at 1:32 AM, Joerg Mayer wrote: > I've created a small list that shows the HAVE_PCAP... symbols used in > the source code and by build type (configure, cmake, windows). > Looks like we have some inconsistencies, but some of them might be due > to differences in winpcap and libpcap.

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.6-x64

2011-08-06 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.6-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.6-x64/builds/3481 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.6-x64 Build Reason: Bui

Re: [Wireshark-dev] Still compile problems with capture_dlg.c

2011-08-06 Thread Michael Tuexen
On Aug 6, 2011, at 5:42 PM, Joerg Mayer wrote: > On Sat, Aug 06, 2011 at 02:42:00PM +0200, Michael Tuexen wrote: >> No, not a bug in the compiler, a bug in the code. I checked in a fix in >> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=38375 > > Thanks, it is gone now. > >>>

Re: [Wireshark-dev] Still compile problems with capture_dlg.c

2011-08-06 Thread Joerg Mayer
On Sat, Aug 06, 2011 at 02:42:00PM +0200, Michael Tuexen wrote: > No, not a bug in the compiler, a bug in the code. I checked in a fix in > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=38375 Thanks, it is gone now. > > /home/jmayer/work/wireshark/svn/trunk/gtk/capture_dlg.c: A

Re: [Wireshark-dev] CaveBear's Ethernet link is dead

2011-08-06 Thread Joerg Mayer
> > > http://www.cavebear.com/archive/cavebear/Ethernet/Ethernet.txt If this file has been static for so long, how about integrating its content into our template file? Ciao Joerg -- Joerg Mayer We are stuck with technology when what we really want

Re: [Wireshark-dev] CaveBear's Ethernet link is dead

2011-08-06 Thread Chris Maynard
Chris Maynard writes: > Ed Beroset writes: > > > That seems actually to be the last revision. The "current" CaveBear > > link is: > > > > http://www.cavebear.com/archive/cavebear/Ethernet/Ethernet.txt > > ... except that page has the same dead link back to > http://www.cavebear.com/archive/

Re: [Wireshark-dev] CaveBear's Ethernet link is dead

2011-08-06 Thread Chris Maynard
Ed Beroset writes: > That seems actually to be the last revision. The "current" CaveBear > link is: > > http://www.cavebear.com/archive/cavebear/Ethernet/Ethernet.txt ... except that page has the same dead link back to http://www.cavebear.com/archive/cavebear/Ethernet/index.html, which is rea

Re: [Wireshark-dev] Still compile problems with capture_dlg.c

2011-08-06 Thread Michael Tuexen
On Aug 6, 2011, at 12:27 PM, Joerg Mayer wrote: > There are two problems: > 1) Some functions are defined but not used in my configuration. > 2) The else without previous if error. If I #undefine HAVE_PCAP_CREATE, the > compile succeeds. Maybe a compiler bug? > Note: On my Linux system both HAV

Re: [Wireshark-dev] Unusual test in capture_dlg.c

2011-08-06 Thread Michael Tuexen
On Aug 6, 2011, at 12:13 PM, Joerg Mayer wrote: > Hello, > > I have some questions regarding the following code inside the function > select_if_type_cb: > > #if GTK_CHECK_VERSION(2,6,0) > if (new_iftype == num_remote + 4) > #else > if (new_iftype == num_remote + 2) > #endif > > What's

[Wireshark-dev] Still compile problems with capture_dlg.c

2011-08-06 Thread Joerg Mayer
There are two problems: 1) Some functions are defined but not used in my configuration. 2) The else without previous if error. If I #undefine HAVE_PCAP_CREATE, the compile succeeds. Maybe a compiler bug? Note: On my Linux system both HAVE_PCAP_CREATE and HAVE_PCAP_REMOTE are defined. cd /home/j

[Wireshark-dev] Unusual test in capture_dlg.c

2011-08-06 Thread Joerg Mayer
Hello, I have some questions regarding the following code inside the function select_if_type_cb: #if GTK_CHECK_VERSION(2,6,0) if (new_iftype == num_remote + 4) #else if (new_iftype == num_remote + 2) #endif What's the idea behind it? Is the version of 2.6.0 correct? If so, this check

Re: [Wireshark-dev] HAVE_PCAP symbols by build type

2011-08-06 Thread Guy Harris
On Aug 6, 2011, at 1:32 AM, Joerg Mayer wrote: > I've created a small list that shows the HAVE_PCAP... symbols used in > the source code and by build type (configure, cmake, windows). Note: note all the functions checked for by the configure script show up in a grep of HAVE_PCAP in configure.

[Wireshark-dev] buildbot failure in Wireshark (development) on Clang-Code-Analysis

2011-08-06 Thread buildbot-no-reply
The Buildbot has detected a new failure of Clang-Code-Analysis on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Clang-Code-Analysis/builds/324 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: clang-code-analysis

[Wireshark-dev] HAVE_PCAP symbols by build type

2011-08-06 Thread Joerg Mayer
Hello, I've created a small list that shows the HAVE_PCAP... symbols used in the source code and by build type (configure, cmake, windows). Looks like we have some inconsistencies, but some of them might be due to differences in winpcap and libpcap. Anyone willing to take a look? Thanks Joer