Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread Jaap Keuter
On 06/21/2011 07:20 AM, Andreas wrote: Moving some dissectors to be built-in probably make sense, as the ABI wasn't as stable as required to guarantee compatibility with bugfix versions (even in stable branches). Please clarify? Jaap ___

Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread Andreas
Am 21.06.2011 00:27, schrieb Roland Knall: The reason against plugins might be, and I am just guessing here, that everyone is talking about the same dissector if it is built-in. But the plugin could be from a prior installation, or a different wireshark version. I tried to figure out for som

Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread mmann78
Pardon my ignorance on a few of these points, still learning the ropes. I don't mean to incite protocol flame wars, just trying to analyze code. However reading README.plugin I still get the impression that 1. Plugins aren't supported on all platforms. The "Windows only" was just a BIG mist

Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread Ulf Lamping
Am 21.06.2011 00:27, schrieb Roland Knall: Hi There is nothing technically wrong with dissectors being developed as plugins. There might be some technical questions that arise from that fact, if another dissector is using them, but for now, those issues seemed to be dealt with correctly (for ref

Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread Roland Knall
Hi There is nothing technically wrong with dissectors being developed as plugins. There might be some technical questions that arise from that fact, if another dissector is using them, but for now, those issues seemed to be dealt with correctly (for reference see the whole openSAFETY vs. SercosIII

[Wireshark-dev] buildbot failure in Wireshark (development) on Visual-Studio-Code-Analysis

2011-06-20 Thread buildbot-no-reply
The Buildbot has detected a new failure of Visual-Studio-Code-Analysis on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Visual-Studio-Code-Analysis/builds/1071 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: v

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-7-x64

2011-06-20 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-7-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-7-x64/builds/2154 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-7-x64 Build Reason:

Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread Ulf Lamping
Am 20.06.2011 16:29, schrieb mman...@netscape.net: (just added myself to the mailing list so I can include reply history to the topic. This message touches on both Jaap's and Roland's comments) As the (main) author of the PROFINET plugin I may add a few cents ... Excuse me if I'm slightly wron

[Wireshark-dev] buildbot failure in Wireshark (development) on Clang-Code-Analysis

2011-06-20 Thread buildbot-no-reply
The Buildbot has detected a new failure of Clang-Code-Analysis on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Clang-Code-Analysis/builds/216 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: clang-code-analysis

Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread Jaap Keuter
On 06/20/2011 09:47 AM, Roland Knall wrote: Hi Regarding the Profinet dissector. Could you point me towards the discussion, why this specific dissector should stay on as a plug-in? http://www.wireshark.org/lists/wireshark-dev/200902/msg00241.html Besides minor bug-fixes which adapted the dis

Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread Ed Beroset
mman...@netscape.net wrote: > >While I see "grouped protocols" in the current epan\dissector directory, I >thought maybe Profinet could have its own directory off of it if otherwise >'pollutes' the main dissector directory. I just see the plugins directory as >"Windows only", and I don't think

Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread mmann78
(just added myself to the mailing list so I can include reply history to the topic. This message touches on both Jaap's and Roland's comments) Profinet and Ethercat were the 2 protocols I was most looking at to convert to built-ins. Being in the industrial protocol space, they are (could be)

Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Stig Bjørlykke
On Mon, Jun 20, 2011 at 3:20 PM, Graham Bloice wrote: > The current "standard" used for Wireshark releases is VS2008, can you get the > build > machine moved to that? I may have to install a VM. The problem is that I did not intend to use any more time on the windows build issues. With the "fix"

Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Graham Bloice
On 20/06/2011 14:00, Stig Bjørlykke wrote: > On Mon, Jun 20, 2011 at 2:35 PM, Graham Bloice > wrote: >> In what way can't you update your build machine? > It's a production machine, and it's not my table at all. > The build is a "Scheduled Task", all I get is the output. > My main build is for Sol

Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Stig Bjørlykke
On Mon, Jun 20, 2011 at 2:35 PM, Graham Bloice wrote: > In what way can't you update your build machine? It's a production machine, and it's not my table at all. The build is a "Scheduled Task", all I get is the output. My main build is for Solaris and OSX, which I control. > You obviously updat

Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Graham Bloice
On 20/06/2011 13:22, Stig Bjørlykke wrote: > On Mon, Jun 20, 2011 at 2:07 PM, Graham Bloice > wrote: >> I haven't tested it for this specific issue (though I have built Wireshark >> for many years in this way), but I'm pretty positive that if you install a >> newer SDK (use the latest 7.1) and the

Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Stig Bjørlykke
On Mon, Jun 20, 2011 at 2:07 PM, Graham Bloice wrote: > I haven't tested it for this specific issue (though I have built Wireshark > for many years in this way), but I'm pretty positive that if you install a > newer SDK (use the latest 7.1) and then from your command prompt use the > "SetEnv.cmd"

Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Graham Bloice
On 20/06/2011 09:58, Stig Bjørlykke wrote: > On Mon, Apr 4, 2011 at 7:12 PM, wrote: >> Log: >> On Windows, try to use an existing console for our messages. Create one if >> it doesn't exist. > This does not build with MSVC2005, because AttachConsole needs > _WIN32_WINNT 0x0500. > Did we abandon

Re: [Wireshark-dev] [Wireshark-commits] rev 36452: /trunk/gtk/ /trunk/gtk/: main.c

2011-06-20 Thread Stig Bjørlykke
On Mon, Apr 4, 2011 at 7:12 PM, wrote: > Log: >  On Windows, try to use an existing console for our messages. Create one if >  it doesn't exist. This does not build with MSVC2005, because AttachConsole needs _WIN32_WINNT 0x0500. Did we abandon MSVC2005 and older? -- Stig Bjørlykke ___

Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread Roland Knall
Hi Regarding the Profinet dissector. Could you point me towards the discussion, why this specific dissector should stay on as a plug-in? Besides minor bug-fixes which adapted the dissectors to API changes, no significant changes seemed to have happend in over a year. But I think it could benefit

Re: [Wireshark-dev] [Wireshark-commits] rev 37474: /trunk/ /trunk/epan/: Makefile.am /trunk/: Makefile.am.inc abi-descriptor.template /trunk/wiretap/: Makefile.am /trunk/wsutil/: Makefile.am

2011-06-20 Thread Stig Bjørlykke
On Tue, May 31, 2011 at 2:07 PM, wrote: > Log: >  Add dumpabi target to Makefiles in wsutil, epan and wiretap directories. >  We can use the dumped ABI description for comparing ABI changes between > revisions. I have filed bug 6039 for warnings generated after this check-in. https://bugs.wires

Re: [Wireshark-dev] [Wireshark-commits] rev 35992: /trunk/epan/ /trunk/epan/: except.c

2011-06-20 Thread Stig Bjørlykke
On Fri, Feb 18, 2011 at 12:36 AM, wrote: > Log: >  config.h is now included, and it defines _WIN32_WINNT. This broke building with MSVC2005 (and older), as IsDebuggerPresent() needs this define. If we remove support for older compilers we should remove the configuration options from config.nmak

Re: [Wireshark-dev] plugins to builtins

2011-06-20 Thread Jaap Keuter
Hi, Technically there is no real reason to have both build in and plugin style dissectors. The reason they're there is more of an Ethereal origin... (pun intended). A little history first. When Wireshark 1.0 came out it had 29 plugin directories. They came into existence when dissector contr