Re: [Wireshark-dev] Familiar with gtk/sctp_graph_dlg.c?

2011-04-25 Thread Guy Harris
On Apr 25, 2011, at 3:01 PM, Michael Tüxen wrote: > dup_list = (guint32 *)((char *)sack_header + 16 + (nr * sizeof(struct gaps))) Clang likes something that doesn't involve casting a "char *", which is not guaranteed to contain an address that's 4-byte aligned, to a "guint32 *", which is a poi

[Wireshark-dev] buildbot failure in Wireshark (development) on Visual-Studio-Code-Analysis

2011-04-25 Thread buildbot-no-reply
The Buildbot has detected a new failure of Visual-Studio-Code-Analysis on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Visual-Studio-Code-Analysis/builds/552 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: vs

Re: [Wireshark-dev] Familiar with gtk/sctp_graph_dlg.c?

2011-04-25 Thread Michael Tüxen
On Apr 25, 2011, at 11:50 PM, Chris Maynard wrote: > Stephen Fisher writes: > >> Anyone familiar with gtk/sctp_graph_dlg.c? This line in particular >> (#270): >> >> dup_list = (guint32 *)(((char > *)&sack_header->nr_of_dups)+sizeof(guint16)+(nr*sizeof(struct >> gaps))); >> >> I'm trying to

Re: [Wireshark-dev] Familiar with gtk/sctp_graph_dlg.c?

2011-04-25 Thread Michael Tüxen
On Apr 25, 2011, at 11:02 PM, Stephen Fisher wrote: > Anyone familiar with gtk/sctp_graph_dlg.c? This line in particular > (#270): > > dup_list = (guint32 *)(((char > *)&sack_header->nr_of_dups)+sizeof(guint16)+(nr*sizeof(struct > gaps))); It computes the the pointer to the list of duplicates

Re: [Wireshark-dev] Familiar with gtk/sctp_graph_dlg.c?

2011-04-25 Thread Chris Maynard
Stephen Fisher writes: > Anyone familiar with gtk/sctp_graph_dlg.c? This line in particular > (#270): > > dup_list = (guint32 *)(((char *)&sack_header->nr_of_dups)+sizeof(guint16)+(nr*sizeof(struct > gaps))); > > I'm trying to investigate a clang error about this increasing required > align

[Wireshark-dev] Familiar with gtk/sctp_graph_dlg.c?

2011-04-25 Thread Stephen Fisher
Anyone familiar with gtk/sctp_graph_dlg.c? This line in particular (#270): dup_list = (guint32 *)(((char *)&sack_header->nr_of_dups)+sizeof(guint16)+(nr*sizeof(struct gaps))); I'm trying to investigate a clang error about this increasing required alignment from 1 to 4 and the complexity of t

[Wireshark-dev] Hidden Proto Fields

2011-04-25 Thread Alex Lindberg
The latest version of epan/proto.h indicates that hiding protocol fields is deprecated. How does one then create a generic filter type like ip.addr? I need to create a filter like ip.addr that can be used in place of a more specific one. Thanks in advance. Alex Lindberg___

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-7-x64

2011-04-25 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-7-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-7-x64/builds/1646 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-7-x64 Build Reason:

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.5-x86

2011-04-25 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.5-x86 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.5-x86/builds/2953 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.5-x86 Build Reason: Bui

[Wireshark-dev] buildbot failure in Wireshark (development) on OSX-10.6-x64

2011-04-25 Thread buildbot-no-reply
The Buildbot has detected a new failure of OSX-10.6-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/OSX-10.6-x64/builds/2498 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: osx-10.6-x64 Build Reason: Bui

Re: [Wireshark-dev] Using cf_callback_add from a plugin

2011-04-25 Thread Guy Harris
On Apr 25, 2011, at 11:43 AM, Bruce, Joseph R (Joe) wrote: > I still don't understand why this code works on the *nix side, but not > Windows. Any ideas there? The dynamically-linked library systems used by most if not all UN*X systems and and the dynamically-linked library system used by Wind

Re: [Wireshark-dev] Using cf_callback_add from a plugin

2011-04-25 Thread Bruce, Joseph R (Joe)
On 4/25/11 11:17 AM, "Jeff Morriss" wrote: >Bruce, Joseph R (Joe) wrote: >>> Bruce, Joseph R (Joe) wrote: Hi, I'm writing a plugin that registers a capture file callback via cf_callback_add (./file.c:173, ./file.h:83). The callback is invoked on read and other inter

Re: [Wireshark-dev] Bug in new_packet_list_thaw/_freeze while loading file

2011-04-25 Thread Anders Broman
Gerald Combs skrev 2011-04-25 19:08: On 4/23/11 3:12 PM, Guy Harris wrote: On Apr 23, 2011, at 11:29 AM, Jakub Zawadzki wrote: About actual bug: In old packet list _freeze stops GtkClist from redraw while adding packets to list. In new packet list _freeze sets empty (NULL) model, and _thaw re

Re: [Wireshark-dev] Using cf_callback_add from a plugin

2011-04-25 Thread Jeff Morriss
Bruce, Joseph R (Joe) wrote: Bruce, Joseph R (Joe) wrote: Hi, I'm writing a plugin that registers a capture file callback via cf_callback_add (./file.c:173, ./file.h:83). The callback is invoked on read and other interesting cf events. This works fine on my *nix build, but Windows is unhappy.

Re: [Wireshark-dev] Using cf_callback_add from a plugin

2011-04-25 Thread Guy Harris
On Apr 25, 2011, at 10:25 AM, Jeff Morriss wrote: > libui is a static library (archive). Building one of those does not require > that all the symbols be resolved (which is a good thing: you can't link an > archive against another archive or shared libraries anyway). It just means > that whe

Re: [Wireshark-dev] Using cf_callback_add from a plugin

2011-04-25 Thread Bruce, Joseph R (Joe)
>Bruce, Joseph R (Joe) wrote: >> Hi, >> >> I'm writing a plugin that registers a capture file callback via >> cf_callback_add (./file.c:173, ./file.h:83). The callback is invoked on >> read and other interesting cf events. This works fine on my *nix build, >> but Windows is unhappy. The only ot

Re: [Wireshark-dev] Using cf_callback_add from a plugin

2011-04-25 Thread Jeff Morriss
Bruce, Joseph R (Joe) wrote: Hi, I'm writing a plugin that registers a capture file callback via cf_callback_add (./file.c:173, ./file.h:83). The callback is invoked on read and other interesting cf events. This works fine on my *nix build, but Windows is unhappy. The only other code that reg

Re: [Wireshark-dev] Bug in new_packet_list_thaw/_freeze while loading file

2011-04-25 Thread Gerald Combs
On 4/23/11 3:12 PM, Guy Harris wrote: > > On Apr 23, 2011, at 11:29 AM, Jakub Zawadzki wrote: > >> About actual bug: >> In old packet list _freeze stops GtkClist from redraw while adding packets >> to list. >> In new packet list _freeze sets empty (NULL) model, and _thaw restores model >> with

Re: [Wireshark-dev] Using cf_callback_add from a plugin

2011-04-25 Thread Bruce, Joseph R (Joe)
>>I'm writing a plugin that registers a capture file callback via >> cf_callback_add (./file.c:173, ./file.h:83). The callback is invoked on >> read and other interesting cf events. This works fine on my *nix build, >> but Windows is unhappy. The only other code that registers a cf >>callback >>

Re: [Wireshark-dev] Using cf_callback_add from a plugin

2011-04-25 Thread Chris Maynard
Bruce, Joseph R (Joe writes: > I'm writing a plugin that registers a capture file callback via > cf_callback_add (./file.c:173, ./file.h:83). The callback is invoked on > read and other interesting cf events. This works fine on my *nix build, > but Windows is unhappy. The only other code that

Re: [Wireshark-dev] Bug in new_packet_list_thaw/_freeze while loading file

2011-04-25 Thread Stephen Fisher
On Sat, Apr 23, 2011 at 03:12:17PM -0700, Guy Harris wrote: > Is this something that applied to the old GTKCList but that doesn't > apply to GTK2's tree view? The reason for the freeze and thaw in the GTK2 new packet list is based on the GtkTreeView tutorial (see below). It was added early on