[Wireshark-dev] range in filters

2011-03-14 Thread Stephen Fisher
Has anyone ever looked into implementing range checks in display filters? For example, a typical Unix style traceroute would be in the UDP port range 33434 to 33464, so I would like to do a filter such as "udp.port range 33434 33464"

Re: [Wireshark-dev] [Wireshark-commits] rev 36193: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-icmp.c

2011-03-14 Thread Stephen Fisher
Chris, Thanks for pointing that out - I had forgotten about that bug report. The case I'm looking at is where an ICMP echo request goes out with an ICMP header of 8 bytes + a payload of 32 bytes for a ping. Then I receive an ICMP destination host unreachable containing the original IP header

Re: [Wireshark-dev] how to handle dissecting length encoded strings

2011-03-14 Thread Chris Maynard
Jakub Zawadzki writes: > hf of type FT_UINT_STRING wouldn't work for you? > > FT_UINT_STRING > A counted string of characters, consisting > of a count (represented as an integral value, > of width given in the proto_tree_add_item() > call) followed immediately by th

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-7-x64

2011-03-14 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-7-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-7-x64/builds/1268 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-7-x64 Build Reason:

Re: [Wireshark-dev] [Wireshark-commits] rev 36193: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-icmp.c

2011-03-14 Thread Maynard, Chris
Hi Steve, Is this valid? See https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5105. - Chris -Original Message- From: wireshark-commits-boun...@wireshark.org [mailto:wireshark-commits-boun...@wireshark.org] On Behalf Of sfis...@wireshark.org Sent: Monday, March 14, 2011 3:58 PM To: wi

Re: [Wireshark-dev] how to handle dissecting length encoded strings

2011-03-14 Thread Jakub Zawadzki
On Mon, Mar 14, 2011 at 09:51:06AM -0400, Fulko Hew wrote: > I'm looking into a bug in a dissector, and I don't see what the 'right > way' to fix it would be. > Here's the existing code snippet: > > static int > dissect_octet_string(tvbuff_t *tvb, proto_tree *tree, int offset, char flags) > { >

[Wireshark-dev] New openSAFETY dissector

2011-03-14 Thread Roland Knall
Hello openSAFETY is a machine safety standard, which has been certified by TUEV Rheinland as well as other organizations for SIL 3 , and is currently implemented in a wide range of products. This plugin allows dissection of the openSAFETY protocol using the Industrial Ethernet Network standards E

Re: [Wireshark-dev] how to handle dissecting length encoded strings

2011-03-14 Thread Fulko Hew
On Mon, Mar 14, 2011 at 12:17 PM, Chris Maynard wrote: > Chris Maynard writes: > > Oops, I guess you still need to NULL-terminate context if n_oct is 0 The trouble is that tvb_get_nstringz0() calls tvb_get_nstringz() under the covers and its tvb_get_nstringz() that has the issue. It expects to

Re: [Wireshark-dev] how to handle dissecting length encoded strings

2011-03-14 Thread Chris Maynard
Chris Maynard writes: Oops, I guess you still need to NULL-terminate context if n_oct is 0: Index: epan/dissectors/packet-agentx.c === --- epan/dissectors/packet-agentx.c (revision 36188) +++ epan/dissectors/packet-agentx.c

Re: [Wireshark-dev] how to handle dissecting length encoded strings

2011-03-14 Thread Chris Maynard
Fulko Hew writes: > Comments anyone? How about this patch?: Index: epan/dissectors/packet-agentx.c === --- epan/dissectors/packet-agentx.c (revision 36188) +++ epan/dissectors/packet-agentx.c (working copy) @@ -308,8 +308,7

Re: [Wireshark-dev] help with compiling problem

2011-03-14 Thread Bill Meier
On 3/13/2011 9:15 PM, tnec priv wrote: hi when compiling i get an error: NMAKE: fatal error V1077: '"C:\Program Files\Microsoft SDKs\Windows\v6.0\VC\Bin\nmake.exe"' : return code '0x2' Stop. please help You'll need to look at the output before the above message. There should be an error me

[Wireshark-dev] help with compiling problem

2011-03-14 Thread tnec priv
hi when compiling i get an error: NMAKE: fatal error V1077: '"C:\Program Files\Microsoft SDKs\Windows\v6.0\VC\Bin\nmake.exe"' : return code '0x2' Stop. please help ___ Sent via:Wireshark-dev mailing list Archives:http

[Wireshark-dev] how to handle dissecting length encoded strings

2011-03-14 Thread Fulko Hew
I'm looking into a bug in a dissector, and I don't see what the 'right way' to fix it would be. Here's the existing code snippet: static int dissect_octet_string(tvbuff_t *tvb, proto_tree *tree, int offset, char flags) { guint32 n_oct, p_noct; char context[1024]; NORLEL(flags, n_oct,

Re: [Wireshark-dev] Different wireshark behaviour on Linux as on Windows

2011-03-14 Thread Roland Knall
Hello Sorry for the late reply, but work took over. Taking your concerns into consideration, I changed the setup a little bit. With Bugs #5751 and Bugs #5752 I added two patches, which add heuristic sub-dissectors to both EPL and SercosIII dissectors. As a side-effect, I cleaned the EPL dissector