Re: [Wireshark-dev] [Wireshark-commits] rev 32822: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-q708.c

2010-05-15 Thread Anders Broman
Gerasimos Dimitriadis skrev 2010-05-16 00:42: > Anders Broman wrote: > >> I'm sure the GSM/UMTS related dissectors would benefit especially if >> "index method" can be used. Asn2wrs >> should perhaps be changed to use the new method. I just don't have the >> traces nor time to so benchmarking.

Re: [Wireshark-dev] [Wireshark-commits] rev 32822: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-q708.c

2010-05-15 Thread Gerasimos Dimitriadis
Anders Broman wrote: > I'm sure the GSM/UMTS related dissectors would benefit especially if > "index method" can be used. Asn2wrs > should perhaps be changed to use the new method. I just don't have the > traces nor time to so benchmarking. > Regards > Anders Yes, going to O(1) will definitely m

Re: [Wireshark-dev] CMake -fPIC flag

2010-05-15 Thread Joerg Mayer
On Sat, May 15, 2010 at 09:12:27PM +0100, Jose Pedro Oliveira wrote: > > Anything I'm missing here? Can you please provide a few more details on your > > system and your cmake options? > > I believe Bruno was mentioning this problem that appears in > Fedora 12 x86_64 systems: > > System : Fed

Re: [Wireshark-dev] _POSIX_C_SOURCE redefined

2010-05-15 Thread Joerg Mayer
On Fri, May 14, 2010 at 10:30:18PM +0100, Bruno Matos wrote: > In version_info.c file, if we put the Python include in first place we > remove the warning/error "_POSIX_C_SOURCE redefined", as in this > article: > http://bytes.com/topic/python/answers/30009-warning-_posix_c_source-redefined >

Re: [Wireshark-dev] [Wireshark-commits] rev 32822: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-q708.c

2010-05-15 Thread Anders Broman
Gerasimos Dimitriadis skrev 2010-05-15 23:12: > Hi, > > I did some benchmarking on the performance gains from the switch to > binary search in the SANC and ISPC arrays, that I want to share with the > list. The SANC array contains ~900 entries, while the 2 ISPC arrays > (signalling point and operat

Re: [Wireshark-dev] [Wireshark-commits] rev 32822: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-q708.c

2010-05-15 Thread Gerasimos Dimitriadis
Hi, I did some benchmarking on the performance gains from the switch to binary search in the SANC and ISPC arrays, that I want to share with the list. The SANC array contains ~900 entries, while the 2 ISPC arrays (signalling point and operator names) contain ~5k entries each. For this experime

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-XP-x86

2010-05-15 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-XP-x86 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-XP-x86/builds/246 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-xp-x86 Build Reason:

Re: [Wireshark-dev] CMake -fPIC flag

2010-05-15 Thread Jose Pedro Oliveira
Joerg, On 2010-05-15 17:47, Joerg Mayer wrote: > On Fri, May 14, 2010 at 09:37:22PM +0100, Bruno Matos wrote: >> The -fPIC flag is missing in WIRESHARK_EXTRA_C_FLAGS variable. >> >> I didn't make the patch because it's too small, but I can do it if you >> want. > > Interesting, it gets added au

[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-7-x64

2010-05-15 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-7-x64 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-7-x64/builds/279 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-7-x64 Build Reason: B

Re: [Wireshark-dev] [Wireshark-commits] rev 32804: /trunk/gtk/ /trunk/gtk/: capture_dlg.c

2010-05-15 Thread Guy Harris
On May 14, 2010, at 10:51 AM, Stig Bjørlykke wrote: > On Fri, May 14, 2010 at 7:16 PM, Guy Harris wrote: >> Yes - the stuff I'm doing is still a work in progress. For example, the >> tooltip for monitor mode is the same as the tooltip for promiscuous mode; >> that's what I'm fixing now, and t

Re: [Wireshark-dev] CMake -fPIC flag

2010-05-15 Thread Joerg Mayer
On Fri, May 14, 2010 at 09:37:22PM +0100, Bruno Matos wrote: > The -fPIC flag is missing in WIRESHARK_EXTRA_C_FLAGS variable. > > I didn't make the patch because it's too small, but I can do it if you > want. Interesting, it gets added automagically on my system: cd /home/jmayer/work/wireshark

Re: [Wireshark-dev] Wireshark 1.4

2010-05-15 Thread Jaap Keuter
On 05/15/2010 08:05 AM, Stephen Fisher wrote: > On Tue, May 11, 2010 at 04:40:36PM -0700, Gerald Combs wrote: > >> If you have added a new feature in the past year, please review the >> release notes to make sure it's listed. > > That's a long time to think back to :-) Are the release notes anywhe