[Wireshark-dev] buildbot failure in Wireshark (development) on Windows-XP-x86

2009-03-24 Thread buildbot-no-reply
The Buildbot has detected a new failure of Windows-XP-x86 on Wireshark (development). Full details are available at: http://buildbot.wireshark.org/trunk/builders/Windows-XP-x86/builds/5876 Buildbot URL: http://buildbot.wireshark.org/trunk/ Buildslave for this Build: windows-xp-x86 Build Reason

Re: [Wireshark-dev] [Wireshark-commits] rev 27844: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dect.c

2009-03-24 Thread Guy Harris
On Mar 24, 2009, at 3:13 PM, jma...@wireshark.org quoted Andreas Schuler: > weiter hab ich festgestellt das das b-field nicht richtig > dargestellt wird . > Entweder ist g_snprintf broken , oder wir sind beide zu unfähig die > funktion zu benutzen . > Der string wird aus 16x %.2x + leerzeiche

Re: [Wireshark-dev] Memory Leak

2009-03-24 Thread Gianluca Varenni
If the memory is allocated within the DLL, it should be freed from within the DLL (i.e. you should provide a function exported by the DLL to free such memory). Allocating memory with malloc in a DLL and free'ing it from outside the DLL is bad mojo. http://msdn.microsoft.com/en-us/library/ms235

[Wireshark-dev] Memory Leak

2009-03-24 Thread gogrady
Hi all, So in my dissector, i call a dll that allocates memory for information to be returned back for output, but when i try and free the memory, i get an error. I was wondering what the scope of the memory would be and where i should free it, maybe i'm freeing it wrong. I allocate it in my dl

Re: [Wireshark-dev] proto_tree -> proto_item

2009-03-24 Thread Sébastien Tandel
ok, my bad. I haven't read proto_tree_get_parent() documentation and was guessing - erroneously - that it was returning a tree ... because a parent of a tree should be a tree and not an item (in the case, one day someone would like to have an API which differentiates proto_item from proto_tree). R

Re: [Wireshark-dev] one possible way to speed up filtering

2009-03-24 Thread didier
Hi, Le mardi 24 mars 2009 à 19:46 +0800, yami a écrit : > Hi > > I've tried Didier's patch in Windows (compiled in MSVC 2005 Express > with a few code tweak). Great, I think you are the first on Windows, can you mail me your change? (I haven't a Windows tool chain). About your patch, two small st

Re: [Wireshark-dev] proto_tree -> proto_item

2009-03-24 Thread l...@lucaceresoli.net
Sébastien Tandel wrote: > I'm not sure it's really safe and cleaner since it's > working only because proto_item = proto_tree = proto_node ... > On Mon, Mar 23, 2009 at 18:48, Luca Ceresoli > wrote: > > my_tree = ptvcursor_add_text_with_subtree(cursor, ..,"foo"); > > my_item = proto_tree_get_par

Re: [Wireshark-dev] proto_tree -> proto_item

2009-03-24 Thread Sébastien Tandel
Hi Luca, I'm not sure it's really safe and cleaner since it's working only because proto_item = proto_tree = proto_node and the legend says that nothing guarantees it won't change. Then it is working now but be aware that one day it might not work anymore. Regards, Sebastien Tandel On Mon, Mar 2

Re: [Wireshark-dev] one possible way to speed up filtering

2009-03-24 Thread yami
Hi I've tried Didier's patch in Windows (compiled in MSVC 2005 Express with a few code tweak). It is really fast. I hope one day it can come to trunk. On Tue, Mar 24, 2009 at 1:29 AM, didier wrote: > Hi, > Le lundi 23 mars 2009 à 10:40 +0800, yami a écrit : > > > > > I'm interested in: > > > >

Re: [Wireshark-dev] complie fail on WinXP 32bit

2009-03-24 Thread Andreas Heise
to avoid such problems it make sense to add the cygwin on the first position instead of the end. It should no problem for other applications, because the settings are lost if CMD.exe is closed I would suggest to change the batch example in the devel guide to the following which is working well in