Re: [Wireshark-dev] Register dissector to MAC address

2007-12-17 Thread Michael A. McCartney
Chris, I spoke too soon. I went back to see what was implemented in the custom dissector (been a while) and the data being dissected with the code, and found that the proposed change would not work for me. The packets I'm dissecting are actually non-Ethernet packets inside Ethernet framing. I t

[Wireshark-dev] Version handling

2007-12-17 Thread Anders Broman
Hi, Found this on the GTK mailing list: http://mail.gnome.org/archives/gtk-devel-list/2007-December/msg00113.html >I humbly suggest that the versioning recommendation for the GTK+ stack >and GNOME in general is amended for the third "micro" part of the >version numbers to match the convention used

Re: [Wireshark-dev] New Dissector: LLRP

2007-12-17 Thread Jaap Keuter
Hi, Patience my friend, patience. With over 250 bug reports and 75 patches pending it will take some time before anyone gets to it. Especially since your dissector is not small and very atypical, someone has to a liking to it and invest the time to verify it. That will take some time. Thanx, J

Re: [Wireshark-dev] Register dissector to MAC address

2007-12-17 Thread Maynard, Chris
Yes, but the source & destination MAC's are passed to sub-dissectors in the pinfo->src and pinfo->dst fields anyway, so the original poster could have gleaned them from there instead: packet-eth.c Line 205: SET_ADDRESS(&pinfo->src, AT_ETHER, 6, src_addr); Line 209: SET_ADDRESS(&pinfo->dst,

Re: [Wireshark-dev] Register dissector to MAC address

2007-12-17 Thread Michael A. McCartney
Chris, Orignal poster wanted a way to select the frames based on MAC signature - that was a way to do that. Yes, I agree with you that it passed the whole eth frame instead of just the payload like other dissectors do. Just the way it works now in eth dissector. It should be easy to change it

Re: [Wireshark-dev] Register dissector to MAC address

2007-12-17 Thread Maynard, Chris
Mike, First, thanks for the response. Like I said below though, I don't think any of the other dissectors work that way. UDP, for example, makes a call to tvb_new_subset() to pass the payload of the UDP packet to the registered heuristic dissectors, so those dissectors only get the payload witho

Re: [Wireshark-dev] Register dissector to MAC address

2007-12-17 Thread Michael A. McCartney
Chris, I used to hack into packet-eth.c until I learned a better way using heuristic dissector instead and leave packet-eth.c alone. Not sure why you had difficulties but this is what I did and it works fine. And using the if(...), one can be selective on MAC address. static gboolean dissect__h

Re: [Wireshark-dev] Please apply 23907 to 0.99.7 (array overflow)

2007-12-17 Thread Gerald Combs
Joerg Mayer wrote: > In case packet-erf.c is in 0.99.7 this patch should be applied. It is. I've copied the change over and restarted the build. 0.99.7 will have to be released tomorrow. ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://w

[Wireshark-dev] Please apply 23907 to 0.99.7 (array overflow)

2007-12-17 Thread Joerg Mayer
In case packet-erf.c is in 0.99.7 this patch should be applied. -- Joerg Mayer <[EMAIL PROTECTED]> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. __

Re: [Wireshark-dev] Dissector bug, protocol CPFI

2007-12-17 Thread Stephen Fisher
On Mon, Dec 17, 2007 at 05:42:21PM +0100, Andries E. Brouwer wrote: > Wireshark version: 0.99.6. > > Message: > 17:25:48 Warn Dissector bug, protocol CPFI, in packet 1: > packet-cpfi.c:196: failed assertion "pinfo->src.type == AT_ETHER" > > Cause: this particular packet has pinfo->sr

Re: [Wireshark-dev] New Dissector: LLRP

2007-12-17 Thread Matt Poduska
What else needs to be done before this dissector can be added to the Wireshark source tree? Is there something I've missed in this process? Thank you, Matt Poduska -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Matt Poduska Sent: Wednesday, November 07,

[Wireshark-dev] Dissector bug, protocol CPFI

2007-12-17 Thread Andries E. Brouwer
Wireshark version: 0.99.6. Message: 17:25:48 Warn Dissector bug, protocol CPFI, in packet 1: packet-cpfi.c:196: failed assertion "pinfo->src.type == AT_ETHER" Cause: this particular packet has pinfo->src.type == 2 (AT_IPv4) instead of 1 (AT_ETHER). OS: Linux (various distros, various k

Re: [Wireshark-dev] [Wireshark-commits] rev 23873: /trunk/gtk/ /trunk/gtk/: menu.c proto_dlg.c proto_dlg.h

2007-12-17 Thread Jaap Keuter
Hi list, Maybe someone can give me a pointer where to look since I can't really find a way to get at and traverse this path. Thanx, Jaap Jaap Keuter wrote: > Hi, > > I tried to avoid walking the tree, but failed to spot this issue. Let's > see how to treewalk then. > > Thanx, > Jaap > > Guy

Re: [Wireshark-dev] ASN.1 enumeration extension coding question

2007-12-17 Thread Nichols, Roger
Is anyone aware of an ITU specification using enumerated values not in the root besides T.38? This code change is in a generic prototcol handler, and could have unintended consequences. I am willing to believe I am wrong, I am just looking for an ITU document which clarifies whether the exte

Re: [Wireshark-dev] ASN.1 enumeration extension coding question

2007-12-17 Thread Kukosa, Tomas
Hi, it seems that it was implemented by me (rev 17530, March 2006) but I do not remember why. I will fix it. Tomas Od: [EMAIL PROTECTED] za uživatele Anders Broman Odesláno: po 17.12.2007 20:36 Komu: 'Developer support list for Wireshark' Předmět: Re: [Wi

Re: [Wireshark-dev] ASN.1 enumeration extension coding question

2007-12-17 Thread Anders Broman
Hi, After reading your previous post on the subject I did a quick check Of the ITU spec and it looks like you are right...I'm not sure why the Check is there - Tomas? Ronny? Regards Anders -Ursprungligt meddelande- Från: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] För Nichols, Roger Skicka

Re: [Wireshark-dev] [PATCH] packet-sctp.c: rename SERIAL_NUMBER_LENGTH to SCTP_SERIAL_NUMBER_LENGTH to fix compilation failure

2007-12-17 Thread Jeff Morriss
Kaul wrote: > On Windows, with both MSVC 2005 express and MSVC 2008 express, > compilation fails due to redefinition of SERIAL_NUMBER_LENGTH. > Changed it to SCTP_SERIAL_NUMBER_LENGTH to avoid the collision. Huh, it compiles fine for me using MSVC 2005 Express (free) edition. SERIAL_NUMBER_LEN

[Wireshark-dev] ASN.1 enumeration extension coding question

2007-12-17 Thread Nichols, Roger
Hi, Is this the proper forum to ask a question about 'why' something is coded the way it is? We are developing a V.34 enabled T.38 end point, and are confused by the Wireshark decoding. It seems the Wireshark decoder is aligning fields which are extension values. For example, the 2002 T.38 ASN

Re: [Wireshark-dev] [Wireshark-commits] rev 23851: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-airopeek.c

2007-12-17 Thread Joerg Mayer
On Fri, Dec 14, 2007 at 12:56:59PM -0800, Guy Harris wrote: > [EMAIL PROTECTED] wrote: > > > Beginnings of airopeek remote capture support. > > The metainformation is not yet decoded > > Is the metainformation in the same format as in *Peek version 9 files? > (See wiretap/airopeek9.c; that for

[Wireshark-dev] RFC: Detecting duplicate IP addresses [PATCH]

2007-12-17 Thread Martin Mathieson
Hi, I want to see an expert item to report when wireshark can see that more than one endpoint is configured with the same IP address. The approach this (not-fully-tested-yet) patch takes is to pick IP/MAC pairs out of ARP requests/reponses and maintain an IP->MAC hash table. Should this work - i