Re: [Wireshark-dev] Patches for compilation warnings

2007-03-26 Thread ronnie sahlberg
On 3/27/07, Peter Johansson <[EMAIL PROTECTED]> wrote: > Oh, my bad. So how can one fix these problems then? I am not really "on top > of" IDL, what should one generally do to correct this? I have sent patches to Jelmer that maintains PIDL that will address most of the warnings from the pidl gene

Re: [Wireshark-dev] preference tree for SS7

2007-03-26 Thread Jeff Morriss
Ulf Lamping wrote: > So if we want to group protocols, we should group (at least) most protocols, > to have the protocol list length dastically reduced. True. This could be a first step, though. (I have to admit I was amazed there were 21 protocols--and that's only those with preferences--i

Re: [Wireshark-dev] Patches for compilation warnings

2007-03-26 Thread Peter Johansson
2007/3/26, Stephen Fisher <[EMAIL PROTECTED]>: On Mon, Mar 26, 2007 at 08:58:39AM +0200, Peter Johansson wrote: These can't be applied directly to the source files because the source files are generated from other files (see the top of each file for more information): packet-cosnaming.c.dif

Re: [Wireshark-dev] preference tree for SS7

2007-03-26 Thread Jeff Morriss
Luis Ontanon wrote: > Now I have to type [Ctrl-Shift-P][p][r][o][RET][fw-arrow][t][c][TAB] > and I can modify TCAP's > prefs. > > Tomorrow I'll have to: > [Ctrl-Shift-P][p][r][o][RET][fw-arrow][s][s][RET][fw-arrow][t][c][TAB] > for a keyboard animal like me that's a loss... > > On the other han

[Wireshark-dev] FYI: Status of gcc warnings in epan/dissectors

2007-03-26 Thread Stephen Fisher
FYI: Update on warnings in epan/dissectors under gcc 4.0 Below is a list of the number of warnings remaining in epan/dissectors when using gcc 4.0. There are 3,915 warnings in this directory across 163 files. Excluding files that show warnings as being in the .cnf filename (such as asn genera

Re: [Wireshark-dev] Diameter AVP decoding : Same AVP codes withdifferent names

2007-03-26 Thread Anders Broman
Hi, This is most probably a bug. Please file a bug report, preferably with a sample trace. Best regards Anders Från: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] För Xavier Ameziane Skickat: den 26 mars 2007 12:29 Till: wireshark-dev@wireshark.org Ämne: [Wir

[Wireshark-dev] A very pragmatic approach to fix remaining MSVC warnings ...

2007-03-26 Thread Ulf Lamping
Hi List! As I've got no response to my previous approach to fix the warnings of the generated source files in "epan/dissectors" I had to look for a more "pragmatic" approach. There are already changes rushing in, that are adding new warnings, so I've thought it was time to fix this hole by set

Re: [Wireshark-dev] [Wireshark-commits] rev 21212: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-megaco.c

2007-03-26 Thread ronnie sahlberg
There was a missing constant preventing it from compiling. I just added it to gcp.h Please review that the constant is the correct one. On 3/26/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=21212 > > User: lego > Date: 2007/

Re: [Wireshark-dev] [Wireshark-commits] rev 21110: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dcerpc-eventlog.c packet-dcerpc-eventlog.h /trunk/epan/dissectors/pidl/: eventlog.cnf

2007-03-26 Thread ronnie sahlberg
Yes, PIDL is maintained by the samba team. Jelmer is a bit busy right now but he will hopefully check the pathces i sent in when he gets time. Once that is done I will regenerate the other PIDL dissectors. On 3/26/07, Stephen Fisher <[EMAIL PROTECTED]> wrote: > Ronnie, > > Can we get a copy o

Re: [Wireshark-dev] [Wireshark-commits] rev 21110: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dcerpc-eventlog.c packet-dcerpc-eventlog.h /trunk/epan/dissectors/pidl/: eventlog.cnf

2007-03-26 Thread Stephen Fisher
Ronnie, Can we get a copy of the patched pidl program you used below? Is all of pidl maintained by the Samba team so that they would be the ones that would permanently make the _U_ change to it? On Thu, Mar 22, 2007 at 08:45:02AM +, [EMAIL PROTECTED] wrote: > http://anonsvn.wireshark.org/v

Re: [Wireshark-dev] Patches for compilation warnings

2007-03-26 Thread Stephen Fisher
On Mon, Mar 26, 2007 at 08:58:39AM +0200, Peter Johansson wrote: > Sure, no problem. Resending all patches since they still apply, > 'diffed' agains the most recent SVN version. These patches have been applied as SVN revision 21214: packet-afp.c.diff.txt packet-smb.h.diff.txt packet

Re: [Wireshark-dev] dissecting and decoding an 8 byte field

2007-03-26 Thread Luis Ontanon
what about FT_BYTES, FT_UINT64, FT_STRING, FT_DOUBLE? these are either 8 octets long or any size. On 3/26/07, Bill Fassler <[EMAIL PROTECTED]> wrote: > Is there recommended way to decode 8 byte fields? I see I can use FT_NONE > with a size of 8 bytes and the appropriate bytes highlight in the byt

[Wireshark-dev] dissecting and decoding an 8 byte field

2007-03-26 Thread Bill Fassler
Is there recommended way to decode 8 byte fields? I see I can use FT_NONE with a size of 8 bytes and the appropriate bytes highlight in the bytes of the packet, but the value does not display in the decoded details? Bill - No need to miss a message. Get email o

[Wireshark-dev] Broken Record - Release tag

2007-03-26 Thread Bryant Eastham
Gerald Combs wrote: > /trunk-0.99.2 was copied from /trunk last week. Once the 0.99.2 release > is made it will be moved to /releases/wireshark-0.99.2. Some time in > the future we'll start over again by copying /trunk to /trunk-0.99.3. Sorry to sound like a broken record. Is there going to b

Re: [Wireshark-dev] [Wireshark-commits] rev 21195: /trunk/ /trunk/: configure.in

2007-03-26 Thread Guy Harris
Sebastien Tandel wrote: > Note that '==' is not portable on BSD unix. For the test/[ command, the standard string-comparison operator is "=", rather than "==". (There's also "-eq" for a numerical comparison.) ___ Wireshark-dev mailing list Wireshark-d

Re: [Wireshark-dev] preference tree for SS7

2007-03-26 Thread Michael Tuexen
What about calling it SS7/SIGTRAN ? Best regards Michael On Mar 26, 2007, at 4:05 PM, Jeff Morriss wrote: > > Hi list, > > I finally had a chance to look at the new feature from revision 21066: > > http://anonsvn.wireshark.org/viewvc/viewvc.py?view=rev&revision=21066 > > and see what it looks lik

[Wireshark-dev] Duplicate posts?

2007-03-26 Thread Bryan Miller
Hi All, Sorry for the slightly off-topic post but since we have no postmaster I am pinging the list. Is anyone else receiving duplicate posts? The mailing list site shows me only subscribed once but I am receiving duplicate messages for all posts. Certainly not life threatening but very aggravat

Re: [Wireshark-dev] preference tree for SS7

2007-03-26 Thread Luis Ontanon
On 3/26/07, Ulf Lamping <[EMAIL PROTECTED]> wrote: > > > > > Hi list, > > > > I finally had a chance to look at the new feature from revision 21066: > > > > http://anonsvn.wireshark.org/viewvc/viewvc.py?view=rev&revision=21066 > > > > and see what it looks like if I put, say, all the SS7 dissectors

Re: [Wireshark-dev] preference tree for SS7

2007-03-26 Thread Luis Ontanon
Now I have to type [Ctrl-Shift-P][p][r][o][RET][fw-arrow][t][c][TAB] and I can modify TCAP's prefs. Tomorrow I'll have to: [Ctrl-Shift-P][p][r][o][RET][fw-arrow][s][s][RET][fw-arrow][t][c][TAB] for a keyboard animal like me that's a loss... On the other hand I know that TCAP is an SS7 protocol so

Re: [Wireshark-dev] preference tree for SS7

2007-03-26 Thread Ulf Lamping
> > Hi list, > > I finally had a chance to look at the new feature from revision 21066: > > http://anonsvn.wireshark.org/viewvc/viewvc.py?view=rev&revision=21066 > > and see what it looks like if I put, say, all the SS7 dissectors' > preferences in one preference tree called "SS7". The resul

Re: [Wireshark-dev] preference tree for SS7

2007-03-26 Thread Jacques, Olivier (PD&E IT Test)
I'll second that! Olivier. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jeff Morriss Sent: Monday, March 26, 2007 16:05 To: wireshark-dev@wireshark.org Subject: [Wireshark-dev] preference tree for SS7 Hi list, I finally had a chance to look at the

[Wireshark-dev] Expert info missing entries

2007-03-26 Thread Andrej Mikus
Team, I came across a problem that is described in posting http://www.wireshark.org/lists/wireshark-dev/200607/msg04326.html I can confirm that the change as described there works, e.g. in expert_dlg_init() I call: cf_redissect_packets(&cfile); instead of cf_retap_packets(&cfile, FALSE);

Re: [Wireshark-dev] preference tree for SS7

2007-03-26 Thread Abhik Sarkar
I agree! On 3/26/07, Jeff Morriss <[EMAIL PROTECTED]> wrote: > > Hi list, > > I finally had a chance to look at the new feature from revision 21066: > > http://anonsvn.wireshark.org/viewvc/viewvc.py?view=rev&revision=21066 > > and see what it looks like if I put, say, all the SS7 dissectors' > pre

[Wireshark-dev] preference tree for SS7

2007-03-26 Thread Jeff Morriss
Hi list, I finally had a chance to look at the new feature from revision 21066: http://anonsvn.wireshark.org/viewvc/viewvc.py?view=rev&revision=21066 and see what it looks like if I put, say, all the SS7 dissectors' preferences in one preference tree called "SS7". The result was a little sta

Re: [Wireshark-dev] Regarding buiding Ethereal

2007-03-26 Thread Ulf Lamping
Please read and follow http://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html *literally*!!! Don't use gtk, glib, gcc and/or gdb from/for cygwin, this is for experts only! Use MSVC 2005EE (and the binary library versions) mentioned to save you from a lot of trouble. Regards, ULFL

Re: [Wireshark-dev] Regarding buiding Ethereal

2007-03-26 Thread Manjunath P
I hv read the Developer's guide and through my Cygwin, I hv already gcc,gdb,flex,make,bash,python,perl,sed,bison,flex,diff,patch tools. Also, when I do a $ gtk-config --version 1.2.10 $ glib-config --version 1.2.10 This means that gtk+and Glib libraries are also installed. But still , I

Re: [Wireshark-dev] Compilation failure on MSVC 6.0 with Platform SDK

2007-03-26 Thread Ulf Lamping
Graham Bloice wrote: > > From the include files. > > I haven't been able to check your changes yet, but I imagine that they > are close to my tests so that they should be OK. I'll check tomorrow. > In the meantime the buildbot found out that MSVC6 without PSDK doesn't compile, as _WINSOCK2API_

Re: [Wireshark-dev] Regarding buiding Ethereal

2007-03-26 Thread Abhik Sarkar
Hi Manjunath, On WIN32, there are several other requirements than just cygwin to compile WS. Please check out the documentation at http://wireshark.org/develop.html and http://wireshark.org/download/docs/developer-guide-a4.pdf to start with. If you follow the instructions in the developer guide wi

[Wireshark-dev] Regarding buiding Ethereal

2007-03-26 Thread Manjunath P
I am a newbie to Wireshark development. My aim is to have a protocol dissector. I have Windows XP along with cygwin installed on my m/c. I have downloaded source from http://www.wireshark.org/download/src/wireshark-0.99.5.tar.gz I read the "INSTALL" file and tried to do a "./configure" i

Re: [Wireshark-dev] gsm_map dissector question

2007-03-26 Thread Abhik Sarkar
Hi Anders, It is in ETSI GSM MAP specification "GSM 09.02 version 4.19.1" -- short message service operation codes sendRoutingInfoForSM SendRoutingInfoForSM ::= 45 forwardSM ForwardSM ::= localValue 46 ... There is no distinction between mt-fsm and mo-fsm. Thanks for looking into this. No hurr

Re: [Wireshark-dev] [PATCH] bunch of warnings fixes

2007-03-26 Thread ronnie sahlberg
checked in On 3/26/07, Sebastien Tandel <[EMAIL PROTECTED]> wrote: > One big patch is provided to apply all the changes. > It contains warnings fixes and removed some declarations after statement > too. > > I also provide patch-per-file.tar.gz containing one patch for each file > affected by "big

[Wireshark-dev] Diameter AVP decoding : Same AVP codes with different names

2007-03-26 Thread Xavier Ameziane
Hello I have a question about the way Wireshark decodes Diameter AVP. Is the "ApplicationID" taken into account when Wireshark decodes an AVP ? Example : - in 3GPP CX/DX Application(ID=16777216, 3GPP TS 29.228 and 29.229), the AVP code 1 is "Visited-Network-Identifier". The vendor-

Re: [Wireshark-dev] gsm_map dissector question

2007-03-26 Thread Anders Broman (AL/EAB)
Hi, In which specification is mt-fsm(MT-ForwardSM?) given with Opcode 46? I supose a solution would be to introduce a preference if MAPv2 or V3 is used. I have little time to look at this currently. Best regards Anders -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] O

[Wireshark-dev] [PATCH] bunch of warnings fixes

2007-03-26 Thread Sebastien Tandel
One big patch is provided to apply all the changes. It contains warnings fixes and removed some declarations after statement too. I also provide patch-per-file.tar.gz containing one patch for each file affected by "big patch", in case some modifs have been committed on one of these files : packet-

Re: [Wireshark-dev] gsm_map dissector question

2007-03-26 Thread Abhik Sarkar
Hi Anders, Thanks for your reply. Attached are sample captures. The MSUs are syslog encapsulated, so you need to be running SVN rev 21109 or higher. Decode UDP destination port 7890 as syslog and you will see the MTP3 and higher layers. example1.cap : A simple MAPv2 mt-fsm showing up as mo-fsm.

Re: [Wireshark-dev] [PATCH][UPDATE] analyzing SHIM6 protocol

2007-03-26 Thread Matthijs Mekking
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, > - in hf_register_info, there are two items of the same name : > hf_ipv6_shim6_opt_len This is fixed in the source and in the patch. > - you should create an helper function to add hf_ipv6_shim6_ct to the tree. I know, but at the moment I d

Re: [Wireshark-dev] Compilation failure on MSVC 6.0 with Platform SDK

2007-03-26 Thread Graham Bloice
Ulf Lamping wrote: > Graham Bloice wrote: >> When compiling with MSVC 6.0 and the platform SDK, there are failures >> due to the redefinition of sockaddr_storage in capture_wpcap_packet.c >> and gtk/capture_if_details_dlg.c. >> >> The definition is conditional on the version of MSVC used, whereas t

Re: [Wireshark-dev] gsm_map dissector question

2007-03-26 Thread Anders Broman (AL/EAB)
Hi, If you could supply a sample trace we could see what can be done. Best regards Anders From: [EMAIL PROTECTED] on behalf of Abhik Sarkar Sent: Mon 3/26/2007 9:49 AM To: wireshark-dev@wireshark.org Subject: [Wireshark-dev] gsm_map dissector question Hi List,

Re: [Wireshark-dev] [PATCH][UPDATE] analyzing SHIM6 protocol

2007-03-26 Thread Matthijs Mekking
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I did indeed. I fixed the patch. Regards, Matthijs Sebastien Tandel wrote: > Hi, > your patch is malformed line 63. You've probably deleted some hf_items > or some comments directly in the patch but that must be reflected in the > "accounting numb

Re: [Wireshark-dev] [Wireshark-commits] rev 21195: /trunk/ /trunk/: configure.in

2007-03-26 Thread Sebastien Tandel
Note that '==' is not portable on BSD unix. Jeff Morriss wrote: > Thanks & sorry for the trouble. Unfortunately something was stripping > the []'s out of the test in "configure.in" so the resulting "configure" > just had "if $? == 0 ;" which didn't work. I just checked in a new > version wh

Re: [Wireshark-dev] [Wireshark-commits] rev 21195: /trunk/ /trunk/: configure.in

2007-03-26 Thread Jeff Morriss
Thanks & sorry for the trouble. Unfortunately something was stripping the []'s out of the test in "configure.in" so the resulting "configure" just had "if $? == 0 ;" which didn't work. I just checked in a new version which should work for everyone. ronnie sahlberg wrote: > I just checked in

Re: [Wireshark-dev] [PATCH][UPDATE] analyzing SHIM6 protocol

2007-03-26 Thread Matthijs Mekking
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I did indeed! I deleted a line that didn't matter, but screwed up the accounting numbers apparently. It is now fixed. Regards, Matthijs Sebastien Tandel wrote: > Hi, > your patch is malformed line 63. You've probably deleted some hf_items > or som