Re: [Wireshark-dev] WireShark Indent Style (was: Kismet protocol dissector)

2006-07-14 Thread Mike Duigou
ronnie sahlberg wrote: > hi > checked in. > > > i reindented your patch and changed some stuff like space between a > function name and the '(' Is there a standard 'indent' command line that would be appropriate for WireShark sources? For instance in the JXTA-C project (which I work on) we doc

[Wireshark-dev] New packet disassembly module

2006-07-14 Thread Sean Sheedy
Attached is a packet disassembly module I wrote for Pegasus Lightweight Stream Control, a protocol used by some cable set-top boxes for video-on-demand. I would appreciate it being added to the source base. Thanks. Sean -- Sean Sheedy [EMAIL PROTECTED] /* pac

[Wireshark-dev] Expert dialog [patch] needed?

2006-07-14 Thread Martin Mathieson
Hi, I noticed a while back that the "Expert Info" dialog sometimes wasn't catching items that appeared in "Expert Info Composite". I'm currently using the attached patch, i.e. at the end of expert_dlg_init() I call: cf_redissect_packets(&cfile); instead of cf_retap_packets(&cfile, FAL

Re: [Wireshark-dev] Repository updates

2006-07-14 Thread Gerald Combs
Guy Harris wrote: > On Jul 13, 2006, at 3:58 PM, Gerald Combs wrote: > >> Yes, and yes. Right now in the repository root we have: >> >>/trunk - The repository everyone should be using for development. > > Which could be thought of as the equivalent of CVS "top of tree". > >>/trunk-0.99.

Re: [Wireshark-dev] More Diameter [patches]

2006-07-14 Thread Martin Mathieson
And with them attached. Martin Mathieson wrote: Hi, These patches - add a few more chargecontrol AVPs, and add the vendor-id where needed - report as expert info when AVPs' lengths don't match their type Regards, Martin ___ Wireshark-dev mailing l

[Wireshark-dev] More Diameter [patches]

2006-07-14 Thread Martin Mathieson
Hi, These patches - add a few more chargecontrol AVPs, and add the vendor-id where needed - report as expert info when AVPs' lengths don't match their type Regards, Martin ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark

[Wireshark-dev] [Patch] Another SIP response code for stats

2006-07-14 Thread Martin Mathieson
Hi, This adds the code 429 ("Provide Referrer Identity", from RFC 3892) to SIP stats. Regards, Martin Index: gtk/sip_stat.c === --- gtk/sip_stat.c (revision 18734) +++ gtk/sip_stat.c (working copy) @@ -127,6 +127,7 @@

Re: [Wireshark-dev] New dissector: PANA

2006-07-14 Thread ronnie sahlberg
checked in can you upload the/a capture file to the SampleCaptures page of the wireshark wiki so it gets pulled in to fuzztesting? please also create a wiki page for this protocol. it does not take much time. i made some changes to the code and strengthened the heuristics. is is very import

Re: [Wireshark-dev] Kismet protocol dissector

2006-07-14 Thread ronnie sahlberg
hi checked in. i reindented your patch and changed some stuff like space between a function name and the '(' for the next patch, please send it as a unified diff against current svn instead of the entire file so it is easier to review. i made some changes as removing the spaces between the