Alexandre Julliard wrote:
> Nikolay Sivov writes:
>
>
>> @@ -4,7 +4,7 @@ SRCDIR= @srcdir@
>> VPATH = @srcdir@
>> MODULE= gdiplus.dll
>> IMPORTLIB = gdiplus
>> -IMPORTS = uuid shlwapi oleaut32 ole32 user32 gdi32 kernel32
>> +IMPORTS
Marcus Meissner wrote:
> Hi,
>
> CID 69, section name NULL will just crash in the calls below and
> without it we cannot work anyway. So return FALSE;
>
> Ciao, Marcus
> ---
> dlls/kernel32/profile.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/dlls/kernel32/profi
Alexandre Julliard wrote:
> Nikolay Sivov writes:
>
>
>> @@ -0,0 +1,34 @@
>> +/*
>> + * Property schema routines
>> + *
>> + * Copyright 2009 Nikolay Sivov
>> + *
>> + * This library is free software; you can redistribute it and/or
>>
Christoph von Wittich wrote:
> dlls/kernel32/comm.c | 55
> +++--
> 1 files changed, 35 insertions(+), 20 deletions(-)
>
> diff --git a/dlls/kernel32/comm.c b/dlls/kernel32/comm.c
> index d83eacb..11cfda0 100644
> --- a/dlls/kernel32/comm.c
> +++ b/dl
Rob Shearman wrote:
> 2009/2/5 Nikolay Sivov :
>
>> Changelog:
>>- Check for null endpoint in RpcServerUseProtseqEpExW.
>> Installed IE8 RC1 crashes on this call, parameter set is specified in
>> test case.
>>
>> >From 89f889b2c7a7543
EA Durbin wrote:
> I just saw this linux distribution on distrowatch. They claim to be
> able to run all microsoft products. Interesting.
> http://www.imagicos.com/
> http://www.imagicos.com/microsoft.html
>
>
> Windows Live™
Andrew Talbot wrote:
> Changelog:
> itss: Replace malloc() with HeapAlloc().
>
> diff --git a/dlls/itss/lzx.c b/dlls/itss/lzx.c
> index b5fdfc7..0ffeeb6 100644
> --- a/dlls/itss/lzx.c
> +++ b/dlls/itss/lzx.c
> @@ -36,15 +36,17 @@
> *
Vincent Povirk wrote:
> This is a very simple drawing test that I've created to establish a precedent
> for drawing tests in gdiplus.
>
> Gdiplus currently has no tests that draw things and then check what was
> drawn. I've added some functions that should make this easy. It's important
> to get
Vincent Povirk wrote:
>> As for me I'm not against it if it'll work stably, but will this really
>> help? It's much easier to check this visually, comparing with native output.
>>
> I think it will help. It should be stable as long as we are careful
> about how strict the tests are. It's proba
Aric Stewart wrote:
> ---
> dlls/gdiplus/graphics.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c
> index 2673042..c276a43 100644
> --- a/dlls/gdiplus/graphics.c
> +++ b/dlls/gdiplus/graphics.c
> @@ -1901,7 +1901,8
André Hentschel wrote:
> sorry, had the wrong mail-account last time.
> updating the man-page of winemaker.
> there were such old things, there was dust on it!
>
>
>
>
No attachment here...
Anything wrong with that?
http://www.winehq.org/pipermail/wine-patches/2009-February/069267.html
http://www.winehq.org/pipermail/wine-patches/2009-February/069273.html
Austin English wrote:
> Needed by photoshop cs4. See bug 16385.
>
> diff --git a/dlls/atmlib/atmlib_main.c b/dlls/atmlib/atmlib_main.c
> new file mode 100644
> index 000..bb17989
> --- /dev/null
> +++ b/dlls/atmlib/atmlib_main.c
> @@ -0,0 +1,45 @@
> +/*
> + * MSSIGN32 implementation
> + *
>
Building today crosstests I've got:
i586-mingw32msvc-gcc -c -I. -I. -I../../../include -I../../../include
-g -O2 -o inputprocessor.cross.o inputprocessor.c
i586-mingw32msvc-gcc -c -I. -I. -I../../../include -I../../../include
-g -O2 -o testlist.cross.o testlist.c
i586-mingw32msvc-gcc input
hal,0x001b,0x,0x,0xc0,0x00,0x00,0x00,0x00,0x00,0x00,0x46);
DEFINE_GUID(IID_IBindStatusCallbackHolder,0x79eac9cc,0xbaf9,0x11ce,0x8c,0x82,0x00,0xaa,0x00,0x4b,0xa9,0x0b);
Could this be a reason of my failed build?
> Nikolay Sivov wrote:
>> Building today crosstests I've got:
>>
>
Nicolas Le Cam wrote:
> 2009/2/19 Nikolay Sivov :
>
>> Nicolas Le Cam wrote:
>>
>>> 2009/2/18 Nikolay Sivov :
>>>
>>>
>>>> Building today crosstests I've got:
>>>>
>>>> i586-mingw32msvc-gcc
Austin English wrote:
> On Thu, Feb 19, 2009 at 9:21 AM, Nikolay Sivov wrote:
>
>> Changelog:
>>- Don't import uuid library cause it could break crosstest
>>
>> >From 26890998dc20bd31c2d23b8b59dfaf664ca98dc0 Mon Sep 17 00:00:00 2001
>> From: Ni
Silver Blade wrote:
> Hi guys,
>
> Whilst looking into some winmm.dll modifications for ReactOS, I found
> that the Drivers and Drivers32 registry keys (used for determining the
> wavemapper, midi devices etc.) effectively replace those entries found
> in SYSTEM.INI of previous Windows version
Andreas Rosenberg wrote:
+TRACE("%p %s %p\n", hToken, debugstr_w(lpProfileDir), lpcchSize );
+/* profile specific tokens not supported, so hToken ignored */
+
+SetLastError(0);
+res =
RegOpenKeyExW(HKEY_LOCAL_MACHINE,profile_pathname,0L,KEY_QUERY_VALUE,&keyProfileDir);
Why
Andreas Rosenberg wrote:
> On Monday 02 March 2009 17:26:47 Nikolay Sivov wrote:
>
>> Andreas Rosenberg wrote:
>>
>> +TRACE("%p %s %p\n", hToken, debugstr_w(lpProfileDir), lpcchSize );
>> +/* profile specific tokens not supported, so hToken
Alexandre Julliard wrote:
Nikolay Sivov writes:
@@ -775,6 +777,16 @@ STATUSBAR_SetTextT (STATUS_INFO *infoPtr, INT nPart, WORD
style,
strcpyW (ntext, text);
} else ntext = 0;
+ /* replace nonprintable characters with spaces */
+ if (ntext) {
+ idx
Andreas Rosenberg wrote:
+if ( !lpcchSize ) {
+SetLastError(ERROR_INVALID_PARAMETER);
+return FALSE;
+SetLastError(ERROR_MORE_DATA);
+}
+}
+}
+else
+SetLastError(ERROR_REGISTRY_CORRUPT);
+}
+
Andreas Rosenberg wrote:
Nikolay Sivov wrote:
Andreas Rosenberg wrote:
+if ( !lpcchSize ) {
+SetLastError(ERROR_INVALID_PARAMETER);
+return FALSE;
+SetLastError(ERROR_MORE_DATA);
+}
+}
+}
+else
Andreas Rosenberg wrote:
Test looks better but:
+r = OpenProcessToken(GetCurrentProcess(), TOKEN_QUERY|TOKEN_DUPLICATE, &htoken);
+expect(TRUE, r);
+
+r = GetUserProfileDirectoryW(htoken , NULL, NULL );
+lastError = GetLastError();
+expect(FALSE, r);
+expect(last
Andreas Rosenberg wrote:
Fails on XP SP2 with:
---
userenv.c:308: Test failed: Expected 1, got 39
userenv: 92 tests executed (0 marked as todo, 1 failure), 0 skipped.
---
Much less important but still: please remove trailing whitespaces.
'git apply' should not pro
Robert Wilhelm wrote:
Initial vbscript stubs, similar to jscript.
Diff looks corrupted by mailing application. Lines are wrapped.
Robert Wilhelm wrote:
Second try, now patch as attachment.
1) Please don't add autogenerated files to patch.
configure |9
configure.ac |1 +
2) Patches [2/n] and [3/n].
Each patch should contain all related changes to be usefu
Andrey Turkin wrote:
Hi Nikolay,
There are few issues:
+.BI wineserver\ [options]
+.SH ОПИСАНИЕ
+.B wineserver
+это сервис предоставляющая процессам Wine аналогичные набор функций, который
no comma after сервис; it should be "предоставляющий"; probably should
be "набор функций, ан
>/From c419ca8f87ae3103e63604d9646d3851a5d959e7 Mon Sep 17 00:00:00 2001
/From: Nikolay Sivov http://www.winehq.org/mailman/listinfo/wine-patches>>
Date: Sun, 22 Mar 2009 18:43:46 -0400
Subject: Implement TCM_REMOVEIMAGE
It's wrong in case when several tabs use same image. Please ignore it.
Vitaliy Margolen wrote:
Nikolay Sivov wrote:
Changelog:
- try2: fix for several items with a same image case
- implement TCM_REMOVEIMAGE
What about this comment from msdn?
-
The tab control updates each tab's image index, so each tab remains
associated with the
Vitaliy Margolen wrote:
Nikolay Sivov wrote:
Changelog:
- try2: fix for several items with a same image case
- implement TCM_REMOVEIMAGE
What about this comment from msdn?
-
The tab control updates each tab's image index, so each tab remains
associated with the
Paul Vriens wrote:
Nikolay Sivov wrote:
IE8 requested this.
Changelog:
- Implemented GetWindowRgnBox with tests
+static void test_winregion()
+{
+HWND hwnd;
+RECT r;
+int ret;
+HRGN hrgn;
+
+hwnd = CreateWindowExA(0, "static", NULL, WS_VISIBLE, 10, 10,
10, 1
Robert Lunnon wrote:
I Get the following unimplemented call in Wine 1.1.16 when using the
word 2007 file-selector
wine: Call from 7fbb155b to unimplemented function
shdocvw.dll.IEILIsEqual, aborting
Hints anyone
Hi, Robert. Post bug reports here http://bugs.winehq.org/ .
Joris Huizer wrote:
Hi, Joris. Thanks for spotting this, but changes you've made will fail
on Windows. I've just sent a corrected version with one test more.
Here it is if you're interested:
http://www.winehq.org/pipermail/wine-patches/2009-April/071433.html
Joris Huizer wrote:
--- On Thu, 4/2/09, Nikolay Sivov wrote:
From: Nikolay Sivov
Subject: Re: dlls/comctl32/tests/listview.c: fix ok statements to actually test
something
To: wine-devel@winehq.org, joris_hui...@yahoo.com
Date: Thursday, April 2, 2009, 2:04 PM
Joris Huizer wrote
Vitaliy Margolen wrote:
Nikolay Sivov wrote:
With patch this time.
This makes hottracked tab button look like it does in native.
Bounding rectangle is still wrong but it's another problem,
anyway now it looks better.
Maybe you should fix that rectangle first? There wer
remi.assai...@free.fr wrote:
Hi all,
I'm submitting the PulseAudio patch from Arthur Talyor.
As most distros have PulseAudio by default Wine should provide
upstream support.
Both Fedora and Mandriva have included this work and it is reported to
work very well.
I used latest patch from http:/
Igor Tarasov wrote:
Hi there!
I try to implement as precise as possible one undocumented feature in
comctl32, this all deals with one structure field. After lots of
testing I know the following:
1. Default value for that field returned by getter is 0.
2. By default it is ignored in behavior.
3.
Igor Tarasov wrote:
2009/4/10 Nikolay Sivov :
Igor Tarasov wrote:
Hi there!
I try to implement as precise as possible one undocumented feature in
comctl32, this all deals with one structure field. After lots of
testing I know the following:
1. Default value for that field returned by
Alexandre Julliard wrote:
Module: wine
Branch: master
Commit: b5dbbd4f3a16d074f0bdff39077973efdffe6c55
URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b5dbbd4f3a16d074f0bdff39077973efdffe6c55
Author: Christian Costa
Date: Mon Apr 13 10:07:35 2009 +0200
amstream/tests: Beginning of
André Hentschel wrote:
This is needed to bring up IE8. Otherwise there is a Backtrace:
=>0 0x7e80198d SHDefExtractIconW+0x7d(pszIconFile=0x32e310, iIndex=0,
uFlags=0, phiconLarge=(nil), phiconSmall=0x32e30c, nIconSize=1048592)
---
dlls/shell32/iconcache.c |4 ++--
1 files changed, 2 inser
André Hentschel wrote:
Ok, corrected that.
But where to go with the test case? create a new testfile for iconcache?
Sure, why not, if no relevant file exists already to place it in.
Paul Vriens wrote:
Nikolay Sivov wrote:
Changelog:
- Additional tests for LVM_GETSUBITEMRECT
From 2f2cb8e54b81ff6be7229b7931945a3bb76f4bde Mon Sep 17 00:00:00 2001
From: Nikolay Sivov
Date: Wed, 22 Apr 2009 13:05:56 -0400
Subject: Additional tests for LVM_GETSUBITEMRECT
---
dlls
Paul Vriens wrote:
Nikolay Sivov wrote:
Paul Vriens wrote:
Nikolay Sivov wrote:
Changelog:
- Additional tests for LVM_GETSUBITEMRECT
From 2f2cb8e54b81ff6be7229b7931945a3bb76f4bde Mon Sep 17 00:00:00
2001
From: Nikolay Sivov
Date: Wed, 22 Apr 2009 13:05:56 -0400
Subject: Additional
Dimitriu Petru wrote:
2009/4/26 Dimitriu Petru :
Ok then, regarding Romanian translations...
ReactOS would appreciate if I retain the Windows-like terminology but
I'm going to use Anulare instead of Renunţă. Please notice that
Renunţă, Aplică, Deschide, Salvează etc. are imperative verbs, while
W
Massimo Del Fedele wrote:
This one implements GdipBitmapSetPixel() besides unhandled alpha channel.
Ciao
Max
+SetPixel(hdc, x, y, ((color << 16) & 0xff) | (color & 0x00ff00) | ((color
>> 16) & 0xff));
Use ARGB2COLORREF(ARGB color) from gdiplus.c for that.
Massimo Del Fedele wrote:
Massimo Del Fedele ha scritto:
Should work for both DIBs and DDBs format, but strange enough the
IPicture bitmap
inside wine gdiplus bitmap is always a 32 bit DDB by now... haven't
found any
other case.
Ciao
Max
Dan Kegel wrote:
Hi Martin,
thanks for the patch. Two suggestions:
1) if possible, please write a conformance test.
2) It appears you're a ReactOS developer, so you should
expect some turbulence. You may have to go
the "file a really good bug" route if Wine
can't accept your patches.
- Dan
Joel Holdsworth wrote:
Is there a reason why my patch (attached) hasn't been included yet? This
is my first patch, so maybe someone can help me get it in.
Joel+
Just a quick look:
1)
+Sleep(200);
+
+return hWnd;
+}
+
Why are you sleeping here?
2) Why do you need a window here? It
Vitaliy Margolen wrote:
André Hentschel wrote:
I made one patch out of them and improved my tests.
now i wonder again why its not getting in...
You should use SNDMSGW.
Vitaliy.
No actually. Native uses ListView_SetItemState for that macro which is
SNDMSGA in wine and SNDMSG in n
André Hentschel wrote:
now using SNDMSGW
---
dlls/comctl32/listview.c |1 -
dlls/comctl32/tests/listview.c |8
include/commctrl.h |6 ++
3 files changed, 14 insertions(+), 1 deletions(-)
I still don't follow you. How will it run on systems without unico
André Hentschel wrote:
now PSDK compatible
---
dlls/comctl32/listview.c |1 -
dlls/comctl32/tests/listview.c |8
include/commctrl.h |6 ++
3 files changed, 14 insertions(+), 1 deletions(-)
Still wrong:
+#define ListView_SetCheckState(hwndLV, i, bCheck
Stefan Stranz wrote:
Fixes bug #13867
Original fix by GameZelda
A test needed for such changes. Especially for that part:
@@ -519,7 +519,7 @@ static inline int textcmpWT(LPCWSTR aw, LPCWSTR bt, BOOL
isW)
if (!aw) return bt ? -1 : 0;
if (!bt) return aw ? 1 : 0;
if (aw == LPSTR_TEXTC
. After that my Gecko setup script
failed and did not even try to start up Steam.
Same problem here. Grr. Time for a regression test.
Regression test says:
commit 24d6c88d16c46f00d99fd8529196590aca88b0f4
Author: Nikolay Sivov
Date: Wed May 13 23:23:57 2009 +0400
comctl32/tab
Vincent Povirk wrote:
From 1de9b2291bf9a5617ca1e3b0cba5f1260889c259 Mon Sep 17 00:00:00 2001
From: Vincent Povirk
Date: Mon, 23 Mar 2009 16:34:12 -0500
Subject: [PATCH] gdiplus: implement GdipTransformPoints
It's a strange way to check enumeration with integer comparison, isn't it?
And not c
Vincent Povirk wrote:
It's odd, but it seems like the simplest way to write this.
I've tried what I think was your suggestion, and that's attached. I
don't think it's an improvement.
Vincent Povirk
Could be a single switch maybe. Don't know, looks better for me.
Comparisons were really ugl
Hi.
I've just prepared some simple MRU tests and I need test them on various native
platfoms -
tested only on xp sp2 so this one could be skipped.
Could somebody do it?
comctl32_mru_090524.patch
Description: application/mbox
Ge van Geldorp wrote:
From: Nikolay Sivov
I've just prepared some simple MRU tests and I need test them on various
native platfoms -
tested only on xp sp2 so this one could be skipped.
Could somebody do it?
Your tests pass on my W2K, XP, W2K3, Vista and W2K8 machines,
Ge van Geldorp wrote:
Hi Nikolay,
From: Nikolay Sivov [mailto:bungleh...@gmail.com]
Ge van Geldorp wrote:
From: Nikolay Sivov
I've just prepared some simple MRU tests and I need test them on various
native platfoms -
tested only on xp sp2 so this one could be skipped.
Sergey Khodych wrote:
From a2bf101f7ede3937373b7b8f9e2a8ea032b7790d Mon Sep 17 00:00:00 2001
From: Sergey Khodych
Date: Mon, 25 May 2009 02:21:39 +0300
Subject: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.
---
dlls/comctl32/rebar.c | 12
dlls/comctl32
Paul Vriens wrote:
Nikolay Sivov wrote:
Changelog:
- Basic LVM_GETVIEWRECT tests
+todo_wine expect(104, rect.right);
+expect(0, rect.top);
+expect(73, rect.bottom);
The first and last one of these 3 introduces errors on several boxes
(see test.winehq.org). I guess these
Sergey Khodych wrote:
Nikolay Sivov пишет:
Where did you test that it isn't stored?
The patch fixes a bug when wine allocates an extra space for a band with
an empty string. I replaced NULL by "" in the size test to show the
native realization doesn't change its behavior
Hib Eris wrote:
Hi all,
hmm, I've tested it again with current git, and it still works fine here.
I have looked at my new code and it does not seem wrong to me, but
maybe it is somewhere else. Unfortunately, as I cannot reproduce this
failure, I have no idea how to debug it. Does this fail for
Paul Vriens wrote:
Nikolay Sivov wrote:
This test fails to create window sometimes on Win95,
let's turn it into general failure.
Changelog:
- replace assert() with ok() test
From b63fc6defb497505ecaab4921449327e875ab252 Mon Sep 17 00:00:00 2001
From: Nikolay Sivov
Date: Wed, 2
Paul Vriens wrote:
Paul Vriens wrote:
Nikolay Sivov wrote:
This test fails to create window sometimes on Win95,
let's turn it into general failure.
Changelog:
- replace assert() with ok() test
From b63fc6defb497505ecaab4921449327e875ab252 Mon Sep 17 00:00:00 2001
From: Nikolay
Paul Vriens wrote:
Maybe it's true. But what about two others boxes:
http://test.winehq.org/data/bf353f180d622cbf8508af7dbc9590e33293a6ab/95_gvg-w95/version.html
http://test.winehq.org/data/bf353f180d622cbf8508af7dbc9590e33293a6ab/95_fg-win95/version.html
Version reported as 4.0, so it's pu
Paul Vriens wrote:
Nikolay Sivov wrote:
+ok(hwnd != NULL, "Expected window to be created\n");
+if (!hwnd)
+{
+win_skip("IPAddress control not implemented\n");
+return;
+}
/* check text just after creation */
r = GetWindowText
Sergey Khodych wrote:
Nikolay Sivov пишет:
It looks like you need to add a simple test like that:
- add band with empty string and RBBIM_TEXT mask of course;
- query band data back with RB_GETBANDINFO and check this lpText field.
If it's really NULL (e.g. your buffer didn't chang
Sergey Khodych wrote:
From 37cd774e71f8d260d94bd672715b1eab879c4b2d Mon Sep 17 00:00:00 2001
From: Sergey Khodych
Date: Thu, 28 May 2009 04:52:45 +0300
Subject: comctl32:rebar: Don't store an empty string in REBAR_InsertBandT.
---
dlls/comctl32/rebar.c | 12
dlls/comctl32
Sergey Khodych wrote:
Nikolay Sivov пишет:
If a band has an empty string, wine allocates a padding space in
lpBand->rcCapText that causes an offset in a band.
It looks like a workaround, if get/set text behaves ok now (no tests
exist I suppose) then
the only place to be changed is t
Vincent Povirk wrote:
I think you should add @ stdcall DdQueryDisplaySettingsUniqueness() line
to gdi32.spec file, otherwise you will get message like this:
err:module:find_forwarded_export function not found for forward
'gdi32.DdQueryDisplaySettingsUniqueness' used by L"C:\\windows\\system32
\\g
Hi.
I'm thinking about adding a possibility to test both previous comctl32
and version 6 (or greater maybe in next versions).
For example if I compiled in a manifest resource for 6.0 I'll get 6.0
loaded on >= XP,
but the best variant for me is to load not manifest aware version first,
then unl
Josselin Bardet wrote:
Hi,
As next of the discussion on the bug 18772
(http://bugs.winehq.org/show_bug.cgi?id=18772), I send here the
implemenation for User32.PrintWindow function
I've tested it with an application that was crashing because of this
unimplemented function.
Regards
Jos
As I alr
Josselin Bardet wrote:
Nikolay Sivov a écrit :
As I already said in bugzilla:
- use SendMessageW
- add FIXME for unused flags or use them
- no need for brackets around SendMessage
- add a simple test (if native send this message - you can check it
easily with Spy in Windows)
Proposed
André Hentschel wrote:
related to Bug 4742
try2: fixed indentation
---
dlls/user32/edit.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
---
- countA = strlen(textA) + 1;
+if(textA)
+countA = strlen(textA) + 1;
}
--
André Hentschel wrote:
Nikolay Sivov schrieb:
André Hentschel wrote:
related to Bug 4742
try2: fixed indentation
---
dlls/user32/edit.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
---
-countA = strlen(textA) + 1;
+if(textA)
+countA
Paul Vriens wrote:
Andrew Eikum wrote:
This patch was submitted back on Tuesday and I haven't received a
response one way or the other about it. Does anyone see anything
immediately wrong with it?
I more-or-less copied the functionality of test_GdipDrawBezier right
above, testing each of th
Andrew Eikum wrote:
Nikolay Sivov wrote:
Paul Vriens wrote:
Andrew Eikum wrote:
This patch was submitted back on Tuesday and I haven't received a
response one way or the other about it. Does anyone see anything
immediately wrong with it?
I more-or-less copied the functionali
Andrew Eikum wrote:
Nikolay Sivov wrote:
Exactly, you should patch code too, not only tests. In this
particular case it's better to check count first and return
InvalidParameter and check
for GdipAlloc result and return OutOfMemory if it's NULL.
Okay, excellent. I'll mak
Hi.
Does anyone no whose box is it (dr-asus)? It has some (actually always
10) test failures for ListView and
I think it's possible to find a cause. Same failures on 2k and XP actually.
I'd like to contact owner for testing some patches.
Thanks.
Ken Sharp wrote:
These stubs stop three crashes in Photoshop CS4.
>From 4e5dd892a7a577001072fd7701467c262c483b1f Mon Sep 17 00:00:00 2001
From: Ken Sharp
Date: Tue, 9 Jun 2009 21:48:05 +0100
Subject: [PATCH] gdiplus: Add stubs for GdipGetVisibleClipBoundsI,
GdipDrawDriverString & GdipMeasureDri
Ken Sharp wrote:
I must have missed this. This would be incredibly useful.
Does this affect all users though? Anastasius Focht would probably go
over these limits but his comments are helpful.
Vitaliy Margolen wrote:
Vitaliy Margolen wrote:
The limits are:
20 lines for logs (fixme, trace,
Ken Sharp wrote:
Nikolay Sivov wrote:
What is the purpose of that change? To reduce mailed amount or what?
To improve readability of reports?
Log quotation are very useful sometimes and this blocking only makes
things harder for people who knows
what they're pasting.
Davide Pizzetti wrote:
Here are the italian translations for winecfg.
1. Use 'git diff' format to produce patches
2. Use plain text attachments.
Feel free to ask here any related questions.
Davide Pizzetti wrote:
i've got a question: how i produce a patch with 'git diff'? what is the
correct syntax of the command?
Il giorno mer, 24/06/2009 alle 19.17 +0400, Nikolay Sivov ha scritto:
Davide Pizzetti wrote:
Here are the italian translations for winecfg.
Davide Pizzetti wrote:
Here's the italian translation for cmdlgtst
- MENUITEM "Pa&ge Setup", CM_U_PAGESETUP
+ MENUITEM "Installazione Pa&gina", CM_U_PAGESETUP
}
Correct me if I'm wrong, but it looks like you treated this as
'installation page',
but it really means 'print page setup' - p
Davide Pizzetti wrote:
Here's the italian translation for winedbg
This is wrong of course - you broke English resource file.
You need to create a new file here with same naming convention
(rsrc_It.rc) and 'git add' it to your tree before commit.
Davide Pizzetti wrote:
Here's the italian translation for winedbg
Hi, Davide.
This patch is malformed too.
When you need to create new file in repo, first create it in your file
system, then do 'git add programs/winedbg/rsrc_It.rc' .
This will add it to your repo. Don't forget to edit rsrc
Davide Pizzetti wrote:
i think i made a little mess with the files for winedbg. how do i
restore the situation to the previous state?
Il giorno dom, 28/06/2009 alle 16.14 +0400, Nikolay Sivov ha scritto:
Davide Pizzetti wrote:
Here's the italian translation for winedbg
Davide Pizzetti wrote:
Another question: when i create a new language translation file, i have
to copy the english file into a new file and translate it?
Il giorno dom, 28/06/2009 alle 16.14 +0400, Nikolay Sivov ha scritto:
Davide Pizzetti wrote:
Here's the italian translatio
Davide Pizzetti wrote:
Il giorno dom, 28/06/2009 alle 16.39 +0400, Nikolay Sivov ha scritto:
Davide Pizzetti wrote:
i think i made a little mess with the files for winedbg. how do i
restore the situation to the previous state?
Il giorno dom, 28/06/2009 alle 16.14 +0400, Nikolay Sivov
Davide Pizzetti wrote:
I've got another question: i've created some new files and translated
them into italian. How can i submit them as a patch? I made a git diff
but these files i created don't appear there
As I told you. Do 'git add '. This will
add it to your local repo.
Davide Pizzetti wrote:
Il giorno dom, 28/06/2009 alle 17.43 +0400, Nikolay Sivov ha scritto:
Davide Pizzetti wrote:
I've got another question: i've created some new files and translated
them into italian. How can i submit them as a patch? I made a git diff
but these files
Kovács András wrote:
Hi,
This patch is for GetTitleBarInfo, when it gets NULL hwnd and/or pti
parameter.
GTA IV tries to use this function with NULL, NULL parameters.
This doesn't hurt Windows, but crashes in wine.
Tested against Windows 7.
Best Regards,
Andras Kovacs
I think IsWindow()
Kovács András wrote:
Hi,
This patch is for GetTitleBarInfo, when it gets NULL hwnd and/or pti
parameter.
GTA IV tries to use this function with NULL, NULL parameters.
This doesn't hurt Windows, but crashes in wine.
Tested against Windows 7.
Best Regards,
Andras Kovacs
---
TRACE("(%p
Kovács András wrote:
Hi,
GetTitleBarInfo tests for NULL values.
Best Regards,
Kovács András
What about this one:
---
ret = GetTitleBarInfo(NULL, NULL);
---
What error code will come first?
Michael Stefaniuc wrote:
Hello Nikolay,
Nikolay Sivov wrote:
Michael Stefaniuc wrote:
instead of including them from an other rc file.
---
What is the purpose of these changes? I'm not talking it's wring :),
just interested.
Well, Alexandre did the first
Andrew Eikum wrote:
---
dlls/gdiplus/gdiplus_private.h |3 +
dlls/gdiplus/graphics.c| 154 ++--
include/gdiplusflat.h |1 +
3 files changed, 152 insertions(+), 6 deletions(-)
This looks wrong for me cause I don't think you could pa
Alexander Nicolaysen Sørnes wrote:
Hello,
Could someone give me a hint as to what is wrong with the following patches?
http://www.winehq.org/pipermail/wine-patches/2009-June/074908.html
http://www.winehq.org/pipermail/wine-patches/2009-June/074909.html
They only adds some defines plus a stub,
Andrew Eikum wrote:
Nikolay Sivov wrote:
Andrew Eikum wrote:
---
dlls/gdiplus/gdiplus_private.h |3 +
dlls/gdiplus/graphics.c| 154
++--
include/gdiplusflat.h |1 +
3 files changed, 152 insertions(+), 6 deletions(-)
This looks
1 - 100 of 990 matches
Mail list logo
