Re: gdi32/tests: Use the ANSI text metrics so the tests work on win9x.

On Thu, Feb 12, 2009 at 01:40:54PM +0100, Paul Vriens wrote: > Huw Davies wrote: >> --- >> dlls/gdi32/tests/font.c | 20 ++-- >> 1 files changed, 10 insertions(+), 10 deletions(-) >> >> >> -

Re: Problem with compiling ole32 crosstest

On Fri, Feb 13, 2009 at 02:01:35PM +0300, Vitaly Perov wrote: > Hi! > > Does anybody have a problem compilling the crosstest of ole32? > Or maybe it's only my fault? > > I have: > usrmarshal.cross.o: In function `func_usrmarshal': > /srv/vitperov/Projects/wine-dev/dlls/ole32/tests/usrmarshal.c:44

Re: [PATCH 5/5] user32/tests: Fix tests on win9x.

On Tue, Apr 21, 2009 at 11:34:04AM +0200, Paul Vriens wrote: > Huw Davies wrote: >> On Tue, Apr 21, 2009 at 11:22:29AM +0200, Paul Vriens wrote: >>> Huw Davies wrote: >>>> --- >>>> dlls/user32/tests/clipboard.c |7 +-- >>&

Re: [PATCH 5/5] user32/tests: Fix tests on win9x.

On Tue, Apr 21, 2009 at 11:22:29AM +0200, Paul Vriens wrote: > Huw Davies wrote: >> --- >> dlls/user32/tests/clipboard.c |7 +-- >> 1 files changed, 5 insertions(+), 2 deletions(-) >> >> >> ---

Re: [PATCH 1/2] ole32: Register the clipboard formats at load time.

On Thu, Apr 23, 2009 at 03:40:11PM +0200, Alexandre Julliard wrote: > Huw Davies writes: > > > --- > > dlls/ole32/clipboard.c | 54 > > + > > dlls/ole32/compobj.c |2 + > > dlls/ole32/compobj_priva

Re: [2/2] winex11.drv: export copied images as image/bmp

On Fri, May 01, 2009 at 01:25:33PM +0200, Alexandre Julliard wrote: > "Vincent Povirk" writes: > > > +if (dibinfo->biBitCount < 16) > > +numcolors = dibinfo->biClrUsed || 1 > You have been doing too much Perl ;-) Hi Vincent, You may find bitmap_info_size() useful here

Re: ntdll/tests: Mark return value of RtlUnicodeStringToInteger("", 16) as broken for nt4.

On Tue, May 19, 2009 at 03:39:07PM +0200, Alexandre Julliard wrote: > Paul Vriens writes: > > > I don't think this is correct. This test has always succeeded until > > March 9th. There haven't been any changes to the test in that period, > > but I remember an upgrade of winehq in that weekend. >

Re: oleaut32/tests: Add some tests for [lcid] parameters.

On Wed, Jun 17, 2009 at 03:58:33PM +0200, Paul Vriens wrote: > Huw Davies wrote: >> --- >> dlls/oleaut32/tests/tmarshal.c | 53 >> +++- >> dlls/oleaut32/tests/tmarshal.idl |6 +++ >> dlls/oleaut32/tests/tmarsh

Re: [PATCH 4/4] gdi32: Add tests for the GetWinMetaFileBits MFCOMMENT record.

On Tue, Jun 30, 2009 at 12:40:54PM +0200, Paul Vriens wrote: > Huw Davies wrote: >> --- >> dlls/gdi32/tests/metafile.c | 80 >> +++ >> 1 files changed, 80

Re: msctf: fully clear the Variant before setting it.

On Wed, Jul 01, 2009 at 10:29:22AM -0500, Aric Stewart wrote: > diff --git a/dlls/msctf/compartmentmgr.c b/dlls/msctf/compartmentmgr.c > index 3afcfda..e1c7187 100644 > --- a/dlls/msctf/compartmentmgr.c > +++ b/dlls/msctf/compartmentmgr.c > @@ -537,6 +537,7 @@ static HRESULT WINAPI Compartment_GetV

Re: [PATCH 1/5] msdaps: Use 2 byte structure packing.

On Mon, Aug 24, 2009 at 01:51:24PM +0200, Alexandre Julliard wrote: > Huw Davies writes: > > > diff --git a/dlls/msdaps/Makefile.in b/dlls/msdaps/Makefile.in > > index d6f71a0..cebf659 100644 > > --- a/dlls/msdaps/Makefile.in > > +++ b/dlls/msdaps/Makefil

Re: winetest: Add the ability to retrieve the dll path for com dlls from the registry.

Paul Vriens wrote: The attached patch fixes the issue. We are using LOAD_LIBRARY_AS_DATAFILE as we don't really want to load the dll but we need some info from it. The problem is that GetModuleFileName can't cope with LOAD_LIBRARY_AS_DATAFILE loaded dlls. So will using LoadLibrary introduce

Re: oledb32: Implement CanConvert.

On Mon, Sep 21, 2009 at 03:36:21PM +0200, Marcus Meissner wrote: > On Mon, Sep 21, 2009 at 01:50:51PM +0100, Huw Davies wrote: > > +if(src_type & DBTYPE_VECTOR || dst_type & DBTYPE_VECTOR) return > > S_FALSE; > > I think this needs brackets... Why? It&#x

Re: Wine fonts too big for their input fields.

On Wed, Apr 12, 2006 at 10:14:58AM -0700, Duane Clark wrote: > Huw D M Davies wrote: > > > >MS Shell Dlg maps to either Microsoft Sans Serif or Tahoma depending > >on Windows version; the default wine.inf maps it to Tahoma so you > >should check whether you have tahoma.ttf installed. If in doubt a

Re: Wine fonts too big for their input fields.

On Wed, Apr 12, 2006 at 11:28:21AM -0700, Duane Clark wrote: > Testing more on Win2k shows > that with Tahoma, the edit field sets margins that depend on the font > size. Explicitely setting "Microsoft Sans Serif" gives me the correct > font, and it is indeed True Type, but both margins remain z

Re: Wine fonts too big for their input fields.

On Wed, Apr 12, 2006 at 12:26:07PM -0700, Duane Clark wrote: > Huw Davies wrote: > >Interesting, so to clarify, even a large edit control and a small > >Microsoft Sans Serif has a zero margin? > > Yep. Fascinating. This will probably be a huge clue in working out exactly w

Re: undefined reference to `FT_Load_Sfnt_Table'

On Wed, Apr 12, 2006 at 09:22:10PM +0100, Paul Millar wrote: > On Wednesday 12 Apr 2006 10:49, Saulius Krasuckas wrote: > > WRT suite build fails for quite long time already: [1] > > So that probably was caused by the patch from Huw: [2] > > It may happen because of missing FreeType 2 stuff: [3] >

Re: Wine fonts too big for their input fields.

On Wed, Apr 12, 2006 at 03:13:43PM -0700, Duane Clark wrote: > >Fascinating. This will probably be a huge clue in working out exactly > >what Windows does here - unfortunately, at the moment, I have no idea > >what it means :-( > > > > Hmmm, well I found this: > > http://msdn.microsoft.com/libra

Re: Google Sketch-Up Not Starting

On Mon, May 01, 2006 at 12:09:18PM +0100, Mike Hearn wrote: > On 5/1/06, Andreas Mohr <[EMAIL PROTECTED]> wrote: > >Hmm... ordinal mixup issue? > >Probably it's the error message which is wrong, but possibly it's our > >ChoosePixelFormat which sits at the wrong place... > > I don't think so. It ha

Re: SoC idea: fix wine 2398 bug.

aybe I will have to rewritte wine graphics function > to use only OpenGL (or may be I will found another way). What do you > think about it? One of the hard things about the glScissor approach is coping with clipping other child windows. Have you thought about how to do this yet? Huw. -- Huw Davies [EMAIL PROTECTED]

Re: rpcrt4: Fix some conditional includes

> -#ifdef HAVE_SYS_TYPES > #include > -#endif There is a HAVE_SYS_TYPES_H though. However since HAVE_SYS_TYPES isn't defined, couldn't you remove the #include too? Huw. -- Huw Davies [EMAIL PROTECTED]

Re: Still missing glyph

On Sun, May 14, 2006 at 11:16:29PM +0200, Uwe Bonnes wrote: > even with a recent fontforge, I get "Missing glyph for": > LD_LIBRARY_PATH="../libs/unicode:$LD_LIBRARY_PATH" ../tools/sfnt2fnt > small_fonts.ttf 11 1253 96 128 5 > Missing glyph for char 0385 > ... > > Is this expected behaviour? Yes.

Re: Fonts getting corrupted in x11drv

able to serve, so a new one is created, which ends > up being based on the Tahoma (TrueType) font. On the next paint loop, when > the test program calls SetFont it is the new, scalable font (based on Tahoma) > that is found. Nice catch! This should fix it. Huw. -- Huw Davies [EMAIL PROT

Re: How do fonts work ?

On Mon, May 29, 2006 at 09:44:40PM +1000, Robert Lunnon wrote: > Hmm, more on the Google earth saga, I have been looking at the font traces > and > get things like the following but freetype doesn't support these tags (except > GSUB) ??? ... > Should freetype be able to find these tables ? Free

Re: Re: Wine 1.0 Tasks

out X changes > (But X additions as GLX_EXT_texture_from_pixmap will help a lot). How does this help? Thanks, Huw. -- Huw Davies [EMAIL PROTECTED]

Re: How are we doing?

/* this returns i to the caller */ >return i; > } There's a bug in this code, let's try this: /* change by Huw Davies 02-Jun-2006, to fix the return type of the function */ int the_function_that_adds_one_to_i(int i) { /* this adds one to i */ i = i + 1; /* this returns

Re: FW: RE: My 1.0 wish list

On Sun, Jun 04, 2006 at 12:49:41PM -0500, EA Durbin wrote: > > Why when i edit the code to change this, does it revert back when i compile > it? You need to edit cond.y (bison generates cond.tab.c). Huw.

Re: [Setuapi] implement SetupDiCreateDeviceInfoListExW

t going to be used by functions outside devinst.c? If not then this should be moved into that file. Also please include a test with your patch and, in this case, I think it makes sense to include the appropiate Destroy function too, that way it's easy to check that you haven't introduced a memory leak. Thanks, Huw. -- Huw Davies [EMAIL PROTECTED]

Re: Speed up GetTextExtentExPointW (Take 3)

On Mon, Jul 10, 2006 at 01:24:53PM -0700, Dan Hipschman wrote: > > Hi, > > This is a fix for http://bugs.winehq.org/show_bug.cgi?id=5569 It speeds up > the loading of the EULA for the trial version of Acrobat by about 50x. Since > the last attempt at this fix I improved performance in the case

Re: Pen Widths, and patch etiquette

s then please let me know. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: This patch should fix bug 4863 - Icons in Notes Workspace

On Wed, Aug 09, 2006 at 06:29:56PM -0300, Augusto Arcoverde da Rocha wrote: > Here is the link to the patch which I have sent (thanks VJ): > http://winehq.org/pipermail/wine-patches/2006-July/028932.html > > And the link to the bug report and the subsequent discussion on Wine > bugzilla is: > http

Re: gdi: Implement GetFontUnicodeRanges.

On Sun, Aug 13, 2006 at 08:26:24PM +0200, Hans Leidekker wrote: > > Any word on this patch? > > -Hans > > Changelog > Implement GetFontUnicodeRanges on top of fontconfig and freetype. I wonder whether FcFreeTypeCharSet is what you really want here. It uses a lot of heuristics which almost c

Re: Patch to riched20 (resubmission)

On Sun, Aug 27, 2006 at 05:35:54PM -0700, Mark Lu wrote: > If the rtf control is a child window AND it doesn't display its own context > menu, > then the WM_CONTEXTMENU message should be passed to the parent window in > the rtf > control's DefWindowProc. Here is what MSDN says on the subject: >

Re: ole32: Do a QueryInterface for IOleLink in OleLoad, like native does.

&IID_IPersistStorage, > + (void**)&persistStorage); s/it's/its/ ;-) Huw. -- Huw Davies [EMAIL PROTECTED]

Re: Fix a memory leak, fix a typo in the comment, add a trace

ning table format Hi Dmitry, Wouldn't it be nicer to simply resend the first patch again with these fixes applied? Thanks, Huw. -- Huw Davies [EMAIL PROTECTED]

Re: make test failure

check that the 'Symbol' font is installed before running the test. I'll send a patch in for this in a bit. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: Implement GetKerningPairs for TrueType fonts, take 3

, nPairs) at the start of the loop, then you can eliminate the break and get rid of the kern_pairs_copied variable that basically mirrors i. Thanks, Huw. -- Huw Davies [EMAIL PROTECTED]

Re: Implement GetKerningPairs for TrueType fonts, take 4

On Thu, Sep 21, 2006 at 12:18:51AM +0900, Dmitry Timoshkov wrote: > this version of the patch incorporates another Huw's suggestion > in eliminating redundant local variable and simplifying the code. Thanks Dmitry, Looks good to me. -- Huw Davies [EMAIL PROTECTED]

Re: gdi32: GetTextExtentPoint and GetTextExtentExPoint behavedifferently if there's a \n in the string.

On Thu, Sep 21, 2006 at 01:34:09PM +0900, Dmitry Timoshkov wrote: > "Huw Davies" <[EMAIL PROTECTED]> wrote: > > >-ok(sz1.cx == sz2.cx && sz1.cy == sz2.cy, > >- "results from GetTextExtentExPointW and GetTextExtentPointW > >differ\

Re: gdi32: GetTextExtentPoint and GetTextExtentExPoint behavedifferently if there's a \n in the string.

#x27;ve just sent a patch which removes that test. Thanks, Huw. -- Huw Davies [EMAIL PROTECTED]

Re: Whither msxml?

rently no SAX support, so that could be another area of fruitful work. Some of the helper apis like IXMLHTTPRequest would also be fun. We also don't have a plan for msxml4, so some design decisions regarding this should be made at some point. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: Route WGL font code through gdi32.dll

On Wed, Sep 27, 2006 at 11:34:35PM +0200, Roderick Colenbrander wrote: > Hi, > > This patch routes the WGL font code through gdi32.dll. The patch depends on > the other routing patch which routed the WGL context code through gdi32.dll. > --- dlls/opengl32/opengl32.spec 2006-09-25 23:15:35.0

Re: Route WGL font code through gdi32.dll

linesW You're still forwarding the wrong set of UseFont functions here. Your patch moved wglUseFontBitmaps to gdi32, so you should forward those not wglUseFontOutlines. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: Route WGL font code through gdi32.dll

On Thu, Sep 28, 2006 at 08:20:51PM +0200, Roderick Colenbrander wrote: > Again as mentioned by Huw, the gdi32.spec file wasn't correct. > It should be correct this time. No. Your gdi32.spec was fine. It was the opengl32.spec that was wrong (hint: that's why I quoted that bit of the patch ;-). Y

Re: gdi32: Improve get_nearest_charset().

On Mon, Oct 02, 2006 at 06:42:50AM +0900, Byeong-Sik Jeon wrote: > Use the font linking information at get_nearest_charset(). > MS-Windows do it(equal behavior). Looks good to me. Thanks, Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [gdi32 1/6]: Cleanup the update_font_list().

TRUE); > +RegCloseKey(hkey); Here you only create either the win9x key or the winnt key. I'd prefer that you created both like the old code did. Thanks, Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [TRY2 1/8] gdi32: Cleanup the update_font_info().

On Wed, Oct 04, 2006 at 11:26:49AM +0900, Byeong-Sik Jeon wrote: > Changelog: > Cleanup the updata_font_info(). > > +static void add_nls_font_to_registry( > +HKEY hkey, > +const char *value_name, > +const char *value_data, > +BOOL is_force) > +{ > +

Re: [msxml3] Add IRunnableObject stub implementation

On Tue, Oct 10, 2006 at 04:45:40PM -0400, Vijay Kiran Kamuju wrote: > Add IRunnableObject stub implementation, It's not at all clear to me what this interface should do in this context. Could you at least add a test that shows that the domdoc object should expose IRunnableObject? Thanks, Huw.

Re: [PATCH] handle XML_DOCUMENT_NODE like XML_ATTRIBUTE_NODE.

On Mon, Oct 09, 2006 at 07:33:15PM +, Marcus Meissner wrote: > --- a/dlls/msxml3/node.c > +++ b/dlls/msxml3/node.c > +case XML_DOCUMENT_NODE: /* FIXME: not sure if node() is correct for > document nodes. */ Nor me. Which means we really need a test ;-) Huw.

Re: Add IRunnableObject stub implementation

On Wed, Oct 11, 2006 at 12:55:41AM -0400, Vijay Kiran Kamuju wrote: > I will wait on sending tests on this one. > Until the first one gets in > (http://www.winehq.org/pipermail/wine-patches/2006-September/030659.html) Ok, so let's look at that one. I think the problem here is that ISupportErrorIn

Re: Add IRunnableObject stub implementation

On Wed, Oct 11, 2006 at 09:00:32AM -0400, Vijay Kiran Kamuju wrote: > Huw, > > Can you look at the debug log after applying the SupportInfo Patch in > the bug#6341. Well of course I see the app QI(IRunnableObject) but that doesn't mean that it should succeed. Note there are a bunch of unimplemen

Re: [PATCH 11/31] oledlg: Initial management of private structure fordialog box control.

On Fri, Oct 20, 2006 at 12:07:14AM +0900, Dmitry Timoshkov wrote: > "Huw Davies" <[EMAIL PROTECTED]> wrote: > > >case WM_COMMAND: > >switch(LOWORD(wp)) > >{ > >case IDOK: > >case IDCANCEL: > >+

Re: [PATCH 5/5] Implement MsgWaitForMultipleObjectsEx and initial Carbon event handling.

> diff --git a/dlls/winequartz.drv/quartzdrv_carbon.c > b/dlls/winequartz.drv/quartzdrv_carbon.c > new file mode 100644 > index 000..082970d > --- /dev/null > +++ b/dlls/winequartz.drv/quartzdrv_carbon.c ... > +#import import is nasty. Can't you use include instead? Huw.

Re: gdi32: Remove call to CreateCompatibleDC() from GetDIBits() implementation (try 1)

ed and you're not allow to call GetDIBits with the bitmap selected into the dc... Huw. -- Huw Davies [EMAIL PROTECTED]

Re: Truetype fonts installed by Wine

diate steps in generating the bitmap fonts. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: oledlg: Cast-qual warnings fix

On Wed, Nov 08, 2006 at 09:56:54PM +, Andrew Talbot wrote: > @@ -666,16 +672,20 @@ > if(psA->cPasteEntries > 0) > { > UINT i; > -for(i = 0; i < psA->cPasteEntries; i++) > + > +for(i = psA->cPasteEntries; i != 0;) Was there any need for this? Huw.

Re: dlls/gdi: fix GetGlyphOutline(resend)

amp; > + (pOS2->version == 0xU || pOS2->panose[3]!=9)) > TM.tmPitchAndFamily = TMPF_FIXED_PITCH; > else > TM.tmPitchAndFamily = 0; Isn't this a bug in FreeType? If we have to have this in Wine, could you use the defines in wingdi.h instead

Re: Relax Marlett LOGFONT specification

On Fri, Sep 09, 2005 at 12:46:10PM +0100, Richard Cohen wrote: > Index: dlls/user/uitools.c > === > RCS file: /home/wine/wine/dlls/user/uitools.c,v > retrieving revision 1.7 > diff -u -p -r1.7 uitools.c > --- dlls/user/uitools.c

Re: GDI/tests: link to {G|S}etRelAbs() during runtime

On Fri, Oct 21, 2005 at 01:06:48PM +0300, Saulius Krasuckas wrote: > +hGDI = LoadLibraryA("gdi.dll"); You mean "gdi32.dll" -- Huw Davies [EMAIL PROTECTED]

Re: Add a test for bitmap font metrics to ensure that they match the Windows ones

ttf and sfnt2fnt reading that ttf (using FreeType) the value has changed to 13. Hence my comment that either fontforge or FreeType is doing something odd. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: fonts: Add a Tahoma replacement. Almost entirely based on a patch by Larry Snyder.

Chris Robinson wrote: > On Wednesday 03 October 2007 04:15:17 am Huw Davies wrote: >> --- >> fonts/.gitignore |1 + >> fonts/Makefile.in |3 +- >> fonts/tahoma.sfd |10850 >> + 3 files changed, &g

Re: Improving http://tests.winehq.org/data/

70 00431698 00431680 001a >The above probably does not help much so that this will have to be >taken to a debugger... > Actually it does help. 0x6c6 (== 1734) is the key and we have: #define RPC_S_INVALID_BOUND1734 Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [PATCH 07/18] inetcomm: Add an implementation of an SMTP transport.

On Fri, Nov 02, 2007 at 07:15:23AM -0700, Juan Lang wrote: > Hi Rob, > > +const char szHostName[] = "roblaptop"; /* FIXME */ > > Did you mean to leave that in? Nice. Ok, I've just resent the patchset without the smtp stuff. Rob can tidy that up and submit it

Re: [PATCH 04/18] inetcomm: Add self-registration code.

cleanup. I'm about to resubmit the patchset anyway and have made this change. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: (corrected) Add 18 pixel strike with japanese fonts to system.sdf Widths corrected and double checked for both strikes

Aric Stewart wrote: > --- > fonts/system.sfd | 1587 > +- > 1 files changed, 1341 insertions(+), 246 deletions(-) You seem to have changed a couple of glyphs in the 16 pixel strike too. Was that on purpose (and if so shouldn't it be a separa

Re: system.sfd: make 18 pixel strike with Japanese jvgasys glyphs

Dmitry Timoshkov wrote: > "Aric Stewart" <[EMAIL PROTECTED]> wrote: > >> Ahh, too late at night and my attempts to get the widths for the 18 >> pixel strikes had side effects. >> >> I have resubmitted. Hand checked the widths of the glyphs for both 16 >> and 18 pixles to make sure they are corr

Re: (corrected) Add 18 pixel strike with japanese fonts to system.sdf Widths corrected and double checked for both strikes

> added similar black boxes to what where already there. It was these lines that looked suspicious: -BDFChar: 351 154 4 0 2 0 8 -?smAM?smAM?iU0, -BDFChar: 352 156 4 0 2 0 8 -?smAM?smAM?iU0, +BDFChar: 351 154 4 1 2 0 8 +^qdb$^qdb$^]4?7 +BDFChar: 352 156 4 1 2 0 8 +^qdb$^qdb$^]4?7 Huw. -- Huw D

Re: [2/2] msxml3: Register Missing Components

; -}, > +"XML DOM Document", > +NULL, > +"msxml3.dll", > +"Both", > +"Microsoft.XMLDOM", > +"1.0" > +}, There are a lot of white-space changes in this patch. Please re-submit without them. Thanks, Huw. -- Huw Davies [EMAIL PROTECTED]

Re: gdi32: Update fontsubstitutes and add ms shell dlg 2

ife.fon", "smalle.fon", "sserife.fon", > - "Tahoma","Times New Roman", > + "MS Sans Serif", "Tahoma","Times New Roman", > }, I'm fairly sure we don't want to map MS Shell Dlg to MS Sans Serif. Which version of Windows has this mapping? Some map it to Microsoft Sans Serif, but that's a completely different font... Huw. -- Huw Davies [EMAIL PROTECTED]

Re: msxml3:Implement wcscpy_s (try 4)

45 > > dlls/msvcrt/wcs.c | 41 > 3 files changed, 87 insertions(+), 0 deletions(-) Note that the subject line should be 'msvcrt:...'. I guess Alexandre will fix this. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: gdi32-related commit between 0.9.57<->0.9.58 broken .NET2/Systems.Windows.Forms

On Wed, Mar 26, 2008 at 02:55:07PM +, Hin-Tak Leung wrote: > --- On Wed, 26/3/08, Huw Davies <[EMAIL PROTECTED]> wrote: > > > > The error message I got was 'attempt to read or > > write protected memory. This is often > > > an indication th

Re: gdi32-related commit between 0.9.57<->0.9.58 broken .NET2/Systems.Windows.Forms

On Wed, Mar 26, 2008 at 02:05:25PM +, Hin-Tak Leung wrote: > I found a .NET2/System.Windows.Forms application which was running alright > in 0.9.56/0.9.57 with the appdb adaptations broke in 0.9.58. So I did a git > bisect > and found that it is a commit to gdi32/freetype.c fro

Re: gdi32-related commit between 0.9.57<->0.9.58 broken .NET2/Systems.Windows.Forms

On Wed, Mar 26, 2008 at 03:33:27PM +, Hin-Tak Leung wrote: > --- On Wed, 26/3/08, Huw Davies <[EMAIL PROTECTED]> wrote: > > Well yes, but that doesn't actually mean the patch is > > incorrect. > > Well, it is certainly doing something that the .NET framew

Re: gdi32-related commit between 0.9.57<->0.9.58 broken .NET2/Systems.Windows.Forms

On Wed, Mar 26, 2008 at 04:38:26PM +, Hin-Tak Leung wrote: > --- On Wed, 26/3/08, Huw Davies <[EMAIL PROTECTED]> wrote: > But, OTOH, should one expose the whole of fontconfig-available > fonts to wine? A lot of them may be dubious to various extent. Well we already did that

Re: Revert "winspool.drv: Make sure the printer driver registry entry exists.

Huw (added a circular dependance). > > Changelog: > Revert "winspool.drv: Make sure the printer driver registry entry > exists. > But won't we still get the same problem when a new printer (and its driver) are added? In which case we should fix that rather than hiding the issue. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: Revert "winspool.drv: Make sure the printer driver registry entry exists.

On Wed, Jun 25, 2008 at 11:28:35AM +0100, Huw Davies wrote: > On Wed, Jun 25, 2008 at 12:17:36AM +0200, Detlef Riekenberg wrote: > > On Di, 2008-06-24 at 10:25 -0700, Dan Kegel wrote: > > > Today I started getting a heap corruption and crash in localspl: > > > ... >

Re: Memory leak patch

t;+++ b/dlls/gdiplus/font.c >@@ -42,6 +42,7 @@ static inline REAL get_dpi (void) > HDC hdc = GetDC(0); > GdipCreateFromHDC (hdc, &graphics); > GdipGetDpiX(graphics, &dpi); >+GdipFree(graphics); > ReleaseDC (0, hdc); > > return dpi; This should be GdipDeleteGraphics. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: memory leak fix

to me that the tmw element may as well be an embedded structure rather than a structure pointer. That'll save having to worry about alloc'ing/free'ing it. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: gdiplus: font.c: ensure to release resources

Joris Huizer wrote: > A modified patch, taking hints into account from Huw Davies > You need to select out the hfont before deleting it. So the SelectObject should look like hfont_old = SelectObject(hdc, hfont); then after the GetTextMetrics do DeleteObject(SelectObject(hdc, hfont_old))

Re: Gdiplus [1/3] Improve accuracy in calculating height

* (get_dpi() * points_per_inch); And this then becomes points * get_dpi() / points_per_inch; [Hint check the units: pixels (aka dots) = points * (dots / inch) / (points / inch) ] Huw. -- Huw Davies [EMAIL PROTECTED]

Re: Gdiplus [1/3] Improve accuracy in calculating height

On Fri, Jun 27, 2008 at 03:27:44PM +0100, Huw Davies wrote: > On Fri, Jun 27, 2008 at 10:16:41AM -0400, Adam Petaccia wrote: > > --- a/dlls/gdiplus/font.c > > +++ b/dlls/gdiplus/font.c > > @@ -34,6 +34,7 @@ WINE_DEFAULT_DEBUG_CHANNEL (gdiplus); > > #include "gdi

Re: [Gdiplus 4/4] Implement GdipCloneImage

> +return Ok; > } > You can't simply copy an interface ptr like this. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: user32: sizeof DDEPOKE and DDEDATA is six, which is probably not what is expected, so use offsetof instead.

James Hawkins wrote: > 2008/7/8 Huw Davies <[EMAIL PROTECTED]>: >> Fixes a todo_wine and a Valgrind warning. > > @@ -699,10 +699,7 @@ static HDDEDATA CALLBACK > server_ddeml_callback(UINT uType, UINT uFmt, HCONV hcon > > ptr = (LPSTR)DdeAccessData(hdata, &

Re: gdiplus: Add a test to show that bitmap fonts aren't used for fontfamilies.

Adam Petaccia wrote: > On Tue, 2008-07-08 at 13:20 +0100, Huw Davies wrote: >> --- >> dlls/gdiplus/tests/font.c |7 +++ >> 1 files changed, 7 insertions(+), 0 deletions(-) > > On my Windows system I can't find MSSansSerif, only Microsoft Sans > Serif.

Re: [Gdiplus 07/15] Stub GdipFillRegion

this in the 'graphics' section of the gdiplus flat api, so I'd suggest it goes in graphics.c Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [Gdiplus 11/15] Implement GdipCreateRegionRect

extend them to add paths), these are supposed to help understanding how regions are stored. It looks to me that a region is stored as a sequence of rects and paths that are combined with various CombineMode ops. I'll send a patch that adds paths to the test in a bit. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [Gdiplus 11/15] Implement GdipCreateRegionRect

On Wed, Jul 09, 2008 at 11:58:23AM +0100, Huw Davies wrote: > This doesn't look right. See the GdipGetRegionData tests (and extend > them to add paths), these are supposed to help understanding how > regions are stored. It looks to me that a region is stored as a > sequence o

Re: [Gdiplus 11/15] Implement GdipCreateRegionRect

oring the data in a similar way to native gdiplus. Then you can go on to work on the bounds (which would appear to be non-trivial - good luck!). Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [Gdiplus 2/3] Add a test for a floating-point triangle

. that you noted in an earlier patch). As you've also noticed there are two ways of storing paths, if all the co-ords are short ints then they get stored that way and the 0x4000 bit of buf + 8 is set. Otherwise the co-ords are stored as floats. In addition, the 0x2000 bit of that same DWORD corresponds to the FillMode of the path. Anyway, good work! Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [Gdiplus 02/15] Implement GdipCreateRegion

Adam Petaccia wrote: > @@ -226,6 +277,11 @@ GpStatus WINGDIPAPI GdipSetEmpty(GpRegion*region) > > if(!(calls++)) > FIXME("not implemented\n"); > +TRACE("%p\n", region); > + > +GdipDeleteRegion(region); > +GdipCreateRegion(®ion); > +region->node->type = RegionD

Re: [Gdiplus try2 02/16] Implement GdipCreateRegion

Adam Petaccia wrote: >@@ -226,6 +277,11 @@ GpStatus WINGDIPAPI GdipSetEmpty(GpRegion*region) > > if(!(calls++)) > FIXME("not implemented\n"); >+TRACE("%p\n", region); >+ >+GdipDeleteRegion(region); >+GdipCreateRegion(®ion); >+region->node->type = RegionDataEmpty

Re: [Gdiplus try3 02/16] Implement GdipCreateRegion

FlushIntention; > typedef enum CoordinateSpace CoordinateSpace; > Are you sure RegionType is in the win32 api? I can't find this is my gdiplusenums.h. If it isn't then it should be put in gdiplus_private.h (or even just in region.c if nothing else uses it) and renamed to enum region_type. Again, I think you'd be better off submitting a couple of patches at a time. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: [Gdiplus try3 02/16] Implement GdipCreateRegion

Adam Petaccia wrote: > On Tue, 2008-07-22 at 11:11 +0100, Huw Davies wrote: >>> +} RegionElement; >> It would be better to avoid the mixed upper/lower case names, since >> this makes it look like they're win32 api structures. Something like >> typedef stru

DIB engine status

send me patches! Thanks, Huw. -- Huw Davies [EMAIL PROTECTED]

Re: DIB engine status

not planning on doing any work on it for a while, but will probably return to it at some point in the future. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: wininet: default to keep-alive when the server is HTTP/1.1, not when it isn't

Vincent Povirk wrote: > This is a fix to a problem I introduced in > fd5b97bc4d12adc69085b739061c56e9107f8d1f. The expression that checked > the HTTP version was true for HTTP/1.0 servers, and I treated it as if > it were true for HTTP/1.1 servers. That means we defaulted to keep-alive > for HTTP/1

Re: [Gdiplus] Implement GdipCloneImage

> bitmap, > > GpStatus WINGDIPAPI GdipCloneImage(GpImage *image, GpImage **cloneImage) > { > +hr = OleLoadPicture(stream, size, FALSE, &IID_IPicture, > +(LPVOID*)(*cloneImage)->picture); This can't be right. You need to pass the address of the interface ptr. Huw. -- Huw Davies [EMAIL PROTECTED]

Re: oleaut32: Add support for loading typelibs from NE files.

On Wed, Sep 03, 2008 at 12:51:36PM +0100, Rob Shearman wrote: > 2008/9/2 Huw Davies <[EMAIL PROTECTED]>: > > --- a/dlls/oleaut32/typelib.c > > +++ b/dlls/oleaut32/typelib.c > > @@ -64,6 +64,7 @@ > > #include "winnls.h" > > #include "w

Re: [PATCH 3/3] ole32: Call the appropriate storage function when we run the object.

On Wed, Oct 22, 2008 at 12:46:39PM +0100, Rob Shearman wrote: > 2008/10/21 Huw Davies <[EMAIL PROTECTED]>: > > @@ -1728,6 +1767,10 @@ static HRESULT WINAPI > > DefaultHandler_IPersistStorage_HandsOffStorage( > > if(SUCCEEDED(hr) && objec

Re: [PATCH 3/3] ole32: Call the appropriate storage function when we run the object.

On Wed, Oct 22, 2008 at 02:03:26PM +0100, Rob Shearman wrote: > 2008/10/22 Huw Davies <[EMAIL PROTECTED]>: > > On Wed, Oct 22, 2008 at 12:46:39PM +0100, Rob Shearman wrote: > >> 2008/10/21 Huw Davies <[EMAIL PROTECTED]>: > >> > @@

  1   2   >