Re: [2/13]msctf: implement SetFocus and GetFocus

2009-01-30 Thread Aric Stewart
. There is also a note in msdn about AssociateFocus which states that it does not increment the lock possibly in contrast to SetFocus. The documentation on these interfaces is very very sparse. -aric Jacek Caban wrote: > Hi Aric, > > Aric Stewart wrote: >> --- >> dlls/msc

Re: advapi32: add Security Label sids used by IE7

2009-02-03 Thread Aric Stewart
yes as far as i can tell there was not an Untrusted label that is defined like the others. I included it in winnt.h for completeness. -aric Paul Vriens wrote: > Aric Stewart wrote: >> --- >> dlls/advapi32/security.c |4 >> include/winnt.h | 16 +++

Re: imm32: Make space for a 64bit pointer in the IMM window.

2009-02-11 Thread Aric Stewart
I am not a 64 bit expert but i do not think this is going to work. ddk/imm.h is a Microsoft header so IMEs and programs compiled with the original header will not have the expanded space. To fix this properly (I assume you are trying to support 64 bit) is that we will probibly have to store a h

Re: imm32: Make space for a 64bit pointer in the IMM window.

2009-02-11 Thread Aric Stewart
my concern is not valid. -aric Michael Stefaniuc wrote: > Aric Stewart wrote: >> I am not a 64 bit expert but i do not think this is going to work. >> >> ddk/imm.h is a Microsoft header so IMEs and programs compiled with the >> original header will not have the expande

Re: gdiplus: in GdipDrawString only NULL terminate if we have room in the buffer.

2009-02-12 Thread Aric Stewart
when we do the stringdup[j] = 0 we are writing one WCHAR off the end of the buffer. -aric Nikolay Sivov wrote: > Aric Stewart wrote: >> --- >> dlls/gdiplus/graphics.c |3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/dlls/gdiplus/gr

Re: wininet: parse cookie information from cookie value

2009-02-16 Thread Aric Stewart
Thanks for the tip. Resent. -aric Rob Shearman wrote: > 2009/2/13 Aric Stewart : >> +if (CompareStringW(GetThreadLocale(), NORM_IGNORECASE, ptr, 6, >> + szDomain, 6) == 2) > > LOCALE_INVARIANT should be used when comparing with a constant s

Re: [5/6]wininet: handle cookie expiration

2009-02-18 Thread Aric Stewart
Wonderful, I was looking for a function JUST like that. Reworked patch coming up shortly. -aric Hans Leidekker wrote: >>> +LPCWSTR ptr,ptr2; >>> +SYSTEMTIME tm; >>> +int i; >>> + >>> +memset(&tm,0,sizeof(tm)); >>> + >>> +ptr = expiry; >>> +for (i = 0; i < 7; i++) >>> +

Re: msctf crosstest build failed

2009-02-18 Thread Aric Stewart
could you check to see if uuid is being build properly? -aric Nikolay Sivov wrote: > Building today crosstests I've got: > > i586-mingw32msvc-gcc -c -I. -I. -I../../../include -I../../../include > -g -O2 -o inputprocessor.cross.o inputprocessor.c > i586-mingw32msvc-gcc -c -I. -I. -I../../../

Re: msctf crosstest build failed

2009-02-18 Thread Aric Stewart
Not sure. I can crossbuild it here on my mac with mingw without any issue. I will admit my knowledge of why is pretty limited. -aric Nikolay Sivov wrote: > Aric Stewart wrote: >> could you check to see if uuid is being build properly? >> >> -aric > Aric, is there

Re: msi: begin support for finding network last sources in find_published_source

2009-02-20 Thread Aric Stewart
wrote: > On Thu, Feb 19, 2009 at 12:28 PM, Aric Stewart wrote: >> Fix for office 2007 sp 1 install. >> --- >> dlls/msi/media.c | 33 + >> 1 files changed, 33 insertions(+), 0 deletions(-) >> > > I believe you're going do

Re: msi: begin support for finding network last sources in find_published_source

2009-02-20 Thread Aric Stewart
Ok i am following you but. James Hawkins wrote: > On Fri, Feb 20, 2009 at 4:45 AM, Aric Stewart wrote: >> Hello, . . . > No, I think the patch is wrong in that if you remove the original > media and the stored cabs, the install will fail. By that thinking then the

Re: msctf: add internal function for handling TfClientIds

2009-02-23 Thread Aric Stewart
Yup, reworked and resent. -aric James Mckenzie wrote: > Alexandre Julliard wrote on Feb 23: >> Aric Stewart writes: >> >>> +/* If i understand this correctly at most a process should generate >>> + * only a handful of these... But in case I am wrong

Re: [1/12] dinput: begin joystick separation into a generic module

2009-03-07 Thread Aric Stewart
Vitaliy Margolen wrote: Aric Stewart wrote: --- Patch set looks good with exception of - few more things can be moved out of joystick_linuxinput.c. But that can be separate patch(es). Vitaliy

Re: (try 2)advapi32: base implementation of LsaLookupNames2

2009-03-19 Thread Aric Stewart
! -aric Paul Vriens wrote: Aric Stewart wrote: fix tests for win95 --- dlls/advapi32/lsa.c | 51 +++- dlls/advapi32/tests/lsa.c | 82 - 2 files changed, 131 insertions(+), 2 deletions

Re: [1/3]msctf: ThreadMgr sink framework

2009-03-24 Thread Aric Stewart
Thanks, resent. -aric Alexandre Julliard wrote: Aric Stewart writes: typedef struct tagACLMulti { const ITfThreadMgrVtbl *ThreadMgrVtbl; const ITfSourceVtbl *SourceVtbl; LONG refCount; ITfDocumentMgr *focus; + +/* kept as separate lists to reduce unnecessary

Re: advapi32: stub TreeResetNamedSecurityInfo for the IE8 installer

2009-03-25 Thread Aric Stewart
I will admit I do not have access to the latest headers but my impression from MSDN and a web search is that FN_PROGRESS is not defined in a header. I will keep looking but that is why i did it that way. -aric Alexandre Julliard wrote: Aric Stewart writes: diff --git a/dlls/advapi32

Re: msi: avoid negative index in TABLE_insert_row

2009-03-25 Thread Aric Stewart
t;table->row_count which is generating an idx of less than 0; It looks like a wine bug. I can look into writing a test. -aric James Hawkins wrote: On Wed, Mar 25, 2009 at 10:39 AM, Aric Stewart wrote: fixes bug Bug 17600 --- dlls/msi/table.c |3 ++- 1 files changed, 2 insertions(+), 1

Re: X11DRV_AlphaBlend: FIXME not a DIB section

2009-03-27 Thread Aric Stewart
Hi there, As the author of one of the patches that was not approved, Alexandre told me that he felt that the whole X11DRV_AlphaBlend needed to be rewritten, maybe not even found in that module. If i recall correctly there was worries about how it was starting to duplicate code from the DIB

Re: gdi32/enhmfdrv: Actaully save the state in SaveDC and RestoreDCin the metafile

2009-04-04 Thread Aric Stewart
Hi Dmitry, Yeah, Alexandre did not like any of my patches and feels that duplicating the GDI code would be incorrect (it would result in too many SelectObject records and such) so he had me write up patch with a bunch of tests as wine_todos that demonstrate the problem so he could think abou

Re: [2/2] wine.inf: Add HKCU\Keyboard Layout\Preload key.

2009-04-10 Thread Aric Stewart
I had a patch that did this, it never got through. Let me see if i can polish it off and make it acceptable. -aric Alexandre Julliard wrote: Hans Leidekker writes: @@ -546,6 +546,7 @@ HKLM,System\CurrentControlSet\Control\Session Manager,,,"" HKLM,System\CurrentControlSet\Control\VMM32Fi

Re: ole32: CoGetTreatAsClass should return S_FALSE if it cannot even find the key for the requested CLSID

2009-04-23 Thread Aric Stewart
Good point, actually it should not be leaving the clsid alone it should be duplicating the requested GUID into it. (wine already does this part) I will update the test to properly show that. -aric Paul Vriens wrote: Aric Stewart wrote: Fixes issues with IE7 involving constant prompting to

Re: Mac OS X Joystick problem

2009-05-21 Thread Aric Stewart
Well the Mac OS X Joystick code will only work on Leopard. So you will have to build and run it on Leopard box using xcode3. If you are good there then try building the winetests for dinput and run them with your joystick plugged in. You should get some status traces about your joystick (findi

Re: Mac OS X Joystick problem

2009-05-26 Thread Aric Stewart
games so I can take a look? -aric Nathan Gray wrote: On Thu, May 21, 2009 at 10:45 AM, Aric Stewart wrote: If you are good there then try building the winetests for dinput and run them with your joystick plugged in. You should get some status traces about your joystick (finding the name and

Re: shlwapi: add test for CombineUrl

2009-06-02 Thread Aric Stewart
Humm, how odd, it was working here on my mac. i will test further. -aric Alexandre Julliard wrote: Aric Stewart writes: Associated with bug 18063 which is fixed. Apparently not: ../../../tools/runtest -q -P wine -M shlwapi.dll -T ../../.. -p shlwapi_test.exe.so url.c && touc

Re: ActiveX support in IE7

2009-06-25 Thread Aric Stewart
Hello, I have been working in this area for the last several days. It is actually greatly improving. I think the bulk of the remaining work is in the wintrust area to correctly validate the downloaded cabinet files. Then the prompting of the user to install these files. With some of my pendi

transl question

2009-07-14 Thread Aric Stewart
I am looking at the Japanese report from transl and i see something odd. looking at DIALOG MSGBOX for user32... http://source.winehq.org/transl/resource.php?lang=011%3A00&resfile=dlls%2Fuser32&type=5&id=MSGBOX&compare= the STYLE is reported as different, but when I look at the source they appe

Re: gdi32: ensure that the last_resort family at least has FS_LATIN1characters.

2009-07-15 Thread Aric Stewart
seemed too hackish. -aric Dmitry Timoshkov wrote: "Aric Stewart" wrote: Corrects a large number of font issues with east asian programs. -if(csi.fs.fsCsb[0] & (face->fs.fsCsb[0] | face->fs_links.fsCsb[0])) { +if((csi.fs.fsCsb[0] & (f

Re: gdi32: ensure that the last_resort family at least has FS_LATIN1characters.

2009-07-15 Thread Aric Stewart
fonts. It would be nice to have a more general fix. -aric Dmitry Timoshkov wrote: "Aric Stewart" wrote: Ok maybe you could help me brainstorm a better fix. The issue I am seeing is that this application is a chinese application and it is asking for Tahoma for GB2312_CHARSET. The

Re: Question about the gphoto2.ds resources

2009-07-30 Thread Aric Stewart
Humm, You know I have no idea. I know I used a freeware program called resource builder to make that dialog and then i think i just pretty much wholesale used that programs output. It very well may be something that resource builder put in that I did not catch. I am sure it can be removed

Re: gdi32: Ensure child fonts have names

2009-07-31 Thread Aric Stewart
Timoshkov wrote: "Aric Stewart" wrote: @@ -5792,6 +5792,9 @@ static BOOL load_child_font(GdiFont *font, CHILD_FONT *child) child->font->scale_y = font->scale_y; hfontlist = HeapAlloc(GetProcessHeap(), 0, sizeof(*hfontlist)); hfontlist->hfont = CreateFontIndirec

Re: gdi32: Ensure child fonts have names

2009-07-31 Thread Aric Stewart
Thanks, resent. -aric Dmitry Timoshkov wrote: "Aric Stewart" wrote: load_child_font calls neither WineEngCreateFontInstance nor GetEnumStructs. It allocates the the child font structure above in the function sets the few fields it thinks it needs and then goes on. I see no evid

Re: winemp3: a fix for security alert CVE-2006-1655

2009-08-07 Thread Aric Stewart
It means similar fix... however that wording appears in the original patch to libmpg123 that corrects this problem and so in the layer3.c implementation in modern libmpg123 So i debated changing the wording or keeping the original wording and decided to keep it the same as layer3.c in libmpg12

Re: Review: winex11.drv: Add workaround for 'phantom key' presence in X

2009-08-12 Thread Aric Stewart
It seems to be 'OK' for X11 to return that because everyone in the X11 universe seems to just accept that as how X works. Not fixing it wine would mean require all wine users to use something like xmodmap to modify their own xservers to get the correct behavior. That doesn't seem like an accep

mp3 update

2009-08-12 Thread Aric Stewart
Hello all, I am working on updating our winemp3.acm implementation to a modern libmpg123. We where at about 0.59r and I have 1.8.1 working very well. I have a few questions. Right now I have the smallest subset of files from libmpg123 that are needed to compile and work in the wine fram

Re: mp3 update

2009-08-12 Thread Aric Stewart
Well the main advantage I can see is that we are able to have mp3 support without adding a new library dependency. This will be especially useful for platforms other than Linux where libmpg123 is not present. Such as the Mac. There is no technical or licensing reason we would have to link to

Re: mp3 update

2009-08-18 Thread Aric Stewart
Sorry, I was out Friday and Monday so I am just getting back here. Am i reading that the general opinion is that I should rework winemp3.acm to load the external libmpg123 and just abandon the builtin mp3 support? Or was there still something else of issue with my work? thanks, -aric Marcus

Re: winemp3.acm: link to system libmpg123.so

2009-08-20 Thread Aric Stewart
I am looking into libmad, their programming APIs are completely undocumented so not sure how it works yet. But really it should be easy to add it to the frameworks as well so that either libmpg123 or libmad would be able to be used. But i see this as an addition onto the libmpg123 work instea

Re: winemp3.acm: link to system libmpg123.so

2009-08-20 Thread Aric Stewart
A quick license check does show that libmad is indeed GPL which means we cannot use it in WINE at all. -aric Aric Stewart wrote: I am looking into libmad, their programming APIs are completely undocumented so not sure how it works yet. But really it should be easy to add it to the

Re: winemp3.acm: link to system libmpg123.so

2009-08-20 Thread Aric Stewart
That is what I am worried about. I am willing to believe that direct show uses the acm drivers to decode the audio. I have not found anything to prove that yet but it is my gut feeling. -aric Henri Verbeet wrote: 2009/8/20 Roderick Colenbrander : If you are considering to write an additional

Re: [3/3]msctf/tests: test ITfThreadMgr::AssociateFocus

2009-09-08 Thread Aric Stewart
Thanks. I will take a look. -aric Paul Vriens wrote: On 09/01/2009 02:08 PM, Aric Stewart wrote: --- dlls/msctf/tests/inputprocessor.c | 141 - 1 files changed, 139 insertions(+), 2 deletions

Re: (resend) shlwapi: implement StrChrNW

2009-09-23 Thread Aric Stewart
MSDN states that "The comparison is not case-sensitive" -aric Jacek Caban wrote: Hi Aric, Aric Stewart wrote: --- dlls/shlwapi/shlwapi.spec |1 + dlls/shlwapi/string.c | 23 +++ 2 files changed, 24 insertions(+), 0 deletions(-) I didn't test

Re: (resend) shlwapi: implement StrChrNW

2009-09-24 Thread Aric Stewart
I will write up a conformance test to check. It should not be too hard. thanks, -aric Alexandre Julliard wrote: Aric Stewart writes: MSDN states that "The comparison is not case-sensitive" Considering that there is also a StrChrNIW, it's a pretty safe bet that MSDN is once again on crack.

Re: (try 3) shlwapi: implement StrChrNW

2009-09-24 Thread Aric Stewart
Ah that is what i get for trying to rush to get this written before breakfast. try 4 coming. -aric Paul Vriens wrote: On 09/24/2009 02:19 PM, Aric Stewart wrote: includes test to show that MSDN is wrong and the search IS case-sensitive. thanks for all the comments. --- dlls/shlwapi

Re: RFC/PATCH: Twain + Gphoto

2006-04-17 Thread Aric Stewart
This is really cool! I have poked a bit at it to see and like how it is going so far. It does not appear to actually get any photos from the cameras yet or am i missing that code. The ImageInfoGet and ImageMemXferGet are sort of the heart of that. At least for the program I am working on supp

Re: msi: appsearch

2006-07-05 Thread Aric Stewart
Maybe, i am unclear about how a fake dll in wine.inf would work. the problem is that previously we where doing a FindFile on the given directory and of course there is no file there so the process stopped. -aric Juan Lang wrote: if trying to find a DLL that is located in the system directory

Re: comcat work

2006-07-14 Thread Aric Stewart
Timoshkov wrote: "Aric Stewart" <[EMAIL PROTECTED]> wrote: Here are 2 patches, the first is resending my handing of -1 in EnumClassesOfCategories, the second patch is a test case for the first patch. It would be interesting to see how other negative values are supposed to be hand

Re: no keyboard events in ddraw application.

2004-01-06 Thread Aric Stewart
I believe this is the same issue i am seeing with IE started in full screen mode. It appears that those windows are being created in unmanaged mode and thus never generate any of the focus events that wine uses to try to track input focus. if you place them into a desktop then it works fine. I

Re: event.c freezes on XFilterEvent

2004-01-06 Thread Aric Stewart
Hello, I have done extensive XIM work in the crossover tree and have it working very well with a wide range of input methods including half and full ime input methods used in applications such as office-jp. I have been quite busy recently but will try hard to get a patch put together to get

Re: imm work

2004-01-07 Thread Aric Stewart
If you could point out what you would need me to modify to make it work better i could see what i could do. -aric Steven Edwards wrote: Hiya Aric, --- Aric Stewart <[EMAIL PROTECTED]> wrote: Notes: I fear this may violate dll separation between Imm32 and X11drv. I have a very long a

Re: wine/dlls x11drv/x11drv_main.c x11drv/x11drv.s ...

2004-01-25 Thread Aric Stewart
e: Log message: Aric Stewart <[EMAIL PROTECTED]> Use X11 XIM callbacks to enable full IME support. Correct some timing issues with XIM input. Start to provide the framework for the MSIME messages. langid = PRIMARYLANGID(LANGIDFROMLCID(layout)); if (langid == LANG_CHINESE || langid == L

Re: wine/dlls x11drv/x11drv_main.c x11drv/x11drv.s ...

2004-01-25 Thread Aric Stewart
before making that change. Once that is made then we can probably remove this chunk of code. Which would be nice. -aric Dmitry Timoshkov wrote: "Alexandre Julliard" <[EMAIL PROTECTED]> wrote: Log message: Aric Stewart <[EMAIL PROTECTED]> Use X11 XIM callbacks to enable ful

Re: SelectionMark

2004-02-12 Thread Aric Stewart
my patch. -aric Dimitrie O. Paun wrote: On February 11, 2004 02:07 pm, Aric Stewart wrote: +if (bResult && lvItem.stateMask & LVIS_SELECTED && +lvItem.state&LVIS_SELECTED && ((infoPtr->nSelectionMark + == -1) || (lvItem.iItem <= infoPtr-

Re: USB?

2004-08-10 Thread Aric Stewart
Hi, Sorry for not getting back to you all faster, i was at linux world and such. Yup i am looking hard at the setupapi device calls and cfgmgr to try to get some usb support targeted toward the iPod. I have made some progress and am beginning to have an understand of how usb is handled in wind

Re: USB?

2004-08-11 Thread Aric Stewart
key that would show that transition. -aric Rolf Kalbermatter wrote: Aric Stewart wrote: I do have some difficulty figuring out how win2k is translating vender and product ids into class and interface guids. The documentation reports that they look them up in inf files, however i am finding that

Re: IShellLink and non-existant exe files

2004-08-23 Thread Aric Stewart
still empty. Shouldn't we set exePath to the same value as This->sPath ? Christian Aric Stewart wrote: It is possible under windows to create a .Lnk file to an exe file before it exists. Office 2000 does this, Scientific Word does this as do other apps as well. So a quick fix so that in IPer

Input Focus problems with IE

2003-12-16 Thread Aric Stewart
Hello, I am working on a problem with IE where if you start the application in full screen mode: (start IE, change to full screen using view->full screen, shutdown IE, restart IE) the keyboard focus never gets given to the application so you cannot enter any information into forms. L

Re: Input Focus problems with IE

2003-12-17 Thread Aric Stewart
Yes i do believe this is the same bug. humm, i will investigate more about full screen windows and X although i am no expert with the x level windows in wine. -aric Mike Hearn wrote: On Wed, 2003-12-17 at 03:15, Dmitry Timoshkov wrote: That sounds like a bug either in Window Manager you are us

Re: InternetGetConnectedStateExA

2004-11-03 Thread Aric Stewart
ah, thanks for catching that i will redo my patch. -aric Alexandre Julliard wrote: Aric Stewart <[EMAIL PROTECTED]> writes: +BOOL WINAPI InternetGetConnectedStateExA(LPDWORD lpdwStatus, +LPSTR lpszConnectionName, DWORD dwNameLen, DWORD dwReserved) +{ +INT len; +

Re: IME fixes

2004-12-07 Thread Aric Stewart
You have a few places where variable declaration has moved from the top of the function to under your block. That should be fixed. It is hard to read through the whitespace changes for me. I though general convention was that you did not change whitespace (i seems to remember a small war over t

State of the Msi

2004-12-15 Thread Aric Stewart
Hi all, Long time no post :) I just wanted to give an update that Mike M. and I have done alot of msi work over the first few weeks of December which caused a few significant changes to particularly action.c where we eliminated many of the static buffers for file paths and replaced them with d

Re: MSI: partially implement of AppSearch action

2005-02-01 Thread Aric Stewart
Hi Juan, YAY! someone else doing action work.. However there are a few problems i want to point out so you can review your code and check. I have attached a patch i quickly made to avoid some problems i was having. But what you will want to look over and figure out is a) if the action returns

Re: msi: detect registry keypaths

2005-02-22 Thread Aric Stewart
Ahh you are correct, That is unnecessary. I can rework it or you can remove that test. Thanks for pointing it out. -aric Alexandre Julliard wrote: Aric Stewart <[EMAIL PROTECTED]> writes: -FIXME("Only working for installed files, not registry keys\n"); -if ( GetFile

Re: msi: PublishComponents and MsiGetQualifiedComponentExW

2005-04-19 Thread Aric Stewart
Thanks for the pointers, I have resubmitted the patch taking these into account. Index: dlls/msi/msipriv.h === RCS file: /home/wine/wine/dlls/msi/msipriv.h,v retrieving revision 1.52 diff -u -r1.52 msipriv.h --- dlls/msi/msipriv.h

msi dialogs, events and office 2003

2005-05-26 Thread Aric Stewart
ls/msi/msipriv.h 26 May 2005 12:24:28 - 1.58 +++ dlls/msi/msipriv.h 26 May 2005 16:16:06 - @@ -226,6 +226,7 @@ LPWSTR next_dialog; BOOL ExecuteSequenceRun; +struct _subscriptions *EventSubscriptions; } MSIPACKAGE; typedef struct tagMSIPREVIEW --- /dev/null 2005-03-17 08:20:

Re: msi: hook up dialogs and control events (big)

2005-05-26 Thread Aric Stewart
Strange. it looks like diff cut of the very last trailing }. add that in and it should work. -aric Stefan Dösinger wrote: Am Donnerstag, 26. Mai 2005 17:57 schrieb Aric Stewart: Hook up the dialog code, get a basic UI and handle basic control events. +if( r

Re: msi: source one off error correction

2005-07-11 Thread Aric Stewart
True, there shouldn't be because that string is of format ;; but i will work out some better error checking to handle garbage strings more gracefully. -aric Mike McCormack wrote: Aric Stewart wrote: rc = RegQueryValueExW(sourcekey, INSTALLPROPERTY_LASTUSEDSOURCEst

uxtheme requiring shlwapi

2005-09-01 Thread Aric Stewart
Thanks for the great work on this! It is really cool, however I am having a dependency problem that would be great to resolve. uxtheme currently links in shlwapi.dll, shlwapi.dll in turn links in ole32.dll. Since WM_NCCREATE seems to load uxtheme it would be that ole32 is being loaded almost all

Re: uxtheme requiring shlwapi

2005-09-01 Thread Aric Stewart
Great thanks, missed that patch. -aric Frank Richter wrote: On 01.09.2005 15:59, Aric Stewart wrote: Any chance these changes could be made? Actually, some chaps in #winehackers asked for the same already ;) : http://www.winehq.org/pipermail/wine-patches/2005-August/020373.html

Re: mlang

2005-09-23 Thread Aric Stewart
: On Fri, Sep 23, 2005 at 01:38:39PM -0500, Aric Stewart wrote: Implement a basic beginning for fnIMLangFontLink_CodePageToCodePages, fnIMLangFontLink_CodePagesToCodePage and fnIMLangFontLink_GetFontCodePages. Also some tests for the new functions. Index: dlls/mlang/mlang.c

Re: mlang

2005-09-26 Thread Aric Stewart
Well, looks like i misread the MSDN page on that one. Thanks! I will rewrite those parts of the code to use that. -aric Dmitry Timoshkov wrote: "Aric Stewart" <[EMAIL PROTECTED]> wrote: I did not see a way to go both ways. From a CHARSET to CodePage was given in Translat

riched20.dll asserts

2005-09-27 Thread Aric Stewart
Hello, So looking into an issue with IE6 i found the following problem. If I install IE6, and then go to a japanese web site. (for example http://www.mainichi.co.jp) I get given the option to download and install the Japanese Text Display Support. However if i click Download then the download

Re: http headers reworking

2005-12-13 Thread Aric Stewart
: Aric Stewart <[EMAIL PROTECTED]> writes: Redo how headers are handled. eliminating the concept of Standard Headers and allow all headers to be added multiple times. Allow querying of headers with an index to get the multiple headers. Respect response vs request headers in HttpQueryInfo.

Re: buffer check in comdlg

2006-04-07 Thread Aric Stewart
Drat bitten by formatting again. And i thought i checked but i realized i checked and then reedited the file and my setting returned to default. Should i redo the formatting and resubmit? -aric Robert Shearman wrote: Aric Stewart wrote: if(fodInfos->unicode) { LPOPENFILENAMEW

Re: comctl32: TCM_SETCURSEL also updates the focus item

2007-09-04 Thread Aric Stewart
I have not written a wine test but i did test it on window xp. I will write up a wine test. -aric Reece Dunn wrote: On 04/09/07, Aric Stewart <[EMAIL PROTECTED]> wrote: --- dlls/comctl32/tab.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Do you have a test fo

Re: iphlpapi: Intel Mac do not implement /proc filesystem so return Unimplemented for the functions trying to read from there.

2007-10-24 Thread Aric Stewart
Yeah after I submitted the patch, I was thinking about that as well. I will look at doing that. -aric Juan Lang wrote: > Hi Aric, > > @@ -104,6 +104,9 @@ DWORD getInterfaceStatsByName(const char > { >FILE *fp; > > +#ifdef __APPLE__ > + return ERROR_NOT_SUPPORTED; > +#endif > > This is ug

Re: shdocvw #3: Set default home and search page.

2007-12-03 Thread Aric Stewart
I see that the native shdocvw sets neither the Start page nor the Search page when registered. This patch forces the users home page to initially be www.winehq.com which can be confusing to IE users who are expecting the normal default of msn.com While amusing I do not think this is correct. -a

Re: shdocvw #3: Set default home and search page.

2007-12-04 Thread Aric Stewart
Edwards wrote: > On Dec 3, 2007 11:33 PM, Aric Stewart <[EMAIL PROTECTED]> wrote: >> While amusing I do not think this is correct. > > Plenty of OEM's change the default IE home page, and we should make it > easy to do so in Wine. I think a edit box in winecfg is th

Re: shdocvw #3: Set default home and search page.

2007-12-04 Thread Aric Stewart
True, making it something for wine.inf or for winecfg, but not shdocvw.dll in my opinion. -aric Steven Edwards wrote: > On Dec 4, 2007 5:56 AM, Aric Stewart <[EMAIL PROTECTED]> wrote: >> Do we consider wine to be an OEM or a reimplementation of the base >> windows? Setting

Re: shdocvw #3: Set default home and search page.

2007-12-04 Thread Aric Stewart
to handle not having a Start Page by pulling up a default one. -aric Jacek Caban wrote: > Aric Stewart wrote: >> True, making it something for wine.inf or for winecfg, but not >> shdocvw.dll in my opinion. >> > > Native shdocvw.dll doesn't support

Re: system.sfd: make 18 pixel strike with Japanese jvgasys glyphs

2007-12-05 Thread Aric Stewart
into the proper widths. -aric Dmitry Timoshkov wrote: > "Aric Stewart" <[EMAIL PROTECTED]> wrote: > >> fonts/system.sfd | 1407 >> ++ >> 1 files changed, 1213 insertions(+), 194 deletions(-) >

Re: (corrected) Add 18 pixel strike with japanese fonts to system.sdf Widths corrected and double checked for both strikes

2007-12-06 Thread Aric Stewart
: > Aric Stewart wrote: >> --- >> fonts/system.sfd | 1587 >> +- >> 1 files changed, 1341 insertions(+), 246 deletions(-) > > You seem to have changed a couple of glyphs in the 16 pixel strike too. > Was tha

Re: imagehlp: improve last error handling in ImageGetCertificateData

2007-12-11 Thread Aric Stewart
Humm, I wrote a test program mimicking the calls in the application I am working on and found this behavior. The app was passing in a NULL buffer and a pointer for the size set to 0, We where exiting with TRUE and not setting the last error correctly which was confusing the app. Testing on wi

Re: imagehlp: improve last error handling in ImageGetCertificateData

2007-12-11 Thread Aric Stewart
Indeed testing with my test app i see that if the Len is sufficient but the buffer is null i get a return of FALSE and a last error of ERROR_INVALID_PARAMETER. I will update my patch. -aric Juan Lang wrote: >> Humm, I wrote a test program mimicking the calls in the application I >> am working

Re: shdocvw #3: Set default home and search page.

2007-12-12 Thread Aric Stewart
. Either that or we move the registration of shdocvw.dll into win2000 bottles only where IE does not install anyway. But to be correct to windows i feel like none of that extra registration code should be there. -aric Jacek Caban wrote: > Aric Stewart wrote: >> Humm, maybe i am confuse

Re: More correctly handle the presence of the default ime inputwindow on Ime open and close

2008-02-08 Thread Aric Stewart
Good point, resending. thanks, -aric Dmitry Timoshkov wrote: > "Aric Stewart" <[EMAIL PROTECTED]> wrote: > >> diff --git a/dlls/imm32/imm.c b/dlls/imm32/imm.c >> index 4acbde3..f3ed6f9 100644 >> --- a/dlls/imm32/imm.c >> +++ b/dlls/imm32

Re: regedit: stdin is not seekable so do not try to seek the input file if it is not seekable

2008-03-14 Thread Aric Stewart
True, through I did not add the code that was doing the seeking so i tried to not be too intrusive. Should I rework the way we do the line processing to be able to do this then? -aric Alexandre Julliard wrote: > Aric Stewart <[EMAIL PROTECTED]> writes: > >> --- >> pr

Re: (resend)imm: implement ImmGetIMEFileNameW and ImmGetIMEFileNameA correct registry lookups

2008-03-25 Thread Aric Stewart
ok thanks. I will rework this. -aric Alexandre Julliard wrote: > Aric Stewart <[EMAIL PROTECTED]> writes: > >> +if (rc > 0) >> +{ >> +if (uBufLen && lpszFileName) >> +rc = WideCharToM

Re: imm: Keep track of context associations between HWND and HIMC

2008-04-01 Thread Aric Stewart
It would be but I could not find evidence that such a property existed for all windows in Window. If you are proposing a wine internal property then it would work well. -aric Alexandre Julliard wrote: > Aric Stewart <[EMAIL PROTECTED]> writes: > >> @@ -93,12 +93,21

Re: Recent imm changes triggered widespread valgrind errors?

2008-04-02 Thread Aric Stewart
Thanks for the heads up, With Alexandre's latest fix to the code do the valgrind errors persist? -aric Dan Kegel wrote: > Aric, can you have a look? > > Any call to CreateWindow now spews lots of Valgrind errors. > For instance, > http://kegel.com/wine/valgrind/logs-2008-04-01/vg-advpack_instal

IMM / IME work

2008-04-15 Thread Aric Stewart
Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framewo

Re: IMM / IME work

2008-04-16 Thread Aric Stewart
Wonderful! I am glad you have this working for you as well. I think this will make it much easier to test and greatly improve our IME support in WINE. -aric ByeongSik Jeon wrote: > Aric Stewart wrote: >> I have tested with windows ATOK20 (a popular Japanese IME) and >> succes

Re: wininet: correct the case where Content-Length is set as well as Transer-Encoding = chunked

2008-04-17 Thread Aric Stewart
This patch is for the receiving direction, unless I misread the code. The issue is that after a sent request the response is coming back with both Transfer-Encoding=chunked and a Content-Length. -aric Hans Leidekker wrote: > On Thursday 17 April 2008 20:05:41 Aric Stewart wr

Re: wininet: correct the case where Content-Length is set as well as Transer-Encoding = chunked

2008-04-18 Thread Aric Stewart
Here is the download where i see the behavior is where I see the behavior. http://site.ebrary.com/lib/stanford/support/plugins/ebraryReader.exe thanks, -aric Hans Leidekker wrote: > On Thursday 17 April 2008 21:28:57 Aric Stewart wrote: > >> This patch is for the receiving directi

Re: MSIME support causing slow setup until explorer.exe paused?

2008-04-21 Thread Aric Stewart
Humm, MSIMEService, MSIMEReconvertOptions, MSIMEMouseOperator, etc... those are all Messages that Microsoft Office looks for and sends to the IME during operations. For the most part all those messages are just stubbed. The messages are Registered in Imm32/imm.c once per process, and als

Re: imm32: Fix a test that fails on all systems

2008-04-21 Thread Aric Stewart
Are this tests failing on windows? When I did my recent IME work I was working to make sure that these tests succeeded at that time. have they started failing on wine as well? thanks, -aric James Hawkins wrote: > Hi, > > Changelog: > * Fix a test that fails on all systems. > > dlls/imm32/t

Re: [3/4] user32: Set the vkey value to VK_PROCESSKEY when IME process key.

2008-04-24 Thread Aric Stewart
Thank you for these investigations This is really nice. I support those patches. I just wanted to also communicate a bit of additional information from my investigations just in case someone asks. I placed hooks on both WH_KEYBOARD_LL and WH_KEYBOARD. Even when the IME is active both of thos

Re: Kusanagi Kouichi : winex11: Destroy the handle to the composition string after it is cancelled.

2008-04-25 Thread Aric Stewart
Comming in a bit late on this one, (missed the patch submission) I do not think this is correct as far as i know hCompStr should never be NULL. Much of our code depends on that not being NULL. I would recommend using ImeCreateBlankCompStr instead. (something like below) diff --git a/dlls/winex

Re: Kusanagi Kouichi : winex11: Destroy the handle to the composition string after it is cancelled.

2008-04-25 Thread Aric Stewart
de sure that the hCompStr was never NULL. -aric Kusanagi Kouichi wrote: > On Fri, Apr 25, 2008 at 09:36:36AM -0500, Aric Stewart wrote: >> Comming in a bit late on this one, (missed the patch submission) >> >> I do not think this is correct as far as i know hCompStr should never be

Re: dinput: the DIK_ keycode is not the same as the scancode.

2008-07-22 Thread Aric Stewart
uld use VK from the hook but i dont remember why i decided not to do that, but i am very sleepy right now, if that is better, and probably this should be extended to include VK codes for non ascii characters in case they do not line up either. But it was a first pass. Vitaliy Margolen wrote:

DSurface optimization, comments requested

2008-07-25 Thread Aric Stewart
Hi there, I was playing with a older Japanese side scrolling shooter benchmark and was getting 4.3 frames per second. Some digging revealed that the game made extensive use of Blt on gdi surfaces and it looks like the current implementation of Blt actually locks the entire destination surface

  1   2   3   >