Re: mmdevapi/tests: test MMDevPropStore_GetAt

2013-09-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2403 Your paranoid andr

Re: [3/3] ws2_32: Implement WSASendMsg() (try 2)

2013-09-30 Thread Alexandre Julliard
Bruno Jesus <00cp...@gmail.com> writes: > @@ -2427,6 +2427,46 @@ static void WINAPI WS2_GetAcceptExSockaddrs(PVOID > buffer, DWORD data_size, DWORD > } > > /*** > + * WSASendMsg > + */ > +int WINAPI WSASendMsg( SOCKET s,

Re: [PATCH 1/2] setupapi: Also look in datadir/fakedlls for the re-compiled fakedlls.

2013-09-30 Thread Alexandre Julliard
Huw Davies writes: > --- > dlls/setupapi/fakedll.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) I don't think that's correct. The datadir is for platform-independent files, but the fakedlls are platform specific. -- Alexandre Julliard julli...@winehq.org

Re: atl90: Add new DLL

2013-09-30 Thread Zhenbo Li
2013/9/4 Zhenbo Li : > This patch could fix bug 34431, which is caused by missing atl90.dll > > --- > configure | 1 + > configure.ac | 1 + > dlls/atl90/Makefile.in | 7 > dlls/atl90/atl90.c | 93 > ++ > dlls/atl90

Increasing max_req_size and subsequent errors

2013-09-30 Thread Hugh McMaster
I need to increase the $max_req_size in tools/make_requests. A new request structure for GetConsoleScreenBufferInfoEx is 80 bytes and primarily made up of 16 unsigned long integers. This is fine, but raises the error: wineserver: request.c:755: open_master_socket: Assertion `sizeof(union gen

Re: [2/3] kernel32/tests: test CopyFileEx callback and cancellation (resend)

2013-09-30 Thread Juan Lang
On Sun, Sep 29, 2013 at 11:10 PM, Daniel Jeliński wrote: > 2013/9/30 Nikolay Sivov > >> On 9/30/2013 00:51, Daniel Jeliński wrote: >> >> >> +struct progress_list { >>> +const DWORD progress_retval_init; /* value to return from progress >>> routine */ >>> +const BOOL cancel_init;

Re: [2/3] kernel32/tests: test CopyFileEx callback and cancellation (resend)

2013-09-30 Thread Nikolay Sivov
On 9/30/2013 10:10, Daniel Jeliński wrote: 2013/9/30 Nikolay Sivov > On 9/30/2013 00:51, Daniel Jeliński wrote: +struct progress_list { +const DWORD progress_retval_init; /* value to return from progress routine */ +cons

Re: [3/3] ws2_32: Implement WSASendMsg() (try 2)

2013-09-30 Thread Bruno Jesus
On Mon, Sep 30, 2013 at 6:32 AM, Alexandre Julliard wrote: > > Bruno Jesus <00cp...@gmail.com> writes: > > > @@ -2427,6 +2427,46 @@ static void WINAPI WS2_GetAcceptExSockaddrs(PVOID > > buffer, DWORD data_size, DWORD > > } > > > > /***

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-09-30 Thread Alexandre Julliard
Dmitry Timoshkov writes: > --- > dlls/ntdll/file.c | 3 ++- > dlls/ntdll/tests/file.c | 5 +++-- > 2 files changed, 5 insertions(+), 3 deletions(-) I don't see the point. Do you actually have an app that depends on this? -- Alexandre Julliard julli...@winehq.org

Re: wldap32: Use BOOL type where appropriate

2013-09-30 Thread Rico Schüller
On 01.10.2013 00:06, Frédéric Delanoy wrote: --- dlls/wldap32/init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/wldap32/init.c b/dlls/wldap32/init.c index b5aed58..54b5b24 100644 --- a/dlls/wldap32/init.c +++ b/dlls/wldap32/init.c @@ -113,13 +113,13 @@ oom:

Re: [1/3] gdi32: Return fake BBox when requested empty glyph metrics. (try 3)

2013-09-30 Thread Bruno Jesus
On Fri, Sep 27, 2013 at 8:16 AM, Akihiro Sagawa wrote: > > Fixes bug 18440, 20847. > > Try 3: >- Rebase to recent source. >- Separate ABC metrics change. >- Use conditional operator. > --- > dlls/gdi32/freetype.c |4 ++-- > dlls/gdi32/tests/font.c | 24

Re: [4/5] ntdll: Make asynchronous NtWriteFile on a disk file always return STATUS_PENDING.

2013-09-30 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > I don't see the point. Do you actually have an app that depends on this? When I started to work on this I had an app that has one of the reasons to require running under Vista+ was the difference in overlapped IO behavior. On the other hand the tests clearly show that

RE: Increasing max_req_size and subsequent errors

2013-09-30 Thread Hugh McMaster
Solved. server/protocol.def is the correct place to adjust the request_max_size value.