Re: iphlpapi: Add AllocateAndGetTcpExTableFromStack()

2013-09-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=1995 Your paranoid andr

Re: [PATCH try3] atl110: Added new DLL.

2013-09-04 Thread Jacek Caban
On 09/03/13 13:51, Qian Hong wrote: > On Tue, Sep 3, 2013 at 7:42 PM, Jacek Caban wrote: >> Not really, good catch. We should make them consistent. Honestly, I'm >> not sure which one is better. Both have their problems. Some functions >> are forwarded, others are not, so having one debug channel

Re: wininet: Don't start the next chunk if the read is satisfied.

2013-09-04 Thread Jacek Caban
Hi Hans, On 09/04/13 09:22, Hans Leidekker wrote: > --- > dlls/wininet/http.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c > index 1832b4f..521e4aa 100644 > --- a/dlls/wininet/http.c > +++ b/dlls/wininet/http.c > @@ -2795,7

Re: atl90: Add new DLL

2013-09-04 Thread Zhenbo Li
Sorry, I've made a typo. This patch is for bug 34432 2013/9/4 Zhenbo Li > This patch could fix bug 34431, which is caused by missing atl90.dll > > --- > configure | 1 + > configure.ac | 1 + > dlls/atl90/Makefile.in | 7 > dlls/atl90/atl90.c | 93 +++

Re: iphlpapi: Add AllocateAndGetTcpExTableFromStack()

2013-09-04 Thread Bruno Jesus
On Wed, Sep 4, 2013 at 8:02 AM, Ralf Habacker wrote: > > - added test case (update) > > Signed-off-by: Ralf Habacker > --- > dlls/iphlpapi/iphlpapi.spec|1 + > dlls/iphlpapi/ipstats.c| 33 + > dlls/iphlpapi/tests/iphlpapi.c | 32 +++

Re: wininet: Don't start the next chunk if the read is satisfied.

2013-09-04 Thread Hans Leidekker
On Wed, 2013-09-04 at 13:11 +0200, Jacek Caban wrote: > On 09/04/13 09:22, Hans Leidekker wrote: > > --- > > dlls/wininet/http.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c > > index 1832b4f..521e4aa 100644 > > --- a/

Re: wininet: Don't start the next chunk if the read is satisfied.

2013-09-04 Thread Jacek Caban
On 09/04/13 14:38, Hans Leidekker wrote: > On Wed, 2013-09-04 at 13:11 +0200, Jacek Caban wrote: >> On 09/04/13 09:22, Hans Leidekker wrote: >>> --- >>> dlls/wininet/http.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c

Re: [2/2] rpcrt4: Clear the connection pool when closing an http connection.

2013-09-04 Thread Jacek Caban
On 09/04/13 15:36, Hans Leidekker wrote: > On Wed, 2013-09-04 at 15:28 +0200, Jacek Caban wrote: >> On 09/04/13 15:01, Hans Leidekker wrote: >>> --- >>> dlls/rpcrt4/rpc_transport.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transp

Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode. (try 2)

2013-09-04 Thread Nikolay Sivov
On 9/4/2013 07:17, Jactry Zeng wrote: -ME_EndToUnicode(unicode, wszText); +ME_EndToUnicode(unicode ? 1200 : CP_ACP, wszText); It's still ugly to use magic numbers like that, in a similar situation I had some time ago I use ~0 to mark WCHAR data encoding that does need special ha

Re: [PATCH] opencl/tests: Add initial tests

2013-09-04 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=2003 Your paranoid andr

Re: [2/2] rpcrt4: Clear the connection pool when closing an http connection.

2013-09-04 Thread Hans Leidekker
On Wed, 2013-09-04 at 15:28 +0200, Jacek Caban wrote: > On 09/04/13 15:01, Hans Leidekker wrote: > > --- > > dlls/rpcrt4/rpc_transport.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c > > index d0857fa..1eb0151 100644 > >

Re: [2/2] rpcrt4: Clear the connection pool when closing an http connection.

2013-09-04 Thread Jacek Caban
On 09/04/13 15:01, Hans Leidekker wrote: > --- > dlls/rpcrt4/rpc_transport.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c > index d0857fa..1eb0151 100644 > --- a/dlls/rpcrt4/rpc_transport.c > +++ b/dlls/rpcrt4/rpc_transport.c

Re: [PATCH 1/3] riched20: Use codepage in ME_ToUnicode. (try 2)

2013-09-04 Thread Jactry Zeng
Hi Nikolay, 2013/9/5 Nikolay Sivov > > On 9/4/2013 07:17, Jactry Zeng wrote: >> >> -ME_EndToUnicode(unicode, wszText); >> +ME_EndToUnicode(unicode ? 1200 : CP_ACP, wszText); > > It's still ugly to use magic numbers like that, in a similar situation I had some time > ago I use ~0 t

Re: [2/2] rpcrt4: Clear the connection pool when closing an http connection.

2013-09-04 Thread Hans Leidekker
On Wed, 2013-09-04 at 18:16 +0200, Jacek Caban wrote: > On 09/04/13 15:36, Hans Leidekker wrote: > > On Wed, 2013-09-04 at 15:28 +0200, Jacek Caban wrote: > >> On 09/04/13 15:01, Hans Leidekker wrote: > >>> + /* don't allow this connection to be reused */ > >>> + InternetSetOptionW(NULL, INTERNET

Re: [3/6] ntdll: NtWriteFile should fail for overlapped IO on files if offset is negative.

2013-09-04 Thread Alexandre Julliard
Dmitry Timoshkov writes: > diff --git a/dlls/ntdll/tests/file.c b/dlls/ntdll/tests/file.c > index cde299c..c802432 100644 > --- a/dlls/ntdll/tests/file.c > +++ b/dlls/ntdll/tests/file.c > @@ -2124,11 +2124,8 @@ todo_wine > iob.Information = -1; > offset.QuadPart = (LONGLONG)-2 /* FILE_U

RE: D3D command stream patches for testing

2013-09-04 Thread Vedran Rodic
Hello, I was not subscribed to wine-devel, so I can't reply to Stefan's mail directly, but here are some of my observations with Dota 2 on an Intel HD4000 GPU. Intel Mesa driver doesn't seem to like glBufferSubData in a way this patchset uses it. I get many many messages like these per frame when

Re: 0001-Fix-race-for-IOCTL_SERIAL_WAIT_ON_MASK.patch

2013-09-04 Thread Alexandre Julliard
Wolfgang Walter writes: > @@ -1265,8 +1265,12 @@ static inline NTSTATUS io_control(HANDLE hDevice, > case IOCTL_SERIAL_WAIT_ON_MASK: > if (lpOutBuffer && nOutBufferSize == sizeof(DWORD)) > { > +piosb->u.Status = STATUS_PENDING; > +piosb->Information

Re: [PATCH] wined3d: Fix per-stage constant in GLSL fixed function pipeline + add tests. (try 2)

2013-09-04 Thread Matteo Bruni
2013/9/4 Christian Costa : > This patch fixes part of bug 33606 and 31918. > > The current code generates shaders that support per-stage constant but does > not declare the variables used causing thus compilation failures. > With this patch, these variables are declared and updated when needed. Te

Re: oledb32: Implement IDataSourceLocator get/put hWnd

2013-09-04 Thread Alexandre Julliard
Alistair Leslie-Hughes writes: > Hi, > > > Changelog: > oledb32: Implement IDataSourceLocator get/put hWnd It doesn't work here: ../../../tools/runtest -q -P wine -M oledb32.dll -T ../../.. -p oledb32_test.exe.so database.c && touch database.ok database.c:252: Test failed: got 80040154 mak

Re: [PATCH 3/5] wined3d: Don't set WINED3DUSAGE_RENDERTARGET on the front buffer.

2013-09-04 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-04 08:56, schrieb Henri Verbeet: > We never render directly to the front buffer, and in case of e.g. a > P8 front buffer, we would fail surface creation if we were to > enforce format restrictions. This patch uncovers a problem I am not quit

Re: [PATCH 3/5] wined3d: Don't set WINED3DUSAGE_RENDERTARGET on the front buffer.

2013-09-04 Thread Henri Verbeet
On 4 September 2013 23:18, Stefan Dösinger wrote: > We set the frontbuffer as render target in wined3d_device_init_3d if > there's no backbuffer, i.e., when ddraw is used. In theory this > doesn't matter because we're not rendering to it, just blitting. > > Similarly, dlls/ddraw/device.c calls set

Re: D3D command stream patches for testing

2013-09-04 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-09-04 16:30, schrieb Vedran Rodic: > Using a blit copy to avoid stalling on 12b glBufferSubData() to a > busy buffer object. The long term plan is to use GL_ARB_buffer_storage to create buffers that can be used for rendering while mapped. That

Re: [PATCH 1/5] use a correct timeout in test_waittxempty

2013-09-04 Thread Dmitry Timoshkov
Wolfgang Walter wrote: > When we send 17 bytes with 150 baud, no parity, one stop bit then > we need to wait at least 17*10/150 seconds > 1000 ms Under Windows with both real COM-port and USB-serial cable this test takes no longer than 890 ms, usually it's even shorter like 875 ms. Testbot VMs a

Re: [PATCH 2/5] wait until all data from earlier test has been written in test_waittxempty

2013-09-04 Thread Dmitry Timoshkov
Wolfgang Walter wrote: > +if (res || (!res && GetLastError() == ERROR_IO_PENDING)) > +/* if data has been sent: wait for termination */ > +Sleep(timeout); I don't see such a problem with real COM-port and serial-USB cable under Windows or Linux here and under testbot VMs. --

Re: [PATCH 5/5] kernel32/tests: remove several todos in test_waittxempty

2013-09-04 Thread Dmitry Timoshkov
Wolfgang Walter wrote: > -ok(!res && GetLastError() == ERROR_IO_PENDING, "%d: WaitCommEvent > error %d\n", i, GetLastError()); > +ok(res || (!res && GetLastError() == ERROR_IO_PENDING), "%d: > WaitCommEvent error %d\n", i, GetLastError()); This change looks spurious and unrelat

Re: D3D command stream patches for testing

2013-09-04 Thread Prot Secret
Hi, I am interested in your work, but after patching wine171 of this patch and enabled csmt, i have seen this in SC2 http://postimg.org/gallery/1w8y6jbg I use nvidia GTX 680 with proprietary i386 nvidia driver 319.49. Where I could be wrong, or what else can be set that would be normalized image u