Re: [2/2] ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit.

2013-08-30 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Dmitry Timoshkov wrote: > >> Printing complete lsr value in the log may help with diagnosing >> test failures on Alexandre's machine. > > This patch is marked as 'Build failure' in the tracker, but I've checked it > once again and compiles just fine here. What kind of

Re: d3d9: Partial implementation of IDirect3DSwapChain9Ex

2013-08-30 Thread Nikolay Sivov
On 8/30/2013 12:19, Michael Müller wrote: This patch implements the IDirect3DSwapChain9Ex interface as an extension of IDirect3DSwapChain9 and thus fixes bug 34252 - "Silverlight accelerated graphics cause a D3D critical section lockup" since Silverlight does no longer try to create a Direct3D co

Re: d3d9: Partial implementation of IDirect3DSwapChain9Ex

2013-08-30 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Am 2013-08-30 10:19, schrieb Michael Müller: > This patch implements the IDirect3DSwapChain9Ex interface as an > extension of IDirect3DSwapChain9 and thus fixes bug 34252 - > "Silverlight accelerated graphics cause a D3D critical section > lockup

Re: ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit. Take 2.

2013-08-30 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Printing complete lsr value in the log may help with diagnosing > test failures on Alexandre's machine. I don't see how, since TIOCSER_TEMT is the only defined bit. Do you actually have a driver that returns other status? -- Alexandre Julliard julli...@winehq.org

Re: ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit. Take 2.

2013-08-30 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > > Printing complete lsr value in the log may help with diagnosing > > test failures on Alexandre's machine. > > I don't see how, since TIOCSER_TEMT is the only defined bit. Do you > actually have a driver that returns other status? I don't, but maybe yours does. The

Re: ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit. Take 2.

2013-08-30 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> > Printing complete lsr value in the log may help with diagnosing >> > test failures on Alexandre's machine. >> >> I don't see how, since TIOCSER_TEMT is the only defined bit. Do you >> actually have a driver that returns other status? >

Re: ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit. Take 2.

2013-08-30 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > >> > Printing complete lsr value in the log may help with diagnosing > >> > test failures on Alexandre's machine. > >> > >> I don't see how, since TIOCSER_TEMT is the only defined bit. Do you > >> actually have a driver that returns other status? > > > > I don't, but

Re: kernel32/tests: Add a FlushFileBuffers test for a COM port. Resend.

2013-08-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=1932 Your paranoid andr

Re: ntdll: Store full line status register in the internal structure, not just the TIOCSER_TEMT bit. Take 2.

2013-08-30 Thread Alexandre Julliard
Dmitry Timoshkov writes: > Alexandre Julliard wrote: > >> >> > Printing complete lsr value in the log may help with diagnosing >> >> > test failures on Alexandre's machine. >> >> >> >> I don't see how, since TIOCSER_TEMT is the only defined bit. Do you >> >> actually have a driver that returns

Re: oleaut32: Add ICreateTypeInfo2::SetVarName implementation

2013-08-30 Thread Nikolay Sivov
On 8/30/2013 16:28, Piotr Caban wrote: --- dlls/oleaut32/tests/typelib.c | 13 +++-- dlls/oleaut32/typelib.c | 13 +++-- 2 files changed, 22 insertions(+), 4 deletions(-) ITypeInfoImpl *This = info_impl_from_ICreateTypeInfo2(iface); -FIXME("%p %u %s - stub\n",

Sequences in a loop

2013-08-30 Thread matyapiro31
I found many wine sources use not a pointer,but a sequence . for example: krnl386.exe16/dma.c: for(i=0,p=(char*)DMA_CurrentBaseAddress[channel];i

Re: Help to create a server request

2013-08-30 Thread Bruno Jesus
On Thu, Aug 29, 2013 at 10:38 PM, Charles Davis wrote: > To add a new request to the server, you first add a definition to > server/protocol.def . This file is processed by the make_requests tool, which > generates a bunch of other files from it. The syntax of the server protocol > definition f

Re: Sequences in a loop

2013-08-30 Thread Nikolay Sivov
On 8/30/2013 16:33, matyapiro31 wrote: I found many wine sources use not a pointer,but a sequence . for example: krnl386.exe16/dma.c: for(i=0,p=(char*)DMA_CurrentBaseAddress[channel];i I guess by sequences you mean arrays? Should I change them? Change them to what? And what will it solve?

Re: Sequences in a loop

2013-08-30 Thread Michael Stefaniuc
On 08/30/2013 02:33 PM, matyapiro31 wrote: > I found many wine sources use not a pointer,but a sequence . > for example: > krnl386.exe16/dma.c: > for(i=0,p=(char*)DMA_CurrentBaseAddress[channel];i msdaps/usrmarshal.c: for(prop = 0; prop < > rgPropertySets[prop_set].cProperties; prop++) > I know in

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

2013-08-30 Thread Henri Verbeet
On 30 August 2013 17:35, Stefan Dösinger wrote: > Am 2013-08-30 17:31, schrieb Henri Verbeet: >> Is this different from surfaces? IIRC surfaces are padded up to >> the next multiple of the block size, although I may have that >> wrong. Not a fan of the "(%p) : " trace formatting. > Padding happens

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

2013-08-30 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-30 17:31, schrieb Henri Verbeet: > On 30 August 2013 00:19, Stefan Dösinger > wrote: >> +if (format->flags & WINED3DFMT_FLAG_BLOCKS) +{ + >> UINT width_mask = format->block_width - 1; +UINT >> height_mask = format->block_hei

Re: [PATCH 3/5] d3d9/tests: Add a DXT5 volume test

2013-08-30 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-30 17:31, schrieb Henri Verbeet: > On 30 August 2013 00:19, Stefan Dösinger > wrote: >> +/* A 8x4x2 texture consisting of 4 4x4 blocks. The >> colors of the blocks are red, green, blue and white. */ + >> 0xff, 0xff, 0x00, 0x00, 0x00

Re: [PATCH 3/5] d3d9/tests: Add a DXT5 volume test

2013-08-30 Thread Henri Verbeet
On 30 August 2013 00:19, Stefan Dösinger wrote: > +/* A 8x4x2 texture consisting of 4 4x4 blocks. The colors of the > blocks are red, green, blue and white. */ > +0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF8, 0x00, > 0xF8, 0x00, 0x00, 0x00, 0x00, > +0xff, 0x

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

2013-08-30 Thread Henri Verbeet
On 30 August 2013 00:19, Stefan Dösinger wrote: > +if (format->flags & WINED3DFMT_FLAG_BLOCKS) > +{ > +UINT width_mask = format->block_width - 1; > +UINT height_mask = format->block_height - 1; > +if (desc->width & width_mask || desc->height & height_mask) > +

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

2013-08-30 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-30 17:50, schrieb Henri Verbeet: > Well, regardless of which one it is, I don't see a similar check > for 2D and cube textures at the moment. I think some tests would > be welcome. You are right, there's neither a check nor tests. I am certa

Re: [PATCH] widl: Limit recursion deepth within structs to 1 for checking for full-pointers.

2013-08-30 Thread Paul Chitescu
Hi! It would help to attach the patch, not your editor's swap file. Paul On Friday 30 August 2013 10:57:26 pm Kai Tietz wrote: > Hello, > > attached patch limits recursion in type_has_full_pointer-function to a > deeth of 1. By this all necessary checks should be possible, but > endless-recurs

Re: [PATCH] widl: Limit recursion deepth within structs to 1 for checking for full-pointers.

2013-08-30 Thread Kai Tietz
Ups, sorry 2013/8/30 Paul Chitescu : > Hi! > > It would help to attach the patch, not your editor's swap file. > > Paul > > > On Friday 30 August 2013 10:57:26 pm Kai Tietz wrote: >> Hello, >> >> attached patch limits recursion in type_has_full_pointer-function to a >> deeth of 1. By this all nec

Re: [PATCH 3/3] ws2_32: Implement get socket option SO_PROTOCOL_INFO

2013-08-30 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=1945 Your paranoid andr