Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26878 Your paranoid android

Re: ntdll: Store all 'comClass' attributes (try2)

2013-08-27 Thread Alexandre Julliard
Nikolay Sivov writes: > +static OLEMISC get_olemisc_value(const WCHAR *str, int len) > +{ > +int min, max; > + > +min = 0; > +max = ARRAY_SIZE(olemisc_values) - 1; > + > +while (min <= max) > +{ > +int n, c; > + > +n = (min+max)/2; > + > +c = memcmp(ole

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-27 Thread Dmitry Timoshkov
Marvin wrote: > === WVISTAX64 (32 bit comm) === > comm.c:835: Test failed: WriteFile took 16 ms to write 0 Bytes at 150 Baud Failure is not caused by this patch, probably a VM is very slow. -- Dmitry.

Re: [1/4] ntdll: Ignore ioctl(TIOCGICOUNT) failures.

2013-08-27 Thread Wolfgang Walter
Hello, I made similar changes so that several applications we use work. I tested your patches, all but one do work. I don't know why one does not, though. I attached my patch, maybe it is usefull to you. Regards, -- Wolfgang Walter Studentenwerk München Anstalt des öffentlichen Rechts Abteilun

Re: [1/4] ntdll: Ignore ioctl(TIOCGICOUNT) failures.

2013-08-27 Thread Dmitry Timoshkov
Hi Wolfgang, Wolfgang Walter wrote: > I made similar changes so that several applications we use work. I tested > your > patches, all but one do work. I don't know why one does not, though. What patch doesn't work for you? Do you have a test case or a specific scenario which doesn't work? Wha

Re: ntdll: Implement job objects

2013-08-27 Thread Dmitry Timoshkov
Andrew Cook wrote: > +typedef struct _JOBOBJECT_ASSOCIATE_COMPLETION_PORT { > + PVOID CompletionKey; > + HANDLE CompletionPort; > +} JOBOBJECT_ASSOCIATE_COMPLETION_PORT, *PJOBOBJECT_ASSOCIATE_COMPLETION_PORT; This needs to go into its owm header. > +static DWORD getProcess(PHANDLE handle) {

Re: ntdll: Implement job objects

2013-08-27 Thread Andrew Cook
On 27/08/13 22:02, Dmitry Timoshkov wrote: > Andrew Cook wrote: >> --- a/include/wine/server_protocol.h >> +++ b/include/wine/server_protocol.h > > And don't include autogenerated stuff in the patch. > Is there anything about this on the wiki? i wasn't sure how autogenerated files are supposed

Re: ntdll: Implement job objects

2013-08-27 Thread Dmitry Timoshkov
Andrew Cook wrote: > On 27/08/13 22:02, Dmitry Timoshkov wrote: > > Andrew Cook wrote: > >> --- a/include/wine/server_protocol.h > >> +++ b/include/wine/server_protocol.h > > > > And don't include autogenerated stuff in the patch. > > > > Is there anything about this on the wiki? i wasn't sur

Re: ntdll: Implement job objects

2013-08-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26885 Your paranoid android

Re: Does auto-apt work to get wine dependencies in source code?

2013-08-27 Thread Susan Cragin
--Sorry about the HTML in the earlier message. >> Was thinking of running some tests but the list of dependencies on the >> website seems outdated, apt-get build-dep does not work. >Is that with the ubuntu-wine ppa enabled? There are two answers to that question, surprisingly. (1) bitbox In t

Retiring winetestbot

2013-08-27 Thread Jeremy White
Folks, I am writing to announce that we will be retiring the original Wine Test Bot, written by the late Ge van Geldorp, as of August 31, 2013. We will switch over to the new test bot that Francois has been working on at that time. On September 1, we'll panic and fix everything that is broken ).

Re: [1/4] ntdll: Ignore ioctl(TIOCGICOUNT) failures.

2013-08-27 Thread Wolfgang Walter
Am Dienstag, 27. August 2013, 22:00:59 schrieben Sie: > Wolfgang Walter wrote: > > > Wolfgang Walter wrote: > > > > I made similar changes so that several applications we use work. I > > > > tested > > > > your patches, all but one do work. I don't know why one does not, > > > > though. > > > >

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-27 Thread Alexandre Julliard
Dmitry Timoshkov writes: > --- > dlls/kernel32/tests/comm.c | 5 + > dlls/ntdll/serial.c| 13 + > 2 files changed, 6 insertions(+), 12 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so comm.c && to

RFC: Mark dylib/mach-o on Mac OS X

2013-08-27 Thread André Hentschel
Hi, at [1] i noticed that dylibs are printed as PEs. This intents to fix that, but i have no Mac, could someone please review/test? [1] http://test.winehq.org/data/8ef3a142263e6db11f1514f77b3de84c8b08d7a0/mac_fg-snow-macdrv/advapi32:cred.html diff --git a/dlls/dbghelp/module.c b/dlls/dbghelp/mod

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-27 Thread Wolfgang Walter
On Tuesday 27 August 2013 21:14:05 Alexandre Julliard wrote: > Dmitry Timoshkov writes: > > --- > > > > dlls/kernel32/tests/comm.c | 5 + > > dlls/ntdll/serial.c| 13 + > > 2 files changed, 6 insertions(+), 12 deletions(-) > > It doesn't work here: > > ../../../tools/r

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-27 Thread Ken Thomases
Hi, On Aug 27, 2013, at 4:08 PM, André Hentschel wrote: > @@ -94,6 +95,9 @@ static void module_fill_module(const WCHAR* in, WCHAR* out, > size_t size) > if (len > 3 && !strcmpiW(&out[len - 3], S_DotSoW) && > (l = match_ext(out, len - 3))) > strcpyW(&out[len - l -

Re: msvcr90/tests: Add more ARM forwards and use them in tests

2013-08-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26894 Your paranoid android

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-27 Thread Dmitry Timoshkov
Alexandre Julliard wrote: > It doesn't work here: > > ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p > kernel32_test.exe.so comm.c && touch comm.ok > comm.c:835: Test failed: WriteFile took 1 ms to write 17 Bytes at 150 Baud > comm.c:848: Test failed: WaitCommEvent failed with

Re: RFC: Mark dylib/mach-o on Mac OS X

2013-08-27 Thread Charles Davis
On Aug 27, 2013, at 3:08 PM, André Hentschel wrote: > Hi, > at [1] i noticed that dylibs are printed as PEs. > This intents to fix that, but i have no Mac, could someone please review/test? > > [1] > http://test.winehq.org/data/8ef3a142263e6db11f1514f77b3de84c8b08d7a0/mac_fg-snow-macdrv/advapi3

Re: [4/4] ntdll: Properly set flag which indicates buffer empty state.

2013-08-27 Thread Dmitry Timoshkov
Dmitry Timoshkov wrote: > Alexandre Julliard wrote: > > > It doesn't work here: > > > > ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p > > kernel32_test.exe.so comm.c && touch comm.ok > > comm.c:835: Test failed: WriteFile took 1 ms to write 17 Bytes at 150 Baud > > comm.c:8

[AppDB] How to deal with hardware/driver dependent test result?

2013-08-27 Thread Felix Yan
Hi, I'm maintaining Spore 1.0, and it works correctly in wine for over a year on Nvidia video card with closed-source nvidia driver - but I do noticed with Intel cards with open source drivers, the game is nearly not playable - missing texture and more problems. Today comes in a new test resul

Re: kernel32/tests: Remove a useless trace.

2013-08-27 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26897 Your paranoid android

Re: [AppDB] How to deal with hardware/driver dependent test result?

2013-08-27 Thread Austin English
On Tue, Aug 27, 2013 at 8:57 PM, Felix Yan wrote: > Hi, > > I'm maintaining Spore 1.0, and it works correctly in wine for over a year on > Nvidia video card with closed-source nvidia driver - but I do noticed with > Intel cards with open source drivers, the game is nearly not playable - > missi