Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

2013-08-30 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-30 17:50, schrieb Henri Verbeet: > Well, regardless of which one it is, I don't see a similar check > for 2D and cube textures at the moment. I think some tests would > be welcome. You are right, there's neither a check nor tests. I am certa

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

2013-08-30 Thread Henri Verbeet
On 30 August 2013 00:19, Stefan Dösinger wrote: > +if (format->flags & WINED3DFMT_FLAG_BLOCKS) > +{ > +UINT width_mask = format->block_width - 1; > +UINT height_mask = format->block_height - 1; > +if (desc->width & width_mask || desc->height & height_mask) > +

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

2013-08-30 Thread Stefan Dösinger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 2013-08-30 17:31, schrieb Henri Verbeet: > On 30 August 2013 00:19, Stefan Dösinger > wrote: >> +if (format->flags & WINED3DFMT_FLAG_BLOCKS) +{ + >> UINT width_mask = format->block_width - 1; +UINT >> height_mask = format->block_hei

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

2013-08-30 Thread Henri Verbeet
On 30 August 2013 17:35, Stefan Dösinger wrote: > Am 2013-08-30 17:31, schrieb Henri Verbeet: >> Is this different from surfaces? IIRC surfaces are padded up to >> the next multiple of the block size, although I may have that >> wrong. Not a fan of the "(%p) : " trace formatting. > Padding happens