Re: NtQuerySystemInformation and exposing unix_pid

2011-08-03 Thread Paul Vriens
On 08/03/2011 07:13 PM, Alexandre Julliard wrote: Paul Vriens writes: Hi, I would like to add some per-process information in NtQuerySystemInformation with respect to cpu-usage. The wine server doesn't currently expose the unix_pid so I can't use /proc//* information. Would i

NtQuerySystemInformation and exposing unix_pid

2011-08-01 Thread Paul Vriens
Hi, I would like to add some per-process information in NtQuerySystemInformation with respect to cpu-usage. The wine server doesn't currently expose the unix_pid so I can't use /proc//* information. Would it be ok to expose the unix_pid in some of the server calls (like next_process)? Or

Re: NtQuerySystemInformation needs a little bit more flesh for SystemProcessorPerformanceInformation

2011-08-01 Thread Paul Vriens
On 07/28/2011 08:31 PM, Juan Lang wrote: This Reserved1[0] is the DPC Time but I'm wondering what values from /proc/stat to use here (remainder[0] is I/O wait). We could always make up something of course but being accurate would be nicer. DPC Time has no equivalent in /proc/stat. It's an NT t

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2, resend)

2011-07-28 Thread Paul Vriens
On 07/29/2011 01:29 AM, Octavian Voicu wrote: +else +win_skip("Not on WOW64, skipping test.\n"); Why a win_skip()? Isn't a normal skip() more appropriate? -- Cheers, Paul.

NtQuerySystemInformation needs a little bit more flesh for SystemProcessorPerformanceInformation

2011-07-27 Thread Paul Vriens
Hi, I was trying out the latest SysInternals Process Explorer and it struck me that the overall CPU % stayed at 0. Adding some values to the sppi structure fixed this but I'm just wondering what values to use: sppi[cpus-1].Reserved1[0].QuadPart = (ULONGLONG)remainder[0] * 1000 / clk_

Re: richedit: Implement WB_DELIMITER and remove todo_wine's in tests.

2011-07-26 Thread Paul Vriens
On 07/26/2011 03:36 AM, James McKenzie wrote: if (wbuf[0] == 0x20 || wbuf[0] == 0xf020) -todo_wine -ok(result == delimiter_tests[i].isdelimiter, - "wanted ISDELIMITER_W(0x%x) %d, got %d\n", - delimiter_tests[i].c, delimite

Re: [PATCH] wscript: implemented Host_get_BuildVersion

2011-07-05 Thread Paul Vriens
On 07/04/2011 11:28 PM, Michał Ziętek wrote: +ok(typeof(WScript.BuildVersion) === "number", "typeof(WScript.BuldVersion) = " + typeof(WScript.BuldVersion)); Patch is already committed but there is a typo here 'BuldVersion' instead of 'BuildVersion'. -- Cheers, Paul.

Re: [PATCH 04/13] winmm: Clean up waveform.c's style

2011-06-24 Thread Paul Vriens
On 06/23/2011 08:12 PM, Andrew Eikum wrote: +if(dwFlags& WAVE_FORMAT_QUERY) +TRACE("WAVE_FORMAT_QUERY requested!\n"); How is removing the spaces for all these if/else statements an improvement? It's also not consistent with the rest of the winmm code. -- Cheers, Paul.

Ge (Greg) van Geldorp

2011-06-10 Thread Paul Vriens
ers, Paul. Original Message Subject:RE: Ge van Geldorp Date: Thu, 9 Jun 2011 23:05:46 +0200 From: Erven Gé van Geldorp To: 'Paul Vriens' Hi all, My name is Arno van Geldorp. I'm the brother of Gé (Greg) van Geldorp. I'm very sorry that

Re: [Fwd: po files]

2011-04-28 Thread Paul Vriens
On 04/28/2011 11:21 AM, Łukasz Wojniłowicz wrote: Hi Łukasz, Frederic had the same "issues" if I'm correct. Please have a look at: http://www.winehq.org/pipermail/wine-patches/2011-April/101200.html and http://www.winehq.org/pipermail/wine-devel/2011-April/089796.html -- Cheers, Paul.

Re: kernel32/tests: remove win9x hacks

2011-02-23 Thread Paul Vriens
On 02/23/2011 10:15 AM, Austin English wrote: SetLastError(0xdeadbeef); ret = GetFullPathNameW(NULL, 0, NULL, NULL); I think you can get rid of the above two as well as they are merely used to trigger the ERROR_CALL_NOT_IMPLEMENTED. -is_win9x = !ret&& GetLastError() == ERRO

Re: RFC: Patch to change what sets the is_win9x in riched20/tests

2011-02-21 Thread Paul Vriens
On 02/22/2011 01:21 AM, James McKenzie wrote: All: Upon examining other test code that creates a variable called is_win9x, I realized that using get_version and comparing it to a fixed value may not be best for the riched20 tests and have attached a proposed change to how this variable is set. I

Re: po: Update French translation

2011-02-08 Thread Paul Vriens
On 02/08/2011 05:28 PM, Frédéric Delanoy wrote: #: avifil32.rc:27 +#, fuzzy msgid "Waveform: %s" msgstr "Waveform : %s" #: avifil32.rc:28 +#, fuzzy msgid "Waveform" msgstr "Waveform" Hi, Are you adding the 'fuzzy' on purpose? I think that the fuzzy ones are ignored for translatio

Re: wintrust/tests: make sure return values are used (LLVM/Clang) (resend)

2011-02-04 Thread Paul Vriens
On 02/04/2011 09:32 AM, Austin English wrote: -ret = funcs->pfnObjectTrust(&data); +funcs->pfnObjectTrust(&data); +ok(ret == S_FALSE, "Expected S_FALSE, got %08x\n", ret); This doesn't look correct (you are removing the assignment and then check it). I know

Re: [dlls/shdocvw] Initialize variable (Coverity)

2011-02-01 Thread Paul Vriens
On 02/01/2011 03:26 PM, Nikolay Sivov wrote: On 2/1/2011 17:14, Paul Vriens wrote: Hi, Addresses Coverity #1090. If CoCreateInstance() fails we check the uninitialized urlfile variable. Same story with urlobj. In fact it looks better to try CoCreateInstance first, before anything else like

Re: Testbot not accepting patch

2011-01-15 Thread Paul Vriens
On 01/14/2011 11:20 PM, Travis Athougies wrote: Hi there, I've been trying to submit this patch to the testbot, and it keeps refusing it with the error "Unrecognized file typea" (that's not a typo, that's the exact error). The testbot has also refused to accept the patch when I sent it in on win

Re: gdiplus: Support for indexed formats in GdipBitmapSetPixel

2011-01-11 Thread Paul Vriens
On 01/11/2011 02:26 AM, MP wrote: +case PixelFormat8bppIndexed: +setpixel_8bppIndexed(r,g,b,a,row,x,bitmap); +break; +case PixelFormat4bppIndexed: +setpixel_8bppIndexed(r,g,b,a,row,x,bitmap); +break; +case PixelFormat1bppInde

Re: "N" shows up as missing on the translations status website

2011-01-05 Thread Paul Vriens
On 01/05/2011 09:44 PM, Sven Baars wrote: Hey all, since today, the "N" string shows up as missing on http://source.winehq.org/transl/ even though it's there in the po file. This happened for both xcopy and cmd. In the po file it says #: cmd.rc:257 xcopy.rc:41 msgctxt "No key" msgid "N" msgstr

Re: spoolss/tests: Skip tests on Win7

2010-12-27 Thread Paul Vriens
On 12/27/2010 12:47 PM, Greg Geldorp wrote: From: Paul Vriens But that means we will skip on Wine as well (when/if implemented). Is that OK? We skip if UnloadDriver is NOT present. It is present on Wine, so the tests do run on Wine. Win7 is the only platform where the function is not present

Re: spoolss/tests: Skip tests on Win7

2010-12-27 Thread Paul Vriens
On 12/27/2010 12:35 PM, Greg Geldorp wrote: --- dlls/spoolss/tests/spoolss.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) But that means we will skip on Wine as well (when/if implemented). Is that OK? -- Cheers, Paul.

Re: Hebrew version of Wine History

2010-12-27 Thread Paul Vriens
On 12/24/2010 01:32 AM, Yaron Shahrabani wrote: Hey, I translated the Wine History into Hebrew several weeks ago and I noticed that although the patches are in, when I click on Wine's History on the Hebrew website I'm being taken to the English version of the document in Wine's wiki. That's act

Re: Testbot: User not logged in Problem with WVISTAADM

2010-12-14 Thread Paul Vriens
On 12/14/2010 04:44 PM, Greg Geldorp wrote: Hi André there is a noisy problem with the WVISTAADM, which causes much tests to be shown as "Failed" in the patchtracker. should we blacklist the Message returned by WVISTAADM or can you fix the underlying problem? I'm making some changes to the Te

Re: [PATCH 5/6] mshtml: Added IHTMLWindow2::open test.

2010-12-12 Thread Paul Vriens
Hi Jacek, On 06/14/2010 02:20 AM, Jacek Caban wrote: --- dlls/mshtml/tests/htmldoc.c | 100 ++- 1 files changed, 98 insertions(+), 2 deletions(-) Some of these tests fail on IE6 SP1: http://test.winehq.org/data/tests/mshtml:htmldoc.html What would

Re: wine's configure says "gst/gstpad.h usability... No"

2010-12-11 Thread Paul Vriens
On 12/11/2010 08:26 AM, wy...@volny.cz wrote: Hi guys, i'm overworked so wanted to relax a bit with wine :-D and noticed that Debian Squeeze says: gstreamer-0.10 development files not found, gstreamer support disabled but "dpkg -l | grep -i gst": ii libgstreamer-plugins-base0.10-0

Re: winemenubuilder: Include icons in .url menus

2010-12-07 Thread Paul Vriens
On 12/07/2010 06:45 PM, Andrew Bogott wrote: This should supersede the previous version of this patch. This one plugs a memory leak present in the last version. Hi Andrew, The previous patch has already been committed. -- Cheers, Paul.

Re: [1/4] shdocvw: skip some tests if a modern IE is not present

2010-12-05 Thread Paul Vriens
On 12/02/2010 04:38 AM, Andrew Bogott wrote: As suggested by Jacek. Hi Andrew, Even IE6 does things differently as can be seen: http://test.winehq.org/data/tests/shdocvw:intshcut.html Just a matter of adding a broken() statement and bailing out (with cleanup) if the IPropertyStorage_ReadMu

How to deal with variables where the size differs for 32 and 64bit

2010-12-05 Thread Paul Vriens
Hi, Just found the fix for the oledb32:convert tests on 64bit. We need to adjust our oledb.idl (see patch attached). How should I deal with the ok() messages where we currently specify the 32bit variant? I mean this will of course introduce warnings on the 64bit side. Do I need to create a

Re: Use of the L prefix for wide strings in resource files

2010-12-05 Thread Paul Vriens
On 12/05/2010 04:14 PM, Alexandre Julliard wrote: Paul Vriens writes: Hi, Yaron just made me aware of something he and I discussed briefly a few weeks ago. The shlwapi resource files uses the following: PUSHBUTTON L"&OK", IDOK, 105, 40, 50, 14, WS_GROUP | WS_TABSTOP

Use of the L prefix for wide strings in resource files

2010-12-05 Thread Paul Vriens
Hi, Yaron just made me aware of something he and I discussed briefly a few weeks ago. The shlwapi resource files uses the following: PUSHBUTTON L"&OK", IDOK, 105, 40, 50, 14, WS_GROUP | WS_TABSTOP PUSHBUTTON L"&Cancel", IDCANCEL, 160, 40, 50, 14, WS_GROUP | WS_TABSTOP PUSHBUTTON L"&Yes", I

Re: Death to win9x?

2010-11-30 Thread Paul Vriens
On 11/30/2010 08:53 PM, Eric Durbin wrote: On Tue, Nov 30, 2010 at 12:17 PM, Dan Kegel mailto:d...@kegel.com>> wrote: I'm all for removing stuff that nobody needs anymore. I imagine there are still a few popular older apps that will force us to keep some old win9x behaviors around,

Re: mshtml: Added beginning ActiveX tests.

2010-11-30 Thread Paul Vriens
On 11/30/2010 04:41 PM, Alexandre Julliard wrote: Jacek Caban writes: I can see that these tests may be useful sometimes, eg. if someone is interested in old apps that don't run on new Windows. But the honest true is that it's not what happens with our tests. All we usually do with old Windows

Re: mshtml: Added beginning ActiveX tests.

2010-11-30 Thread Paul Vriens
On 11/30/2010 03:42 PM, Jacek Caban wrote: Hi Paul, On 11/30/10 2:46 PM, Paul Vriens wrote: Changing the lstrcmpW and using A-functions to create the window makes the tests succeed on my win98 box (changed activex.c attached). Thanks for catching it. How about this version: http

Re: mshtml: Added beginning ActiveX tests.

2010-11-30 Thread Paul Vriens
On 11/30/2010 01:56 PM, Paul Vriens wrote: Hi Jacek, On 11/30/2010 01:38 PM, Jacek Caban wrote: +static HRESULT WINAPI PropertyNotifySink_OnChanged(IPropertyNotifySink *iface, DISPID dispID) +{ + if(dispID == DISPID_READYSTATE){ + BSTR state; + HRESULT hres; + + static const WCHAR completeW

Re: mshtml: Added beginning ActiveX tests.

2010-11-30 Thread Paul Vriens
Hi Jacek, On 11/30/2010 01:38 PM, Jacek Caban wrote: +static HRESULT WINAPI PropertyNotifySink_OnChanged(IPropertyNotifySink *iface, DISPID dispID) +{ +if(dispID == DISPID_READYSTATE){ +BSTR state; +HRESULT hres; + +static const WCHAR completeW[] = {'c','o','m','p','

Re: [PATCH 3/5] mshtml: Added SetUIHandler tests.

2010-11-29 Thread Paul Vriens
Hi Jacek, On 11/29/2010 12:18 AM, Jacek Caban wrote: --- dlls/mshtml/tests/htmldoc.c | 111 --- 1 files changed, 104 insertions(+), 7 deletions(-) This one introduced some test failures: http://test.winehq.org/data/tests/mshtml:htmldoc.html Just a matte

Re: atl/tests: Fix test in test_registrar.

2010-11-27 Thread Paul Vriens
Hi Gerald, On 11/27/2010 10:19 PM, Gerald Pfeifer wrote: An obvious one I'd say... Gerald --- dlls/atl/tests/registrar.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/atl/tests/registrar.c b/dlls/atl/tests/registrar.c index 422608b..268765f 100644 --- a/dlls/

Re: [2/2] atl: add support for binary values in IRegistrar

2010-11-27 Thread Paul Vriens
On 11/27/2010 10:50 PM, Paul Vriens wrote: On 11/27/2010 10:18 PM, Paul Vriens wrote: I could imagine that binary values are not supported on Win95 but the same (?) issue is also present on some NT4, XP and even Windows7. The XP and Windows7 failures can be explained by the fact that those

Re: [2/2] atl: add support for binary values in IRegistrar

2010-11-27 Thread Paul Vriens
On 11/27/2010 10:18 PM, Paul Vriens wrote: I could imagine that binary values are not supported on Win95 but the same (?) issue is also present on some NT4, XP and even Windows7. The XP and Windows7 failures can be explained by the fact that those users weren't running the tes

Re: [2/2] atl: add support for binary values in IRegistrar

2010-11-27 Thread Paul Vriens
Hi Damjan, On 11/24/2010 10:10 AM, Damjan Jovanovic wrote: Changelog: * atl: add support for binary values in IRegistrar It appears that 'm' (REG_MULTI_SZ) values do not work on Windows (not even the MSDN example on http://msdn.microsoft.com/en-us/library/ttd53fhh(VS.71).aspx), so this conclude

Re: wininet: add a stub for InternetShowSecurityInfoByURL

2010-11-25 Thread Paul Vriens
On 11/25/2010 03:35 PM, Austin English wrote: On Wed, Nov 24, 2010 at 11:32 PM, Paul Vriens wrote: On 11/25/2010 03:29 AM, Austin English wrote: Fixes http://bugs.winehq.org/show_bug.cgi?id=25278 Shouldn't you create the A-version and forward to that one in the .spec? That wouldn

Re: wininet: add a stub for InternetShowSecurityInfoByURL

2010-11-24 Thread Paul Vriens
On 11/25/2010 03:29 AM, Austin English wrote: Fixes http://bugs.winehq.org/show_bug.cgi?id=25278 Shouldn't you create the A-version and forward to that one in the .spec? -- Cheers, Paul.

Re: services: Allow one more combined service type

2010-11-23 Thread Paul Vriens
On 11/23/2010 11:17 PM, André Hentschel wrote: Am 23.11.2010 22:31, schrieb Paul Vriens: Hi André, On 11/23/2010 08:45 PM, André Hentschel wrote: I have a service with type 3, this patch allows him to run. It runs perfectly and does not produce FIXMEs or ERRORs, so it's fine. --- D

Re: services: Allow one more combined service type

2010-11-23 Thread Paul Vriens
Hi André, On 11/23/2010 08:45 PM, André Hentschel wrote: I have a service with type 3, this patch allows him to run. It runs perfectly and does not produce FIXMEs or ERRORs, so it's fine. --- Do you have some more information? It's not possible (at least on XP) to create a service that has '

Re: ntdll/tests: add tests for NtQueryVolumeInformationFile with FileFsVolumeInformation class

2010-11-22 Thread Paul Vriens
On 11/22/2010 07:59 PM, Louis Lenders wrote: +status = NtQueryVolumeInformationFile( dir,&io, buf, sizeof(buf), FileFsVolumeInformation ); You have to use the 'p' one here to please Win9x where this function is not exported. -- Cheers, Paul.

Re: [mscoree/tests 4/4] Fix test failures on W2K and earlier

2010-11-22 Thread Paul Vriens
On 11/22/2010 05:57 PM, Vincent Povirk wrote: I think this test can be removed. I wanted to verify that LoadLibraryShim would succeed for a dll that is absent from the .NET system directory but present in system32. I had heard of LoadLibraryShim succeeding for gdiplus, so I was very surprised wh

Re: [resend]: [dlls/dbgeng]: add initial stub dll implementation

2010-11-19 Thread Paul Vriens
On 11/19/2010 03:50 PM, Volodymyr Shcherbyna wrote: (I am re-sending this patch as gmail did extra formattings to previous patches) Hi, +MODULE= dbgeng.dll +IMPORTLIB = dbgebg Typo? You also have to use your own wording for the comments, if needed at all, to the functions. You can't jus

Re: crypt32/tests: Add tests for decoding enveloped messages.

2010-11-14 Thread Paul Vriens
Hi Alexander, On 11/02/2010 01:56 PM, Alexander Morozov wrote: +CryptAcquireContextA(&hCryptProv, NULL, MS_ENHANCED_PROV_A, PROV_RSA_FULL, + CRYPT_VERIFYCONTEXT); Other calls use pCryptAcquireContextA but I guess that had to do with some platforms in the past that didn't export CryptA

Re: [try 2] Test for window messages of a property sheet with custom dialog proc (bug 12104)

2010-11-13 Thread Paul Vriens
On 11/13/2010 10:59 AM, Bernhard Übelacker wrote: When I run both tests as single files from a "make crosstest" I was not able to reproduce neither the explorer crash or the explorer windows not opening. I didn't see a crash but maybe this is because I'm testing on W2K. I can still reliably ge

Re: Compilation error with latest wine

2010-11-13 Thread Paul Vriens
Hi, rm dlls/atl/atliface.h Cheers, Paul On Nov 13, 2010 12:00 PM, "Joel Holdsworth" wrote: > Hmm, > > Looks like it was caused by commit > 9c4432f69d91007d02c52c50ba565ca795f44765, I think the CLSID isn't being > included properly. Probably easy to fix. > > Joel > > >

Re: [2/11] update Simplified Chinese translation: notepad

2010-11-12 Thread Paul Vriens
On 11/12/2010 02:26 PM, cheer_xiao wrote: Here is my update for the Simplified Chinese translation. I have "make"d all corresponding files to ensure that they don't get broken. Copyright info has been included (if not present). Hi, Most of your emails don't contain the actual patches. -- C

Re: [try 2] Test for window messages of a property sheet with custom dialog proc (bug 12104)

2010-11-11 Thread Paul Vriens
On 11/06/2010 11:16 AM, Bernhard Übelacker wrote: Hello, this patch checks for correct arrival of messages to a subclassed property page. For this bug http://bugs.winehq.org/show_bug.cgi?id=12104 specifically the first WM_SIZE message is interesting which is not sent in wine. I have changed the

Re: inetcpl.cpl: Added Portuguese (Brazilian) translation (try 2)

2010-11-11 Thread Paul Vriens
On 11/11/2010 03:13 PM, Eu wrote: I had forgotten to configure the author name and e-mail, resending patch. Hi Gustavo, The header says "English resources for the Internet control panel applet". You also need only one "LANGUAGE LANG_PORTUGUESE, SUBLANG_PORTUGUESE_BRAZILIAN" at the beginning

Re: comdlg32: Added Hebrew translation.

2010-10-26 Thread Paul Vriens
On 10/26/2010 10:59 AM, Yaron Shahrabani wrote: What is wrong with the patch? Yaron Shahrabani 2010/10/23 Yaron Shahrabani mailto:sh.ya...@gmail.com>> Verified by Paul Vriens Nothing: http://source.winehq.org/git/wine.git/?a=co

Re: Re : missing tests in test.winehq.org

2010-10-24 Thread Paul Vriens
On 10/24/2010 01:51 PM, paulo lesgaz wrote: but nothing at http://test.winehq.org/data/8c5718ec9d0613be7208e1ceaecac0e7434c4cf5/index_2003.html for instance. (And to list, I should remember to hit the correct button). That's because there are no failures/skips for ddraw:drawmodes on that plat

Re: missing tests in test.winehq.org

2010-10-24 Thread Paul Vriens
On 10/24/2010 09:23 AM, paulo lesgaz wrote: Hello, looking at http://test.winehq.org, i remarked that the file ddraw/tests/ddrawmodes does not exist and so it is never tested. What about: http://test.winehq.org/data/tests/ddraw:ddrawmodes.html or am I missing something? -- Cheers, Paul.

Re: winegstreamer error with 'make install'

2010-10-22 Thread Paul Vriens
On 10/22/2010 09:37 PM, Reece Dunn wrote: On 22 October 2010 20:07, Paul Vriens wrote: Hi, Current Git (Fedora 13) gives me: /usr/bin/install -c winegstreamer.so /usr/local/lib64/wine/winegstreamer.so /usr/bin/install: cannot stat `winegstreamer.so': No such file or directory There

winegstreamer error with 'make install'

2010-10-22 Thread Paul Vriens
Hi, Current Git (Fedora 13) gives me: /usr/bin/install -c winegstreamer.so /usr/local/lib64/wine/winegstreamer.so /usr/bin/install: cannot stat `winegstreamer.so': No such file or directory There is a winegstreamer.dll.so in this directory. Anyone? -- Cheers, Paul.

Re: Website: Change language string

2010-10-17 Thread Paul Vriens
On 10/17/2010 12:21 PM, Yaron Shahrabani wrote: Where does the translation of "Change Language" string at the bottom of the page and in the lang.template come from? (The current term used is male specific, I want to make it genderless). Kind regards, Yaron Shahrabani Hi Yaron, See http

Re: msi/tests: Move test coverage for standard actions to a separate module.

2010-10-14 Thread Paul Vriens
On 10/14/2010 01:12 PM, Hans Leidekker wrote: This is to get rid of the remaining timeouts on testbot. We now have a clean test run: http://testbot.winehq.org/JobDetails.pl?Key=6167 On platforms where we need to create a restore point the install tests still take over two minutes, so depending

Re: (6th try) winhlp32: Added Hebrew translation

2010-10-05 Thread Paul Vriens
Hi Yaron, I'm see this one is still not applied. Maybe because there are still some small issues? See below. On 10/03/2010 11:12 PM, Yaron Shahrabani wrote: +LANGUAGE LANG_HEBREW, SUBLANG_DEFAULT This line should go, it's redundant (it's already stated at the beginning). This line was pres

Re: Question on use of TextMetricsW

2010-10-03 Thread Paul Vriens
On 10/03/2010 08:44 PM, James McKenzie wrote: All: I am running code like the following in a richedit control to set the font to Courier 12 point font: + static const WCHAR courier[] = {'C','o','u','r','i','e','r',0}; + testFont1 = CreateFontW (12,0,0,0,FW_LIGHT, 0, 0, 0, ANSI_CHARSET, + OUT_D

Re: (5th try) winhlp32: Added Hebrew translation

2010-10-03 Thread Paul Vriens
On 10/03/2010 05:04 PM, Yaron Shahrabani wrote: + +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT + Hi Yaron, This piece should go. And I still have an apply warning for your Makefile.in patch. -- Cheers, Paul.

Re: [PATCH] user32: Update Finnish translation.

2010-09-25 Thread Paul Vriens
On 09/25/2010 03:43 PM, Lauri Kenttä wrote: Hi! Great to see that someone is picking up the Finnish translations again (last real contribution is from 2006). I'm a bit sorry I didn't have time for this before the 1.2 release, but better late than never. :) My girlfriend will maybe send patche

Re: Right-To-Left (RTL) languages and Wine

2010-09-24 Thread Paul Vriens
On 07/30/2010 10:02 AM, Alexandre Julliard wrote: Paul Vriens writes: On 07/29/2010 08:13 PM, Alexandre Julliard wrote: That depends on the situation. In some cases it can be set globally through the version resources, in other cases it will have to be set on an individual resource basis, or

Re: [PATCH 1/4] kernel32: add test for WaitForSingleObject with lower 2 bits of handles set

2010-09-22 Thread Paul Vriens
On 09/22/2010 07:53 PM, Peter Oberndorfer wrote: +if(GetVersion()& 0x8000) +{ +win_skip("Handles work differently on win9x\n"); +return; +} + +signaled = CreateEventW(NULL, TRUE, TRUE, NULL); Hi Peter, You could just as easily check for the last error of Cr

Re: ipconfig: Add the Polish translation.

2010-09-21 Thread Paul Vriens
On 09/19/2010 07:30 PM, Paul Vriens wrote: On 09/19/2010 11:11 AM, Łukasz Wojniłowicz wrote: +#include "ipconfig.h" + +LANGUAGE LANG_POLISH, SUBLANG_DEFAULT + +STRINGTABLE Hi Łukasz, This newly created file is UTF-8 so you should add the needed pragma (or convert to some

Re: ipconfig: Add the Polish translation.

2010-09-19 Thread Paul Vriens
On 09/19/2010 11:11 AM, Łukasz Wojniłowicz wrote: +#include "ipconfig.h" + +LANGUAGE LANG_POLISH, SUBLANG_DEFAULT + +STRINGTABLE Hi Łukasz, This newly created file is UTF-8 so you should add the needed pragma (or convert to something else). Compiling this one results in: Warning: string "Sp

Re: winhlp32: Added Hebrew translation

2010-09-17 Thread Paul Vriens
On 09/17/2010 06:31 PM, Yaron Shahrabani wrote: +LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT + Hi Sharon, This line should be removed. It results in: winebuild: duplicate resource type 0004 name f001 language 0409 winebuild: duplicate resource type 0005 name 0150 language 0409 winebuild: duplicat

Re: [4/4] msxml3: Properly set default value for SelectionLanguage property

2010-09-15 Thread Paul Vriens
On 09/15/2010 04:11 PM, Paul Vriens wrote: On 09/14/2010 07:20 AM, Nikolay Sivov wrote: Properly set default value for SelectionLanguage property Hi Nikolay, I wondered why there were only a few testbot reports on test.winehq.org. Looking at the reports on test.winehq.org (I have an account

Re: [4/4] msxml3: Properly set default value for SelectionLanguage property

2010-09-15 Thread Paul Vriens
On 09/14/2010 07:20 AM, Nikolay Sivov wrote: Properly set default value for SelectionLanguage property Hi Nikolay, I wondered why there were only a few testbot reports on test.winehq.org. Looking at the reports on test.winehq.org (I have an account) shows that the reports are filled (12000+

Re: kernel32: add a stub for GetSystemDEPPolicy()

2010-09-12 Thread Paul Vriens
On 09/12/2010 08:04 PM, Marcus Meissner wrote: On Sun, Sep 12, 2010 at 12:50:39PM -0500, Austin English wrote: -- -Austin diff --git a/dlls/kernel32/kernel32.spec b/dlls/kernel32/kernel32.spec index 8a33013..43e339b 100644 --- a/dlls/kernel32/kernel32.spec +++ b/dlls/kernel32/kernel32.spec @@

Re: user32: Update Italian translation (try 2)

2010-09-10 Thread Paul Vriens
On 09/09/2010 07:52 PM, Luca Bennati wrote: Fix for Paul's comment Hi Luca, You forgot the patch. -- Cheers, Paul.

Re: user32: Update Italian translation

2010-09-09 Thread Paul Vriens
On 09/09/2010 04:09 PM, Luca Bennati wrote: Hi Luca, You need to add the UTF-8 pragma: Warning: string "&Sì" seems to be UTF-8 but codepage 1252 is in use. Warning: string "&Più finestre..." seems to be UTF-8 but codepage 1252 is in use. -- Cheers, Paul.

Re: [2/7] urlmon/tests: Removed no longer needed todo_wine's

2010-09-08 Thread Paul Vriens
On 09/09/2010 02:46 AM, Thomas Mullaly wrote: These todo's should have been removed as I implemented each of the IUriBuilder_{Get/Set}* functions, but, I forgot about them. Hi Thomas, todo_wine's that succeed are marked as failures so that means these are not fixed on (at least) AJ's box as o

Re: dlls/rstrtmgr: add stubs for RmGetList and RmRegisterResources

2010-09-08 Thread Paul Vriens
On 09/09/2010 07:41 AM, Austin English wrote: +@ stdcall RmGetList(long ptr ptr ptr) Hi Austin, This function has 5 parameters. -- Cheers, Paul.

specfiles containing 'str' instead of 'wstr' for some W-functions

2010-09-07 Thread Paul Vriens
Hi, I see some specfiles that contain 'str' instead of the correct 'wstr'. Is it worth sending a patch to fix these? If so, only one? -- Cheers, Paul.

Using the eventlog API for Wine errors

2010-09-07 Thread Paul Vriens
Hi, I was just reading the emails about the winediag stuff and more particularly AJ's remark about the 'hypothetical GUI'. Would it make sense to really start fleshing out the eventlog API so we can/could log errors (or whatever) in that way? The GUI (or commandline app) could then 'easily'

Re: Does testbot's MingW miscompile winmm:midi tests?

2010-09-06 Thread Paul Vriens
On 09/06/2010 11:02 AM, joerg-cyril.hoe...@t-systems.com wrote: Hi, on test.winehq, WinME systems always report 8 rc=MMSYSERR_INVALPARAM errors. However, when running a MSVC compiled binary (as found in testbot job #4990), no such error occurs. Paul Vriens wrote: I only see those 8 errors

Re: shdocvw: Add the Polish translation

2010-08-04 Thread Paul Vriens
Hi Łukasz, On 08/04/2010 05:45 PM, Łukasz Wojniłowicz wrote: +CAPTION "Otw�rz URL" This file needs the UTF-8 pragma. -- Cheers, Paul.

Re: wordpad: Added Hebrew translation.

2010-08-02 Thread Paul Vriens
On 08/02/2010 05:04 PM, Yaron Shahrabani wrote: On Sun, Aug 1, 2010 at 4:59 PM, Paul Vriens mailto:paul.vriens.w...@gmail.com>> wrote: Hi Yaron, On 08/01/2010 10:52 AM, Yaron Shahrabani wrote: Alexander and Paul, please notice I added the EXSTYLE WS_EX_LAY

Re: write: Added Hebrew translation

2010-08-02 Thread Paul Vriens
On 08/02/2010 04:57 PM, Yaron Shahrabani wrote: +++ b/programs/write/He.rc @@ -0,0 +1,30 @@ +/* + * English language support Should be 'Hebrew' of course ;) -- Cheers, Paul.

Re: wordpad: Added Hebrew translation.

2010-08-01 Thread Paul Vriens
Hi Yaron, On 08/01/2010 10:52 AM, Yaron Shahrabani wrote: Alexander and Paul, please notice I added the EXSTYLE WS_EX_LAYOUTRTL for the dialogs, hope that helps. Also found out that menus does not need any special RTL property, they are self aligned according to the app. What do you mean by t

Re: [2/2] Try2: imagehlp: Implement ImageGetDigestStream

2010-07-31 Thread Paul Vriens
Hi Andrey, On 07/18/2010 12:39 PM, Andrey Turkin wrote: +static BOOL IMAGEHLP_ReportImportSection( IMAGE_SECTION_HEADER *hdr, +DWORD num_sections, BYTE *map, DWORD fileSize, DWORD DigestLevel, +DIGEST_FUNCTION DigestFunction, DIGEST_HANDLE DigestHandle ) +{ +BOOL ret = FALSE; +DW

Re: [5/9] msi: Set/unset the SourceDir property at the right stage in the execution sequence.

2010-07-30 Thread Paul Vriens
Hi Hans, On 07/23/2010 09:42 AM, Hans Leidekker wrote: +/* full UI, no ResolveSource action */ +r = MsiInstallProductA(msifile, NULL); +ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %u\n", r); Right about here I get a popup, waiting for 'OK' to be pushed, on Win95/98/Me that

Re: shdocvw: Add Italian translation

2010-07-30 Thread Paul Vriens
Hi Luca, You need to add the UTF-8 pragma: Warning: string "&Proprietà..." seems to be UTF-8 but codepage 1252 is in use. -- Cheers, Paul.

Re: Right-To-Left (RTL) languages and Wine

2010-07-30 Thread Paul Vriens
On 07/30/2010 10:02 AM, Alexandre Julliard wrote: Paul Vriens writes: On 07/29/2010 08:13 PM, Alexandre Julliard wrote: That depends on the situation. In some cases it can be set globally through the version resources, in other cases it will have to be set on an individual resource basis, or

Re: Right-To-Left (RTL) languages and Wine

2010-07-29 Thread Paul Vriens
On 07/29/2010 08:13 PM, Alexandre Julliard wrote: Paul Vriens writes: I've been in talks with a Hebrew translator for some time now and I'd like to have Wine being able to start doing more RTL stuff. I'm looking for example at http://bugs.winehq.org/show_bug.cgi?id=1158 If I

Right-To-Left (RTL) languages and Wine

2010-07-29 Thread Paul Vriens
Hi, I've been in talks with a Hebrew translator for some time now and I'd like to have Wine being able to start doing more RTL stuff. I'm looking for example at http://bugs.winehq.org/show_bug.cgi?id=1158 If I run an English winmine.exe on an Arabic box (thanks to the testbot) the main windo

Re: user32: Add a test for GetClassInfo, make it pass under Wine.

2010-07-29 Thread Paul Vriens
On 07/29/2010 08:55 AM, Dmitry Timoshkov wrote: +SetLastError(0xdeadbeef); +ret = GetClassInfoEx(0, "static", NULL); Why not the explicit A-function? I see there is already an existing call in the current tests, but still. +ok(!ret, "GetClassInfoEx() should fail\n"); +ok(Get

Re: shdocvw: Add French translation

2010-07-28 Thread Paul Vriens
On 07/27/2010 10:28 AM, Frédéric Delanoy wrote: We now have an error on the translation site as you've merged 'New' and 'Window'. I know you brought this up on wine-devel but until agreed upon we should stick to the English one IMHO. -- Cheers, Paul.

Ukrainian translation of Wine at 100%

2010-07-27 Thread Paul Vriens
Hi, And Ukrainian is also at a 100% !!! Thanks go to Igor for his efforts in getting us this far. -- Cheers, Paul.

Re: programs/winetest: bump file size limit to 1.75 MB (1/2)

2010-07-27 Thread Paul Vriens
On 07/27/2010 03:48 AM, Austin English wrote: There were no test results on winehq today. Seems everyone's exceeding 1.5. Guess some new tests today have a lot of output... I do see output for July 26th or am I missing something? We could use a volunteer to implement compression for the winet

Re: [PATCH 1/2] shlwapi: Implement SHGetIniStringW

2010-07-23 Thread Paul Vriens
On 07/23/2010 04:19 PM, Andrew Eikum wrote: +memset(out, 0, sizeof(out)); It's usually better to fill it with something other than '0'. Checking later for '0' could mean that either the rest of the buffer is indeed untouched or is cleared/zeroed. -- Cheers, Paul.

Re: Any more infos about the build failure for my (small) patch

2010-07-23 Thread Paul Vriens
On 07/23/2010 11:18 AM, Paul Vriens wrote: On 07/23/2010 10:53 AM, Uwe Bonnes wrote: Hello, on my Suse 11.3, /usr/include/ssl/ssl.h defines const SSL_METHOD *method; as does http://www.openssl.org/docs/ssl/ssl.html and so in ../dlls/winhttp/net.c and ../dlls/wininet/netconnection.c static

Re: Any more infos about the build failure for my (small) patch

2010-07-23 Thread Paul Vriens
On 07/23/2010 10:53 AM, Uwe Bonnes wrote: Hello, on my Suse 11.3, /usr/include/ssl/ssl.h defines const SSL_METHOD *method; as does http://www.openssl.org/docs/ssl/ssl.html and so in ../dlls/winhttp/net.c and ../dlls/wininet/netconnection.c static SSL_METHOD *method; is flagges as an warning. M

Re: [shlwapi/tests] Load shell32 explicitly

2010-07-22 Thread Paul Vriens
On 07/22/2010 05:34 PM, (Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/Job

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Paul Vriens
On 07/22/2010 02:55 PM, Alexandre Julliard wrote: Paul Vriens writes: On 07/22/2010 02:03 PM, Andrew Nguyen wrote: There are a few things I'm wondering about: When the winetest shlwapi binary was built, what made the compiler decide to import shell32 for the problematic string func

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Paul Vriens
On 07/22/2010 02:36 PM, Andrew Nguyen wrote: On 07/22/2010 07:21 AM, Paul Vriens wrote: On 07/22/2010 02:03 PM, Andrew Nguyen wrote: There are a few things I'm wondering about: When the winetest shlwapi binary was built, what made the compiler decide to import shell32 for the proble

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Paul Vriens
On 07/22/2010 02:03 PM, Andrew Nguyen wrote: There are a few things I'm wondering about: When the winetest shlwapi binary was built, what made the compiler decide to import shell32 for the problematic string functions? Neither my local cross-compile build nor the build that the test bot perform

Re: [6/6] shlwapi/tests: Correct the prototype of the StrRetToBSTR function pointer.

2010-07-22 Thread Paul Vriens
On 07/22/2010 12:31 PM, Andrew Nguyen wrote: On 07/22/2010 04:32 AM, Paul Vriens wrote: On 07/20/2010 06:14 AM, Andrew Nguyen wrote: --- dlls/shlwapi/tests/string.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) This patchset introduces crashes in these tests on W2K, XP and W2K3

  1   2   3   4   5   6   7   8   9   10   >