On Tue, 2013-10-01 at 09:32 -0300, Bruno Jesus wrote:
> On Tue, Oct 1, 2013 at 6:37 AM, Hans Leidekker wrote:
> > ---
> > dlls/ws2_32/socket.c | 9 +
> > dlls/ws2_32/tests/sock.c | 6 +++---
> > 2 files changed, 4 insertions(+), 11 deletions(-)
>
On Thu, 2013-09-19 at 17:38 +0200, Jacek Caban wrote:
> I was hoping for a test like the attached one, which shows that there is
> still more work to do. But it's a step in the right direction, so I'm
> fine with your patch.
The issue here is that HTTP_ReceiveRequestData calls refill_read_buffer,
On Wed, 2013-09-11 at 17:53 +0200, Jacek Caban wrote:
> > Network traces tell me that native also performs a read on the first call to
> > InternetQueryDataAvailable.
>
> Are you sure it's not an asynchronous read from a separated thread that
> is ordered by InternetQueryDataAvailable if no data is
On Wed, 2013-09-11 at 16:38 +0200, Jacek Caban wrote:
> Hi Hans,
>
> On 09/11/13 13:50, Hans Leidekker wrote:
> > static DWORD chunked_get_avail_data(data_stream_t *stream, http_request_t
> > *req)
> > {
> > -/* Allow reading only from read bu
On Wed, 2013-09-04 at 18:16 +0200, Jacek Caban wrote:
> On 09/04/13 15:36, Hans Leidekker wrote:
> > On Wed, 2013-09-04 at 15:28 +0200, Jacek Caban wrote:
> >> On 09/04/13 15:01, Hans Leidekker wrote:
> >>> + /* don't allow this connection to be reused
On Wed, 2013-09-04 at 15:28 +0200, Jacek Caban wrote:
> On 09/04/13 15:01, Hans Leidekker wrote:
> > ---
> > dlls/rpcrt4/rpc_transport.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c
On Wed, 2013-09-04 at 13:11 +0200, Jacek Caban wrote:
> On 09/04/13 09:22, Hans Leidekker wrote:
> > ---
> > dlls/wininet/http.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c
> >
On Wed, 2013-08-28 at 14:49 +0200, Ralf Habacker wrote:
> >> diff --git a/dlls/iphlpapi/ipstats.h b/dlls/iphlpapi/ipstats.h
> >> index bf5bb92..efdb1cc 100644
> >> --- a/dlls/iphlpapi/ipstats.h
> >> +++ b/dlls/iphlpapi/ipstats.h
> >> @@ -33,6 +33,7 @@
> >> DWORD getInterfaceStatsByName(const char
On Wed, 2013-08-28 at 12:21 +0200, Ralf Habacker wrote:
> diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec
> index 36ba13f..1eed5ae 100644
> --- a/dlls/iphlpapi/iphlpapi.spec
> +++ b/dlls/iphlpapi/iphlpapi.spec
> @@ -6,6 +6,7 @@
> @ stdcall AllocateAndGetIpForwardTableFromSta
On Wed, 2013-08-28 at 11:41 +0200, Ralf Habacker wrote:
> diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec
> index 36ba13f..cad2ca9 100644
> --- a/dlls/iphlpapi/iphlpapi.spec
> +++ b/dlls/iphlpapi/iphlpapi.spec
> @@ -6,6 +6,7 @@
> @ stdcall AllocateAndGetIpForwardTableFromSta
On Sat, 2013-08-10 at 15:55 +0800, Jing Li wrote:
> Hi,
> When I ran a simple win32 program just via WMI with query of "SELECT *
> from Win32_Directory", wine1.6 crashed. And when I checked the related code
> I found that the function of "static UINT seed_dirs( struct dirstack
> *dirstack, const
On Tue, 2013-07-02 at 20:34 +0900, Rosen Diankov wrote:
> you are right again, i'll be more careful. now, i've addressed every
> problem except creating the patches with git. any help would be
> appreciated.
See http://wiki.winehq.org/GitWine
> --- wine-1.6-rc4-old/dlls/wbemprox/builtin.c2013
On Mon, 2013-07-01 at 18:08 +0900, Rosen Diankov wrote:
> you are right, i'm attaching a new patch.
You didn't address all comments.
On Mon, 2013-07-01 at 08:56 +0900, Rosen Diankov wrote:
> diff -ru wine-1.6-rc3-old/dlls/wbemprox/builtin.c
> wine-1.6-rc3/dlls/wbemprox/builtin.c
> --- wine-1.6-rc3-old/dlls/wbemprox/builtin.c2013-06-22 03:24:01.0
> +0900
> +++ wine-1.6-rc3/dlls/wbemprox/builtin.c2013-06-27
On Mon, 2013-06-24 at 19:57 +0900, 中川祥 wrote:
> diff --git a/dlls/winhttp/session.c b/dlls/winhttp/session.c
> index 660eae5..dfe23d4 100644
> --- a/dlls/winhttp/session.c
> +++ b/dlls/winhttp/session.c
> @@ -1316,6 +1316,8 @@ BOOL WINAPI WinHttpDetectAutoProxyConfigUrl( DWORD
> flags, LPWSTR *url
On Sun, 2013-06-23 at 18:55 +0200, Sylvain Petreolle wrote:
> +static WCHAR *get_localdatetime(void)
> +{
> +static const WCHAR fmtW[] =
> +
> {'%','0','4','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u','%','0','2','u',
> + '.','%','0','6','u','+','0','0','0
On Sat, 2013-06-22 at 12:17 +0900, Kim Jung Eon (김중언) wrote:
> static const struct column col_bios[] =
> {
> +{ prop_biosversionW, CIM_STRING|CIM_FLAG_ARRAY},
> { prop_descriptionW, CIM_STRING },
> { prop_manufacturerW, CIM_STRING },
> { prop_releasedateW, CIM_DATETIME },
>
On Tue, 2013-06-04 at 10:16 +0200, Marcus Meissner wrote:
> 1020943 Uninitialized scalar variable
>
> After suggestion by Hans, do it in the helper ... especially
> as the other external callers do not initialize schemes either.
I also said that you shouldn't touch the parameter on error :) The
On Tue, 2013-06-04 at 01:36 +0200, Marti Maria wrote:
> > (specifically cmsReadRawTag and cmsWriteRawTag don't do what we want),
>
> Ops, so I did something wrong. These functions were in the API to
> implement mscms
> and JDK APIs. Could you please elaborate what the issue is?
They don't allow
On Tue, 2013-06-04 at 00:48 +0200, Detlef Riekenberg wrote:
> Hans, you found a way to change Wine to use getter/setter functions
> while still linking to lcms v1 and than switch to lcms2?
No, I'm not interested in doing that.
On Sun, 2013-06-02 at 22:49 +0200, Detlef Riekenberg wrote:
> try2:
> import the unchanged icc34.h from the lcms (v1) dev. package.
> (Do we need to add a Wine LGPL licence header for icc34.h?)
>
> The plan is to remove this include, when changing Wine
> to use the new getter/setter functions of l
On Fri, 2013-05-31 at 03:30 +0800, Qian Hong wrote:
> On Tue, May 28, 2013 at 6:42 PM, Hans Leidekker wrote:
> > +hr = SHGetKnownFolderPath( &FOLDERID_Desktop, 0, NULL, &desktop_folder
> > );
> > +if (FAILED( hr ))
> > +{
> > +WINE
On Tue, 2013-05-28 at 22:46 +0200, Marcus Meissner wrote:
> 1020943 Uninitialized scalar variable
>
> schemes is |= in the called function, but not
> initialized before.
>
> Was submitted 2 weeks ago already, I think it is good.
It's good but query_auth_schemes is called from more places, so
i
On Fri, 2013-05-10 at 20:07 -0600, Erich E. Hoover wrote:
> +/***
> + * IPHLPAPI_createmonitorhandle (INTERNAL)
> + *
> + * Routine to create the interface monitoring handle for NotifyAddrChange
> requests.
> + */
>
On Fri, 2013-05-10 at 08:00 -0600, Erich E. Hoover wrote:
> On Fri, May 10, 2013 at 3:48 AM, Hans Leidekker wrote:
> >
> > On Wed, 2013-05-08 at 15:34 -0600, Erich E. Hoover wrote:
> > > ...
> > > +#ifdef NLMSG_OK
> > > +# define WINE_LINKMON
On Wed, 2013-05-08 at 15:34 -0600, Erich E. Hoover wrote:
> +#ifdef HAVE_LINUX_NETLINK_H
> +# include
> +#endif
> +#ifdef HAVE_LINUX_RTNETLINK_H
> +# include
> +#endif
> +
> +#ifdef NLMSG_OK
> +# define WINE_LINKMON_FAMILY PF_NETLINK
> +# define WINE_LINKMON_TYPE SOCK_RAW
> +# d
On Fri, 2013-05-10 at 02:05 +0200, Detlef Riekenberg wrote:
> > For most apps it will be a matter of adding a configure check for lcms2
> > and then recompiling. This is not the case for Wine as you have pointed out.
> - cmsCreateLabProfile was renamed to cmsCreateLab2Profile
> cmsvirt.c (1.19:
On Thu, 2013-05-09 at 18:56 +0200, wine@web.de wrote:
> Hi Hans.
>
> >> lcms2 was released on 8. May 2010
> >> lcms v1 is on the way to be phased out in the newest
> >> distribution versions.
>
> >Are there any distributions that have released without v1?
>
> I don't know, but Ubuntu has a
On Tue, 2013-05-07 at 22:45 +0200, Detlef Riekenberg wrote:
> lcms2 was released on 8. May 2010 and should be present in important
> distributions since a while.
>
> lcms v1 is on the way to be phased out in the newest distribution
> versions.
Are there any distributions that have released withou
On Tue, 2013-05-07 at 10:04 -0600, Erich E. Hoover wrote:
> On Tue, May 7, 2013 at 3:14 AM, Hans Leidekker wrote:
> > ...
> > TerminateThread is not the right tool here. If the thread is blocked on the
> > recv call while being terminated it will leak the netlink socket.
>
On Mon, 2013-05-06 at 19:23 -0600, Erich E. Hoover wrote:
> --- a/dlls/iphlpapi/iphlpapi_main.c
> +++ b/dlls/iphlpapi/iphlpapi_main.c
> @@ -210,8 +210,14 @@ DWORD WINAPI
> AllocateAndGetIpAddrTableFromStack(PMIB_IPADDRTABLE *ppIpAddrTable,
> */
> BOOL WINAPI CancelIPChangeNotify(LPOVERLAPPED ov
On Wed, 2013-05-01 at 12:40 +0200, Christian Costa wrote:
> diff --git a/dlls/msi/media.c b/dlls/msi/media.c
> index 612624d..4145c76 100644
> --- a/dlls/msi/media.c
> +++ b/dlls/msi/media.c
> @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet(FDINOTIFICATIONTYPE
> fdint,
>
> if (strc
On Mon, 2013-04-08 at 01:56 +0900, Kim Jung Eon (김중언) wrote:
> @@ -241,18 +243,21 @@ static const struct column col_compsys[] =
> { prop_modelW,CIM_STRING },
> { prop_numlogicalprocessorsW, CIM_UINT32, VT_I4 },
> { prop_numprocessorsW,CIM_UINT32, VT_I4 },
> -
On Thu, 2013-02-21 at 18:47 +1100, Alistair Leslie-Hughes wrote:
> +#include "wine/debug.h"
> +
> +WINE_DEFAULT_DEBUG_CHANNEL(wincodecs);
That channel is already taken :)
On Wed, 2013-02-06 at 18:10 +0100, Ludger Sprenker wrote:
> On Wed, 06 Feb 2013 13:51:32 +0100, Hans Leidekker wrote:
>
> > + handle = CreateFileW(filename, GENERIC_READ, 0, NULL,
>
> > OPEN_EXISTING, 0, NULL);
>
> > + if (handle == INVALID_HANDLE_VALUE) re
On Wed, 2013-02-06 at 10:25 -0600, Vincent Povirk wrote:
> > +hr = map_file(file, &map, &mem, &size);
> > +if (FAILED(hr)) return hr;
> > +
> ...
> > +
> > +hr = IWICStreamImpl_InitializeFromMemory(stream, mem, size.u.LowPart);
> > +if (FAILED(hr)) goto error;
>
> This makes me sad
On Thu, 2013-01-31 at 19:35 +1100, Alistair Leslie-Hughes wrote:
> diff --git a/dlls/fusion/asmname.c b/dlls/fusion/asmname.c
> index 162a76b..2c4b379 100644
> --- a/dlls/fusion/asmname.c
> +++ b/dlls/fusion/asmname.c
> @@ -561,6 +561,10 @@ static HRESULT parse_pubkey(IAssemblyNameImpl *name,
> LP
On Wed, 2013-01-30 at 18:52 +0800, Dmitry Timoshkov wrote:
> > The test added by 6395af1ae7b0cc5f2f1f82796502e2a605bc5a6b says otherwise,
> > GetThumbnail
> > is supported for ICO frames.
>
> It's still better to return WINCODEC_ERR_CODECNOTHUMBNAIL instead of
> E_INVALIDARG. Real implementation
On Wed, 2013-01-30 at 18:02 +0800, Dmitry Timoshkov wrote:
> diff --git a/dlls/windowscodecs/icoformat.c b/dlls/windowscodecs/icoformat.c
> index 7aec245..da5a733 100644
> --- a/dlls/windowscodecs/icoformat.c
> +++ b/dlls/windowscodecs/icoformat.c
> @@ -200,8 +200,12 @@ static HRESULT WINAPI
> Ico
On Tue, 2013-01-22 at 16:49 +0100, Jacek Caban wrote:
> @@ -1460,6 +1460,13 @@ int netconn_get_cipher_strength( netconn_t *conn )
> pSSL_CIPHER_get_bits( cipher, &bits );
> return bits;
> #else
> -return 0;
> +SecPkgContext_ConnectionInfo conn_info;
> +SECURITY_STATUS res;
>
On Wed, 2012-12-19 at 12:25 +0100, Marvin wrote:
> Hi,
>
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> http://te
On Tue, 2012-12-11 at 12:59 -0800, Juan Lang wrote:
> Getting the client to trust the server cert can be as easy as ignoring
> untrusted
> root errors, if you don't think this impacts the revocation results.
>
> Returning revocation is straightforward enough, assuming you have a server
> under
>
On Tue, 2012-12-11 at 11:52 -0800, Juan Lang wrote:
> On Tue, Dec 11, 2012 at 6:10 AM, Hans Leidekker wrote:
> On Tue, 2012-12-11 at 14:52 +0100, Jacek Caban wrote:
> > On 12/11/12 09:45, Hans Leidekker wrote:
> > > https://testbot.winehq.org/JobDeta
On Tue, 2012-12-11 at 14:52 +0100, Jacek Caban wrote:
> On 12/11/12 09:45, Hans Leidekker wrote:
> > https://testbot.winehq.org/JobDetails.pl?Key=23300 is a test which shows
> > that
> > revocation checks fail for the certificate on outlook.com when passed
On Sat, 2012-12-08 at 21:59 +, Andrew Talbot wrote:
> diff --git a/dlls/msi/action.c b/dlls/msi/action.c
> index 076d1b3..677a43f 100644
> --- a/dlls/msi/action.c
> +++ b/dlls/msi/action.c
> @@ -6763,7 +6763,7 @@ static UINT ACTION_RemoveODBC( MSIPACKAGE *package )
> #define ENV_MOD_PREFIX
On Thu, 2012-12-06 at 12:56 +0100, André Hentschel wrote:
> diff --git a/dlls/schannel/tests/main.c b/dlls/schannel/tests/main.c
> index b576848..9c28e8b 100644
> --- a/dlls/schannel/tests/main.c
> +++ b/dlls/schannel/tests/main.c
> @@ -179,8 +179,8 @@ static void testGetInfo(void)
> /* First
On Fri, 2012-11-16 at 11:50 +0100, Frédéric Delanoy wrote:
> diff --git a/dlls/msi/files.c b/dlls/msi/files.c
> index 11913ef..98d7513 100644
> --- a/dlls/msi/files.c
> +++ b/dlls/msi/files.c
> @@ -336,6 +336,7 @@ UINT ACTION_InstallFiles(MSIPACKAGE *package)
> if (rc != ERROR_SUCCESS)
>
On Thu, 2012-11-15 at 09:41 +0100, Stefan Leichter wrote:
> i have to say sorry, this answer is rude.
>
> But i don't like to do unnecessary iteration on source code especially when
> the "complain" has been in the previous version too. Source code usually does
> not get better from iteration to
On Wed, 2012-11-14 at 16:28 +0100, Stefan Leichter wrote:
> @@ -2053,6 +2053,8 @@ static BOOL cred_decode( const WCHAR *cred, unsigned
> int len, char *buf )
> char c0, c1, c2, c3;
> const WCHAR *p = cred;
>
> +TRACE("%s\n", debugstr_wn(cred,len));
This string is already traced i
On Wed, 2012-11-14 at 09:48 +0100, Stefan Leichter wrote:
> +char buffer[6];
> +unsigned int buflen, *size = (unsigned int*) buffer;
>
> -if (len < 9 || !cred_decode( cred + 3, 6, (char *)&size ) || !size
> || size % sizeof(WCHAR))
> +if (len < 9 || !cred_decode(
On Mon, 2012-11-12 at 21:16 +0100, Alexandre Julliard wrote:
> > Fixes a crash in the .NET 4 runtime which queries this value via
> > SystemParametersInfo(SPI_GETFONTSMOOTHINGCONTRAST).
>
> It shouldn't need the registry key to behave sanely. Does b5d96da32f
> help?
Yes.
On Thu, 2012-11-08 at 01:32 +0100, Frédéric Delanoy wrote:
> diff --git a/dlls/msi/action.c b/dlls/msi/action.c
> index f9ab550..8a6c952 100644
> --- a/dlls/msi/action.c
> +++ b/dlls/msi/action.c
> @@ -5809,7 +5809,16 @@ static UINT ITERATE_InstallService(MSIRECORD *rec,
> LPVOID param)
> {
>
On Thu, 2012-11-01 at 14:52 +0100, Marvin wrote:
> While running your changed tests on Windows, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> Full results can be found at
> http://testbot.win
On Tue, 2012-10-30 at 09:50 +0100, Christian Costa wrote:
> Just by curiosity. What the difference with strncmpW?
strncmp tests the first string for null termination. You should really
determine that by yourself though :-)
> >> Do you have a concrete example that does not work with this implement
On Tue, 2012-10-30 at 08:42 +0100, Christian Costa wrote:
> > This is almost the same as your first try. You're testing a trivial
> > case only - ASCII range.
> > I feel like it should behave more like memcmp for case insensitive
> > comparison,
> > that's what documentation mildly suggests.
> >
On Sat, 2012-10-20 at 18:18 +0200, Patrick Rudolph wrote:
> >> The code was copied from ntdll and modified in order to retrieve
> >> processorname and vendorID. There's no similiár functionality in
> >> wine.
> >
> > There is such functionality in WBEM (formerly known as WMI). I think
> > you're l
On Sat, 2012-10-20 at 16:04 +0200, Patrick Rudolph wrote:
> Am 2012-10-20 14:54, schrieb Eric Pouech:
> > Le 20/10/2012 12:42, Patrick Rudolph a écrit :
> >> This patch need lots of testing, since I can only test it on linux
> >> using an Intel CPU.
> >> Please tests on other OS and systems, too.
On Tue, 2012-10-09 at 20:30 +0200, Daniel Jelinski wrote:
> diff --git a/dlls/wbemprox/table.c b/dlls/wbemprox/table.c
> index c414aa9..71c62c8 100644
> --- a/dlls/wbemprox/table.c
> +++ b/dlls/wbemprox/table.c
> @@ -63,6 +63,7 @@ UINT get_type_size( CIMTYPE type )
> return sizeof(INT64);
On Thu, 2012-09-27 at 23:07 +0200, Christian Costa wrote:
> >> if (!(cabinet_file = get_cabinet_filename(mi)))
> > The requirement that the continuous cabinet name matches the next cabinet
> > in the media table
> > might simply be too strict. Perhaps we need to try them one by one and let
On Thu, 2012-09-27 at 09:59 +0200, Christian Costa wrote:
> diff --git a/dlls/msi/media.c b/dlls/msi/media.c
> index 612624d..8a39fcd 100644
> --- a/dlls/msi/media.c
> +++ b/dlls/msi/media.c
> @@ -358,8 +358,18 @@ static INT_PTR cabinet_next_cabinet(FDINOTIFICATIONTYPE
> fdint,
>
> if (str
On Thu, 2012-07-19 at 07:27 +, Heiko Hund wrote:
> The strings shouldn't be const according to the docs at [1] and
> declaring them as LPWSTR removes some false warnings when
> compiling code GlobalFree()ing them with mingw.
Please also remove unnecessary casts from Wine.
On Wed, 2012-07-11 at 15:03 +, Oleg Jakobsen wrote:
> @@ -203,6 +203,7 @@ BOOL decode_streamname(LPCWSTR in, LPWSTR out)
> *out++ = mime2utf(ch&0x3f);
> count++;
> ch = mime2utf((ch>>6)&0x3f);
> + continue;
>
On Thu, 2012-06-28 at 22:22 +0300, John Yani wrote:
> On 28 June 2012 22:17, Hans Leidekker wrote:
> > On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote:
> > That's better. Does NFS actually query the Caption and Description
> > properties?
> >
> >
> W
On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote:
> +static void fill_logicaldisk( struct table *table )
> +{
> +static const WCHAR caption[] =
> +{'C',':',0};
> +static const WCHAR description[] =
> +{'L','o','c','a','l',' ','F','i','x','e','d',' ','D','i','s','k',0};
> +
On Wed, 2012-06-27 at 14:41 +0300, John Yani wrote:
> +static void fill_logicaldisk( struct table *table )
> +{
> +static const WCHAR device_id[] = {'0',0};
> +struct record_logicaldisk *rec;
> +FIXME("returns a fake logical disks table\n");
> +if (!(table->data = heap_alloc( sizeof
On Wed, 2012-06-27 at 11:34 +0300, John Yani wrote:
> +static void fill_logicaldisk( struct table *table )
> +{
> +static const WCHAR fmtW[] = {'%','u',0};
> +WCHAR device_id[11];
> +struct record_logicaldisk *rec;
> +UINT num_rows = 1;
> +FIXME("returns a fake logical disks tab
On Thu, 2012-06-21 at 09:57 -0600, Erich E. Hoover wrote:
> On Thu, Jun 21, 2012 at 4:28 AM, Hans Leidekker wrote:
> > ...
> >
> > This is not an atomic operation since you need two Unix calls. So you would
> > need locking or rollback to deal with possible races.
>
On Wed, 2012-06-20 at 17:26 -0600, Erich E. Hoover wrote:
> +TRACE("Linking %s to %s\n", unix_src.Buffer, unix_dest.Buffer);
> +if (rmdir( unix_src.Buffer ) < 0)
> +{
> +status = FILE_GetNtStatus();
> +goto cleanup;
> +}
> +if (symlink( unix_dest.Buffer, unix_src
On Thu, 2012-06-21 at 16:03 +0900, Dmitry Timoshkov wrote:
> > Shall I file a bug report?
>
> Try to add a test case to dlls/kenel32/tests/file.c,test_file_sharing().
>
> > HANDLE h2 = CreateFileA(filename, GENERIC_READ, FILE_SHARE_DELETE |
> > FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0);
> >
On Wed, 2012-06-20 at 12:13 +0200, robert.van.h...@serioustoys.com wrote:
> IStream is not exposed to the user, but an internal interface would
> probably end up looking a lot like IStream because we need read/write/seek
> operations, reference counting and the ability to create clones. So we
> mig
On Tue, 2012-06-19 at 21:45 +0200, robert.van.h...@serioustoys.com wrote:
> > We don't have to call SHCreateStreamOnFileEx, we can add a suitable
> > implementation to msi.
>
> Ah, I see.
>
> I guess this stream cannot escape from MSI. The only way it can be accessed is
> through MsiRecordReadSt
On Tue, 2012-06-19 at 20:55 +0200, robert.van.h...@serioustoys.com wrote:
> > Yes, the concern is that the file could be changed or removed. We should
> > test what native does here but it probably means that we need to create a
> > stream
> > on the file with a sharing mode that denies writing.
>
On Tue, 2012-06-19 at 12:36 +0200, robert.van.h...@serioustoys.com wrote:
> I altered my local source tree, such that it opens the file exclusively as a
> stream. That seems to work.
>
> Having that fixed, at least provisionally, I am now facing another issue: my
> MSIs
> are most of the time ver
On Mon, 2012-06-18 at 14:14 +0200, robert.van.h...@serioustoys.com wrote:
> But then I was thinking: this seems like such an obvious thing to do, that it
> is
> almost suspicious. Was there any reason for copying the file contents to main
> memory and then create a memory stream?
>
> For instance
On Tue, 2012-06-05 at 20:35 +0200, Alexandre Julliard wrote:
> Hans Leidekker writes:
>
> > ---
> > dlls/msi/action.c| 30 +++---
> > dlls/msi/msi_main.c |1 +
> > dlls/msi/msipriv.h |1 +
> > dlls/msi/package.c |
On Fri, 2012-03-30 at 17:27 -0700, Austin English wrote:
> +case MSIRUNMODE_REBOOTNOW:
> +r = package->need_reboot;
> +break;
> +
MSIRUNMODE_REBOOTNOW and MSIRUNMODE_REBOOTATEND are not the same thing.
On Thu, 2012-03-29 at 18:29 +0200, Robert van Herk wrote:
> + mapping = CreateFileMappingW( handle, NULL, PAGE_READONLY, 0, 0, NULL
> );
> + if (mapping)
> + {
> + p = MapViewOfFile( mapping, FILE_MAP_READ, 0, 0, length );
> + if (p)
> + {
> +
On Mon, 2012-03-26 at 11:14 +0200, Andoni Morales wrote:
> -case MSIMODIFY_REPLACE:
> case MSIMODIFY_MERGE:
> + /* check for a duplicated key */
> + r = msi_table_find_row( tv, rec, &row, column );
> + if (r == ERROR_SUCCESS) {
> +/* check that both are identical */
On Fri, 2012-03-09 at 19:54 +1100, Alistair Leslie-Hughes wrote:
> @@ -755,7 +755,7 @@ SC_HANDLE WINAPI OpenSCManagerA( LPCSTR lpMachineName,
> LPCSTR lpDatabaseName,
> SC_HANDLE WINAPI OpenSCManagerW( LPCWSTR lpMachineName, LPCWSTR
> lpDatabaseName,
> DWORD dwD
Hi Ričardas,
> +key = 0xdeadbeef;
> +num_bytes = 0xdeadbeef;
> +olp = (WSAOVERLAPPED *)0xdeadbeef;
> +bret = GetQueuedCompletionStatus( io_port, &num_bytes, &key, &olp, 100 );
> +todo_wine ok( bret == FALSE && GetLastError() == ERROR_NETNAME_DELETED,
> "failed to get completio
> -static UINT HANDLE_CustomType50(MSIPACKAGE *package, LPCWSTR source,
> +static msi_custom_action_info *HANDLE_CustomType50(MSIPACKAGE *package,
> LPCWSTR source,
> LPCWSTR target, const INT type, LPCWSTR
> action)
> {
> WCHAR *exe, *arg;
> msi_custo
On Tue, 2011-10-11 at 13:20 +0200, Bernhard Loos wrote:
+static HRESULT get_action_info( msi_custom_action_info *info, INT *type,
+BSTR *source, BSTR *target, BSTR *name,
+IWineMsiRemotePackage **package )
{
-IClassFactory *cf = N
On Sun, 2011-09-18 at 16:05 +0200, Maarten Lankhorst wrote:
> I moved the windows 7 x64 vm with sp1 applied to the base pool now. This means
> that all submitted patches will be run on that vm as well. The original win7
> vm
> is still available under its own name. Since all tests pass on that acc
On Tue, 2011-09-20 at 10:51 +0200, Michael Stefaniuc wrote:
> Hans Leidekker wrote:
> > On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote:
> >> @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall,
> >> LPCSTR szFolder,
> >>
On Mon, 2011-09-19 at 21:24 +0200, Michael Stefaniuc wrote:
> @@ -489,7 +489,7 @@ UINT WINAPI MsiGetSourcePathA( MSIHANDLE hInstall, LPCSTR
> szFolder,
> awstring str;
> UINT r;
>
> -TRACE("%s %p %p\n", debugstr_a(szFolder), debugstr_a(szPathBuf),
> pcchPathBuf);
> +TRACE("%s
On Fri, 2011-08-26 at 09:32 +0200, Bernhard Loos wrote:
> On Fri, Aug 26, 2011 at 9:11 AM, Hans Leidekker wrote:
> > On Fri, 2011-08-26 at 04:58 +0200, Bernhard Loos wrote:
> >
> > - * Copyright 2007 Google (James Hawkins)
> > + * Copyright 2011 Bernhard Loos
>
On Fri, 2011-08-26 at 04:58 +0200, Bernhard Loos wrote:
- * Copyright 2007 Google (James Hawkins)
+ * Copyright 2011 Bernhard Loos
Please keep the original copyright information.
On Thu, 2011-08-25 at 07:38 -0500, Aric Stewart wrote:
> Yes, it depends on if it is a RTL or LTR string. That is correct.
What I meant is that it does not always match the right hand operand
in the test condition.
On Thu, 2011-08-25 at 07:15 -0500, Aric Stewart wrote:
> "should return piX=0 not 0"? seems like 0 == 0 to me. They are both
> int values...
That test doesn't look right:
winetest_ok(piX == offsets[iCP+1],
"ScriptCPtoX trailing: iCP=%d should return piX=%d not %d\n",
iCP, offsets[iCP
On Wed, 2011-08-24 at 15:11 +0200, Francois Gouget wrote:
> From my understanding, in this case using a simple skip() means that
> anyone running WineTest on Windows in a non-administrator account will
> get a test failure. Since we don't seem to have a policy mandating that
Quite the opposite
On Wed, 2011-08-24 at 03:26 -0500, Austin English wrote:
> Shouldn't that be a win_skip()? Wine always runs as administrator, and
> if the process is running as a limited user, something may be broken?
> Unless you're preparing for when wine supports non-admin mode.. :)
No, win_skip is for behavi
On Tue, 2011-08-09 at 19:31 +0200, André Hentschel wrote:
> diff --git a/dlls/wldap32/tests/parse.c b/dlls/wldap32/tests/parse.c
> index 4cf8564..ed37d88 100644
> --- a/dlls/wldap32/tests/parse.c
> +++ b/dlls/wldap32/tests/parse.c
> @@ -128,7 +128,11 @@ START_TEST (parse)
> LDAP *ld;
>
>
On Tue, 2011-08-09 at 19:17 +0200, André Hentschel wrote:
> diff --git a/dlls/wldap32/tests/parse.c b/dlls/wldap32/tests/parse.c
> index 4cf8564..faad474 100644
> --- a/dlls/wldap32/tests/parse.c
> +++ b/dlls/wldap32/tests/parse.c
> @@ -128,7 +128,11 @@ START_TEST (parse)
> LDAP *ld;
>
>
On Wed, 2011-08-03 at 13:01 +1000, Alistair Leslie-Hughes wrote:
-@ stub TraceMessage
-@ stub TraceMessageVa
+@ varargs TraceMessage(long long ptr long)
+@ stdcall TraceMessageVa(long long ptr long ptr)
These functions take a TRACEHANDLE as the first argument which is
an int64.
On Sat, 2011-07-23 at 16:01 +0200, Jacek Caban wrote:
> > +VariantInit( &body );
> > +V_VT( &body ) = VT_ERROR;
> > +hr = IWinHttpRequest_get_ResponseBody( req, &body );
> > +ok( hr == S_OK, "got %08x\n", hr );
> > +ok( V_VT( &body ) == (VT_ARRAY|VT_UI1), "got %08x\n", V_VT( &b
On Sat, 2011-07-23 at 09:57 +0200, Marvin wrote:
> === W2K8SE (32 bit winhttp) ===
> winhttp.c:926: Test failed: failed to receive response 12152
> winhttp.c:933: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 12019
> winhttp.c:937: Test failed: failed unexpectedly 12019
> winhttp.c:938: Tes
On Fri, 2011-07-22 at 16:16 +0200, Jacek Caban wrote:
> The caller is responsible for freeing the result, so it will destroy
> your internal data. I think you should create an array here and not use
> it to store the data internally.
How do you know that the caller is responsible for freeing this
On Fri, 2011-06-10 at 23:29 -0500, Vincent Povirk wrote:
> Well, I think you may be right that changing it to E_NOTIMPL at this
> point would break something and might be a bad idea. Sadly, Hans
> didn't say what the stub was originally for. Hopefully, we'll soon
> have a working implementation and
On Tue, 2011-05-31 at 06:32 -0500, Andrew Nguyen wrote:
> -DWORD sizeW = *lpSize * 2;
> +DWORD sizeW = 0;
> +
> +GetUserNameW( NULL, &sizeW );
Can we avoid the extra call?
> I didn't intend to scoop Dan's work, but I have a version of his fix,
> which is attached, with deeper tests w
On Mon, 2011-05-30 at 21:13 -0700, Dan Kegel wrote:
> @@ -91,7 +91,7 @@ GetUserNameW( LPWSTR lpszName, LPDWORD lpSize )
>
> if (len > *lpSize)
> {
> -SetLastError(ERROR_MORE_DATA);
> +SetLastError(ERROR_INSUFFICIENT_BUFFER);
GetUserNameA also needs to be fixed. It sets
1 - 100 of 596 matches
Mail list logo
