Re: [PATCH 1/1] include/basetsd.h: fix bad casting

2012-10-12 Thread Dmitry Timoshkov
Max TenEyck Woodbury wrote: > >> -#define IntToPtr(i) ((void *)(INT_PTR)((INT)i)) > >> -#define UIntToPtr(ui) ((void *)(UINT_PTR)((UINT)ui)) > >> -#define LongToPtr(l)((void *)(LONG_PTR)((LONG)l)) > >> -#define ULongToPtr(ul) ((void *)(ULONG_PTR)((ULONG)

Re: [PATCH 1/1] include/basetsd.h: fix bad casting

2012-10-12 Thread Max TenEyck Woodbury
On 10/12/2012 01:46 PM, Dmitry Timoshkov wrote: > Max TenEyck Woodbury wrote: > >> -#define IntToPtr(i) ((void *)(INT_PTR)((INT)i)) >> -#define UIntToPtr(ui) ((void *)(UINT_PTR)((UINT)ui)) >> -#define LongToPtr(l)((void *)(LONG_PTR)((LONG)l)) >> -#define ULongToP

Re: [PATCH 1/1] include/basetsd.h: fix bad casting

2012-10-12 Thread Dmitry Timoshkov
Max TenEyck Woodbury wrote: > -#define IntToPtr(i) ((void *)(INT_PTR)((INT)i)) > -#define UIntToPtr(ui) ((void *)(UINT_PTR)((UINT)ui)) > -#define LongToPtr(l)((void *)(LONG_PTR)((LONG)l)) > -#define ULongToPtr(ul) ((void *)(ULONG_PTR)((ULONG)ul)) > +#def

Re: [PATCH] regedit: err() on printing

2012-10-12 Thread Charles Davis
On Oct 12, 2012, at 6:12 AM, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > >> +ERR("printing is not yet implemented.\n"); > > Printing a FIXME seems more appropriate. Also, aren't programs supposed to use the prefixed calls (e.g. WINE_FIXME() instead of FIXME())? Chip

[PATCH 10/25] mciseq: Limit concurrency when starting to play.

2012-10-12 Thread Joerg-Cyril.Hoehle
Hi, Alexandre Julliard wrote: >If another thread can change dwStatus you need a critical >section or an interlocked function. >> So if AJ is still not satisfied with try 2, I'll change all reads of >> wmm->dwStatus within the player into InterlockedExchange. >> Yet I think that would be a superf

Re: [PATCH] regedit: err() on printing

2012-10-12 Thread Dmitry Timoshkov
Marcus Meissner wrote: > +ERR("printing is not yet implemented.\n"); Printing a FIXME seems more appropriate. -- Dmitry.

Re: [PATCH 4/6] include: Added definitions used by OpenFileById. (try 2)

2012-10-12 Thread Dmitry Timoshkov
"Vincas Miliūnas" wrote: > >> Unless you mind sharing why it is wrong, I will not be able to read your > >> mind. > > Just do your homework and have a look at other places that use > > DUMMYUNIONNAME. > > > Thanks for sharing knowledge with your attitude. You started working on a complex API se

Re: TestBot job 22150 results: [2/3] dwrite: Implement GetWeight() for IDWriteFont

2012-10-12 Thread Nikolay Sivov
This is caused by previously committed patches while testbot was resting, I'll fix these failures after today series gets in if it's okay.

Re: [PATCH 4/6] include: Added definitions used by OpenFileById. (try 2)

2012-10-12 Thread Vincas Miliūnas
On 10/11/2012 07:29 PM, Dmitry Timoshkov wrote: > "Vincas Miliūnas" wrote: > >> Unless you mind sharing why it is wrong, I will not be able to read your >> mind. > Just do your homework and have a look at other places that use DUMMYUNIONNAME. > Thanks for sharing knowledge with your attitude.

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.

2012-10-12 Thread Jacek Caban
On 10/11/12 19:12, Charles Davis wrote: > On Oct 11, 2012, at 4:16 AM, Jacek Caban wrote: >> This patch alone makes SunSpider 0.9 17x faster. > Seems to me that something is really wrong with our BSTR implementation if > replacing it with a home-grown implementation speeds this up by a factor of

Fwd: [1/3] scrrun: Implement IDictionary_Add and Count (try 2)

2012-10-12 Thread Per Johansson
On Fri, Oct 12, 2012 at 8:48 AM, Alistair Leslie-Hughes wrote: > I will have a look at some sort of hash table. > I'd use wine existing tree implementation, unless there's some specific reason to use a hash table. Hash tables are good in theory but with in practice trees are just as effective in

Re: [1/3] scrrun: Implement IDictionary_Add and Count (try 2)

2012-10-12 Thread Nikolay Sivov
On 10/12/2012 09:48, Alistair Leslie-Hughes wrote: On 9/10/2012 8:54 PM, Henri Verbeet wrote: On 9 October 2012 11:26, Alistair Leslie-Hughes wrote: Changelog: scrrun: Implement IDictionary_Add and Count Actually, does it ever make sense to use a linked list at all to implement a dicti