Re: Translation of the AppDB

2010-10-19 Thread James McKenzie
On 10/19/10 10:20 AM, Yaron Shahrabani wrote: On Tue, Oct 19, 2010 at 5:16 PM, Rosanne DiMesio mailto:dime...@earthlink.net>> wrote: On Tue, 19 Oct 2010 12:12:33 +0200 Yaron Shahrabani mailto:sh.ya...@gmail.com>> wrote: > I see but I had another idea in mind... > I was thi

Re: msxml3/domdoc: Partially implement ::setAttributeNode()

2010-10-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6343 Your paranoid android.

Re: windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle

2010-10-19 Thread James McKenzie
On 10/18/10 9:53 PM, Vitaliy Margolen wrote: On 10/18/2010 12:51 PM, Krzysztof Nowicki wrote: Where I come from copying structures directly is considered bad practice and it's safer to use memcpy. We had problems before with broken compilers that would try to do some black magic in such cases

Re: [3/6] msxml3/tests: internal schema doc storage tests (try 2)

2010-10-19 Thread Adam Martinson
On 10/19/2010 03:17 AM, Alexandre Julliard wrote: Adam Martinson writes: --- dlls/msxml3/tests/schema.c | 438 +--- 1 files changed, 334 insertions(+), 104 deletions(-) Please don't resend just a patch marked 3/6, resend a proper series nu

Re: [3/6] msxml3/tests: internal schema doc storage tests (try 2)

2010-10-19 Thread Adam Martinson
On 10/19/2010 11:32 AM, Alexandre Julliard wrote: Adam Martinson writes: OK, just for future reference or do you want me to resend this set? Please resend, it needs to go through testbot again. OK, resent, along with a few new ones.

Re: Translation of the AppDB

2010-10-19 Thread Yaron Shahrabani
On Tue, Oct 19, 2010 at 5:16 PM, Rosanne DiMesio wrote: > On Tue, 19 Oct 2010 12:12:33 +0200 > Yaron Shahrabani wrote: > > > I see but I had another idea in mind... > > I was thinking about having the possibility to rate and report but > without > > any way to comment, I mean that you cannot comm

Re: [3/6] msxml3/tests: internal schema doc storage tests (try 2)

2010-10-19 Thread Alexandre Julliard
Adam Martinson writes: > OK, just for future reference or do you want me to resend this set? Please resend, it needs to go through testbot again. -- Alexandre Julliard julli...@winehq.org

Re: [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in from_bmformat( BMFORMAT format )

2010-10-19 Thread Hans Leidekker
On Tue, 2010-10-19 at 17:35 +0200, Tomasz Michno wrote: > I thought that I only need to test function which I modified, so I > created tests in that way. Now I'm modifying them to use > TranslateBitmapBits. Should I resend the whole patch or only create > one new with only tests/transform.c? Plea

Re: [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in from_bmformat( BMFORMAT format )

2010-10-19 Thread Tomasz Michno
Hi, > That's not how it's done in Wine, you will need to go through the > API. In this case that means you need to define a bitmap in the > appropriate format, create a color transform and then call > TranslateBitmapBits. I thought that I only need to test function which I modified, so I created

Re: [1/2] windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle (try 2).

2010-10-19 Thread Alexandre Julliard
Krzysztof Nowicki writes: > I've decided to keep the optimisation in copy_pixels() that checks if the > source > and dest rectangles + strides matches and if yes, does a straight memcpy of > the > whole bitmap. Please do this as a separate patch. -- Alexandre Julliard julli...@winehq.org

Re: Translation of the AppDB

2010-10-19 Thread Rosanne DiMesio
On Tue, 19 Oct 2010 12:12:33 +0200 Yaron Shahrabani wrote: > I see but I had another idea in mind... > I was thinking about having the possibility to rate and report but without > any way to comment, I mean that you cannot comment in foreign languages but > you can vote and report (any operation

Re: Surprise surprise, "Tmax Window OS" was a complete hoax

2010-10-19 Thread James Mckenzie
Scott Ritchie wrote: > >About a year or so ago a Korean company called Tmax was claiming to have >developed a new operating system that was 100% fully Windows compatible. > They also claimed to have their own office suite, web browser, and >more, all developed with their own special Korean enginee

Re: About: d3dx9: Store transform matrix per-sprite.

2010-10-19 Thread Matteo Bruni
2010/10/19 Joris Huizer : > Hello, > > In this patch ID3DXSpriteImpl_Flush is adapted; the new loop being like: > >    int i, count, start; >    /*  ... */ >    for(start=0;startsprite_count;start+=count,count=0) { >        i=start; >        while(isprite_count && >              (count==0 || > Thi

About: d3dx9: Store transform matrix per-sprite.

2010-10-19 Thread Joris Huizer
Hello, In this patch ID3DXSpriteImpl_Flush is adapted; the new loop being like: int i, count, start; /* ... */ for(start=0;startsprite_count;start+=count,count=0) { i=start; while(isprite_count && (count==0 || This->sprites[i].texture==This->sprites[i-1

Re: [PATCH 3/3] jscript: Add index, input and lastIndex properties to regexp funtions results

2010-10-19 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6322 Your paranoid android.

Re: Reflection interfaces

2010-10-19 Thread Henri Verbeet
2010/10/18 Rico Schüller : > What's the preferred way to implement the different interfaces? > > 1. Implement a parser which parses the shader (RDEF, STAT), and implement 4 > independent interfaces (each in its own dll). Only reuse the parser. > 2. Like 1, but all 4 implementations have there own p

Re: Translation of the AppDB

2010-10-19 Thread Yaron Shahrabani
On Tue, Oct 19, 2010 at 12:40 AM, Austin English wrote: > On Sun, Oct 17, 2010 at 3:59 AM, Yaron Shahrabani > wrote: > > Is there any way to localize the AppDB? > > The Israeli community assumes that having a Hebrew system will make more > > users report issues. > > It seems unlikely. There are m

Re: [3/6] msxml3/tests: internal schema doc storage tests (try 2)

2010-10-19 Thread Alexandre Julliard
Adam Martinson writes: > --- > dlls/msxml3/tests/schema.c | 438 > +--- > 1 files changed, 334 insertions(+), 104 deletions(-) Please don't resend just a patch marked 3/6, resend a proper series numbered from 1 so that winetestbot can figure it out. --

Re: [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in from_bmformat( BMFORMAT format )

2010-10-19 Thread Hans Leidekker
On Mon, 2010-10-18 at 18:10 +0200, Tomasz Michno wrote: > +/* unfortunately GetProcAddress cannot return proper pointer to > from_bmformat() function, but for this function it's not a problem, > using copy from ../transform.c */ That's not how it's done in Wine, you will need to go through the AP