Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/auto_copyr_year into lp:widelands-website

2018-02-20 Thread kaputtnik
I have tested it a lot. Merged and deployed. -- https://code.launchpad.net/~widelands-dev/widelands-website/auto_copyr_year/+merge/337911 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.ne

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-documentation into lp:widelands

2018-02-21 Thread kaputtnik
I think this is good now. For the first time it is confusing that we have functions and the '<>' tags when switching between the pages. It's unclear where one has landet after clicking the link to attributes. Maybe write it in another way? Instead: attributes (string) – the attributes for the i

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/better_notification_mail into lp:widelands-website

2018-02-21 Thread kaputtnik
Merged and deployed -- https://code.launchpad.net/~widelands-dev/widelands-website/better_notification_mail/+merge/335028 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-documentation into lp:widelands

2018-02-22 Thread kaputtnik
Good work :-) The grouping into headers is nice. A user can find the things he needs much better. There is one exception though: The rt tags documentation contain too much headers, imho. E.g for there are headers 'Attributes', 'Padding', 'Background Color' and 'Global Formatting Controls'. Whi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-documentation into lp:widelands

2018-02-23 Thread kaputtnik
I think this is better :-) Maybe i have not explained enough about the code example for the attributes. The reason why i am so stubborn for a related code example is that it took me some time to fiddle out how to use them. E.g. it was unclear how to use values for an attribute. I would suggest

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/bug-1750102_map_admin_page into lp:widelands-website

2018-02-23 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/bug-1750102_map_admin_page into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1750102 in Widelands Website: "Allow map editing without world name&quo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-documentation into lp:widelands

2018-02-23 Thread kaputtnik
Changed the code example and the resulting image. I have tried also to explain in short what the '..' are used for. While a first reader may does not know what my explanation means exactly, one can search the web for the keyword. Feel free to rephrase :-) -- https://code.launchpad.net/~wideland

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-documentation into lp:widelands

2018-02-23 Thread kaputtnik
Ah forgotten: Not directly related to this branch but a question about the translation makro '_' and the use of brackets for strings instead of double quotation marks: Does the _ only work with '_[[some text]]' and not with _"some text"? The doc for _ (https://wl.widelands.org/docs/wl/autogen_g

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-documentation into lp:widelands

2018-02-24 Thread kaputtnik
Thanks for explanation. I have used now blue and white instead of red and completed the example. In r8443 i have changed both code examples accordingly. In r8444 i have removed the code example from wlrichtext and linked the example in richtext.lua. Feel free to revert this change, but one exam

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-documentation into lp:widelands

2018-02-24 Thread kaputtnik
Did now some proof reading, see inline comments. What i stumbled over is a mixed use of uppercase/lowercase after hyphen/colon. Eg. for the two text composition functions we have: In join_sentence() its lowercase: :arg sentence1: text of the first sentence In localize lists its uppercase: :arg

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fh1-documentation into lp:widelands

2018-02-24 Thread kaputtnik
Done. -- https://code.launchpad.net/~widelands-dev/widelands/fh1-documentation/+merge/337545 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fh1-documentation. ___ Mailing list: https://launchpad.net/~widelands-dev Po

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1738553-zip-filesystem-overflow into lp:widelands

2018-02-25 Thread kaputtnik
The newly attached save game "corrupt_wl_autosave.wgf" is already shown as incompatible in load/save dialogs in trunk (r8603) here on linux. This may fix the bug, but i think it is the wrong approach. If a player saves a game, he believes to have a valid save game to load it e.g. the next day. I

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1738553-zip-filesystem-overflow into lp:widelands

2018-02-25 Thread kaputtnik
> And unless you're using ASAN, this branch doesn't appear to change anything. Ok. Nevertheless i think it is solving a symptom, not the main bug. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1738553-zip-filesystem-overflow/+merge/339493 Your team Widelands Developers is requested t

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-pwd-security into lp:widelands

2018-03-04 Thread kaputtnik
I guess the password in this case is the password for Online gaming: https://wl.widelands.org/ggz/changepw which can be accessed through https://wl.widelands.org/profile/edit/ (the last link) The related model is in wlggz: https://bazaar.launchpad.net/~widelands-dev/widelands-website/trunk/view

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/scheduling_minor_fix into lp:widelands-website

2018-03-07 Thread kaputtnik
If i have time zone set to CET +1, shouldn't the displayed time zone be "UTC + 1"? This is not the case. It still says "You are currently noted as UTC". If i have set the users time zone to "-11" the error message says: "The time indicated by your browser (UTC + 1) is different from the one stor

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/wlhelp_internal_names into lp:widelands-website

2018-03-09 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/wlhelp_internal_names into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1753582 in Widelands Website: "Add the name attribute to the encyclopedia&quo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/scheduling_minor_fix into lp:widelands-website

2018-03-11 Thread kaputtnik
I just stumbled over the term 'Multiplayer' as the header for scheduling. What do you think about calling it 'Define your playtime'? -- https://code.launchpad.net/~widelands-dev/widelands-website/scheduling_minor_fix/+merge/341061 Your team Widelands Developers is requested to review the proposed

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/background_images into lp:widelands

2018-03-15 Thread kaputtnik
Review: Approve testing Let's do a try for other coloring in a different branch :-) I have tested this branch by playing a game, check editor and opened all dialogs. So i think this could be merged without a code review? -- https://code.launchpad.net/~widelands-dev/widelands/background_images/+

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/wlhelp_internal_names into lp:widelands-website

2018-03-18 Thread kaputtnik
Merged and deployed -- https://code.launchpad.net/~widelands-dev/widelands-website/wlhelp_internal_names/+merge/341265 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/wlhelp_internal_names into lp:widelands-website. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/bug-1723640_news_current_user into lp:widelands-website

2018-03-18 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/bug-1723640_news_current_user into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1723640 in Widelands Website: "Select the current user in users list when posting

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/bug-1723640_news_current_user into lp:widelands-website

2018-03-19 Thread kaputtnik
The proposal to merge lp:~widelands-dev/widelands-website/bug-1723640_news_current_user into lp:widelands-website has been updated. Description changed to: Use the current user as initial data for the author of a news post. The publish date is also initialized with datetime.now(). Adjusted the

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_encyclopedia into lp:widelands-website

2018-03-24 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/fix_encyclopedia into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #336021 in Widelands Website: "the online-help shoud be enhanced" https://bugs.launchpad.net

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove-external-websites into lp:widelands

2018-03-24 Thread kaputtnik
Is there a specific reason why the "https://"; is omitted? For me it looks strange without it. Otherwise LGTM :-) -- https://code.launchpad.net/~widelands-dev/widelands/remove-external-websites/+merge/342024 Your team Widelands Developers is requested to review the proposed merge of lp:~widelan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/bug-1723640_news_current_user into lp:widelands-website

2018-03-26 Thread kaputtnik
The commas are needed because that are tuples, not lists: >>> tpl = ('a') >>> type(tpl) >>> tpl = ('a',) >>> type(tpl) Of course: >>> tpl = ('a', 'b') >>> type(tpl) So for a tuple with more than one value the last comma could be omitted. To be clear i left them. See also: https://docs.dja

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_encyclopedia into lp:widelands-website

2018-03-26 Thread kaputtnik
Changed the term like you suggested, merged and deployed. Thanks for the review :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/fix_encyclopedia/+merge/342023 Your team Widelands Developers is subscribed to branch lp:widelands-website. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/changelog-2018-03 into lp:widelands

2018-03-27 Thread kaputtnik
LGTM, two small nits :-) Diff comments: > === modified file 'ChangeLog' > --- ChangeLog 2017-05-18 06:37:25 + > +++ ChangeLog 2018-03-27 07:37:29 + > @@ -48,48 +60,92 @@ >- Old scenario save games will no longer work due to changes to the map > scrolling functions. >- Savehan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/bug-1723640_news_current_user into lp:widelands-website

2018-03-27 Thread kaputtnik
I have removed some unneeded commas and deployed it. -- https://code.launchpad.net/~widelands-dev/widelands-website/bug-1723640_news_current_user/+merge/341582 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/bug-1723640_news_current_

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1760581-fix-UnicodeString into lp:widelands

2018-04-03 Thread kaputtnik
All fine. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug_1760581-fix-UnicodeString/+merge/342544 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug_1760581-fix-UnicodeString. ___ Mailing

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/allows_seafaring_performance into lp:widelands

2018-04-11 Thread kaputtnik
wow, finally i can play debug builds again without stuttering, even on big maps. Thanks :-) -- https://code.launchpad.net/~widelands-dev/widelands/allows_seafaring_performance/+merge/342987 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/allows_seafaring_perfor

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-15 Thread kaputtnik
Possible code reviews: Providing usernames for JS when writing PMs: This is maybe a security risk because a username can contain an at sign (@). The Django documentation says: "If additional escaping is not desired, you will need to use mark_safe() if you are absolutely sure that your code doe

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-15 Thread kaputtnik
Here instructions how to update (just in case i can't do that, and of course also as a reminder for myself ;) ): 1. activate the virtualenvironment 2. shut down the website (and activate the maintenance view) 3. make a backup of the database 4. run 'pip install -U pip setuptools' 5. merge this br

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-15 Thread kaputtnik
Thanks, SirVer. Nice to hear from you :-) I assume you logged in on the alpha site, and this worked so far? I will shut down alpha tomorrow, in the morning. -- https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065 Your team Widelands Developers is subscribed to bra

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-15 Thread kaputtnik
Forgotten to answer: > If they can contain other characters (."'/\) we will be vulnerable. This differs on the used python version. Django says: "A field validator allowing only ASCII letters and numbers, in addition to @, ., +, -, and _. The default validator for User.username on Python 2." S

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-15 Thread kaputtnik
The proposal to merge lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website has been updated. Description changed to: Major update of the website code to Django 1.11.12. I have gone through all release notes form Django 1.8 until Django 1.11. - Added migrations for wlscreens

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-18 Thread kaputtnik
Allowing ' needs implementing an own username validator. Can you give an example for real world name containing an apostrophe? What we should consider is to allow unicode characters in usernames, so french, or polish names can be used.See https://docs.djangoproject.com/en/1.11/ref/contrib/auth/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-18 Thread kaputtnik
Got the callback function to work. Will apply the latest change to the alpha site, so this can also be tested in production. Have to shut down and restart the alpha site again... -- https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065 Your team Widelands Develop

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-18 Thread kaputtnik
The proposal to merge lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website has been updated. Description changed to: Major update of the website code to Django 1.11.12. I have gone through all release notes form Django 1.8 until Django 1.11. - Added migrations for wlscreens

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-18 Thread kaputtnik
Review: Needs Fixing Regarding the screenshots: They old ones aren't physical there. I have tested it by adding two categories and uploaded two images to each categorie. The online_users_middleware does not work as i expected... Hitting 'log out' does not remove the user name from the list. Bu

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-19 Thread kaputtnik
As far as i can see the Email subjects are solved. I will announce the website downtime and schedule the update for the next week. @GunChleoc: Regarding your permissions: On alpha you are set as superuser, whereas on wl.widelands you are not a superuser. Thats the difference regarding the shown

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-20 Thread kaputtnik
> The scheduler is producing an error. I got the errors... My fault :-(. When switching the database i had forgotten to run the migrate command. Will try to give you moderator permissions this weekend. -- https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065 Your

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-21 Thread kaputtnik
alpha is shut down again. -- https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/net-user-type into lp:widelands

2018-04-23 Thread kaputtnik
The bot is maybe a holdover from the time ggz was used? http://www.ggzgamingzone.org -- https://code.launchpad.net/~widelands-dev/widelands/net-user-type/+merge/343754 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/net-user-type.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-25 Thread kaputtnik
The update is made on the productive website. I've encountered some problems in the database: When applying the migrations i got some foreign constraints error: django.db.utils.IntegrityError: (1452, 'Cannot add or update a child row: a foreign key constraint fails (`wl_django`.`#sql-2d6_4516`,

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-25 Thread kaputtnik
Oh, there are some warnings about unordered lists: UnorderedObjectListWarning: Pagination may yield inconsistent results with an unordered object_list: QuerySet. UnorderedObjectListWarning: Pagination may yield inconsistent results with an unordered object_list: QuerySet. UnorderedObjectList

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-26 Thread kaputtnik
I think it works in general ... the changes are committed now. I think it is better to have some fixes in a follow up branch. The last server errors were produced by check_input, and were not related to this branch. I will fix it soon. -- https://code.launchpad.net/~widelands-dev/widelands-web

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_check_input into lp:widelands-website

2018-04-26 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/fix_check_input into lp:widelands-website. Commit message: Respect max_length for field 'text' in model check_input Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.lau

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/scheduling_minor_fix into lp:widelands-website

2018-04-26 Thread kaputtnik
I have merged the latest changes. You should update your environment: bzr pull cp local_urls.py.sample local_urls.py pip install -U pip setuptools pip install -r pip_requirements.txt find . -name '*.pyc' -delete ./manage.py migrate If you are using a mysql database, you may need to edit local_set

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/django1_11 into lp:widelands-website

2018-04-27 Thread kaputtnik
The UnorderedObjectListWarning can be fixed by giving the models a default ordering. Not really complicated :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/django1_11/+merge/343065 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_check_input into lp:widelands-website

2018-04-27 Thread kaputtnik
Thanks for the quick review :-) Merged and deployed. -- https://code.launchpad.net/~widelands-dev/widelands-website/fix_check_input/+merge/344559 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://lau

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/scheduling_minor_fix into lp:widelands-website

2018-04-27 Thread kaputtnik
I think it works not correct, see my first post here. -- https://code.launchpad.net/~widelands-dev/widelands-website/scheduling_minor_fix/+merge/341061 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/scheduling_minor_fix into lp:wid

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1358880-ship-statistics into lp:widelands

2018-05-01 Thread kaputtnik
Finally we got this!!! Thanks GunChleoc :-) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1358880-ship-statistics/+merge/343293 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ships_optr. ___ Mailing lis

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_django1_11_warnings into lp:widelands-website

2018-05-02 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/fix_django1_11_warnings into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1767286 in Widelands Website: "Fix UnorderedObjectListWarning" https://bugs.lau

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_django1_11_warnings into lp:widelands-website

2018-05-03 Thread kaputtnik
Thanks :-) Merged and deployed. -- https://code.launchpad.net/~widelands-dev/widelands-website/fix_django1_11_warnings/+merge/344973 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~w

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_online_users into lp:widelands-website

2018-05-05 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/fix_online_users into lp:widelands-website. Commit message: Fix the last server error (meanwhile i should know that getting a dicts key should be done inside a try statement ;-) ) The fix for the linked bug is a bit complicated

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_online_users into lp:widelands-website

2018-05-06 Thread kaputtnik
This is merged in production, but not committed yet. Lets see if my conclusion was correct. For the server error related to the search, i am currently rebuilding the index, hoping this will help. -- https://code.launchpad.net/~widelands-dev/widelands-website/fix_online_users/+merge/345132 Your

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_online_users into lp:widelands-website

2018-05-07 Thread kaputtnik
Didn't saw you comment... This is also committed now. -- https://code.launchpad.net/~widelands-dev/widelands-website/fix_online_users/+merge/345132 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://l

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/add_lua_path into lp:widelands

2018-05-07 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands/add_lua_path into lp:widelands. Commit message: Add lua_path.cc to the documentation Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/add_lua_path

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/sphinx_remove_py_modindex into lp:widelands

2018-05-08 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands/sphinx_remove_py_modindex into lp:widelands. Commit message: Let sphinx create an index but not a module index. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/sphinx_remove_py_modindex into lp:widelands

2018-05-09 Thread kaputtnik
The difference is that on the website the json files are read and passed through the django template system. The used template for py-modindex is: https://bazaar.launchpad.net/~widelands-dev/widelands-website/trunk/view/head:/templates/sphinxdoc/py-modindex.html This template uses a hardcoded st

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/sphinx_remove_py_modindex into lp:widelands

2018-05-10 Thread kaputtnik
Review: Resubmit Ok -- https://code.launchpad.net/~widelands-dev/widelands/sphinx_remove_py_modindex/+merge/345261 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/sphinx_remove_py_modindex. ___ Mailing list: https://

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/sphinx_remove_py_modindex into lp:widelands

2018-05-10 Thread kaputtnik
Thanks :-) I had forgotten to change the commit message ... -- https://code.launchpad.net/~widelands-dev/widelands/sphinx_remove_py_modindex/+merge/345261 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/sphinx_remove_py_modindex. __

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/solitaire_html_documentation into lp:widelands-website

2018-05-12 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/solitaire_html_documentation into lp:widelands-website. Commit message: Serve sphinx documentation as html files; Removes sphinx-doc Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #893275 in

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/solitaire_html_documentation into lp:widelands-website

2018-05-12 Thread kaputtnik
The proposal to merge lp:~widelands-dev/widelands-website/solitaire_html_documentation into lp:widelands-website has been updated. Description changed to: Serve sphinx documentation as html files. This remove unmaintained sphinx-doc. But all features of the produced html could be used (e.g sea

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/solitaire_html_documentation into lp:widelands-website

2018-05-12 Thread kaputtnik
The proposal to merge lp:~widelands-dev/widelands-website/solitaire_html_documentation into lp:widelands-website has been updated. Description changed to: Serve sphinx documentation as html files. This remove unmaintained sphinx-doc. But all features of the produced html could be used (e.g sea

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/bug-1770881_fix_pagination_model_names into lp:widelands-website

2018-05-12 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/bug-1770881_fix_pagination_model_names into lp:widelands-website. Commit message: Fix pagination model names Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1770881 in Widelands Website

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/bug-1770881_fix_pagination_model_names into lp:widelands-website

2018-05-13 Thread kaputtnik
Thanks :-) Merged and deployed. -- https://code.launchpad.net/~widelands-dev/widelands-website/bug-1770881_fix_pagination_model_names/+merge/345465 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://l

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/solitaire_html_documentation into lp:widelands-website

2018-05-13 Thread kaputtnik
Ok, my approach will not work on the server. After some fiddling i will continue the work for this next week. Just if one want's to play around with the alpha site: Be aware that it is currently in a WIP-state. -- https://code.launchpad.net/~widelands-dev/widelands-website/solitaire_html_docume

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/solitaire_html_documentation into lp:widelands-website

2018-05-13 Thread kaputtnik
The alpha site is functional now and running. So one can test the look and feel of the documentation. The link shown in the users addressbar isn't that good now. May i have to adjust nginx for that. Also there is no favicon shown. In regard to bug 1758515 it has to be modified again. -- https:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/solitaire_html_documentation into lp:widelands-website

2018-05-15 Thread kaputtnik
The link shown in user browsers addressbar is also fixed now. I fixed it in the same manner as the links for 'media' and 'wlmedia'. Added a location block to the nginx file and made a symlink to 'wlmedia/documentation/html' I would be glad if some one can have a look at the documentation. In th

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/solitaire_html_documentation into lp:widelands-website

2018-05-15 Thread kaputtnik
Ah, forgotton: I have sometimes trouble to access the alpha site, because my browser opens wl.widelands.org instead. I have to clean the browsers cache to get into alpha... -- https://code.launchpad.net/~widelands-dev/widelands-website/solitaire_html_documentation/+merge/345460 Your team Widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/solitaire_html_documentation into lp:widelands-website

2018-05-23 Thread kaputtnik
Hmmm... currently i didn't get the cron job /etc/cron.hourly/update_widelands_bzr to work... Commenting all other rows (except the 'bzr pull' command) and applying the following do not work for some reason: # Some magic from: http://stackoverflow.com/a/29969243/200945. If we are # run as root (

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/solitaire_html_documentation into lp:widelands-website

2018-05-24 Thread kaputtnik
Just found that a redirect from docs/wl/ to documentation was missing. Will give it another try to get it into production next weekend (when i am not that tired from work ;) ) -- https://code.launchpad.net/~widelands-dev/widelands-website/solitaire_html_documentation/+merge/345460 Your team Wide

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1741779-map-description-edit-cutoff into lp:widelands

2018-05-26 Thread kaputtnik
Review: Approve testing The main bug is solved, IMHO. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1741779-map-description-edit-cutoff/+merge/345495 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1741779-map-description-edit-cutoff. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/solitaire_html_documentation into lp:widelands-website

2018-05-27 Thread kaputtnik
Ok, got it. The problem was that merging this branch the folder media/documentation/ was owned by me, so the script (which runs as user www-data) could not write into it. Fixed also another small issue. Merged and deployed. The django management command to update the documentation is now execu

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1776008-boost-deleted-uuid-function into lp:widelands

2018-06-11 Thread kaputtnik
Review: Approve testing Compiling works fine :-) (beside the known issues) Here are the values of your quick test: Old values: uuid="3436e035-dc2e-46b8-ac1f-7487343547e6" last_start="1528746135" After deleting last_start: uuid="a9f6baf2-04c9-4588-9bbd-7c42e83eb1e6" last_start="1528746335" Afte

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1776007_make_asan_explicit into lp:widelands

2018-06-12 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands/bug-1776007_make_asan_explicit into lp:widelands. Commit message: Make the use of ASAN optional in the compile.sh script Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1776007 in widelands: "Remove

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/changelog-networking into lp:widelands

2018-06-12 Thread kaputtnik
Not a code relevant change. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/changelog-networking/+merge/347830 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/changelog-networking into lp:widelands. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1776007_make_asan_explicit into lp:widelands

2018-06-12 Thread kaputtnik
Ok, will file a bug report for wl_map_object_info -- https://code.launchpad.net/~widelands-dev/widelands/bug-1776007_make_asan_explicit/+merge/347840 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1776007_make_asan_explicit into lp:wide

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1406298-campvis-file into lp:widelands

2018-06-25 Thread kaputtnik
You have to merge trunk into this branch, because trunk has fixed this error. See: https://wl.widelands.org/forum/topic/4217/?page=2#post-25160 -- https://code.launchpad.net/~widelands-dev/widelands/bug-1406298-campvis-file/+merge/346915 Your team Widelands Developers is subscribed to branch lp:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/congestion2 into lp:widelands

2018-06-26 Thread kaputtnik
Took the freedom and merged trunk into this branch. Otherwise i couldn't compile... -- https://code.launchpad.net/~widelands-dev/widelands/congestion2/+merge/348525 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/congestion2 into lp:widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1691339-editor-8-players into lp:widelands

2018-07-10 Thread kaputtnik
Here on linux it looks like https://bugs.launchpad.net/widelands/+bug/1691339/+attachment/5161992/+files/player_options.png The tribe selection looks also some kind of misplaced: https://bugs.launchpad.net/widelands/+bug/1691339/+attachment/5161993/+files/player_options-tribe.png While the trib

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1691339-editor-8-players into lp:widelands

2018-07-12 Thread kaputtnik
Works on linux as expected :-) Regarding Spinbox vs Dropdown: Maybe i am too konservative for such changes ;) The Tooltip for 'Number of Players' says 'Select Item'. Maybe change it to 'Choose amount of players'? 'Set number of players'? 'Number of players'? -- https://code.launchpad.net/~wide

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/editor_infotool_rendering into lp:widelands

2018-07-14 Thread kaputtnik
I did also a test, also with other windows using text formatting, all fine. Should the functions be documented (RST)? -- https://code.launchpad.net/~widelands-dev/widelands/editor_infotool_rendering/+merge/349093 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1736901-shift-market into lp:widelands

2018-07-16 Thread kaputtnik
Tested it for the homepage, all fine, the market does not show up anymore :-) Two tests about lua are failing with this branch: FAIL: test_get_buildings: [string "scripting/tribes_descriptions.lua"]:31: expected '52' but was '51'! stack traceback: [C]: in global 'error' [string "

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1782593-segfault-random-map into lp:widelands

2018-07-21 Thread kaputtnik
So bug 1580892 (Random Map Generator doesn't always find viable player starting positions) is also fixed with this branch? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1782593-segfault-random-map/+merge/350384 Your team Widelands Developers is requested to review the proposed merge

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1736901-shift-market into lp:widelands

2018-07-25 Thread kaputtnik
Review: Approve LGTM :-) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1736901-shift-market/+merge/349630 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1736901-shift-market. ___ Mailing list: https

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/rip_out_old_fontrenderer into lp:widelands

2018-07-26 Thread kaputtnik
Review: Approve testing Tested, found no issues :-) -- https://code.launchpad.net/~widelands-dev/widelands/rip_out_old_fontrenderer/+merge/350442 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/rip_out_old_fontrenderer.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1784151_fix_emp04_due_to_changed_program_names into lp:widelands

2018-07-30 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands/bug_1784151_fix_emp04_due_to_changed_program_names into lp:widelands. Commit message: Fixed program names for scenario emp04 Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1784151 in widelands: "

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1784151_fix_emp04_due_to_changed_program_names into lp:widelands

2018-07-31 Thread kaputtnik
Thanks for approval @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug_1784151_fix_emp04_due_to_changed_program_names/+merge/351830 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug_1784151_fix_emp04_due_to_changed_program_names.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1783878_editor_random_map_tribe into lp:widelands

2018-08-01 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands/bug-1783878_editor_random_map_tribe into lp:widelands. Commit message: Set random tribes when using the random map generator Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1783878 in widelands: "E

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1783878_editor_random_map_tribe into lp:widelands

2018-08-01 Thread kaputtnik
After sleeping a night i am not sure if this is the correct approach to fix the bug ... -- https://code.launchpad.net/~widelands-dev/widelands/bug-1783878_editor_random_map_tribe/+merge/352038 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1783878_editor_random_map_tribe into lp:widelands

2018-08-02 Thread kaputtnik
Since one could also choose "Random tribe" in the Game setup menu, regardless of the maps setting, i am thinking about this: Maybe we can have a special tribe called "Random Tribe". So a map designer can choose "Random tribe" beside the others in the editor player menu for a normal map. "Random

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1783878_editor_random_map_tribe into lp:widelands

2018-08-03 Thread kaputtnik
As ever: The idea might be good, but implementing is quite difficult. I think a special "Random Tribe" needs only the name, descname and an icon, nothing more. So i have tried to add a "Random Tribe" through lua, but it fails because the code for tribe initializing depends on so much other stuff

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1783878_editor_random_map_tribe into lp:widelands

2018-08-09 Thread kaputtnik
ypopecios, can you please make the needed changes? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1783878_editor_random_map_tribe/+merge/352038 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1783878_editor_random_map_tribe.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1783878_editor_random_map_tribe into lp:widelands

2018-08-11 Thread kaputtnik
Thanks GunChleoc. I'll delete this branch then. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1783878_editor_random_map_tribe/+merge/352038 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1783878_editor_random_map_tribe. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1776603_map_info_memory_leak into lp:widelands

2018-08-15 Thread kaputtnik
Review: Approve testing Tested it in my local website installation, no issues found :-) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1776603_map_info_memory_leak/+merge/353140 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1776603_map_info_me

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1639253-atlantean-smoker-leave-house-se into lp:widelands

2018-08-29 Thread kaputtnik
all fine. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1639253-atlantean-smoker-leave-house-se/+merge/353967 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1639253-atlantean-smoker-leave-house-se. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/gdpr_1 into lp:widelands-website

2018-09-05 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/gdpr_1 into lp:widelands-website. Commit message: Removed google analytics and PayPal, make some fields optional in the contact form. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1780536 in

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/gdpr_1 into lp:widelands-website

2018-09-09 Thread kaputtnik
I am thinking about giving SirVer some memorial, or other thing which notice him as the generous donor of the online-server. A way to say 'Thank you!' and also a hint for other users on widelands.org. Maybe a Link the footer, or a special header in the Developers page https://wl.widelands.org/d

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/gdpr_1 into lp:widelands-website

2018-09-09 Thread kaputtnik
Ok :-) Will it deploy this evening. -- https://code.launchpad.net/~widelands-dev/widelands-website/gdpr_1/+merge/354355 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev

<    5   6   7   8   9   10   11   12   13   >