Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_ui_bugs into lp:widelands

2017-09-11 Thread kaputtnik
Review: Approve testing For me all issues in the mentioned bugs are working again. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/fix_ui_bugs/+merge/330176 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix_ui_bugs. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/add_animation_option into lp:widelands

2017-09-11 Thread kaputtnik
Why not... @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/add_animation_option/+merge/330126 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/add_animation_option. ___ Mailing list: https://la

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_ui_bugs into lp:widelands

2017-09-11 Thread kaputtnik
Uos... just see this compiler warnings on trunk (which has this branch already in). I guess that those warnings are related to this branch: ../src/ui_basic/window.cc: In Elementfunktion »virtual bool UI::Window::handle_mousewheel(uint32_t, int32_t, int32_t)«: ../src/ui_basic/windo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/reduce_overlay_manager_use3 into lp:widelands

2017-09-12 Thread kaputtnik
Review: Approve testing Works when testing a release build :-) Did also ran all regression tests. -- https://code.launchpad.net/~widelands-dev/widelands/reduce_overlay_manager_use3/+merge/330496 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/reduce_overlay_ma

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/kill_overlay_manager into lp:widelands

2017-09-13 Thread kaputtnik
Review: Approve testing When compiling this branch: .../kill_overlay_manager/src/editor/tools/set_port_space_tool.cc:42: Trailing whitespace at end of line .../kill_overlay_manager/src/editor/tools/set_starting_pos_tool.cc:58: Trailing whitespace at end of line All is working imho. In Editor i

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/market into lp:widelands

2017-09-17 Thread kaputtnik
Review: Approve testing No errors anymore. Tested single player with three different tribes. -- https://code.launchpad.net/~widelands-dev/widelands/market/+merge/330830 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/market. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_resolution_change_mouse_bug into lp:widelands

2017-09-17 Thread kaputtnik
Review: Approve testing The bug is fixed :-) -- https://code.launchpad.net/~widelands-dev/widelands/fix_resolution_change_mouse_bug/+merge/330888 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix_resolution_change_mouse_bug. _

Re: [Widelands-dev] [Merge] lp:~trimardio/widelands-website/scheduling into lp:widelands-website

2017-09-19 Thread kaputtnik
First look: create a base template and load the needed css and js files in there. This should be done in a block tag: {% block extra_head %} ... load css and js {% endblock %} And in the other templates use then {% extends "wlscheduling/base.html" %} So loading those files are done in place a

Re: [Widelands-dev] [Merge] lp:~trimardio/widelands-website/scheduling into lp:widelands-website

2017-09-19 Thread kaputtnik
An idea for the Main page: Describe what a user can do here as plain text above the 'buttons' and limit the text of the 'buttons' to something like: "Define your playtime" and "Show other users playtime" Additional information could then be made in a title attribute. Just a suggestion :-) I st

Re: [Widelands-dev] [Merge] lp:~trimardio/widelands-website/scheduling into lp:widelands-website

2017-09-19 Thread kaputtnik
> We are talking about one particular hour, not one particular date. >From my understanding the model saves a date and an hour for each chosen hour. >So it is not an particular hour. Finding good names for variables and field names is sometimes difficult. What about calling it "target_date" or

Re: [Widelands-dev] [Merge] lp:~trimardio/widelands-website/scheduling into lp:widelands-website

2017-09-19 Thread kaputtnik
Seems the file base.html is missing. -- https://code.launchpad.net/~trimardio/widelands-website/scheduling/+merge/330997 Your team Widelands Developers is requested to review the proposed merge of lp:~trimardio/widelands-website/scheduling into lp:widelands-website. _

Re: [Widelands-dev] [Merge] lp:~trimardio/widelands-website/scheduling into lp:widelands-website

2017-09-20 Thread kaputtnik
I had to do this also in the past and created a new branch. The particular revisions related to this branch will be lost in the new branch though. This discussion will ever be available, afaik. It's just not linked with the new branch. -- https://code.launchpad.net/~trimardio/widelands-website/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/update_jvascript into lp:widelands-website

2017-09-23 Thread kaputtnik
Review: Needs Fixing I forgot to check wlscreens and fancybox.js -- https://code.launchpad.net/~widelands-dev/widelands-website/update_jvascript/+merge/331244 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/update_jvascript into lp:widelands-website

2017-09-26 Thread kaputtnik
Review: Resubmit This should work now and i have started alpha for testing. Things you could test: - Rating a map - Showing Polls - Viewing screenshots - Preview posts -- https://code.launchpad.net/~widelands-dev/widelands-website/update_jvascript/+merge/331244 Your team Widelands Developers

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/update_jvascript into lp:widelands-website

2017-09-28 Thread kaputtnik
Thanks :-) I am not fully satisfied with the border if a single screenshot is shown, but this could be changed later on. Merged and deployed. -- https://code.launchpad.net/~widelands-dev/widelands-website/update_jvascript/+merge/331244 Your team Widelands Developers is subscribed to branch lp:w

Re: [Widelands-dev] [Merge] lp:~trimardio/widelands-website/scheduling_module into lp:widelands-website

2017-09-28 Thread kaputtnik
So you stick with kalendae, no problem. Please merge the latest changes from trunk into your branch. In the directory of your branch: bzr merge lp:widelands-website bzr commit -m "merged with trunk" -- https://code.launchpad.net/~trimardio/widelands-website/scheduling_module/+merge/331477 Your

Re: [Widelands-dev] [Merge] lp:~trimardio/widelands-website/scheduling_module into lp:widelands-website

2017-09-29 Thread kaputtnik
Just a suggestion for the datepicker style: https://bugs.launchpad.net/widelands-website/+bug/1650735/+attachment/4958543/+files/datepicker_style.png The corresponding css: http://bazaar.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/view/head:/media/css/search.css

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/custom_user_admin_page into lp:widelands-website

2017-09-30 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/custom_user_admin_page into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands-website/custom_user_admin_page/+merge/331613

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-01 Thread kaputtnik
I am struggling a bit with showing additional options in the navigation (preselect a section to search for) https://bugs.launchpad.net/widelands-website/+bug/1650735/+attachment/4959742/+files/search_preselection.png I have made the dropdown button as small as possible and change the text of the

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-01 Thread kaputtnik
Thanks :-) will try that. And i have to test with different browsers too... -- https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-04 Thread kaputtnik
Review: Resubmit I decided to remove the file scripts.js. This was undocumented and clashed with the django widget for input fields. Instead i added a file search.js which contains all of the search related javascript stuff. Also made some browser specific changes to css files. If you agree to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/custom_user_admin_page into lp:widelands-website

2017-10-04 Thread kaputtnik
Thanks, merged and deployed :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/custom_user_admin_page/+merge/331613 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~wi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/custom_user_admin_page into lp:widelands-website

2017-10-04 Thread kaputtnik
Quite interesting how many users had registered but never activated the account ;) https://wl.widelands.org/admin/auth/user/?o=5 -- https://code.launchpad.net/~widelands-dev/widelands-website/custom_user_admin_page/+merge/331613 Your team Widelands Developers is subscribed to branch lp:widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-05 Thread kaputtnik
No need to hurry. Lets wait until Gun has some time again. -- https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mail

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/reveal_hide_animations into lp:widelands

2017-10-09 Thread kaputtnik
Gun did the review already, but reviewing by a another person can't be wrong. Before merging this branch the prerequisite branch needs reviewing and merged: https://code.launchpad.net/~widelands-dev/widelands/bug-1687100-reveal_fields -- https://code.launchpad.net/~widelands-dev/widelands/reveal

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-09 Thread kaputtnik
Thanks for proofreading :-) Searching the forum is default. > Should we also search the map hints? Maybe. I am quite unsure... we could add the map hints later. I am also not very convinced by the default highlighter included in haystack. It seems to be a bit buggy but i didn't want to write a

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-10 Thread kaputtnik
Forgot to answer one question: >> E.g. "main page" will find all wiki articles with this name or the content >> contains 'main page' > Sounds like a wiki article called "main page foo bar" will not be found - id > this correct? Yes, this should be correct. But i have to admit that there is no

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-10 Thread kaputtnik
After todays spam flood i think about how to prevent having spam in the index. This is maybe a task for a follow up branch? -- https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605 Your team Widelands Developers is subscribed to branch lp:widelan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/translation_stats into lp:widelands

2017-10-10 Thread kaputtnik
This is good approach to get more translators, i think. Translation stats: I guess the count of 'total' is ever the same, because English is the base language. Is it needed to store this value for each language? The text for RTL languages are messed up somehow. I guess this will be fixed if th

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-11 Thread kaputtnik
I have set up the alpha site, but did not run it at the moment. So if someone has time for testing (especially browser compatibility) just say a word and i start alpha. -- https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605 Your team Widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/custom_user_admin_page into lp:widelands-website

2017-10-12 Thread kaputtnik
I have deleted the non active accounts where the activation date expired. In total ~140 users. > It will make the list of usernames to trawl through shorter when posting news > etc. Normally the one who will write a news post is the one who opens the appropriate admin page. So i think in the l

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/custom_user_admin_page into lp:widelands-website

2017-10-14 Thread kaputtnik
Sorry this was meant to be a 'will have': bug 1723640 -- https://code.launchpad.net/~widelands-dev/widelands-website/custom_user_admin_page/+merge/331613 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: http

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-14 Thread kaputtnik
I am sure SirVer finds some time for testing. You can access the alpha site now on http://alpha.widelands.org -- https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605 Your team Widelands Developers is subscribed to branch lp:widelands-website.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/custom_user_admin_page into lp:widelands-website

2017-10-15 Thread kaputtnik
Sorry i don't understand what you mean. This branch is already merged so you could watch it on wl.widelands.org? -- https://code.launchpad.net/~widelands-dev/widelands-website/custom_user_admin_page/+merge/331613 Your team Widelands Developers is subscribed to branch lp:widelands-website. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-15 Thread kaputtnik
> In quick search, if I type a search word and then click on the dropdown to > select where to search, the search word will disappear. OK, has to be fixed :-) > It would also be nice if the quick search remembered the previous selection > throughout 1 browser session. This wouldn't be possible f

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-16 Thread kaputtnik
Disappearing the search term when selecting where to search in the quicksearch is fixed now. The search is now immediately executed when a search term is given and a selection is clicked. Map description originated from the map, not from the uploader comment, is included now. So searching for r

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-16 Thread kaputtnik
I have stopped the alpha site again. I fear the actual spammers will find it... -- https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605 Your team Widelands Developers is subscribed to branch lp:widelands-website.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/settings_unicode into lp:widelands-website

2017-10-17 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/settings_unicode into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands-website/settings_unicode/+merge/332381 Let python

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/settings_unicode into lp:widelands-website

2017-10-17 Thread kaputtnik
Tested on alpha. Works fine there :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/settings_unicode/+merge/332381 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/settings_unicode into lp:widelands-website.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/settings_unicode into lp:widelands-website

2017-10-18 Thread kaputtnik
Thanks :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/settings_unicode/+merge/332381 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/settings_unicode into lp:widelands-website. ___

Re: [Widelands-dev] [Merge] lp:~trimardio/widelands-website/scheduling_module into lp:widelands-website

2017-10-19 Thread kaputtnik
> Kaputtnik, could you merge this once you are happy? I am not good at code review, but will try. As i understand trimardio in our last pms, he wants to work further on this? @trimardio: > - clone html element in js: more coherent and a bit less work We should do this i think, so we ha

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-26 Thread kaputtnik
Time for another test round on alpha.widelands.org :-) I have modified the dropdown button in the navigation. I am not happy with the arrow sign, but this could be changed easily. HOpefully this works now with IE10. SiVer, can you test this with a MacOS browser? Remaining tests: On the search

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-26 Thread kaputtnik
hm... with Chromium Version 62 on linux it works as expected. Will test on win7 now. -- https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605 Your team Widelands Developers is subscribed to branch lp:widelands-website. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-26 Thread kaputtnik
IE 9, Chrome and Opera on Windows 7 behaves as SirVer described... i hate it, but has to be fixed. Will close alpha again. -- https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605 Your team Widelands Developers is subscribed to branch lp:widelan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-27 Thread kaputtnik
Funny... Chrome v62 and Opera v48 on archlinux are working fine... -- https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605 Your team Widelands Developers is subscribed to branch lp:widelands-website. _

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spambot into lp:widelands-website

2017-10-27 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/anti_spambot into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1614403 in Widelands Website: "Ideas to prevent spammers, make their work harder&quo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spambot into lp:widelands-website

2017-10-27 Thread kaputtnik
Thanks :-) merged and deployed -- https://code.launchpad.net/~widelands-dev/widelands-website/anti_spambot/+merge/332911 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands

2017-10-28 Thread kaputtnik
I had never played other than Headquarters starting condition, but would say that 'Trading Outpost' should have the same settings. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1075562-initial-trainers/+merge/332959 Your team Widelands Developers is requested to review the proposed m

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands

2017-10-28 Thread kaputtnik
Klaus, since only some data in the datafolder was changed there is no need to compile this branch :) Just use the option --datadir= -- https://code.launchpad.net/~widelands-dev/widelands/bug-1075562-initial-trainers/+merge/332959 Your team Widelands Developers is requested to review the proposed

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-28 Thread kaputtnik
I managed to get the virtual environment under windows working... I have tested the changes with Chrome (win7, win10) and IE11(win7). It should work now. Please test again. I you want to you could also test the latest changes regarding spam. Just write 5 posts/topics with a keyword (e.g. baba

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-10-28 Thread kaputtnik
Forgotton: I have modified the image used for the dropdown in the navigation(just made it smaller in height). In the detailed search page the last "Search in" option (News) is cut at the right side in some browsers. Don't know why or how to fix this. -- https://code.launchpad.net/~widelands-dev

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1075562-initial-trainers into lp:widelands

2017-10-29 Thread kaputtnik
Why not merging? @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1075562-initial-trainers/+merge/332959 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1075562-initial-trainers. ___ Ma

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_code_in_blockquotes into lp:widelands-website

2017-10-29 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/fix_code_in_blockquotes into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands-website/fix_code_in_blockquotes/+merge

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/translation_stats into lp:widelands

2017-10-30 Thread kaputtnik
I have run the update_translation_stats.py: Looks like this could be run only with python2. Maybe add a comment? I got a list out of range error: $ > python2 utils/update_translation_stats.py Fetching translation stats ... Locale Total Translated -- -

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/nethost-split into lp:widelands

2017-10-30 Thread kaputtnik
Is bunnybot ill? Another try: @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/nethost-split/+merge/332385 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/nethost-split. ___ Mailing list: https

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_code_in_blockquotes into lp:widelands-website

2017-10-30 Thread kaputtnik
The proposal to merge lp:~widelands-dev/widelands-website/fix_code_in_blockquotes into lp:widelands-website has been updated. Description changed to: Something that annoys me a long time: When quoting a post which contains a code block, the codeblock is not rendered correct. This branch will f

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/read_changelog_utf8 into lp:widelands-website

2017-10-30 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/read_changelog_utf8 into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1242354 in Widelands Website: "Changelog page is empty; use unicode for input&quo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_small_requests into lp:widelands

2017-10-30 Thread kaputtnik
Review: Approve testing This fixes https://bugs.launchpad.net/widelands/+bug/1724073 :-) So for this bug approval. -- https://code.launchpad.net/~widelands-dev/widelands/ai_small_requests/+merge/332519 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_small_r

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_code_in_blockquotes into lp:widelands-website

2017-10-31 Thread kaputtnik
Review: Needs Fixing Does not work when quoting a quoted codeblock. Does not regard single lines containing tildes. -- https://code.launchpad.net/~widelands-dev/widelands-website/fix_code_in_blockquotes/+merge/332966 Your team Widelands Developers is subscribed to branch lp:widelands-website.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/media_cleanup into lp:widelands-website

2017-11-01 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/media_cleanup into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands-website/media_cleanup/+merge/333088 Some cleanup in

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/translation_stats into lp:widelands

2017-11-01 Thread kaputtnik
Review: Needs Fixing The regex doesn't match here and the match is always 'None', resulting in the List out of range error. Don't know how to fix the regex... but maybe adding an else clause? See diff comment. Diff comments: > > === added file 'utils/update_translation_stats.py' > --- utils/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/translation_stats into lp:widelands

2017-11-01 Thread kaputtnik
Just want to mention that i did run the file with python2 :-) This is what i get now: $:> python2 utils/update_translation_stats.py Fetching translation stats . ERROR: Invalid line in pocount output: /home/kaputtnik/Quellcode/widelands-repo/translation_stats/po/map_the_green_plateau.wmf/la

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-11-02 Thread kaputtnik
Its already running. -- https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/translation_stats into lp:widelands

2017-11-02 Thread kaputtnik
My version of translate-toolkit is 2.2.5-1. Pulled your changes but no change: $:> python2 utils/update_translation_stats.py Fetching translation stats . ERROR: Invalid line in pocount output: /home/kaputtnik/Quellc

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/media_cleanup into lp:widelands-website

2017-11-02 Thread kaputtnik
Regarding the TODO: The file pybb/inlines/post.html is currently not used. So for this cleanup-branch it may had to be removed. I decided to leave it and use it in future, for template inheritance: https://docs.djangoproject.com/en/1.8/ref/templates/language/#template-inheritance Regarding lowe

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/read_changelog_utf8 into lp:widelands-website

2017-11-02 Thread kaputtnik
Thanks :-) I guess encoding failures for the encyclopedia and the documentation may rise up when wlmap_map_object_info (encyclopedia) or extract_rst.py (documentation) ran. Will try to test it, before merging this :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/read_changelo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/read_changelog_utf8 into lp:widelands-website

2017-11-02 Thread kaputtnik
Testet also encyclopedia and documentation: All works fine. Merged and deployed. -- https://code.launchpad.net/~widelands-dev/widelands-website/read_changelog_utf8/+merge/332990 Your team Widelands Developers is subscribed to branch lp:widelands-website. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/media_cleanup into lp:widelands-website

2017-11-02 Thread kaputtnik
Merged and deployed. -- https://code.launchpad.net/~widelands-dev/widelands-website/media_cleanup/+merge/333088 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/read_changelog_utf8 into lp:widelands-website

2017-11-02 Thread kaputtnik
Oh, and i had a look at the encoding of the database tables and columns (possibly again). It's all utf8 :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/read_changelog_utf8/+merge/332990 Your team Widelands Developers is subscribed to branch lp:widelands-website. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_small_requests into lp:widelands

2017-11-03 Thread kaputtnik
> Does this still need testing for the seafaring buildings? Yes. Bug 1722376 needs testing (if Tibor didn't test it already), but bug 1724073 is fixed with this branch. -- https://code.launchpad.net/~widelands-dev/widelands/ai_small_requests/+merge/332519 Your team Widelands Developers is subscr

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/translation_stats into lp:widelands

2017-11-03 Thread kaputtnik
No, it doesn't work :( Whereas the version of pocount used by me has an option '--no-color', it is maybe better to use another pocount output format like --csv in combination with python csv module? https://docs.python.org/2/library/csv.html?highlight=csv#module-csv I guess the csv format prov

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/translation_stats into lp:widelands

2017-11-03 Thread kaputtnik
Now its working :-) Could you please add 'https://' to the underlined link for "...please visit widelands.org/wiki/TranslatinWidelands" -- https://code.launchpad.net/~widelands-dev/widelands/translation_stats/+merge/332029 Your team Widelands Developers is subscribed to branch lp:~widelands-de

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-11-03 Thread kaputtnik
Ah, i had this also... try to clean the browsers cache or http://alpha.widelands.org -- https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605 Your team Widelands Developers is subscribed to branch lp:widelands-website. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-11-04 Thread kaputtnik
You could also try to open the site in a browsers private window. I am probably not on a machine with ssh access from today noontime until Sunday evening. -- https://code.launchpad.net/~widelands-dev/widelands-website/searching_with_haystack_whoosh/+merge/331605 Your team Widelands Developers is

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-11-06 Thread kaputtnik
Upps, i missed your post... I have desaturated the arrows a bit. Regarding the background coloring it isn't possible to make it transparent because the color is also used for the selection menu. If i set the background color transparent, the background of the arrow is transparent but for the me

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/searching_with_haystack_whoosh into lp:widelands-website

2017-11-06 Thread kaputtnik
Ok, after i've made a mistake on the server all should work now for the productive website. SirVer, could you please check if the sphinxsearch package could be uninstalled from the server and care about it? It looks to me like the sphinx search was only used for the website. I have adjusted th

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/pm_menus_overhaul into lp:widelands-website

2017-11-08 Thread kaputtnik
I have tested the autocomplete function with: Win7: Chrome, IE9 Linux: Chrome v62, Opera v48, Firefox v56, konqueror v5 -- https://code.launchpad.net/~widelands-dev/widelands-website/pm_menus_overhaul/+merge/333419 Your team Widelands Developers is requested to review the proposed merge of lp:~

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/pm_menus_overhaul into lp:widelands-website

2017-11-09 Thread kaputtnik
Thanks :-) Merged, deployed and added the management command to cron.daily/django_regular_commands. -- https://code.launchpad.net/~widelands-dev/widelands-website/pm_menus_overhaul/+merge/333419 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/map_version_gt_19 into lp:widelands-website

2017-11-12 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/map_version_gt_19 into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1731732 in Widelands Website: "Check whether a map needs a version of Widelands newer than Bui

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/map_version_gt_19 into lp:widelands-website

2017-11-13 Thread kaputtnik
Thanks :-) Merged and deployed. -- https://code.launchpad.net/~widelands-dev/widelands-website/map_version_gt_19/+merge/333591 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelan

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/correct_link_coloring into lp:widelands-website

2017-11-14 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/correct_link_coloring into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1732101 in Widelands Website: "Wiki link color markup can't handle %20" https://bug

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/correct_link_coloring into lp:widelands-website

2017-11-15 Thread kaputtnik
Thanks :-) Merged and deployed. -- https://code.launchpad.net/~widelands-dev/widelands-website/correct_link_coloring/+merge/333697 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~wide

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_app into lp:widelands-website

2017-11-24 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/anti_spam_app into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1614403 in Widelands Website: "Ideas to prevent spammers, make their work harder&quo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/run-asan into lp:widelands

2017-11-24 Thread kaputtnik
One nit: In print help is a wrong short form option: > echo "-a or --help Print this help." should be > echo "-h or --help Print this help." -a is used for asan. -- https://code.launchpad.net/~widelands-dev/widelands/run-asan/+merge/334227 Your team Widelands Developers is

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_app into lp:widelands-website

2017-11-28 Thread kaputtnik
Thanks for the review :-) Will merge it at Thursday. I want to make backup of the database before merging this. Making a backup of the database prevent saving anything. So i am thinking about having an additional noticeable row below the navigation showing something like "The website is curre

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_app into lp:widelands-website

2017-11-29 Thread kaputtnik
After reading your post and rethinking my suggestion it is much problematic as it seems. Beside the forums, there are also other things which write to the database while using the website, e.g. Downloading a map (Increasing the download number). It is also not clear how to handle active session

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_app into lp:widelands-website

2017-11-29 Thread kaputtnik
> but you could run a backup once on the live system just to see how long it > takes I remember the last time i did this it was not clear to me how long it takes. Say if the terminal lost the ssh connection it stays in a frozen way (no response from the server). That time it takes incredible lo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1734748-savegame-filename into lp:widelands

2017-11-29 Thread kaputtnik
Review: Approve testing approve testing :-) Thanks Jukka! -- https://code.launchpad.net/~widelands-dev/widelands/bug-1734748-savegame-filename/+merge/334429 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1734748-savegame-filename. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_app into lp:widelands-website

2017-11-30 Thread kaputtnik
Merged and deployed. Making a backup of the database was done in a few seconds... I have to admit that i only made a backup of the productive database. User only having staff status (and are not superusers), may not see the entry "Check Input/Suspicious Input" on the main admin page. I gave Gun

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/keep_optr_in_ui into lp:widelands

2017-11-30 Thread kaputtnik
I am just compiling this branch :-) -- https://code.launchpad.net/~widelands-dev/widelands/keep_optr_in_ui/+merge/334524 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/keep_optr_in_ui into lp:widelands.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/keep_optr_in_ui into lp:widelands

2017-11-30 Thread kaputtnik
Review: Approve testing I have opened really many construction site windows in the replay and watched how they change their state, e.g. form Construction site -> building ready -> dismantle -> window closed Also for the Arena: Construction site -> ready building -> update to colloseum -> Collo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1735980-save-map into lp:widelands

2017-12-03 Thread kaputtnik
Will this also fix bug 1734729 "Editor: Crash when saving a map" -- https://code.launchpad.net/~widelands-dev/widelands/bug-1735980-save-map/+merge/334638 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1735980-save-map into lp:widelands

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/wiki_no_delete into lp:widelands-website

2017-12-03 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/wiki_no_delete into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1735435 in Widelands Website: "Deleting a wikipage should not really delete it&quo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1735980-save-map into lp:widelands

2017-12-04 Thread kaputtnik
Review: Approve testing Works fine now, but found two other non critical bugs This fixes also bug 1734729 -- https://code.launchpad.net/~widelands-dev/widelands/bug-1735980-save-map/+merge/334638 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1735980-save

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1735980-save-map into lp:widelands

2017-12-04 Thread kaputtnik
Review: Needs Fixing Sorry, bug 1736095 appears only with this branch, not in trunk. So this needs fixing here. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1735980-save-map/+merge/334638 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-17359

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1735980-save-map into lp:widelands

2017-12-04 Thread kaputtnik
This is crazy... it happen in trunk as well under some circumstances, so during testing trunk the first time i didn't used the settings which causes it. I have to investigate further... So this branch is fine, sorry for confusing. -- https://code.launchpad.net/~widelands-dev/widelands/bug-173

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/wiki_no_delete into lp:widelands-website

2017-12-05 Thread kaputtnik
Yes :-) merged and deployed -- https://code.launchpad.net/~widelands-dev/widelands-website/wiki_no_delete/+merge/334639 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/Mission4 into lp:widelands

2017-12-07 Thread kaputtnik
Just do playtest... with current trunk and datadir of this branch. Found that the tavern is producing ration only from fish, without having bread. Don't know if this is related to this branch or to trunk. I thought normally bread is always used when producing rations? -- https://code.launchpad.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/Mission4 into lp:widelands

2017-12-08 Thread kaputtnik
> I thought normally bread is always used when producing rations? Hm, looks like i had the wrong assumption during playing widelands for the last years :-D Rations are produced either from Bread OR Fish OR Meat. So you better forget my previous post... -- https://code.launchpad.net/~widelands-d

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/better_notification_mail into lp:widelands-website

2017-12-11 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/better_notification_mail into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #340920 in Widelands Website: "wiki change notification mail is very sparse&quo

<    3   4   5   6   7   8   9   10   11   12   >