kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/static_robots_txt into lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #336020 in Widelands Website: "robots.txt should exist"
https://bugs.launchpad.net/widelan
Review: Resubmit
So the first version was better than the adjusted version.
Thanks for looking into it :-)
--
https://code.launchpad.net/~widelands-dev/widelands-website/static_robots_txt/+merge/313398
Your team Widelands Developers is subscribed to branch lp:widelands-website.
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/fix_searchresult_ordering into
lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1446005 in Widelands Website: "Search function only lists 20 oldest
forum posts&quo
Forgot the Wiki :-S
--
https://code.launchpad.net/~widelands-dev/widelands-website/fix_searchresult_ordering/+merge/313466
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands-website/fix_searchresult_ordering into
lp:widelands-website.
___
Thanks :-)
Merged and deployed.
--
https://code.launchpad.net/~widelands-dev/widelands-website/static_robots_txt/+merge/313398
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelan
Thanks :-)
Merged and deployed.
--
https://code.launchpad.net/~widelands-dev/widelands-website/fix_searchresult_ordering/+merge/313466
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/
The proposal to merge lp:~widelands-dev/widelands-website/move_minimaps into
lp:widelands-website has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/move_minimaps/+merge/303493
--
Your team Widelands Develope
I've set this to rejected. I think if we allow submitters of maps to upload
different versions, we may need a better way of saving the files related to
each map (version). E.g. having the wmf and png together in one directory per
version would be better.
--
https://code.launchpad.net/~widelands
Very nice :-)
Zooming in works fine here for each message. But i couldn't test a lot because
of the crash in sound_handler triggers too often. I am wondering when turning
off each sound, this crash happens also.
If the keyboard shortcuts '.' and ',' are removed, please remove also the
descript
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/bug-1399461_error_on_renaming_article into
lp:widelands-website.
Commit message:
Prevent double names of wiki articles. Add a 'What links here' page.
Requested reviews:
Widelands Developers (widelands-dev)
Related b
Review: Approve testing
For me all is working really fine. Could not confirm the issue mentioned by
Tibor.
--
https://code.launchpad.net/~widelands-dev/widelands/animation_manager/+merge/313879
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/animation_manager.
Can't reproduce the thing mentioned by Tibor with the map from the other
Bugreport. The only thing is that in the beginning there is some stuttering,
until all places are visited.
--
https://code.launchpad.net/~widelands-dev/widelands/animation_manager/+merge/313879
Your team Widelands Developer
> 1. "Click to select an item." is redundant, everyone using this tool can be
> expected to guess this.
While i agree here, those string changes have to be in another branch.
To this one: Is it possible to have images aligned at the bottom of each row?
Currently they are aligned at the top. Thi
> > In general i think redirects are not really a good thing at all, because it
> may lead into many redirects after some time.
>
> While I agree here, they are also sorta required: if some external site links
> to a site in our Wiki, we want this link to stay valid forever ideally. So we
> have t
> > Should creating of articles prevented if a redirect exists?
>
> Yes, I think this is acceptable. We create maybe 10 articles per year, it will
> be a while till we run out of names, even including redirects.
Ok, then i try to prevent it in this branch :-)
>
> > If we want redirects to stay
Review: Approve testing
Works here on Linux with multi monitor setup.
--
https://code.launchpad.net/~widelands-dev/widelands/fsmenu_fullscreen_4_options/+merge/312966
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fsmenu_fullscreen_4_options.
> The different terrain window sizes were probably done on purpose as well to
> group the same types of > terrain as much as possible - I coded this a few
> months ago, so I don't remember 100% right now.
I guess one could not be sure that this ordering assumption is ever valid. E.g.
when one a
Puhh... hopefully i get it now. Giving the example of
1. https://wl.widelands.org/wiki/Description/
2. https://wl.widelands.org/wiki/GameHelp/ #redirect to 1.
- Trying to open /wiki/edit/GameHelp opens now 'Description' for editing.
Trying to change the title is handled as follows:
For existi
Thanks for the review :-)
Let's wait for Gun if she complains against my english pronouncing :-)
--
https://code.launchpad.net/~widelands-dev/widelands-website/bug-1399461_error_on_renaming_article/+merge/314033
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
The proposal to merge lp:~widelands-dev/widelands/reset_zoom_button into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/reset_zoom_button/+merge/313058
--
Your team Widelands Developers is re
Found a failure... tomorrow i want to merge this on the alpha site, so anybody
can take a look at it and test.
--
https://code.launchpad.net/~widelands-dev/widelands-website/bug-1399461_error_on_renaming_article/+merge/314033
Your team Widelands Developers is subscribed to branch lp:widelands-w
Merged but not committed on alpha, migrated the changes related to the database
over there. For testing one has to start the alpha site.
--
https://code.launchpad.net/~widelands-dev/widelands-website/bug-1399461_error_on_renaming_article/+merge/314033
Your team Widelands Developers is subscribed
I have interpreted the statement:
> ... , but did not test it
as you would like to test. I think on the alpha site this is easier. The alpha
site is running now.
Maybe i have one thing of the changes to explain further: To show the
Changesets for an Article one has to open an article in the ad
Having the same width of all terrain related tabs is better than switching the
window size :-)
The width of 6 is not like before, so a bit uncommon, but no showstopper.
For my other question i will create another Bug report then, so this can go in.
> Is it possible to have images aligned at the
Thanks a lot :-)
--
https://code.launchpad.net/~widelands-dev/widelands-website/bug-1399461_error_on_renaming_article/+merge/314033
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~wid
For the message menu and the 'load save game' menu it works fine :-)
The only thing is that the highlighted background of an marked element does not
distinguish very well.
I can't test for the "Watch replay" menu, because of bug 1653460. See there
also for a screenshot in comment 8:
https://bu
Review: Approve testing
Small change, great result :D
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1654989-fuzzy-terrain-images/+merge/315095
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1654989-fuzzy-terrain-images.
__
Review: Approve testing
> How about we do a general overhaul if the tips?
Yes, that is a good idea. I think we could ask in the forums for such tips and
get good answers then :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1625502-tips-in-help/+merge/312969
Your team Widelands De
Review: Needs Fixing
Found another:
If you mark an entry and press SHIFT + UP-ARROW the previous list item is
marked. Pressing then SHIFT + DOWN-ARROW the previous item is not unmarked
again. This is unusual in comparison with e.g. a file manager.
--
https://code.launchpad.net/~widelands-dev/w
Review: Needs Fixing
Ahh... using the arrow keys do always mark an additional entry, one doesn't
have to use additionally the SHIFT key.
1. Open menu Load Game
2. Use the down arrow key
The next entry is marked then. If one want's to load the game of next entry in
the list, he must use the mou
kaputtnik has proposed merging lp:~widelands-dev/widelands/reset_zoom_button
into lp:widelands.
Commit message:
modified reset_zoom_button
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/reset_zoom_button
Another try, new button on the bottom:
https://bugs.launchpad.net/widelands/+bug/536461/+attachment/4806375/+files/reset_zoom_button_compare.png
--
https://code.launchpad.net/~widelands-dev/widelands/reset_zoom_button/+merge/313058
Your team Widelands Developers is requested to review the propos
This is merged and deployed now on the productive website.
Alpha is offline again.
--
https://code.launchpad.net/~widelands-dev/widelands-website/bug-1399461_error_on_renaming_article/+merge/314033
Your team Widelands Developers is subscribed to branch lp:widelands-website.
_
> Sorry for holding this off :(
Sorry that i am such impatient in this case... but i think this branch does not
hurt if it is productive. There are no writes to Database or to the storage, so
the worst thing that could happen is a not catched server error (we had for a
long time nor such errors
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/post_django1_8_cleanup into
lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/post_django1_8_cleanup/+merge/315301
I have tried to get more sharpen "x1", and provide three alternatives: "x1",
"1x" and placing the chars outside the magnifier. The right Magnifier is also
better rounded, so depending on what we want to have i use this version of
magnifier glass.
https://launchpadlibrarian.net/303212200/reset_z
> TODO(Franku):
Yes, will do that :-)
Regarding comments in general: The widelands-website code has some old
comments. I would like to mark the comments made by me to distinguish between
the old ones. That's the reason why i used 'Franku: comment'. How is the
convention in such a case?
--
htt
Do you want to add/change the tips suggested in the forum in this branch? Since
it could be a job for a person who don't know much about C++, the related
changes could be made in another branch after this one is merged.
https://wl.widelands.org/forum/topic/2819/
--
https://code.launchpad.net/~
Ups, forgot that one.
--
https://code.launchpad.net/~widelands-dev/widelands-website/post_django1_8_cleanup/+merge/315301
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-d
Maybe a silly question: Looks like the files are opened but not closed?
Python programmers using mostly the 'with' statement when handling files, which
automatically closes files. See the last example in
https://docs.python.org/2/tutorial/inputoutput.html#methods-of-file-objects
--
https://co
Review: Resubmit
I think this good now. I push also the gimp xcf file to the media repo.
--
https://code.launchpad.net/~widelands-dev/widelands/reset_zoom_button/+merge/313058
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/reset_zoom_button.
_
Added some diff comments to use the 'with' statement as example.
There is also a bash script
'find_not_updated_copyright_year_in_modified_src_files'. Is this needed anymore
then?
Diff comments:
>
> === added file 'utils/__init__.py'
> === added file 'utils/file_utils.py'
> --- utils/file_util
Crosspost :-D
--
https://code.launchpad.net/~widelands-dev/widelands/update_copyright_script/+merge/315352
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/update_copyright_script.
___
Mailing list: https://launchpad.n
Merged and deployed.
If some one want to test the changes in future, can we agree on saying "Needs
test" or "run alpha" instead of "Not tested"? Then i start alpha and leave it
running until some one says "tested" or so. This would make things clearer for
me :-)
--
https://code.launchpad.net/~
Review: Approve testing
Works fine now :-)
One issue: If multiple rows are selected and you click on a column title to
have a different ordering, then only the last selected entry is marked anymore.
But for me this is ok :-)
--
https://code.launchpad.net/~widelands-dev/widelands/table_multisel
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/fix_news
into lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1661555 in Widelands Website: "News: New posts with publish 'today' and
'now&#x
Review: Needs Fixing
Sorry, the bug is not fixed here with this branch.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1627537-window-mouserelease/+merge/315986
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1627537-window-mouserelease.
Review: Approve testing
Still works :-)
--
https://code.launchpad.net/~widelands-dev/widelands/table_multiselect/+merge/312747
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/table_multiselect.
___
Mailing list: http
Thanks :-)
Merged and deployed.
--
https://code.launchpad.net/~widelands-dev/widelands-website/fix_news/+merge/316401
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Po
Regarding sound Documentation:
1. Please use underscores instead of spaces for filenames
2. I am unsure about the place where you put it. The doc-folder is mainly for
automatic documentation of code (e.g. description of Lua scripting API). I
think the documentation is better stored in data/sound
The old behavior still applies if the mouse button get released on a
highlighted button. E.g. open tools -> terrain height menu and tools -> terrain
menu. Choose water, hold down left mouse button and move the mouse to one of
the buttons in the change height window. Releasing the mouse button th
Review: Approve testing
Perfect :-)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1627537-window-mouserelease/+merge/315986
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1627537-window-mouserelease.
_
Review: Approve
LGTM :-)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/lua_roadmap/+merge/316562
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/lua_roadmap.
___
Mailing list: https://launch
Review: Approve testing
Played the first tutorial and it works as expected.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1634736-victory-gamespeed/+merge/316973
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1634736-victory-gamespeed.
Sounds interesting.
I will test it in the next days.
--
https://code.launchpad.net/~widelands-dev/widelands-website/wlwebsite_docker/+merge/317036
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands-website/wlwebsite_docker into lp:widelands-we
Review: Approve testing
As far i can see the bug is fixed :-)
But the indentation of code is broken. Looks like widelands c++ code uses tabs
for indentation, whereas you use spaces?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1658489-epedition-tab/+merge/317047
Your team Wideland
Review: Approve testing
Works again :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1653254-flagaction-roads/+merge/317709
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1653254-flagaction-roads.
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/get_rid_of_wikiwords into
lp:widelands-website with lp:~widelands-dev/widelands-website/convert_wikiwords
as a prerequisite.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1595294 in Widelands
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/convert_wikiwords into lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1595294 in Widelands Website: "Get rid of wikiwordification"
https://bugs.launchpad.net
Forgotten: Didn't cleanup the Tests... is this needed in this branch or should
i write a new bug report?
--
https://code.launchpad.net/~widelands-dev/widelands-website/get_rid_of_wikiwords/+merge/318283
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev
Forgotten: The new syntax clashes with the syntax for tables, so if one wants
to create a 'piped' link like [[ Main Page | Look here ]] he has to use the
normal markdown syntax for links.
The Script does not take care of 'piped' links in tables, so after running it,
at least the page https://wl
Review: Needs Fixing
konsole output and Backtrace:
widelands:
/home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/panel.cc:243:
void UI::Panel::set_size(int, int): Assertion `nw >= 0' failed.
Thread 1 "widelands" received signa
I got a failure on make init:
django.core.exceptions.ImproperlyConfigured: settings.DATABASES is improperly
configured. Please supply the ENGINE value. Check settings documentation for
more details.
make: *** [Makefile:32: init] Fehler 1
I am unsure about the benefits:
> 1) get rid of instal
Review: Needs Fixing
Crash when accessing "About Widelands":
This is Widelands Version bzr8310[bug-1653460-panel-init-width] (Debug)
[...]
widelands:
/home/kaputtnik/Quellcode/widelands-repo/bug-1653460-panel-init-width/src/ui_basic/panel.cc:243:
void UI::Panel::set_size(int, int):
Similar crash happens in game if a building wants to be dismantled.
Backtrace then:
https://bugs.launchpad.net/widelands/+bug/1653460/+attachment/4828491/+files/backtrace
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358
Your team Widelands Develop
kaputtnik has proposed merging
lp:~widelands-dev/widelands/bug-1668243-editor_tips into lp:widelands.
Commit message:
Additional tips for loadscreens.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1668243 in widelands: "Add new game and editor tips&quo
Review: Approve testing
Looks good :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1653460-panel-init-width.
_
Can't test it right now, but is it likely that this merge proposal also fixes
bug 1664052?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1653460-panel-init-width/+merge/318358
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1653460-panel-init-w
Review: Approve testing
Played a game a while with this branch: LGTM
--
https://code.launchpad.net/~widelands-dev/widelands/fh1_width_and_mapobject_messages/+merge/318189
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fh1_width_and_mapobject_messages.
__
Review: Approve
One nit, otherwise looks good to me.
Diff comments:
> === modified file 'data/campaigns/atl01.wmf/scripting/texts.lua'
> --- data/campaigns/atl01.wmf/scripting/texts.lua 2017-02-15 19:32:31
> +
> +++ data/campaigns/atl01.wmf/scripting/texts.lua 2017-03-04 13:46:04
For me "Jundlina Writes a Letter" is the heading of this chapter. The header
gives a hint on whats going on in the following text, but isn't a concrete part
of the text.
Since i am not registered on transifex and you are the master of translation,
feel free to change it as you like.
I am not
Started and canceled an expedition about 10 times and no crash anymore.
What i noticed:
1. The Black 'Cargo-space' does not fill the entire window anymore... intended?
2. If an expedition is canceled the button 'Cancel expedition is removed from
the ship window. But if you close the ship window a
Thanks for review :-)
I've run the converting script and merged this branch on alpha. Alpha is still
running. If you have some articles on alpha observed, you should have an e mail
about the change in your inbox. I think all looks good over there (except some
wrong syntax in some tables).
Ther
kaputtnik has proposed merging
lp:~widelands-dev/widelands/bug-1670065_emp01_clear_building_site into
lp:widelands.
Commit message:
Clear building space for Lumberjack in empire campaign 1
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1670065 in widelands
Ah, ok i see... i meant formerly the black area fits the whole inner window,
whereas now there is some space on the left and right between window border and
black area. It looks like the black area is in the air somehow.
I have no time (and maybe no experience) for creating such an image i
ment
Thats better :-)
Made a function remove_trees() and additionally call it for the fields of the
barrack.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1670065_emp01_clear_building_site/+merge/319000
Your team Widelands Developers is requested to review the proposed merge of
lp:~wide
The proposal to merge
lp:~widelands-dev/widelands/bug-1670065_emp01_clear_building_site into
lp:widelands has been updated.
Commit Message changed to:
Clear building space for first buildings in empire campaign 1
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-16
Thanks :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1670065_emp01_clear_building_site/+merge/319000
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1670065_emp01_clear_building_site.
___
Mailing
Review: Approve testing
Looks good :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1664052-expedition-shipwindow-crash/+merge/318986
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1664052-expedition-shipwindow-crash.
_
kaputtnik has proposed merging
lp:~widelands-dev/widelands/move_website_binaries into lp:widelands.
Commit message:
Move website related binaries to base dir in compile.sh; fixed some wrong
indentation for the documentation in the website.
Requested reviews:
Widelands Developers (widelands
Review: Approve testing
Works here :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-536489-pictorial-dropdown/+merge/319023
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-536489-pictorial-dropdown.
___
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/widelands_trunk_binaries into
lp:widelands-website.
Commit message:
Change the PATH variable to include widelands/trunk.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https
I would be pleased if SirVer could test it. I am not sure if this will work on
OsX.
--
https://code.launchpad.net/~widelands-dev/widelands/move_website_binaries/+merge/319231
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/move_website_binaries.
__
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/encyclopedia_beautification into
lp:widelands-website.
Commit message:
Encyclopedia: Redesign of startpage and filter for buildings
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #336021 in
Addressed the nits from
https://bugs.launchpad.net/widelands-website/+bug/336021/comments/24
Merged and deployed now.
--
https://code.launchpad.net/~widelands-dev/widelands-website/encyclopedia_beautification/+merge/319645
Your team Widelands Developers is requested to review the proposed merge
Review: Approve testing
I played a bit with this new feature and it works great :-)
One could hide now also the starting position and reveal it after the map is
scrolled. An imagination of blending in and out different scenes. A nice to
have would be to make the blending more smooth, but a lua
Thanks for looking into it and merging :-)
So i think the website related branch could also be merged then...
This is quite convenient for me, because i didn't have to install and update
the latest package from the arch-linux repo. A few steps less to do, since i
update latest trunk regularly a
Review: Needs Fixing
The tribe selection in "Multiplayer Game Setup" didn't work also. Sometimes the
pictorial dropdwon appears for less than a second, but disappears immediately,
sometimes it isn't shown at all (no tribe selection possible).
--
https://code.launchpad.net/~widelands-dev/widelan
Thanks for proofreading and approval.
Merged and deployed.
--
https://code.launchpad.net/~widelands-dev/widelands-website/widelands_trunk_binaries/+merge/319233
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing li
Review: Approve website related
Works for the website related stuff :-)
Anyway two diff comments.
Diff comments:
>
> === modified file 'data/tribes/workers/atlanteans/carrier/init.lua'
> --- data/tribes/workers/atlanteans/carrier/init.lua 2017-02-12 09:10:57
> +
> +++ data/tribes/worker
Review: Approve testing
Started multiplayer game:
Map was 'The Nile', set tribes with no problems, saved the game and reloaded it
without problems.
So from my side it's ok now :-)
--
https://code.launchpad.net/~widelands-dev/widelands/wincondition_dropdown_multiplayer/+merge/322196
Your team W
I am struggling with the different coloring of texts:
In Load screen there is yellow for constants (like 'Map Name:') and yellow for
variables.
In save screen this is vice versa.
In general an improvement though :-)
--
https://code.launchpad.net/~widelands-dev/widelands/savegame-menu/+merge/32
Sorry for confusing, i was much tired yesterday. I meant: '... white for
variables':
In Load screen there is yellow for constants (like 'Map Name:') and white for
variables.
In save screen this is vice versa.
Another inconsistency:
In 'Watch Replay' the column 'Description' contains an arrow,
I think it is ok if it comes up on the homepage :-)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1512093-workers/+merge/322981
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1512093-workers.
___
Mai
> Colors are reversed between the Fullscreen menus and the in.game menus on
> purpose. This is necessary because the background makes non-bold text
> unreadable in the Fullscreen menus
Can't follow you here. The Save game menu shows currently (in this branch) bold
white constants ('Map name:') w
Review: Approve testing
Looks good :)
Loaded a save game and tested the buildings menus and also other menus. All is
fine.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1685645-workertable/+merge/323080
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widel
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/notifications_cleanup into
lp:widelands-website.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1637632 in Widelands Website: "Cleanup notification_notice"
https://bugs.launchpad.net
Maybe you could find an answer why the pickle warning shows up. The relevant
code for pickling is:
http://bazaar.launchpad.net/~widelands-dev/widelands-website/notifications_cleanup/view/head:/notification/models.py#L310
For unpickling:
http://bazaar.launchpad.net/~widelands-dev/widelands-websi
Thanks for testing and review :-)
Got also all emails (except for the server error).
Deferred vs. Immediate mails: I have tried to use deferred mails for things
where 'maybe' much people get informed. I just guessed that most people are
interested in getting e-mails for new maps, topics and for
Saving the pickled objects in the database is an easy way to store the data,
imho. No need for special rights is needed here. In fact storing in the
database is nearly the same as storing on disk, because mysql stores his
databases and tables on disk.
>From my understanding Djangos ORM is used
501 - 600 of 1276 matches
Mail list logo
