[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/move_minimaps into lp:widelands-website

2016-08-21 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/move_minimaps into lp:widelands-website. Commit message: Move minimaps from 'media/wlmaps/maps/' to 'media/wlmaps/minimaps/' when uploading a map. Requested reviews: Widelands Developers (widelands-dev)

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/move_minimaps into lp:widelands-website

2016-08-22 Thread kaputtnik
'upload_to' was mandatory before Django 1.7, so it is a leftover of the old Django version. We could omit this option, but it is used to get the property of the url attribute, see the link and explanation below: https://docs.djangoproject.com/en/1.8/ref/models/fields/#django.db.models.FileField.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/move_minimaps into lp:widelands-website

2016-08-22 Thread kaputtnik
Just tested: The 'upload_to' property mustn't be set for field 'minimap'. I check this also for the wlmaps.file field. -- https://code.launchpad.net/~widelands-dev/widelands-website/move_minimaps/+merge/303493 Your team Widelands Developers is subscribed to branch lp:widelands-website. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/move_minimaps into lp:widelands-website

2016-08-22 Thread kaputtnik
I don't know what to do with the 'upload_to' property. - for the map it is needed - for the minimap it isn't needed Defining this property for one file field and not on an other in models.py is imho not good. And at least this is a part of the model. What we can do is: - Define the upload_to at

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/move_minimaps into lp:widelands-website

2016-08-23 Thread kaputtnik
I think it would be better if all related code in forms.py depends on 'upload_to', as well for the minimap as also for the mapfile. There are several places where "/wlmaps/maps" or "/wlmaps/minimaps" are hardcoded as strings: 1. Storing the mapfile for wl_map_info 2. Moving the minimap 3. The s

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/move_minimaps into lp:widelands-website

2016-09-01 Thread kaputtnik
Thanks for the hint to the shell. Since the code is already written and i am not as familiar with keyboard writing (5 fingers search :-S ) i am in favor of to use a branch. I would also prefer to make the changes in two steps instead or three. So this branch will become some additional changes

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/sphinx_changes into lp:widelands

2016-09-02 Thread kaputtnik
Making the docs shows no errors or warnings. Regarding the changes to the README: What is meant with 'Building the documentation for the webserver'? The locally installed website, or the webserver where widelands.org is running? Maybe adding a hint on a running cron-job on the webserver (widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/sphinx_changes into lp:widelands

2016-09-03 Thread kaputtnik
> Maybe we should add some documentation on how to build it for the website in > the website project, and only leave a hint in the readme here that it can be > found there? Yes, i think this would be ok. -- https://code.launchpad.net/~widelands-dev/widelands/sphinx_changes/+merge/304751 Your te

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/sphinx_changes into lp:widelands

2016-09-03 Thread kaputtnik
Yes of course :-) -- https://code.launchpad.net/~widelands-dev/widelands/sphinx_changes/+merge/304751 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/sphinx_changes into lp:widelands. ___ Maili

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/adjusted_README into lp:widelands-website

2016-09-04 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/adjusted_README into lp:widelands-website. Commit message: Adjusted README: - Added making "widelands developer documentation" - Added Paragraph for python version Requested reviews: Widelands Developers (widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/adjusted_README into lp:widelands-website

2016-09-04 Thread kaputtnik
Thanks :-) Merged. -- https://code.launchpad.net/~widelands-dev/widelands-website/adjusted_README/+merge/304860 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/compile_switches into lp:widelands

2016-09-05 Thread kaputtnik
Can we add something like "-h" (or --help), saying which options could be set? As a reminder it would be nice to have an output at the end of compiling saying: This build was created with options: - (Release) Debug build - (No) Website related stuff - (No) Translations -- https://code.launchpa

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/sphinx_changes into lp:widelands

2016-09-06 Thread kaputtnik
Review: Approve testing I just found a typo in https://wl.widelands.org/docs/wl/autogen_wl_map/#wl.map.Field.has_caps aka http://bazaar.launchpad.net/~widelands-dev/widelands/trunk/view/head:/src/scripting/lua_map.cc#L5298 swimable -> swimmable -- https://code.launchpad.net/~widelands-dev

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1616661_messagebox_hotkeys into lp:widelands

2016-09-09 Thread kaputtnik
The proposal to merge lp:~widelands-dev/widelands/bug-1616661_messagebox_hotkeys into lp:widelands has been updated. Commit Message changed to: Change the hotkeys used in message box to filter messages from [1..5] to Alt + [1...5] For more details, see: https://code.launchpad.net/~widelands-d

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1616661_messagebox_hotkeys into lp:widelands

2016-09-09 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands/bug-1616661_messagebox_hotkeys into lp:widelands. Commit message: Change the hotkeys used in message box to filter messages from [1..5] to Alt + [1...5] Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1616661_messagebox_hotkeys into lp:widelands

2016-09-10 Thread kaputtnik
> The message button access doesn't work on Ubuntu. Pressing "n"? Clicking the "Message" button? Those work here on arch-linux. Until tomorrow i am away for 14 days so if something goes wrong with this branch feel free to change it. -- https://code.launchpad.net/~widelands-dev/widelands/bug-161

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1616661_messagebox_hotkeys into lp:widelands

2016-09-10 Thread kaputtnik
Until -> As from tomorrow :-S -- https://code.launchpad.net/~widelands-dev/widelands/bug-1616661_messagebox_hotkeys/+merge/305381 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1616661_messagebox_hotkeys. ___ Mai

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/sphinx-tribes into lp:widelands

2016-09-26 Thread kaputtnik
Review: Approve testing Extracts fine and sphinx-build found no failures. I have just a question about the tabbing: If a table is used as parameter, the table entries are at the same column as the "Parameters" entry. Wouldn't it be better to have the "Table"-entries indented? Example image: h

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/changed_terrains_River_Explorers into lp:widelands

2016-09-27 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands/changed_terrains_River_Explorers into lp:widelands. Commit message: Changed terrain for blue player to let him be able to get wood. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1627948 in widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-536489-dropdown into lp:widelands

2016-09-28 Thread kaputtnik
Review: Needs Fixing I get a crash as soon i click on one of the dropdown menus in options: src/ui_basic/panel.h:265: bool UI::Panel::has_focus() const: Assertion `get_can_focus()' failed. Backtrace: https://bugs.launchpad.net/widelands/+bug/536489/+attachment/4750279/+files/backtrace.txt --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-536489-dropdown into lp:widelands

2016-09-30 Thread kaputtnik
Review: Needs Fixing Thanks for fixing the crash :-) The checkmark is IMHO good now. But clicking on the vertical slider in Options->Language let the drop down menu disappear. -- https://code.launchpad.net/~widelands-dev/widelands/bug-536489-dropdown/+merge/306303 Your team Widelands Develo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-536489-dropdown into lp:widelands

2016-10-01 Thread kaputtnik
One little thing: If the dropdown box is once opened and closed (with moving away the mouse pointer) and hitting the down arrow of the keyboard, the dropdownmenu sometimes pops up for little time. Best to see if you keep the down arrow down for a longer time. Not really an issue, so i leave it

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-536489-dropdown into lp:widelands

2016-10-02 Thread kaputtnik
Review: Approve testing Great :-) -- https://code.launchpad.net/~widelands-dev/widelands/bug-536489-dropdown/+merge/306303 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-536489-dropdown. ___ Mailing list: https

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-536489-dropdown into lp:widelands

2016-10-05 Thread kaputtnik
> One possible eye candy > nit/improvement could be a small line outside of the drop down at the bottom > and the sides - to connect the drop down better with the original button. +1 (i thought something like this also) -- https://code.launchpad.net/~widelands-dev/widelands/bug-536489-dropdown/+m

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam into lp:widelands-website

2016-10-06 Thread kaputtnik
Hm, the diff is truncated... maybe remove the akismet api? -- https://code.launchpad.net/~widelands-dev/widelands-website/anti_spam/+merge/307869 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/anti_spam into lp:widelands-website. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-536489-dropdown into lp:widelands

2016-10-06 Thread kaputtnik
Looks better now. Have you tested showing it flattened instead of raised? -- https://code.launchpad.net/~widelands-dev/widelands/bug-536489-dropdown/+merge/306303 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-536489-dropdown. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam into lp:widelands-website

2016-10-06 Thread kaputtnik
Just a thought of last night: Change the Text of the redirect page saying that EACH Post is hided now and will be moderated. So if the spammers ever read this, they should assume that spamming has no chance here. If a non spammer read this (i guess this would be very rare, if it ever comes up)

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam into lp:widelands-website

2016-10-08 Thread kaputtnik
Just short answers because i am in hurry: > 1) Is it necessary that we ship the askimet client in our repo, i.e. can it > not be installed wia pip_requirements.txt? I don't why i am downloaded the complete zip file, whereas one could also download the py-file (containing all classes and function

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam into lp:widelands-website

2016-10-08 Thread kaputtnik
There is a akismet Pypi package, so we could easily add this to pip_requirements.txt. > > 5) You are marking any post of a user with 'ji' in its name as SPAM. Is that > > not a bit too broad? > > Yes, maybe change it into ' ji ' or ' ji' Correcting: 'ji' is only used for topic names (subject)

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam into lp:widelands-website

2016-10-09 Thread kaputtnik
Merged and deployed. -- https://code.launchpad.net/~widelands-dev/widelands-website/anti_spam/+merge/307869 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to :

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_2 into lp:widelands-website

2016-10-10 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/anti_spam_2 into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands-website/anti_spam_2/+merge/308074 - Fix Latest Posts

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_2 into lp:widelands-website

2016-10-11 Thread kaputtnik
Review: Resubmit Yes, thanks for pointing me on this :-) Sometimes i think too complicated... -- https://code.launchpad.net/~widelands-dev/widelands-website/anti_spam_2/+merge/308074 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_2 into lp:widelands-website

2016-10-12 Thread kaputtnik
Thanks, merged and deployed. Beside the blank line i have also changed the anti_spam lists in local_settings.py.sample to ['spam']. Otherwise they will always come true. -- https://code.launchpad.net/~widelands-dev/widelands-website/anti_spam_2/+merge/308074 Your team Widelands Developers is sub

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_REMOTE_ADDR into lp:widelands-website

2016-10-13 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/fix_REMOTE_ADDR into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands-website/fix_REMOTE_ADDR/+merge/308337 Fixes getting

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_REMOTE_ADDR into lp:widelands-website

2016-10-15 Thread kaputtnik
Thanks for pointing me to dict.get() i am too stupid :-S Regarding the tracking app: It's just my personal view... i don't like shipping an app with the widelands code when much code of it is potentially unused. 'Potentially' because i didn't took a closer look into it, just made it work fo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_REMOTE_ADDR into lp:widelands-website

2016-10-17 Thread kaputtnik
I have chosen an easier to remember IP: 192.168.255.255 and added a comment. Django is sometimes really annoying: I have spend now several hours because the rating of maps didn't work anymore. Django showed no errors in debug mode but in console i could see a http500 every time i tried to rate a

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/dev_doc_css into lp:widelands-website

2016-10-18 Thread kaputtnik
Review: Approve Thanks :-) Approved and merged. I will deploy this with the rempte_ADDR branch this evening. -- https://code.launchpad.net/~widelands-dev/widelands-website/dev_doc_css/+merge/308710 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_REMOTE_ADDR into lp:widelands-website

2016-10-18 Thread kaputtnik
Merged and deployed now -- https://code.launchpad.net/~widelands-dev/widelands-website/fix_REMOTE_ADDR/+merge/308337 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_3 into lp:widelands-website

2016-10-24 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/anti_spam_3 into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1614403 in Widelands Website: "Ideas to prevent spammers, make their work harder" https://bugs.lau

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_3 into lp:widelands-website

2016-10-24 Thread kaputtnik
The proposal to merge lp:~widelands-dev/widelands-website/anti_spam_3 into lp:widelands-website has been updated. Description changed to: A bunch of changes: - Moved the spam check from pybb.views.py to pybb.forms.py - Prevent e-mails and notifications to users if spam is detected - Instead inf

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_3 into lp:widelands-website

2016-10-25 Thread kaputtnik
> Instead of sending an email immediately and for each post, how about adding a > django command that sends an email if there are hidden posts every night. That > way even us admins would not be drowned by the SPAM and we could delete > accordingly. Yes that would be good if all hidden posts are r

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_3 into lp:widelands-website

2016-10-26 Thread kaputtnik
Sounds good to me. I guess doing this would be better if we move the spam check to an own directory/app. So the spam check could also be done like is_spam = check_spam(text_to_check) if is_spam: do something This is then independent from pybb and could be used also for the wiki But not in t

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/oars_appdata into lp:widelands/build19

2016-10-28 Thread kaputtnik
The diff shows much more changes than the appdata... i guess this is not the one that should go into build19? -- https://code.launchpad.net/~widelands-dev/widelands/oars_appdata/+merge/309600 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/wideland

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_4 into lp:widelands-website

2016-10-30 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/anti_spam_4 into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1614403 in Widelands Website: "Ideas to prevent spammers, make their work harder" https://bugs.lau

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fs-tile-background into lp:widelands

2016-10-31 Thread kaputtnik
> Oh, placeholder? Thats looks definitely better than just "placeholder" ;). > > I really like this change! dito :-) -- https://code.launchpad.net/~widelands-dev/widelands/fs-tile-background/+merge/309673 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fs-tile

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/prevent_ai_deadlocks into lp:widelands/build19

2016-11-01 Thread kaputtnik
I think Tibor is right. Even if there are posts in the forum we have no bugreprot for this issue. And from my point of view bug reports are the things to go. The mentioned failure isn't such a show stopper as some users meant it is and it's quite worth for working on if there is no bug report.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_changelog_for_website into lp:widelands

2016-11-04 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands/fix_changelog_for_website into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/fix_changelog_for_website/+merge/310085 Removed invalid

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_changelog_for_website into lp:widelands

2016-11-04 Thread kaputtnik
Review: Resubmit > Can you replace the character with a straight quote please? Removing it causes > a grammar error. Done. > And we should label it Build 19-rc1 Feel free to do so. The views on the website depends on trunk as i know, so there is no need to have it in build19. At least if this

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_changelog_for_website into lp:widelands

2016-11-05 Thread kaputtnik
Review: Resubmit Done -- https://code.launchpad.net/~widelands-dev/widelands/fix_changelog_for_website/+merge/310085 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix_changelog_for_website. ___ Mailing list: https:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_changelog_for_website into lp:widelands

2016-11-05 Thread kaputtnik
The proposal to merge lp:~widelands-dev/widelands/fix_changelog_for_website into lp:widelands has been updated. Commit Message changed to: Removed invalid character; Formatting For more details, see: https://code.launchpad.net/~widelands-dev/widelands/fix_changelog_for_website/+merge/310085 --

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/sitemap into lp:widelands-website

2016-11-08 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/sitemap into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #358452 in Widelands Website: "Sitemap.xml is missing" https://bugs.launchpad.net/widelands-website/+

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/auto_one_to_one_ractivating into lp:widelands-website

2016-11-14 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/auto_one_to_one_ractivating into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands-website/auto_one_to_one_ractivating

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/auto_one_to_one_ractivating into lp:widelands-website

2016-11-14 Thread kaputtnik
The proposal to merge lp:~widelands-dev/widelands-website/auto_one_to_one_ractivating into lp:widelands-website has been updated. Description changed to: Another issue from the update to django 1.8: Formerly to django 1.8 entrys to the database of wlprofile and wlggz has been created on deman

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/anti_spam_4 into lp:widelands-website

2016-11-14 Thread kaputtnik
Thanks :-) Merged, deployed and added the management command to /etc/cron.daily/django_regular_commands -- https://code.launchpad.net/~widelands-dev/widelands-website/anti_spam_4/+merge/309642 Your team Widelands Developers is subscribed to branch lp:widelands-website. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/auto_one_to_one_ractivating into lp:widelands-website

2016-11-15 Thread kaputtnik
The @atomic decorator is only used with transactions, which depends on - the version of database - the capability of the Database - table engine of the Database - the settings of a database. As far as i know we doesn't use transactions in our code and trust to the django default Autocommit mod

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/auto_one_to_one_ractivating into lp:widelands-website

2016-11-15 Thread kaputtnik
Related to your code comment: Yes it was a failure during the conflict resolving. Merged and deployed. Hopefully all is working now... -- https://code.launchpad.net/~widelands-dev/widelands-website/auto_one_to_one_ractivating/+merge/310813 Your team Widelands Developers is subscribed to branch l

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/sitemap into lp:widelands-website

2016-11-18 Thread kaputtnik
Review: Resubmit I have failed with the last merge conflict, causing the missing entry 'django.contrib.sitemaps' in installed apps :-S. But this is fixed now. -- https://code.launchpad.net/~widelands-dev/widelands-website/sitemap/+merge/310261 Your team Widelands Developers is subscribed to br

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/news_rework into lp:widelands-website

2016-11-20 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/news_rework into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1640881 in Widelands Website: "News drafts show in news archive" https://bugs.launchpad.net/widelan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/sitemap into lp:widelands-website

2016-11-22 Thread kaputtnik
merged and committed. Thanks for the review :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/sitemap/+merge/310261 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~w

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/wlimages_rework into lp:widelands-website

2016-11-28 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/wlimages_rework into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1523256 in Widelands Website: "Uploading images with uppercase letters cause server error&quo

Re: [Widelands-dev] [Merge] lp:~janus-jhor/widelands-website/unread_read_outbox_messages into lp:widelands-website

2016-11-28 Thread kaputtnik
Funktioniert :-) Ist nur ein bisschen unklar warum das Kursiv dargestellt wird. Evtll einen Tooltip per title="Recipient hasn't read this post yet." einfügen? Gibt ne kleine Erklärung... -- https://code.launchpad.net/~janus-jhor/widelands-website/unread_read_outbox_messages/+merge/311994 Your t

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/wlimages_rework into lp:widelands-website

2016-11-29 Thread kaputtnik
Thanks for looking into it :-) Regarding to 'imagename = forms.ImageField(max_length=90)' 'imagename' is needed for the function (added also a comment there): def clean_imagename( self ): # clean_() acts only for this specific field Django uses theses kind of things in some places..

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/wlimages_rework into lp:widelands-website

2016-11-29 Thread kaputtnik
I am often unsure where to put related comments, below or on top of the related line. For 'if' statements its better below, but for normal lines of code like here i am unsure. -- https://code.launchpad.net/~widelands-dev/widelands-website/wlimages_rework/+merge/311985 Your team Widelands Develop

Re: [Widelands-dev] [Merge] lp:~janus-jhor/widelands-website/unread_read_outbox_messages into lp:widelands-website

2016-11-29 Thread kaputtnik
Diese Kleinigkeit brauchst Du doch nur in diesem branch ändern... -- https://code.launchpad.net/~janus-jhor/widelands-website/unread_read_outbox_messages/+merge/311994 Your team Widelands Developers is requested to review the proposed merge of lp:~janus-jhor/widelands-website/unread_read_outbox_m

Re: [Widelands-dev] [Merge] lp:~janus-jhor/widelands-website/unread_read_outbox_messages into lp:widelands-website

2016-11-30 Thread kaputtnik
Review: Approve Prima :-) -- https://code.launchpad.net/~janus-jhor/widelands-website/unread_read_outbox_messages/+merge/311994 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widel

Re: [Widelands-dev] [Merge] lp:~janus-jhor/widelands-website/unread_read_outbox_messages into lp:widelands-website

2016-11-30 Thread kaputtnik
Review: Approve -- https://code.launchpad.net/~janus-jhor/widelands-website/unread_read_outbox_messages/+merge/311994 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev P

Re: [Widelands-dev] [Merge] lp:~janus-jhor/widelands-website/unread_read_outbox_messages into lp:widelands-website

2016-11-30 Thread kaputtnik
Merged and deployed. Die Änderung ist online. Danke :-) -- https://code.launchpad.net/~janus-jhor/widelands-website/unread_read_outbox_messages/+merge/311994 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_map_upload into lp:widelands-website

2016-12-01 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/fix_map_upload into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1533789 in Widelands Website: "Upload of Map with German Umlaut fails" https://bugs.lau

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix_map_upload into lp:widelands-website

2016-12-01 Thread kaputtnik
This fix worked with the map 'Schrägland.wmf' but not with the map 'Hier ein bößes Beispiel.wmf'. I have reverted the changes. -- https://code.launchpad.net/~widelands-dev/widelands-website/fix_map_upload/+merge/312300 Your team Widelands Developers is subscribed to branch lp:widelands-website.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/pyformat_util into lp:widelands-website

2016-12-05 Thread kaputtnik
Is this meant to run with python3 or python2? I put some comments in the diff. Diff comments: > === added directory 'utils' > === added file 'utils/fix_formatting.py' > --- utils/fix_formatting.py 1970-01-01 00:00:00 + > +++ utils/fix_formatting.py 2016-12-04 06:57:43 + > @@ -0,0 +1,

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/pyformat_util into lp:widelands-website

2016-12-05 Thread kaputtnik
Ah, forgotton: Wouldn't it be better to have this script in the _ops directory? -- https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/pyformat_util

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/news_rework into lp:widelands-website

2016-12-05 Thread kaputtnik
Thanks :-) Merged and deployed. -- https://code.launchpad.net/~widelands-dev/widelands-website/news_rework/+merge/311345 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-de

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/news_rework into lp:widelands-website

2016-12-05 Thread kaputtnik
Because of coloring: Please try hitting F5 (reload) several times because the browser loads the css from his cache. It should like in theses screenshots: https://launchpadlibrarian.net/294049360/news_new_01.png I will change the string in the wlimages_rework branch, which i want to deploy soon.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/news_rework into lp:widelands-website

2016-12-05 Thread kaputtnik
There where some server errors, because two posts from year 2013 had the same slug. I fixed this over the admin page by changing the slug of one of them according to the title. -- https://code.launchpad.net/~widelands-dev/widelands-website/news_rework/+merge/311345 Your team Widelands Develope

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/pyformat_util into lp:widelands-website

2016-12-06 Thread kaputtnik
I think '_ops' is meant as 'operators', or as https://de.wikipedia.org/wiki/Ops ? In both cases it would fit to have this script in '_ops', i believe :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427 Your team Widelands Developers is requested to revi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/wlimages_rework into lp:widelands-website

2016-12-06 Thread kaputtnik
I guess we will have here the same issue with german umlauts as we have for the maps uploads (bug 1533789) But the bug with umlauts has to be solved on the server side, imho. I merge and deploy this branch tomorrow. -- https://code.launchpad.net/~widelands-dev/widelands-website/wlimages_rework

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/wlimages_rework into lp:widelands-website

2016-12-07 Thread kaputtnik
Merged and deployed. Thanks for the review :-) I just found another bug though: Trying uploading images with umlauts fails, like with the maps. The bad thing is that such an image is stored in the database, but not on disk. The admin action "Delete image including file" does not work in this c

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/safe_map_upload into lp:widelands-website

2016-12-08 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/safe_map_upload into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1533789 in Widelands Website: "Upload of Map with German Umlaut fails" https://bugs.lau

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/safe_map_upload into lp:widelands-website

2016-12-08 Thread kaputtnik
Review: Needs Fixing Ups, just triggered some server errors when trying to post something in the forum... -- https://code.launchpad.net/~widelands-dev/widelands-website/safe_map_upload/+merge/312866 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/safe_map_upload into lp:widelands-website

2016-12-08 Thread kaputtnik
hm, on alpha must be more broken... disabling the export causes also server errors when trying to post something in the forum. But i coudn't find the reason yet. Even got no emails about the error. -- https://code.launchpad.net/~widelands-dev/widelands-website/safe_map_upload/+merge/312866 You

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/safe_map_upload into lp:widelands-website

2016-12-09 Thread kaputtnik
Review: Resubmit All ok now, i just forgot to add the anti spam keywords to local_settings.py ... :-D -- https://code.launchpad.net/~widelands-dev/widelands-website/safe_map_upload/+merge/312866 Your team Widelands Developers is subscribed to branch lp:widelands-website. __

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/hotspot_fixes into lp:widelands

2016-12-09 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands/hotspot_fixes into lp:widelands. Commit message: Revert the changes introduced with bzr 8205 causing the hotspot of the flag in buildhelp get centered. Additionally adapted the hotspot of atlantean tower and hightower. Requested

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/safe_map_upload into lp:widelands-website

2016-12-09 Thread kaputtnik
Yes i switched it of. As soon this site is online it is scanned by some web spiders... Please ask if i should switch it on again, or do it by yourself by running "sudo start alpha" and afterwards "sudo stop alpha". For further questions: I am on IRC for some hours, but have to cleanup my rooms

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/safe_map_upload into lp:widelands-website

2016-12-10 Thread kaputtnik
Thanks for testing :-) For some reason i get no emails if a server error occurs on the alpha site... I looked into it and this caused by mysql, more explicit: by the way mysql stores information to the database. mysql has also settings regarding the character set and how string comparison is ex

Re: [Widelands-dev] [Merge] lp:~janus-jhor/widelands-website/switch_to_settings into lp:widelands-website

2016-12-10 Thread kaputtnik
Review: Needs Fixing Bitte auch in local_settings.py.sample mit einem dummy regex eintragen. Ansonsten gibts einen Fehler, wenn jemand den code neu herunterlädt und wie in der README beschrieben den code installiert. Siehe z.B.: http://bazaar.launchpad.net/~janus-jhor/widelands-website/switch_

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/pyformat_util into lp:widelands-website

2016-12-10 Thread kaputtnik
Review: Approve Runs with python3 and python2 now. :-) I don't know why the PYTHON3=... is still in there? Maybe i miss something here? -- https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427 Your team Widelands Developers is subscribed to branch lp:widelands-w

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/safe_map_upload into lp:widelands-website

2016-12-10 Thread kaputtnik
This is merged and deployed, but it does not work on wlwebsite... https://wl.widelands.org/locale/ is showing always ANSI for fs-type :-( -- https://code.launchpad.net/~widelands-dev/widelands-website/safe_map_upload/+merge/312866 Your team Widelands Developers is subscribed to branch lp:widelan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/safe_map_upload into lp:widelands-website

2016-12-10 Thread kaputtnik
Hm.. the map Schrägland could be uploaded, but not the others with strange names. But then a error message is shown, no server error... So the bug is half fixed... -- https://code.launchpad.net/~widelands-dev/widelands-website/safe_map_upload/+merge/312866 Your team Widelands Developers is subsc

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/safe_map_upload into lp:widelands-website

2016-12-10 Thread kaputtnik
> Do we not need to call locale.setlocale? Hm, i don't know. Calling this isn't done on alpha (where it works), so there must another issue. -- https://code.launchpad.net/~widelands-dev/widelands-website/safe_map_upload/+merge/312866 Your team Widelands Developers is subscribed to branch lp:wide

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/hotspot_fixes into lp:widelands

2016-12-10 Thread kaputtnik
I think is good to go. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/hotspot_fixes/+merge/312896 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/hotspot_fixes. ___ Mailing list: https://launc

[Widelands-dev] [Merge] lp:~janus-jhor/widelands-website/switch_to_settings into lp:widelands-website

2016-12-10 Thread kaputtnik
The proposal to merge lp:~janus-jhor/widelands-website/switch_to_settings into lp:widelands-website has been updated. Status: Merged => Approved For more details, see: https://code.launchpad.net/~janus-jhor/widelands-website/switch_to_settings/+merge/312957 -- Your team Widelands Developers

Re: [Widelands-dev] [Merge] lp:~janus-jhor/widelands-website/switch_to_settings into lp:widelands-website

2016-12-10 Thread kaputtnik
merged and deployed -- https://code.launchpad.net/~janus-jhor/widelands-website/switch_to_settings/+merge/312957 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to

[Widelands-dev] [Merge] lp:~janus-jhor/widelands-website/switch_to_settings into lp:widelands-website

2016-12-11 Thread kaputtnik
The proposal to merge lp:~janus-jhor/widelands-website/switch_to_settings into lp:widelands-website has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~janus-jhor/widelands-website/switch_to_settings/+merge/312957 -- Your team Widelands Developers

Re: [Widelands-dev] [Merge] lp:~janus-jhor/widelands-website/switch_to_settings into lp:widelands-website

2016-12-12 Thread kaputtnik
Doch, habe ich. Allerdings musste ich den branch erst noch mit trunk mergen, da Janus keine Lust dazu hatte. Evtll hat bzr das nicht gecheckt, das ich den branch hier zu Hause pepusht habe. Auf https://code.launchpad.net/widelands-website steht er auch in der Spalte 'Last Commit'. Ich habe ihn

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/reset_zoom_button into lp:widelands

2016-12-12 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands/reset_zoom_button into lp:widelands. Commit message: modified reset_zoom_button Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/reset_zoom_button

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/pyformat_util into lp:widelands-website

2016-12-13 Thread kaputtnik
Merged with trunk, ran the script, merged into trunk, deployed. Thanks for the tool :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/pyformat_util/+merge/312427 Your team Widelands Developers is subscribed to branch lp:widelands-website.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/forum_list into lp:widelands-website

2016-12-15 Thread kaputtnik
kaputtnik has proposed merging lp:~widelands-dev/widelands-website/forum_list into lp:widelands-website. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands-website/forum_list/+merge/313357 Removed hard coded

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/forum_list into lp:widelands-website

2016-12-15 Thread kaputtnik
The number of digits doesn't matter. Having different values makes sure the ordering is properly set. Thanks for the review :) I'll make another test on my Laptop and merge this then. -- https://code.launchpad.net/~widelands-dev/widelands-website/forum_list/+merge/313357 Your team Widelands De

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/forum_list into lp:widelands-website

2016-12-15 Thread kaputtnik
Merged and deployed. -- https://code.launchpad.net/~widelands-dev/widelands-website/forum_list/+merge/313357 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net/~widelands-dev Post to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/forum_list into lp:widelands-website

2016-12-15 Thread kaputtnik
And thanks for preparing the position values :-) -- https://code.launchpad.net/~widelands-dev/widelands-website/forum_list/+merge/313357 Your team Widelands Developers is subscribed to branch lp:widelands-website. ___ Mailing list: https://launchpad.net

<    1   2   3   4   5   6   7   8   9   10   >