[Widelands-dev] [Bug 531659] Re: regression: no sound played at message arrival

2010-03-04 Thread SirVer
** Branch unlinked: lp:widelands ** Branch unlinked: lp:widelands/build15 -- regression: no sound played at message arrival https://bugs.launchpad.net/bugs/531659 You received this bug notification because you are a member of Widelands Developers, which is subscribed to widelands. Status in Wid

[Widelands-dev] [Bug 530836] Re: game crash, if host is spectator and there is no player 1

2010-03-04 Thread SirVer
** Branch unlinked: lp:widelands/build15 -- game crash, if host is spectator and there is no player 1 https://bugs.launchpad.net/bugs/530836 You received this bug notification because you are a member of Widelands Developers, which is subscribed to widelands. Status in Widelands: Confirmed Statu

[Widelands-dev] [Bug 531856] [NEW] cmake builds locales each time make is executed

2010-03-04 Thread SirVer
*** This bug is a duplicate of bug 531857 *** https://bugs.launchpad.net/bugs/531857 Public bug reported: on Mac OS X 10.6 ** Affects: widelands Importance: Low Status: Confirmed ** Changed in: widelands Status: New => Confirmed ** Changed in: widelands Importance:

[Widelands-dev] [Bug 531857] [NEW] cmake builds locales each time make is executed

2010-03-04 Thread SirVer
Public bug reported: on Mac OS X 10.6 ** Affects: widelands Importance: High Assignee: Jens Beyer (Qcumber-some) (qcumber-some) Status: Confirmed ** Tags: buildsystem cmake ** Changed in: widelands Status: New => Confirmed ** Changed in: widelands Importance: Unde

[Widelands-dev] [Bug 531857] Re: cmake builds locales each time make is executed

2010-03-04 Thread SirVer
as a matter of fact, cmake should not build locales at all for debug builds, only for releases. -- cmake builds locales each time make is executed https://bugs.launchpad.net/bugs/531857 You received this bug notification because you are a member of Widelands Developers, which is subscribed to wid

[Widelands-dev] [Bug 530767] Re: game crashes/assertion failure

2010-03-04 Thread SirVer
** Tags added: crash military -- game crashes/assertion failure https://bugs.launchpad.net/bugs/530767 You received this bug notification because you are a member of Widelands Developers, which is subscribed to widelands. Status in Widelands: Confirmed Bug description: I was playing. then when

[Widelands-dev] [Bug 530767] Re: game crashes/assertion failure

2010-03-05 Thread SirVer
** Changed in: widelands Importance: Undecided => Critical ** Changed in: widelands Milestone: None => build15-rc1 -- game crashes/assertion failure https://bugs.launchpad.net/bugs/530767 You received this bug notification because you are a member of Widelands Developers, which is subscri

[Widelands-dev] [Bug 530648] Re: Move sf.net bug tracker to launchpad

2010-03-05 Thread SirVer
** Changed in: widelands Status: Confirmed => In Progress -- Move sf.net bug tracker to launchpad https://bugs.launchpad.net/bugs/530648 You received this bug notification because you are a member of Widelands Developers, which is subscribed to widelands. Status in Widelands: In Progress

[Widelands-dev] [Bug 530892] Re: Remove SCons files from build15 branch

2010-03-05 Thread SirVer
** Changed in: widelands/build15 Importance: Undecided => Critical ** Changed in: widelands Importance: Undecided => Low ** Tags added: buildsystem -- Remove SCons files from build15 branch https://bugs.launchpad.net/bugs/530892 You received this bug notification because you are a member

[Widelands-dev] [Bug 530836] Re: game crash, if host is spectator and there is no player 1

2010-03-05 Thread SirVer
** Changed in: widelands Milestone: None => build15-rc1 ** Changed in: widelands/build15 Milestone: None => build15-rc1 ** Changed in: widelands Importance: Undecided => Critical ** Changed in: widelands/build15 Importance: Undecided => Critical -- game crash, if host is spectato

[Widelands-dev] [Bug 531659] Re: regression: no sound played at message arrival

2010-03-05 Thread SirVer
** Changed in: widelands/build15 Importance: Undecided => Medium ** Changed in: widelands/trunk Importance: Undecided => Medium -- regression: no sound played at message arrival https://bugs.launchpad.net/bugs/531659 You received this bug notification because you are a member of Widelands

[Widelands-dev] [Bug 531037] Re: Defending soliders don't join the fighting

2010-03-05 Thread SirVer
Is there some knowledge over this bug already in the sf.net bug tracker? Is this a needed target for build15? It doesn't sound like a totally crucially bad bug that you can't have joy with. ** Changed in: widelands Importance: Undecided => Medium ** Tags added: military ** Changed in: widelan

[Widelands-dev] [Bug 531037] Re: Defending soliders don't join the fighting

2010-03-05 Thread SirVer
confirmed, happens for me too. -- Defending soliders don't join the fighting https://bugs.launchpad.net/bugs/531037 You received this bug notification because you are a member of Widelands Developers, which is subscribed to widelands. Status in Widelands: Confirmed Bug description: Computer pla

[Widelands-dev] [Bug 534235] [NEW] SCons should define -DHAVE_VARARRAY on gcc tool chain

2010-03-08 Thread SirVer
Public bug reported: This is due to Jaris VC++ branch which uses this to avoid using auto pointers in some places. I have not checked, maybe scons already defines this, so somebody just needs to check this or add it to the build environment ** Affects: widelands Importance: Low Stat

[Widelands-dev] [Bug 530646] Re: Idle military people

2010-03-08 Thread SirVer
I can't follow Timowi. If this bug can't/won't reappear in game, close it. If not, leave it open. -- Idle military people https://bugs.launchpad.net/bugs/530646 You received this bug notification because you are a member of Widelands Developers, which is subscribed to widelands. Status in Widela

[Widelands-dev] [Bug 535271] Re: revision detection on macosx broken

2010-03-09 Thread SirVer
running svk asks a question which is not shown on stdout. This is why it seems to run forever. One quickfix is to run svk co -l once and allow it to create its directory. The proper fix for this is off course to remove svk support from scons. With bzr there is no more need for svk. I would leave g

[Widelands-dev] [Bug 535271] Re: revision detection on macosx broken

2010-03-10 Thread SirVer
the way to go is to remove svn & svk support from *both* detect_revisions script. ** Changed in: widelands Status: Confirmed => Triaged -- revision detection on macosx broken https://bugs.launchpad.net/bugs/535271 You received this bug notification because you are a member of Widelands De

[Widelands-dev] [Bug 530646] Re: Idle military people

2010-03-10 Thread SirVer
I set this to triaged since a suitable solution was proposed. Someone can start on it then. ** Changed in: widelands Status: Confirmed => Triaged -- Idle military people https://bugs.launchpad.net/bugs/530646 You received this bug notification because you are a member of Widelands Develop

[Widelands-dev] [Bug 536016] Re: soldiers keep finding opponents when mission is accomplished

2010-03-10 Thread SirVer
Why don't you close it then? -- soldiers keep finding opponents when mission is accomplished https://bugs.launchpad.net/bugs/536016 You received this bug notification because you are a member of Widelands Developers, which is subscribed to widelands. Status in Widelands: New Bug description: Wh

[Widelands-dev] [Bug 536016] Re: soldiers keep finding opponents when mission is accomplished

2010-03-10 Thread SirVer
There has been recent changes in the code that makes soldiers more clever. This can be considered fixed by them. ** Changed in: widelands Status: Invalid => Fix Committed -- soldiers keep finding opponents when mission is accomplished https://bugs.launchpad.net/bugs/536016 You received th

[Widelands-dev] [Bug 530648] Re: Move sf.net bug tracker to launchpad

2010-03-10 Thread SirVer
** Changed in: widelands Status: In Progress => Fix Released -- Move sf.net bug tracker to launchpad https://bugs.launchpad.net/bugs/530648 You received this bug notification because you are a member of Widelands Developers, which is subscribed to widelands. Status in Widelands: Fix Relea

Re: [Widelands-dev] [Merge] lp:~ab-tools/widelands/minimap into lp:widelands

2010-06-20 Thread SirVer
is this working with the opengl renderer as well? -- https://code.launchpad.net/~ab-tools/widelands/minimap/+merge/27998 Your team Widelands Developers is requested to review the proposed merge of lp:~ab-tools/widelands/minimap into lp:widelands. ___ M

Re: [Widelands-dev] [Merge] lp:~ab-tools/widelands/minimap into lp:widelands

2010-06-21 Thread SirVer
I somewhat dislike the borders. They are quite ugly (no offense meant, they just disturb the beauty of the map) and are somewhat arbitrary: the location of the borders have no special for widelands-the-game (and only internal meaning for for widelands-the-engine). And I'd prefer a special graphi

Re: [Widelands-dev] [Merge] lp:~ab-tools/widelands/minimap into lp:widelands

2010-06-21 Thread SirVer
I'd much prefer it, it also feels more logical to me. But it like to put this to a vote. Are others okay with this? +1 for visible screen area in minimap -1 for map borders in minimap -- https://code.launchpad.net/~ab-tools/widelands/minimap/+merge/27998 Your team Widelands Developers is reques

Re: [Widelands-dev] [Merge] lp:~ab-tools/widelands/minimap into lp:widelands

2010-07-12 Thread SirVer
The g_gr object might be what you are looking for. Alternativly you can also access the MapView object of InteractiveBase. -- https://code.launchpad.net/~ab-tools/widelands/minimap/+merge/27998 Your team Widelands Developers is requested to review the proposed merge of lp:~ab-tools/widelands/min

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-bug-582561 into lp:widelands

2010-08-02 Thread SirVer
I approve of the os.popen chance. I trust that the Xcode work around is necessary as I have no experience there :). Applied in r5456. -- https://code.launchpad.net/~widelands-dev/widelands/fix-bug-582561/+merge/31001 Your team Widelands Developers is requested to review the proposed merge of l

Re: [Widelands-dev] [Merge] lp:~ab-tools/widelands/minimap into lp:widelands

2010-10-05 Thread SirVer
2 pixels for me! -- https://code.launchpad.net/~ab-tools/widelands/minimap/+merge/27998 Your team Widelands Developers is requested to review the proposed merge of lp:~ab-tools/widelands/minimap into lp:widelands. ___ Mailing list: https://launchpad.ne

Re: [Widelands-dev] [Merge] lp:~ab-tools/widelands/minimap into lp:widelands

2010-10-06 Thread SirVer
I prefer the red one! I think that it has the best contrast for all world tilesets. -- https://code.launchpad.net/~ab-tools/widelands/minimap/+merge/27998 Your team Widelands Developers is requested to review the proposed merge of lp:~ab-tools/widelands/minimap into lp:widelands. __

Re: [Widelands-dev] [Merge] lp:~ab-tools/widelands/minimap into lp:widelands

2010-10-17 Thread SirVer
merged. Thanks Andreas! -- https://code.launchpad.net/~ab-tools/widelands/minimap/+merge/38618 Your team Widelands Developers is requested to review the proposed merge of lp:~ab-tools/widelands/minimap into lp:widelands. ___ Mailing list: https://launc

Re: [Widelands-dev] [Merge] lp:~angreeone/widelands/trunk into lp:widelands

2010-11-16 Thread SirVer
Review: Needs Fixing the merge conflict: merge trunk into your branch: % bzr merge lp:widelands; fix the conflicts % bzr commit -m "Merged with trunk" About the quotation marks: we can simply let the translate one: function direct_speech(text) return rt( (_ '"%s"'):format(text))) end I th

Re: [Widelands-dev] [Merge] lp:~angreeone/widelands/trunk into lp:widelands

2010-11-16 Thread SirVer
have a look at at start of line = and > and read http://doc.bazaar.canonical.com/latest/en/user-reference/conflict-types-help.html -- https://code.launchpad.net/~angreeone/widelands/trunk/+merge/40936 Your team Widelands Developers is requested to review the propose

Re: [Widelands-dev] [Merge] lp:~angreeone/widelands/trunk into lp:widelands

2010-11-17 Thread SirVer
how about replacing tutorial with introduction for all three campaigns. They are not game tutorials (or maybe the barbarian first mission is), but introduction into the tribes backstory and economy. I think the atlantean campaign is comparable to the empire campaign: first mission is tutorial,

Re: [Widelands-dev] [Merge] lp:~angreeone/widelands/trunk into lp:widelands

2010-11-18 Thread SirVer
I merged this and change some stuff around in later revisions: 1) Some of the changes were not to my liking and I modified or reverted them in the texts. 2) removed all tutorial/introduction in cconfig, instead added the option to write a short difficulty description for each campaign. Added sen

Re: [Widelands-dev] [Merge] lp:~nha/widelands/fonthandler into lp:widelands

2011-01-31 Thread SirVer
Great work! I did only a very quick test though, but OpenGL and Software Rendering of Text areas worked for me. I tested with the atlantean scenario that contains plenty of text messages. One thing I noticed though is that the background of tooltips are yellow now; this makes the tooltips hard

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/martin_i18n into lp:widelands

2011-02-10 Thread SirVer
SirVer has proposed merging lp:~widelands-dev/widelands/martin_i18n into lp:widelands. Requested reviews: SirVer (sirver) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/martin_i18n/+merge/49202 Martin explored wesnoths code and duplicated their ideas to properly

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/martin_i18n into lp:widelands

2011-02-10 Thread SirVer
Review: Needs Fixing I applied martins code with some compile fixes for mac os x. I can report the following for Mac OS X: 1) If you manually set the locale to de, the game is properly localized 2) The locales list in the options menu does not show anything but the current locale (Deutsch), Engl

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/martin_i18n into lp:widelands

2011-02-10 Thread SirVer
Oh, I forgot: please test this branch before we merge it to trunk. We should get linux and windows testing at the very least. -- https://code.launchpad.net/~widelands-dev/widelands/martin_i18n/+merge/49202 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/martin_

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/martin_i18n into lp:widelands

2011-02-11 Thread SirVer
Review: Needs Information Okay, I found the problem with mac os x not filling the list: widelands checks in the CWD for the localedir and enumerates the locales it finds there but it tries to load the locales from the --localedir= commandline option. So things are a bit awkward - currently I can

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/martin_i18n into lp:widelands

2011-02-12 Thread SirVer
Martin, I added you to the list of developers in the martin_i18n branch. Your latest patch didn't apply to this branch, could you repost the diff based on the current tip of the martin_i18n branch? I have no idea about gettext and we have no specialist in this field in the team, otherwise we w

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/martin_i18n into lp:widelands

2011-02-13 Thread SirVer
I pulled your changes from the new branch to the martin_i18n branch to keep the history of commits intact. So the martin_i18n branch should contain your latest version now. Testing wise the issues on mac os x are unchanged but do not provide a problem (as clever packaging will solve all path re

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/martin_i18n into lp:widelands

2011-02-14 Thread SirVer
@Martin: you can delete the i18n branch, it will not interfere with this one. You can also keep it around, but set it to being inactive then please. -- https://code.launchpad.net/~widelands-dev/widelands/martin_i18n/+merge/49202 Your team Widelands Developers is subscribed to branch lp:~wideland

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/martin_i18n into lp:widelands

2011-02-18 Thread SirVer
Thanks a lot Martin and all testers! Makes me always warm and fuzzy when many work so nicely together on widelands. -- https://code.launchpad.net/~widelands-dev/widelands/martin_i18n/+merge/49202 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/martin_i18n. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/win32_glew into lp:widelands

2011-02-20 Thread SirVer
I have no time to review this right now, but this should definitivly go into build 16. I suggest merging right away and wait for the cries of others. -- https://code.launchpad.net/~widelands-dev/widelands/win32_glew/+merge/50529 Your team Widelands Developers is requested to review the proposed m

[Widelands-dev] [Bug 724344] Re: Security issue in sending files in network game

2011-03-14 Thread SirVer
how should we handle this? Should we issue a build 15 security update? build 15.1? I am against this, as builds are 'beta' by definition. I suggest informing our user base and push the update in build 16. This should also speed up adaption of build 16, nor? -- You received this bug notification

[Widelands-dev] [Bug 724344] Re: Security issue in sending files in network game

2011-03-14 Thread SirVer
Okay, so I suggest we pressure on with build 16. I'd suggest we post the security issue right away on the website as Jari suggested and also mention that build 16 will contain the fix. Only joining trusted games should not be a strong restriction. -- You received this bug notification because you

Re: [Widelands-dev] [Merge] lp:~hjd/widelands-website/valid-css into lp:widelands-website

2011-04-11 Thread SirVer
I will merge this as soon as I find a minute! Thanks. -- https://code.launchpad.net/~hjd/widelands-website/valid-css/+merge/53853 Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands-website/valid-css into lp:widelands-website. ___

Re: [Widelands-dev] [Merge] lp:~aber/widelands/deleteSomeFilesNow into lp:widelands

2011-05-01 Thread SirVer
I am sorry. I had planed to review this but failed utterly in remembering to do so... But I am confident that the changes are alright :) -- https://code.launchpad.net/~aber/widelands/deleteSomeFilesNow/+merge/58042 Your team Widelands Developers is requested to review the proposed merge of lp:~a

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/ware-data into lp:widelands

2011-06-17 Thread SirVer
those are error messages. I do not think they should be translated at all. Eg. a turkish user that would open a bug report with the translation of the error would not help me in any way to fix the problem. -- https://code.launchpad.net/~hjd/widelands/ware-data/+merge/63462 Your team Widelands De

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/adding-barriers-bug-787508 into lp:widelands

2011-08-20 Thread SirVer
I agree to your fixes. They have been merged to 5943. Sorry for taking ages again :/. -- https://code.launchpad.net/~hjd/widelands/adding-barriers-bug-787508/+merge/70653 Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/adding-barriers-bug-787508 into

Re: [Widelands-dev] [Merge] lp:~shevonar/widelands/fix-ware-positioning into lp:widelands

2011-09-14 Thread SirVer
Looking good, nice work! I am currently not in germany, therefore I can't merge this. I will put it on my list of TODOs and merge it in ~1-2 weeks. What name should I put onto the list of developers? -- https://code.launchpad.net/~shevonar/widelands/fix-ware-positioning/+merge/75190 Your team Wi

Re: [Widelands-dev] [Merge] lp:~borim/widelands/economyChart into lp:widelands

2011-11-06 Thread SirVer
Very clean implementation! I didn't play test it throughoutly yet but merged it to trunk for more test exposure. Great work! -- https://code.launchpad.net/~borim/widelands/economyChart/+merge/81408 Your team Widelands Developers is requested to review the proposed merge of lp:~borim/widelands/e

Re: [Widelands-dev] [Merge] lp:~nha/widelands/signals into lp:widelands

2011-11-21 Thread SirVer
I will test this on mac os x and report back. I am also pro killing our own signal stuff; in this sweep it would be nice to also get rid of "CallbackButton" and subcalssing Button for clicks and use signals there as well. -- https://code.launchpad.net/~nha/widelands/signals/+merge/82925 Your te

Re: [Widelands-dev] [Merge] lp:~tino79/widelands/gettext018 into lp:widelands

2011-11-26 Thread SirVer
I have some problems with gettext 0.17 on mac os x: i18n.cc:130: error: ‘libintl_setlocale’ was not declared in this scope The version is defined as #define LIBINTL_VERSION 0x001100 which means that std::setlocale was used prior on my system. The following solutions compile on my system: #de

Re: [Widelands-dev] [Merge] lp:~alocritani/widelands/even_more_on_+_- into lp:widelands

2011-12-24 Thread SirVer
Good fixes. I am merging this right now. -- https://code.launchpad.net/~alocritani/widelands/even_more_on_+_-/+merge/85362 Your team Widelands Developers is requested to review the proposed merge of lp:~alocritani/widelands/even_more_on_+_- into lp:widelands.

Re: [Widelands-dev] [Merge] lp:~hjd/widelands-website/irc-help into lp:widelands-website

2011-12-25 Thread SirVer
Review: Approve Good idea! I merged this and it will land on the website as soon as we roll a new version. -- https://code.launchpad.net/~hjd/widelands-website/irc-help/+merge/85227 Your team Widelands Developers is subscribed to branch lp:widelands-website.

Re: [Widelands-dev] [Merge] lp:~aber/widelands/static into lp:widelands

2012-01-01 Thread SirVer
You do have push rights, don't you? What do you want to have reviewed here specifically? -- https://code.launchpad.net/~aber/widelands/static/+merge/87053 Your team Widelands Developers is requested to review the proposed merge of lp:~aber/widelands/static into lp:widelands. ___

Re: [Widelands-dev] [Merge] lp:~alocritani/widelands/shorter_wincondition_button_text into lp:widelands

2012-01-03 Thread SirVer
Good fixes, I'll merge this asap On Mon, Jan 02, 2012 at 05:48:25PM -, Angelo Locritani wrote: > Angelo Locritani has proposed merging > lp:~alocritani/widelands/shorter_wincondition_button_text into lp:widelands. > > Requested reviews: > Widelands Developers (widelands-dev) > Related bugs

Re: [Widelands-dev] [Merge] lp:~aber/widelands/static into lp:widelands

2012-01-03 Thread SirVer
> Just searching for the deeper meaning, the indented behavior... Most of these just seem to be bugs. There is especially one where some effort is done to convert from big to little endian but the value is discarded. This is quite definitively a bug that just never bit us because Big endian machi

Re: [Widelands-dev] [Merge] lp:~aber/widelands/static into lp:widelands

2012-01-07 Thread SirVer
I commited this now. Cleanup is always good. Thanks for your work, aber! It is in r 6180. -- https://code.launchpad.net/~aber/widelands/static/+merge/87053 Your team Widelands Developers is requested to review the proposed merge of lp:~aber/widelands/static into lp:widelands. __

Re: [Widelands-dev] [Merge] lp:~aber/widelands/gcc into lp:widelands

2012-01-24 Thread SirVer
I guess your argument is that 4.5 is reasonably old so that we can drop this workaround. I believe that it is too early for that. Mingw and Mac < 10.7 use older GCCs than 4.5 as default still. -- https://code.launchpad.net/~aber/widelands/gcc/+merge/89785 Your team Widelands Developers is reques

Re: [Widelands-dev] [Merge] lp:~nomeata/widelands/bug887737 into lp:widelands

2012-01-25 Thread SirVer
Joachim, thanks! I much appreciate the democratical sense you've shown by implementing this against your own opinion. -- https://code.launchpad.net/~nomeata/widelands/bug887737/+merge/90035 Your team Widelands Developers is requested to review the proposed merge of lp:~nomeata/widelands/bug8877

Re: [Widelands-dev] [Bug 916545] Re: About depending on GGZ packages

2012-01-30 Thread SirVer
>Should we open a new branch for this purpose, or better keep this in >main trunk to directly force our playtesters to use the new >implementation once it is in testing stage? ;) We should use a new branch and merged it back as soon as it is in testing stage. We need to force our users to switch a

Re: [Widelands-dev] [Bug 916545] Re: About depending on GGZ packages

2012-01-30 Thread SirVer
I didn't seem anything that was not alright. However, I strongly urge you to define an ASCII protocol -> it makes debugging much easier and there is so little traffic on the metaserver that it makes no difference. -- You received this bug notification because you are a member of Widelands Deve

[Widelands-dev] [Bug 916545] Re: About depending on GGZ packages

2012-02-02 Thread SirVer
protocol looks good to me. I would just suggest using static const std::string = "COMMANDNAME". #defines are not typesafe and have no benefits in this case (IMHO). Otherwise the protocol looks good to me. I am also pro ignoring translation of motd and therelike. The other messages should imho be te

Re: [Widelands-dev] [Merge] lp:~gamag/widelands/EditorUndo into lp:widelands

2012-02-14 Thread SirVer
Seems like you beat me to it :). I was actually working on undo in a seperate branch but must admit that I got sidetracked a bit. This is quite a mouthful to review. I plan to do this on the weekend. -- https://code.launchpad.net/~gamag/widelands/EditorUndo/+merge/92957 Your team Widelands Devel

Re: [Widelands-dev] [Merge] lp:~gamag/widelands/Bug892773 into lp:widelands

2012-02-22 Thread SirVer
Cool thing! Thanks a lot Gabriel. I just merged this. -- https://code.launchpad.net/~gamag/widelands/Bug892773/+merge/94045 Your team Widelands Developers is requested to review the proposed merge of lp:~gamag/widelands/Bug892773 into lp:widelands. ___

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/bugfix-657404 into lp:widelands

2012-03-03 Thread SirVer
Thanks for your work Jens! I think that saving a localized name is an error and I prefer the approach you took - i.e. trying to translate the name found in the savegame and failing quietly. I suggest doing this for all savegames. Do you mind fixing the patch up and committing it yourself? -- ht

Re: [Widelands-dev] [Merge] lp:~alocritani/widelands/writeHTML_improvements into lp:widelands

2012-03-08 Thread SirVer
Merged! Thanks, man! -- https://code.launchpad.net/~alocritani/widelands/writeHTML_improvements/+merge/96667 Your team Widelands Developers is requested to review the proposed merge of lp:~alocritani/widelands/writeHTML_improvements into lp:widelands. __

Re: [Widelands-dev] [Merge] lp:~alocritani/widelands/resource_info_in_editor into lp:widelands

2012-03-19 Thread SirVer
The reason is the following: I merged it and forgot to push, then someone else commited stuff to trunk. So I rebase and somehow some metadata of the merge got lost. It is completly in trunk though. Also: thanks for including the help.lua into catalogues - I somehow missed this. -- https://code

[Widelands-dev] [Merge] lp:~alocritani/widelands/resource_info_in_editor into lp:widelands

2012-03-19 Thread SirVer
The proposal to merge lp:~alocritani/widelands/resource_info_in_editor into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~alocritani/widelands/resource_info_in_editor/+merge/98150 -- https://code.launchpad.net/~alocritani/wi

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/help-strings-consistent into lp:widelands

2012-03-26 Thread SirVer
This should be merged imho, but only after build-17. Could you poke us then again if we forget? -- https://code.launchpad.net/~hjd/widelands/help-strings-consistent/+merge/99376 Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/help-strings-consistent

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/cmake_fail_on_sdl_accessories into lp:widelands

2012-03-31 Thread SirVer
not critical enough for build 17 I'd say. Is it okay for you to have this merged after build 17? -- https://code.launchpad.net/~qcumber-some/widelands/cmake_fail_on_sdl_accessories/+merge/100300 Your team Widelands Developers is requested to review the proposed merge of lp:~qcumber-some/widela

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/cmake_fail_on_sdl_accessories into lp:widelands

2012-03-31 Thread SirVer
Sorry.. seems like reading is not my strong point :) -- https://code.launchpad.net/~qcumber-some/widelands/cmake_fail_on_sdl_accessories/+merge/100300 Your team Widelands Developers is requested to review the proposed merge of lp:~qcumber-some/widelands/cmake_fail_on_sdl_accessories into lp:wide

[Widelands-dev] [Bug 916545] Re: Replace ggz implementation with own InternetGaming function + metaserver

2012-04-02 Thread SirVer
Released in build17-rc1. ** Changed in: widelands Status: Fix Committed => Fix Released ** Changed in: widelands (Debian) Status: New => Fix Released -- You received this bug notification because you are a member of Widelands Developers, which is a bug assignee. https://bugs.launc

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/optimizations into lp:widelands

2012-04-06 Thread SirVer
I totally approve! In fact, we have a code-style checker rule for exactly this, seems like it missed these places though. -- https://code.launchpad.net/~hjd/widelands/optimizations/+merge/101116 Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/optimi

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/optimizations into lp:widelands

2012-04-06 Thread SirVer
>If we have a check as part of the stylechecker for this, then I think someone >should check whether that still works and is run. I was mistaken here. We have a check which checks for the inverse (!blah.size()) which should then be replaced through blah.empty(). >How can logic/building.cc:686 ev

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/assert into lp:widelands

2012-04-25 Thread SirVer
Merged! Thanks. -- https://code.launchpad.net/~hjd/widelands/assert/+merge/103340 Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/assert into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands

Re: [Widelands-dev] [Merge] lp:~borim/widelands/fixWarnings into lp:widelands

2012-05-29 Thread SirVer
I am not so fond of the idea to translate warnings. Those warnings will appear in bug reports and will not help when we are unable to understand them because they are in mandarin. Will those warnings be shown to the user? -- https://code.launchpad.net/~borim/widelands/fixWarnings/+merge/1075

Re: [Widelands-dev] [Merge] lp:~peter.waller/widelands/eliminate-unused-arguments into lp:widelands

2012-06-09 Thread SirVer
Nice Work Peter! I saw that you also improved the flexibility of the CodeChecker quite a bit. That is really good work. I am not a fan of the commenting of the parameters. Can you tell me why you find this superior to straightup deleting them? -- https://code.launchpad.net/~peter.waller/widela

Re: [Widelands-dev] [Merge] lp:~ab-tools/widelands/msvs2010-compileerrors into lp:widelands

2012-06-09 Thread SirVer
Some of these fixes are quite strange, but they compile on my system, so I went ahead and merged them. Thanks Andreas! -- https://code.launchpad.net/~ab-tools/widelands/msvs2010-compileerrors/+merge/109357 Your team Widelands Developers is requested to review the proposed merge of lp:~ab-tools/w

Re: [Widelands-dev] [Merge] lp:~gamag/widelands/building_costs_preview into lp:widelands

2012-06-28 Thread SirVer
Quality Work Gabriel! Very nice. Merged in 6407. The only thing bugging me is the window resizing. It is quite distracting imho. I merged now, maybe one gets used to it. Maybe we have to rethink the way we display this information in the UI in a while. -- https://code.launchpad.net/~gamag/wide

Re: [Widelands-dev] [Merge] lp:~borim/widelands/bug1022267 into lp:widelands

2012-07-12 Thread SirVer
Merged! Thanks Borim. -- https://code.launchpad.net/~borim/widelands/bug1022267/+merge/114014 Your team Widelands Developers is requested to review the proposed merge of lp:~borim/widelands/bug1022267 into lp:widelands. ___ Mailing list: https://launch

Re: [Widelands-dev] [Merge] lp:~qcumber-some/widelands/cppcheck_const_refs into lp:widelands

2012-07-12 Thread SirVer
Well... I start to dislike cppcheck. Most of them are harmless, but replacing the passing of a 8 bit integer through a const reference to a 8 bit integer effectively increases the amount of data passed to the functions. It will hardly matter in any case, but it seems futile to mark this as an er

Re: [Widelands-dev] [Merge] lp:~sirius-in4matiker/widelands/spectator-fix into lp:widelands

2012-07-14 Thread SirVer
Thanks! Merged in r6418. -- https://code.launchpad.net/~sirius-in4matiker/widelands/spectator-fix/+merge/114945 Your team Widelands Developers is requested to review the proposed merge of lp:~sirius-in4matiker/widelands/spectator-fix into lp:widelands. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/new-design into lp:widelands-website

2012-07-14 Thread SirVer
Review: Approve This is in my ballbark now. I am in Munich for the forseeable future to look for flats and I have no idea how the internet is there. I hope to get around doing this still this week. Thanks Matthias! -- https://code.launchpad.net/~widelands-dev/widelands-website/new-design/+merg

Re: [Widelands-dev] [Merge] lp:~ebke/widelands/ping-on-pause into lp:widelands

2012-07-23 Thread SirVer
Merged in r6421. Thanks Johannes! -- https://code.launchpad.net/~ebke/widelands/ping-on-pause/+merge/116114 Your team Widelands Developers is requested to review the proposed merge of lp:~ebke/widelands/ping-on-pause into lp:widelands. ___ Mailing list

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/new-design into lp:widelands-website

2012-09-01 Thread SirVer
I finally merged this. I am currently struggling to get it on alpha.widelands.org. Thanks for your work again Shevonar. Please keep it up and I owe you any kind of beverage that you want to drink on the next wihack. -- https://code.launchpad.net/~widelands-dev/widelands-website/new-design/+merge

Re: [Widelands-dev] [Merge] lp:~amdmi3/widelands/widelands into lp:widelands

2012-12-02 Thread SirVer
Thanks. I just merged these changes in. -- https://code.launchpad.net/~amdmi3/widelands/widelands/+merge/137285 Your team Widelands Developers is requested to review the proposed merge of lp:~amdmi3/widelands/widelands into lp:widelands. ___ Mailing li

Re: [Widelands-dev] [Merge] lp:~hjd/widelands-website/updated-installation-instructions into lp:widelands-website

2012-12-10 Thread SirVer
Thanks! I think a warning is not necessary. Could you update the docs? -- https://code.launchpad.net/~hjd/widelands-website/updated-installation-instructions/+merge/138862 Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands-website/updated-installation-in

Re: [Widelands-dev] [Merge] lp:~tino79/widelands/using_sdl_net_init into lp:widelands

2012-12-31 Thread SirVer
Tino, I accidentally overwrote your merge to trunk! Sorry about that - i just realized. I merged this branch now again. It seems like it contains all the fixes you made in the original merge and more, right? Your fix is very important, so I think merging and waiting that other oses complain ma

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/compilation-warnings into lp:widelands

2013-01-05 Thread SirVer
A good idea i think. I merged this and have not seen any problems with building widelands so far. Testing for individual warnings will likely need a script to probe the compiler for what it supports. -Wno-attributes was added by me IIRC because compilation on old gcc version made some noisy ou

Re: [Widelands-dev] [Merge] lp:~hono/widelands/warnings into lp:widelands

2013-01-06 Thread SirVer
I only reviewed the code from the technical point of view and from there it looks fine. I am also not concerned about the individual disabling of the warnings in the code - it was all clear to me when I reviewed it. About the copyright issue - the text seems to have been written/dublicated into

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/recruited-typo into lp:widelands

2013-01-06 Thread SirVer
Merged, done and thanks! -- https://code.launchpad.net/~hjd/widelands/recruited-typo/+merge/142011 Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/recruited-typo into lp:widelands. ___ Mailing list: https:/

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/main-menu-year into lp:widelands

2013-01-12 Thread SirVer
thanks! -- https://code.launchpad.net/~hjd/widelands/main-menu-year/+merge/142918 Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/main-menu-year into lp:widelands. ___ Mailing list: https://launchpad.net/~w

Re: [Widelands-dev] [Merge] lp:~shevonar/widelands-website/django1.4 into lp:widelands-website

2013-01-15 Thread SirVer
Good to see you back in swing, Shevonar. The change LGTM in general - it is also much shorter than I would have expected :). Just one question: do you know if the database schema needs updating for this new version and if yes, how would I do this? -- https://code.launchpad.net/~shevonar/widelan

Re: [Widelands-dev] [Merge] lp:~shevonar/widelands-website/django1.4 into lp:widelands-website

2013-01-17 Thread SirVer
I suggest adding a new document to the repo called transitions which contains revision number + links to the stuff that needs to be done for this revision to work - very similar than what you just wrote. It will make migration a bit easier. Btw, you have push rights to trunk, right? I do not ha

Re: [Widelands-dev] [Merge] lp:~mxsscott/widelands/955908 into lp:widelands

2013-01-20 Thread SirVer
Great - I was missing this myself quite a few times already :). Patch Looks good - I think the in game keyboard shortcuts are also mentioned in the readme some place and there is also an loading screen tip. The first is needed, the second optional. What do you think? -- https://code.launchpad.n

Re: [Widelands-dev] [Merge] lp:~mxsscott/widelands/955908 into lp:widelands

2013-01-21 Thread SirVer
LGTM. -- https://code.launchpad.net/~mxsscott/widelands/955908/+merge/144037 Your team Widelands Developers is requested to review the proposed merge of lp:~mxsscott/widelands/955908 into lp:widelands. ___ Mailing list: https://launchpad.net/~widelands

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/warnings into lp:widelands

2013-01-27 Thread SirVer
Are the PARAMETER_COMPILERFLAG_EXTRAWARNINGS used by default or do I have to do something to enable them? -- https://code.launchpad.net/~hjd/widelands/warnings/+merge/145089 Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/warnings into lp:widelands.

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/warnings into lp:widelands

2013-01-27 Thread SirVer
I have googled a little bit but have not found a good way to figure out which flags are supported on a compiler. Most projects seem to distinguish by compiler name and select their flags this way - of course this is suboptimal because you never know which version of the compiler the user has.

  1   2   3   4   5   6   7   8   9   10   >