Nicolai! The code compiles and runs great on later Mac OS X - I cannot check
with old OS X as my wife took the laptop with her to work. The speedup is quite
tremendous: on 100x speed terrain rendering takes less than 15% CPU now on my
box. Superb work as always from you.
As you might have notic
--
https://code.launchpad.net/~sirver/widelands/autocache/+merge/147559
Your team Widelands Developers is requested to review the proposed merge of
lp:~sirver/widelands/autocache into lp:widelands.
___
Mailing list: https://launchpad.net/~widelands-d
Review: Approve
Lgtm
--
https://code.launchpad.net/~widelands-dev/widelands/bug974679/+merge/147796
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug974679.
___
Mailing list: https://launchpad.net/~widelands-dev
Po
Review: Approve
:). I do not really know myself where to draw the line - it costs the reviewer
very little to read a few lines but having the delay in the push process is
sometimes annoying for the coder. I pushed some bug fixes yesterday also
without reviews... so, I just don't know.
if (Buil
Lgtm. I will Not be able to Push this Till Monday can you do it yourself?
--
https://code.launchpad.net/~hjd/widelands/class-building/+merge/148830
Your team Widelands Developers is requested to review the proposed merge of
lp:~hjd/widelands/class-building into lp:widelands.
___
Review: Approve
lgtm.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1132466/+merge/150244
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1132466.
___
Mailing list: https://launchpad.net/~widelands-dev
nooo, do not pass around shared_ptr's please - they support bad design as they
delute the question who has ownership. And this question is not gone with them
- they do not add garbage collection to c++. Please don't.
I support using smart pointers (for the moment scoped_ptr) in most places, but
Review: Approve
+ const Coords flagpos = baseflag.get_position();
can this be a const reference? Haven't checked.
still lgtm.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1132466/+merge/150244
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wi
A sure - sorry, my mind was not working properly. Your call - you can also
leave it as is.
>From my side, merge is okay. Nicolai had more comments I think though.
--
https://code.launchpad.net/~csirkeee/widelands/memory-leaks-2/+merge/150290
Your team Widelands Developers is requested to review
Oh damn, forgot to write something: Currently, the image and surface and
animation caches are not flushed when a game is ended - some of the leaks you
see might come from this as well.
--
https://code.launchpad.net/~csirkeee/widelands/memory-leaks-2/+merge/150290
Your team Widelands Developers i
I did not jet look at the code - but I feel like this is a bad idea: we should
just cut the logging down if possible and not introduce filtering to it. Also,
sometimes you filter out the messages that show the real problem because you
are too focused on your own little problem and expect your bu
Jens, you are most qualified to comment on this.
--
https://code.launchpad.net/~nha/widelands/release-warnings/+merge/153693
Your team Widelands Developers is requested to review the proposed merge of
lp:~nha/widelands/release-warnings into lp:widelands.
_
SirVer has proposed merging lp:~widelands-dev/widelands/graphic_resetting into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/graphic_resetting/+merge/159985
There is at least one critical bug
SirVer has proposed merging
lp:~widelands-dev/widelands/handle_apple_mouse_quirks into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/handle_apple_mouse_quirks/+merge/164796
Try to handle apple
Works straight out of the box. Thanks!
--
https://code.launchpad.net/~shevonar/widelands-website/fix-missing-revisions/+merge/168897
Your team Widelands Developers is requested to review the proposed merge of
lp:~shevonar/widelands-website/fix-missing-revisions into lp:widelands-website.
___
Public bug reported:
My gripes with the current website is this:
- The image does not convey a good introduction to the game. The old screenshot
was much better suited for that particular task.
- The text is slightly verbose - I think it could be shorter. It also talks to
much about Settlers 1
Frank, some of your suggestions are very work intensive (like the tour
with cookie check). I also dislike too much state in a webpage. I strive
for improvement of what's currently there.
This is my suggestion for the new welcome text. I suggest using the old
image again as it gives a better feel f
Thanks a lot for caring for this! Cleaning up documentation is not the nicest
work a project has to offer, but it is definitively important.
I think the rest of these informations should go to the wiki as well and this
document (compiling.rst that is) should just go away. The stuff that now
rem
Maybe here? https://wl.widelands.org/wiki/DevelopmentPage/? I went ahead and
merged this now - you forgot to remove the compiling page from the TOC though,
I fixed this for you.
Thanks for taking care of this :). There is more stuff to be done in the wiki,
if you feel like brushing it up a litt
SirVer has proposed merging lp:~charlyghislain/widelands/portdock-fix into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1199653 in widelands: "Unseen port crashes the game when saving"
https://bugs.launchpad.net/widelands/+bug/1199653
Thanks for looking into this. I spent too much time on Widelands already today,
so I'll postpone this review till next week.
And another comment: could you push your branches to ~widelands-dev in the
future? that way others can directly edit your branch which makes talking about
nits unnecessar
Review: Abstain
I think the bug needs a bit more discussing, I am not convinced that this is
needed or even a good idea - see my comments on it.
--
https://code.launchpad.net/~widelands-dev/widelands/get_defeated_fix/+merge/174470
Your team Widelands Developers is subscribed to branch
lp:~widel
I just deployed this on the site.
** Changed in: widelands-website
Status: Incomplete => Fix Released
--
You received this bug notification because you are a member of Widelands
Developers, which is a bug assignee.
https://bugs.launchpad.net/bugs/1191655
Title:
Website Frontpage needs
The proposal to merge lp:~widelands-dev/widelands/clang_format into
lp:widelands has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/clang_format/+merge/164570
--
https://code.launchpad.net/~widelands-dev/widelands/cl
Unfortunately, this no longer works. I feel this merge request somehow slipped
by and noone did properly look at it. I am very sorry for this Peter!
Setting to rejected for now.
--
https://code.launchpad.net/~peter.waller/widelands/toggle-fullscreen-rewrite/+merge/103558
Your team Widelands Deve
The proposal to merge lp:~peter.waller/widelands/toggle-fullscreen-rewrite into
lp:widelands has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~peter.waller/widelands/toggle-fullscreen-rewrite/+merge/103558
--
https://code.launchpad.net/~pe
Review: Needs Fixing
I pushed my review of this branch in r6613. You can find all my comments by
grep-ing for #cghislai. I changed some nits around (see the diff) and added a
short comment when I found it appropriate - feel free to just delete them
again, they are for your eyes only :). I did n
Review: Needs Fixing
I did a review in r6620. There is some code duplication which should be
factored into a method and a bunch of comments. As before just grep() for
#cghislai to find all comments or look at the diff.
--
https://code.launchpad.net/~widelands-dev/widelands/save_dialog_improveme
I looked over the code again and removed more of my comments that you adressed
or that I made up my mind about :). One more thing: If you change a Lua method
make sure that you update where it is used in the code (i.e. in all *.lua
files) and add in a backwards compatible version (I did this for
I had one more issue and proposed a fix for it in my latest revision. Can you
have a quick look and say if it is fine?
lgtm otherwise - I will merge as soon as I hear back from you.
--
https://code.launchpad.net/~widelands-dev/widelands/save_dialog_improvements/+merge/174566
Your team Widelands
Thanks and np! I enjoy your contributions very much :)
--
https://code.launchpad.net/~widelands-dev/widelands/save_dialog_improvements/+merge/174566
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/save_dialog_improvements.
__
I'll try to have a look at this during this week - I will be a bit busy though,
so no promises. If anybody else can review this, go ahead of course :).
--
https://code.launchpad.net/~widelands-dev/widelands/csite_improvement/+merge/174623
Your team Widelands Developers is requested to review the
Peter (Nasenbaer), could you review this?
--
https://code.launchpad.net/~widelands-dev/widelands/bug988870/+merge/174639
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug988870 into lp:widelands.
_
This is the error you get when Lua tries to persist a running coroutine. So
this is precisely the error you want to fix :).
In trunk, the save routine must only be called when no coroutine is running,
i.e. outside of any coroutine, i.e. when the script is run the first time. This
is not very fl
Thanks for the testing - I'll review the branch again and try to figure out
what is wrong. That it crashes this early for you is an indication that
something very basic is wrong. Maybe valgrind can help me out.
--
https://code.launchpad.net/~widelands-dev/widelands/graphic_resetting/+merge/15998
The proposal to merge lp:~widelands-dev/widelands/graphic_resetting into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/graphic_resetting/+merge/159985
--
https://code.launchpad.net/~wideland
Review: Needs Fixing
Couple of small comments in the code. search for NOCOM as before.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1201398/+merge/174809
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1201398.
_
Both of the bugs you guys were fixing are really embarrassing - but thanks for
that :).
I will check and see if the branch is now crash free for me as well and then
really propose for merging. This will likely not happen till the weekend though.
--
https://code.launchpad.net/~widelands-dev/wide
Review: Approve
No complaints from my site. Merged!
--
https://code.launchpad.net/~widelands-dev/widelands/ui_improvments/+merge/175090
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ui_improvments.
___
Mailing list
Review: Needs Fixing
Okay, a bunch of minor comments. I did not understand what the anchoring does -
I would love to see some comments about this someplace.
--
https://code.launchpad.net/~widelands-dev/widelands/csite_improvement/+merge/174623
Your team Widelands Developers is subscribed to bra
And I forgot to mention: I much appreciate you adding {} in more places while
going over the code :). I find this so much more readable.
--
https://code.launchpad.net/~widelands-dev/widelands/csite_improvement/+merge/174623
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev
Thanks! Merged.
I didn't try running scan-build. There are currently so much stuff going on
with Widelands that I am not generating extra work for myself if I can avoid it
:).
--
https://code.launchpad.net/~hjd/widelands/scan-build-cmake/+merge/175269
Your team Widelands Developers is requeste
SirVer has proposed merging lp:~widelands-dev/widelands/cxx11 into lp:widelands.
Requested reviews:
Tino (tino79)
Widelands Developers (widelands-dev)
Related bugs:
Bug #1159432 in widelands: "Warnings at compile-time in GCC 4.8"
https://bugs.launchpad.net/widelands/+bug/1159432
As a reminder to myself, should this get merged:
- replace all scoped_ptr and most shared_ptr through unique_ptrs.
- replace all boost::foreach with for( a : b) interations.
--
https://code.launchpad.net/~widelands-dev/widelands/cxx11/+merge/175455
Your team Widelands Developers is requested to r
SirVer has proposed merging lp:~widelands-dev/widelands/graphic_resetting into
lp:widelands.
Requested reviews:
Tino (tino79)
Related bugs:
Bug #1159968 in widelands: "Crash in opengl fonthandler_cc:99"
https://bugs.launchpad.net/widelands/+bug/1159968
For more details,
I am currently Sending a branch using c++11 static_assert for review. Feel free
to comment and review this :)
--
https://code.launchpad.net/~widelands-dev/widelands/boost_static_assert/+merge/175607
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/wid
The proposal to merge lp:~hjd/widelands/prodsite-null into lp:widelands has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~hjd/widelands/prodsite-null/+merge/175538
--
https://code.launchpad.net/~hjd/widelands/prodsite-null/+merge/175538
Your
This is contained in charlys branch as well, so this is kinda merged. Thanks
for finding this!
--
https://code.launchpad.net/~hjd/widelands/prodsite-null/+merge/175538
Your team Widelands Developers is requested to review the proposed merge of
lp:~hjd/widelands/prodsite-null into lp:widelands.
Review: Approve
LGTM. Merged.
--
https://code.launchpad.net/~widelands-dev/widelands/workers_table/+merge/175635
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/workers_table.
___
Mailing list: https://launchpad.net/
Review: Needs Fixing
do not worry - you add code at a tremendous rate and WL has no test suite
(well, only the Lua test suite which tests quite a bit of code actually. And
the new rich text renderer). So regressions do happen.
I can have a look at the OpenGL ones too - it might be as trivial as
This should compile nicely in GCC 4.3 I think (which was released in March 5,
2008). Looking over http://gcc.gnu.org/projects/cxx0x.html would make me think
that we could get by with GCC 4.5 for a while - we would gradually adopt c++ 11
features into the code base. I have no idea about clang (bu
About the tooltips: I think it should be another event. So, when the UI decides
that it would like to show a tooltip, it calls "OnTooltip" or so on the current
panels (very similar to how mousein behaves) and each of them can report with
"true" to set the tooltip or false to pass on to the next
I must have messed up something in the CMake file then - you should be building
using -std=c++0x or -std=c++11. Could you try again and change c++11 in the
cmake file to read c++0x?
--
https://code.launchpad.net/~widelands-dev/widelands/cxx11/+merge/175455
Your team Widelands Developers is reque
Can we Check for both?
--
https://code.launchpad.net/~widelands-dev/widelands/cxx11/+merge/175455
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/cxx11 into lp:widelands.
___
Mailing list: https:
Review: Approve
I did slight modifications to the test and added a bunch of comments - I found
the reason why the test did work for you and then didn't and did again: lunit
did define some handles to cfunctions, so it needs to be pulled in after
loading :).
I will merge this as soon as i get g
I try to be more clever in the CMakefile now. Could you tests again?
--
https://code.launchpad.net/~widelands-dev/widelands/cxx11/+merge/175455
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/cxx11 into lp:widelands.
___
Cool - I am then waiting from feedback from Tino about the windows situation
and if this is sorted I will merge. If anyone does not agree he should speak
now or be forever silent! :)
--
https://code.launchpad.net/~widelands-dev/widelands/cxx11/+merge/175455
Your team Widelands Developers is requ
Also I made a snafu with merging, so you might need to pull -f or pull
--overwrite.
--
https://code.launchpad.net/~widelands-dev/widelands/cxx11/+merge/175455
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/cxx11 into lp:widelands.
___
Review: Approve
Thanks for tracking this down jens! Lgtm.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1203121/+merge/175987
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1203121.
___
Mailing list:
Tino, the problem here is that WIN32 is defined in some header (which we do not
seem to include anymore at this point. I changed this and all other appearances
of ifdef WIN32 to using _WIN32 which is defined by the compiler and therefore
always true under windows. I pushed the change to trunk an
Also:
> According to http://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html "c++0x"
> is deprecated.
Yes, we should now use c++11 - I added a conditional into the CMake file to
check for this.
> I also tried "c++03" :(.
This cannot work, we really need c++11 now.
--
https://code.launchpad.net
Review: Approve
lgtm. I removed one unneeded boost header and merged to trunk.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1201398/+merge/174809
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1201398.
_
I was in a merging mood, so I just merged this :).
--
https://code.launchpad.net/~widelands-dev/widelands/bug1203121/+merge/175987
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1203121.
___
Mailing list: https://
Review: Approve
I think the new solution is really nice. A rt::escape method would have been
nice - but since there is more work to kill the old renderer and make the new
one the only one this will come eventually.
Merged.
--
https://code.launchpad.net/~widelands-dev/widelands/bug657285/+merge
I am not sure if widelands does this or if this is an SDL issue.
However, the graphic system should now be able to handle Reintialize() in the
fullscreen handler given there are no InMemoryImages constructed (which should
be in most cases). So you can try and go for that too and make the
implem
Thanks for looking into this Tino and for the workaround. I captured our
dependency on POSIX functions in bug 1203436 and I'll go ahead and merge this
here now.
--
https://code.launchpad.net/~widelands-dev/widelands/cxx11/+merge/175455
Your team Widelands Developers is requested to review the pr
the cxx11 branch has been merged, so this one is no longer needed. I set it to
rejected - thanks for looking into it though Charly.
Off topic: I am aware that we still have a bunch of your branches to get into
trunk, I have a visitor this weekend and therefore do not have so much time to
review
The proposal to merge lp:~widelands-dev/widelands/boost_static_assert into
lp:widelands has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/boost_static_assert/+merge/175607
--
https://code.launchpad.net/~widelands-de
Review: Needs Fixing
there are merge conflicts in this proposal.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1201398/+merge/176043
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1201398.
___
Mailing
Review: Approve
lgtm. small fix was needed, a typo in unique_ptr.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1201398/+merge/176043
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1201398.
___
Mailin
Review: Approve
Lgtm. I fixed very small nits and merged this.
--
https://code.launchpad.net/~widelands-dev/widelands/csite_improvement/+merge/174623
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/csite_improvement.
___
Charly, could you go over the bugs and mark them fixed as appropriate?
--
https://code.launchpad.net/~widelands-dev/widelands/csite_improvement/+merge/174623
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/csite_improvement.
SirVer has proposed merging lp:~widelands-dev/widelands/normalize_requirements
into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/normalize_requirements/+merge/176062
This branch contains three
I am sorry that I did not yet voice an opinion. I will definitively review this
week.
--
https://code.launchpad.net/~widelands-dev/widelands/game_end_summary/+merge/176000
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/game_end_summary in
This is still marked as wip. Is this correct?
--
https://code.launchpad.net/~widelands-dev/widelands/game_end_summary/+merge/176000
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/game_end_summary into lp:widelands.
Review: Approve
lgtm. Merged.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1203337/+merge/176409
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1203337.
___
Mailing list: https://launchpad.net/~widel
lgtm.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1204171/+merge/176426
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug1204171 into lp:widelands.
___
Mailing list: https://launch
I wish launchpad would merge after so and so many lgtm
--
https://code.launchpad.net/~widelands-dev/widelands/bug1203337/+merge/176409
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1203337.
___
Mailing list:
Thanks for the review. Merged.
--
https://code.launchpad.net/~widelands-dev/widelands/normalize_requirements/+merge/176062
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/normalize_requirements into lp:widelands.
___
Oh, I did not review the conf file changes, only the code.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1170086/+merge/176406
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1170086.
___
Mailing list:
Review: Approve
I pushed some nits - only personal style really, and I pushed them because I
did them to understand the code better. And that I've done something :).
Merged. Thanks.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1170086/+merge/176406
Your team Widelands Developers is
I'd rather wait till you push a somewhat ready version - otherwise I comment on
stuff that you will have changed already in your local branch. I wait till you
set this branch to be ready for review again.
--
https://code.launchpad.net/~widelands-dev/widelands/game_end_summary/+merge/176000
Your
Review: Approve
Lgtm.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1204612/+merge/176752
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1204612.
___
Mailing list: https://launchpad.net/~widelands-de
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/bug1204199/+merge/176664
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1204199.
___
Mailing list: https://launchpad.net/~widelands-dev
Post
I added a line about Mac OS and fixed a few small things. Feel free to merge
when you think it is good that way.
--
https://code.launchpad.net/~widelands-dev/widelands/bug994712/+merge/176747
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/
I added a bunch of comments on this.
--
https://code.launchpad.net/~widelands-dev/widelands/game_end_summary/+merge/176000
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/game_end_summary.
___
Mailing list: https://la
Review: Needs Fixing
--
https://code.launchpad.net/~widelands-dev/widelands/game_end_summary/+merge/176000
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/game_end_summary.
___
Mailing list: https://launchpad.net/~w
SirVer has proposed merging
lp:~widelands-dev/widelands/soldierselect_radiobutton into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1202228 in widelands: "Better controls for specifying preference of
strong and weak soldiers&quo
Well, if you can find a nice separation of concerns that would be great. Keep
in mind that the design has to work for the editor too though. Game and
EditorGameBase are two balls of mud right now: they have too many
responsibilities - I think the design would already improve if they could be
sp
> Should I go toward that or only handle the end status?
I didn't address this question, sorry. My trigger finger is a little too quick
these days :). If you have time to improve the design around those classes a
bit that would be awesome - only go for it if you feel that it clearly improves
the
> Should there be such option for training sites as well, so we can choose to
> train rookies or heroes?
With teppos recent changes I think we have these bases covered - at least we
should gather some experience before we go ahead and tweak there again. So I
think for now we should not further t
Review: Needs Fixing
Some more comments here. I also changed some style and nits around. Also you
forgot to check in logic/playersmanager.[h|cc]. I also think the file should be
called players_manager.h and the class PlayersManager (though we are not very
consistent about this either - we defin
Review: Approve
The code lgtm. I haven't tested this though :).
--
https://code.launchpad.net/~widelands-dev/widelands/bug1204144/+merge/176688
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1204144.
___
Mailing
When you want to have another look, just ping me here.
--
https://code.launchpad.net/~widelands-dev/widelands/bug994712/+merge/176747
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug994712.
___
Mailing list: https:
I merged this now - the new include order style is now part of the style
checker and therefore enforced everywhere. I saw some weird stuff while fixing
the includes - we should have had this a long time ago.
--
https://code.launchpad.net/~widelands-dev/widelands/include_order_fixes/+merge/177045
great that you figured it out. Loading indeed reassigns object serials - this
is the only way to get back no longer used serials. That is why we use the
magic with the map object loader and saver.
This seems like a nice change - I will review asap.
--
https://code.launchpad.net/~widelands-dev/
> I agree that the new buttons look really good, and that their placement is
> good as well.
Thanks! Glad that you like it that way too.
> However, start and stop buttons have now appeared to the lower left corner.
Good catch - I messed that up. I added something along the lines of your patch
a
Code lgtm. I just did some nit fixes and merged.
--
https://code.launchpad.net/~widelands-dev/widelands/fishing/+merge/177237
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/fishing into lp:widelands.
___
Just a general though that crossed my mind: we have many 'manual' test cases in
the last few days (like the one you describe in your last sentence). How about
starting a test suite with lua scenarios that can be automatically run (like
ts.wmf)? they would set up a starting condition (a bunch of
Review: Needs Fixing
--
https://code.launchpad.net/~widelands-dev/widelands/bug1205010/+merge/177137
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug1205010.
___
Mailing list: https://launchpad.net/~widelands-dev
101 - 200 of 1693 matches
Mail list logo
