Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908 into lp:widelands

2019-08-31 Thread Klaus Halfmann
Review: Approve code review Nothing to really check here. I will it compile it anyway -- https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908/+merge/372109 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compiler-warnings-201908. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908 into lp:widelands

2019-08-31 Thread Klaus Halfmann
Review: Approve Compiled withouth any noteworthy complaints @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908/+merge/372109 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compiler-warnings-201908. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908 into lp:widelands

2019-08-31 Thread GunChleoc
Thanks for the review! I'll be going through the Travis/Appveyor logs to see if I can find more stuff to fix. -- https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908/+merge/372109 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compiler

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_wai_files_29082019 into lp:widelands

2019-08-31 Thread GunChleoc
Review: Approve Thanks! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/ai_wai_files_29082019/+merge/372083 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_wai_files_29082019. ___ Mailing l

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_ga_unittests into lp:widelands

2019-08-31 Thread GunChleoc
LGTM :) Just 1 tiny nit: What does ga mean? Add a comment to the test file. -- https://code.launchpad.net/~widelands-dev/widelands/ai_ga_unittests/+merge/372091 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_ga_unittests into lp:widelan

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2019-08-31 Thread Benedikt Straub
Savegame compatibility hack is up :) Thanks for the review and codestyle. -- https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ferry. ___ Mailing

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands

2019-08-31 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands. Commit message: Fix compiler warnings and refactor config dir. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/wide

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2019-08-31 Thread GunChleoc
I have pushed a commit with a comment. -- https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ferry. ___ Mailing list: https://launchpad.net/~widelan

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908 into lp:widelands

2019-08-31 Thread bunnybot
Continuous integration builds have changed state: Travis build 5365. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/579080055. Appveyor build 5135. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_compiler_w

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908 into lp:widelands

2019-08-31 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/compiler-warnings-201908 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908/+merge/372109 -- Your team Widelands Developers i

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_wai_files_29082019 into lp:widelands

2019-08-31 Thread bunnybot
Continuous integration builds have changed state: Travis build 5362. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/578917768. Appveyor build 5132. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_wai_fil

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_wai_files_29082019 into lp:widelands

2019-08-31 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/ai_wai_files_29082019 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ai_wai_files_29082019/+merge/372083 -- Your team Widelands Developers is subs

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/spritesheet_generation into lp:widelands

2019-08-31 Thread bunnybot
Continuous integration builds have changed state: Travis build 5366. State: canceled. Details: https://travis-ci.org/widelands/widelands/builds/579080616. Appveyor build 5136. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_spritesh

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-794407-soldier-stats into lp:widelands

2019-08-31 Thread bunnybot
Continuous integration builds have changed state: Travis build 5367. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/579089392. Appveyor build 5137. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_794407

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-cmakelists-codecheck into lp:widelands

2019-08-31 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/fix-cmakelists-codecheck into lp:widelands. Commit message: Dependency check doesn't work with ninja, so we run it manually from compile.sh Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.la

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_ga_unittests into lp:widelands

2019-08-31 Thread TiborB
ga = Genetic Algorithm :) I am going to add the comment.. -- https://code.launchpad.net/~widelands-dev/widelands/ai_ga_unittests/+merge/372091 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai_ga_unittests into lp:widelands. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai_ga_unittests into lp:widelands

2019-08-31 Thread GunChleoc
Review: Approve Thanks! I have done some final cleanup, so this can go in now :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/ai_ga_unittests/+merge/372091 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai_ga_unittests. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/spritesheet_generation into lp:widelands

2019-08-31 Thread bunnybot
Continuous integration builds have changed state: Travis build 5372. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/579190053. Appveyor build 5142. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_spriteshee

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-cmakelists-codecheck into lp:widelands

2019-08-31 Thread bunnybot
Continuous integration builds have changed state: Travis build 5373. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/579215280. Appveyor build 5143. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_cmakel

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/compiler-warnings-201908-2 into lp:widelands

2019-08-31 Thread GunChleoc
Review: Resubmit I'm done checking the logs, so this is ready for review now. -- https://code.launchpad.net/~widelands-dev/widelands/compiler-warnings-201908-2/+merge/372111 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/compiler-warnings-201908-2. __