OK, found an obvious Bug:
* Two ships find the same PortSpace
* Tell both of them to build a port.
4: Colonization error: unloading wares to constructionsite of atlanteans_port
(owner 4) failed.
Wares unloaded to the site: 3, max capacity: 3, remaining to unload: 13
No free capacity to unload
I believe this is a bug in trunk since I didn´t touch that code, but I´ll fix
it here. Once the portspace becomes unavailable, other ships shouldn´t be
allowed to start colonizing. No savegame needed, should be easy to reproduce.
I´ll also add this case to the testsuite.
Still wasn´t able to re
Next one please check: https://www.magentacloud.de/share/tu4ayusx.k
ShioCrash2.wgf
Crashes here:
Assertion failed: (old_index < nr_dests), function reorder_destinations,
file ../src/logic/map_objects/tribes/ship.cc, line 902.
With a Debugger I found...
Via the ReplayWriter game.cleanup_for_lo
The OPtr is just a wrapper for a MapObject. I use OPtr rather than
PortDock* to avoid segfaults when the portdock is destroyed. The == comparison
compares serials, so it´s 100% safe to use.
I found a potential cause for this assert in the way superfluous or invalid
destinations are discarded, pl
OK, I can load the Savegame again, lets continue hunting ...
--
https://code.launchpad.net/~widelands-dev/widelands/new-shipping/+merge/371155
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/new-shipping.
___
Mailing
Now I was kiled here:
Assertion failed: (detour >= base_length), function check_push_destination,
file ../src/economy/fleet.cc, line 887.
5 widelands 0x0001102aedf9
Widelands::Fleet::check_push_destination(Widelands::Game&, Widelands::Ship&,
Widelands::PortDoc
No wonder it was buggy, I used the wrong variable for calculating the length of
the detour :)
Please check whether it still happens…
--
https://code.launchpad.net/~widelands-dev/widelands/new-shipping/+merge/371155
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wideland
Will it be problem if the AI can't handle ferrys?
Need this branch more testing?
--
https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/ferry.
___
Review: Needs Fixing
OK I have a ShipCrash4.wgf at https://www.magentacloud.de/share/tu4ayusx.k
I start this with $ ./widelands --loadgame=~/Downloads/ShipCrash4.wgf
and wait about 10 Minutes for
Assertion failed: (detour >= base_length), function check_push_destination,
file ../src/economy/
The AI will simply ignore the new feature, it will continue playing exactly as
before. There are some AI code parts that should be looked into eventually (I
added TODOs there), but they should most likely have no effect whatever as long
as it doesn´t build a waterway.
This branch was tested qui
Continuous integration builds have changed state:
Travis build 5347. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/577456819.
Appveyor build 5117. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_new_shippi
11 matches
Mail list logo
