Review: Approve
Thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/new_wai_files_11082019/+merge/371178
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/new_wai_files_11082019.
___
Mailing
Code LGTM :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/371170
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/constructionsite_options into lp:widelands.
Refusing to merge, since Travis is not green. Use @bunnybot merge force for
merging anyways.
Travis build 5315. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/570577164.
--
https://code.launchpad.net/~widelands-dev/widelands/new_wai_files_11082019/+merge/371178
Your te
The proposal to merge lp:~widelands-dev/widelands/constructionsite_options into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/371170
--
Your team Widelands Developers i
Benedikt Straub has proposed merging
lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands.
Commit message:
Forbid changing economy targets by spectators
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1827696 in widelands: "Allow users to define th
Review: Approve
LGTM :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/workarea-fixes/+merge/371171
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/workarea-fixes.
___
Mailing list: https://l
LGTM :)
Do we want to disable the save button too?
--
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/371251
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands.
It cannot affect the game, so this isn´t necessary. But perhaps one might want
to save some clever economy settings of another player for future use in own
games, so why not allow it?
--
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/371251
Your team Widelands
The proposal to merge lp:~widelands-dev/widelands/workarea-fixes into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/workarea-fixes/+merge/371171
--
Your team Widelands Developers is subscribed to bran
Review: Approve
OK, let's have it then :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/371251
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/economy-target-profiles.
___
Mhh, you _did_ compile with LLVM and ASAN?
As this is a use after freee you may live with it for a long time without
noticing much of a difference,
What about the regression tests? do they work for you?
--
https://code.launchpad.net/~widelands-dev/widelands/new-shipping/+merge/371155
Your team W
Yes, with ASan. It complains about the usual memory leak when closing
Widelands, nothing else.
Travis is happy now, regression tests are working there.
--
https://code.launchpad.net/~widelands-dev/widelands/new-shipping/+merge/371155
Your team Widelands Developers is subscribed to branch
lp:~wi
Whatever you did, looks like it fixed the regression tests, too.
I have about no time this weeek. But this deserves some playtesting, mmh.
--
https://code.launchpad.net/~widelands-dev/widelands/new-shipping/+merge/371155
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wid
Review: Resubmit
Sorry didn't applied the init.lua files sent by fraang, because they have
changed in the meantime.
The values are now taken from fraang, but i edited the main init.lua files from
trunk. Looks good now imho.
fraang had also changed the animate program for cornfield_ripe and app
Review: Approve
Yes, much better! :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/atlanteans_cornfield/+merge/371209
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/atlanteans_cornfield.
__
Continuous integration builds have changed state:
Travis build 5320. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/571293137.
Appveyor build 5092. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_economy_ta
The proposal to merge lp:~widelands-dev/widelands/economy-target-profiles into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/371251
--
Your team Widelands Developers is
Thanks, for testing :)
Updated the media branch with the blend file and fraangs license.
--
https://code.launchpad.net/~widelands-dev/widelands/atlanteans_cornfield/+merge/371209
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/atlanteans_cornfield.
___
Review: Approve
travis failure is not related to code.
@bunnybot merge force
--
https://code.launchpad.net/~widelands-dev/widelands/new_wai_files_11082019/+merge/371178
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/new_wai_files_11082019.
__
The proposal to merge lp:~widelands-dev/widelands/new_wai_files_11082019 into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/new_wai_files_11082019/+merge/371178
--
Your team Widelands Developers is su
The proposal to merge lp:~widelands-dev/widelands/atlanteans_cornfield into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/atlanteans_cornfield/+merge/371209
--
Your team Widelands Developers is subscr
21 matches
Mail list logo
