GunChleoc has proposed merging
lp:~widelands-dev/widelands/arrow-keys-map-movement into lp:widelands.
Commit message:
Fixes for keyboard map movement
- Stop minimized windows from handling key presses.
- Handle map movement by key at the proper place.
Requested reviews:
Widelands Developers
Code looks straing forward, wonnder that this was not implemented this way
before.
Will now copile and testplay this a litte.
Gun: please take a look at my refactoring branch.
--
https://code.launchpad.net/~widelands-dev/widelands/arrow-keys-map-movement/+merge/370687
Your team Widelands Develo
Code LGTM. Do we have a restriction on file types? We won't want people to
upload malicious JavaScript ans stuff lie that, so we should have a list of
legal file extensions at least.
--
https://code.launchpad.net/~widelands-dev/widelands-website/pybb_attachments/+merge/370342
Your team Widelands
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/bug_1836107_lGL/+merge/370334
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug_1836107_lGL.
___
Mailing list: https://launchpad.net/~wideland
Review: Approve
LGTM
--
https://code.launchpad.net/~widelands-dev/widelands-website/sitemap_https/+merge/370398
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-dev
Post to
Added some comments with nits. Not tested yet.
Diff comments:
> === modified file 'src/network/gamehost.cc'
> --- src/network/gamehost.cc 2019-05-26 11:39:41 +
> +++ src/network/gamehost.cc 2019-07-18 15:23:31 +
> @@ -980,18 +981,22 @@
> return false;
>
> // if t
Addressed code review. Thanks for the review
Diff comments:
> === modified file 'src/logic/playercommand.cc'
> --- src/logic/playercommand.cc2019-06-23 11:41:17 +
> +++ src/logic/playercommand.cc2019-06-24 22:00:34 +
> @@ -226,7 +200,7 @@
> }
>
> void CmdBulldoze::seri
Review: Approve compile testplay
Works as designed
--
https://code.launchpad.net/~widelands-dev/widelands/arrow-keys-map-movement/+merge/370687
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/arrow-keys-map-movement.
___
Continuous integration builds have changed state:
Travis build 5282. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/564367725.
Appveyor build 5057. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_arrow_keys
Review: Approve
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/arrow-keys-map-movement/+merge/370687
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/arrow-keys-map-movement.
___
Mailing list:
The proposal to merge lp:~widelands-dev/widelands/arrow-keys-map-movement into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/arrow-keys-map-movement/+merge/370687
--
Your team Widelands Developers is
11 matches
Mail list logo
