Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-24 Thread Klaus Halfmann
Most travis builds green, two fail as of test_inputqueues.lua Compiled. To test: * in MapEditor ** Widht/Height dropdowns (new Map) ** Widht/Height dropdowns (resize Map) ** Number of Players dropdown * Filter in news overview * Which examples of minimzed UniqueWindows can you give me? * How ca

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-24 Thread Klaus Halfmann
Found a unrealted, minor Bug: when leaving the "Set Player Positions" Window, the Map still shows only Big buidling Plots. Not sure if we _must_ fix this. Will go away with the next map commands. When trying to open an Online Game I get: InternetGaming: Connecting to the metaserver. [NetClient]: T

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/quiz_captcha into lp:widelands-website

2019-06-24 Thread GunChleoc
I tried about 8 times and did not manage to answer any of the questions correctly. Is this case-sensitive? Diff comments: > > === added file 'quiz_captcha/fields.py' > --- quiz_captcha/fields.py1970-01-01 00:00:00 + > +++ quiz_captcha/fields.py2019-06-23 18:35:44 + > @@ -0,0 +1,

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/constructionsite_options into lp:widelands

2019-06-24 Thread GunChleoc
Changes look good :) -- https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/369210 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/constructionsite_options. ___ Mailing list: https://la

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-24 Thread GunChleoc
> Found a unrealted, minor Bug: when leaving the "Set Player Positions" Window, > the Map still shows only Big buidling Plots. Not sure if we _must_ fix this. > Will go away with the next map commands. That's independent from this branch, so I have created a new bug report: https://bugs.launchpad

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-24 Thread GunChleoc
> * How can I find the hotkeys and test them? Best use https://code.launchpad.net/~widelands-dev/widelands/toolbar-dropdown-menus/+merge/368230 for that where you can see them in action. > * Improved SyntaxErrorImpl - no idea how to test this :-) > Can I break som RichText in an easy way? Y

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1825486-inputqueue-test-wait-longer into lp:widelands

2019-06-24 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1825486-inputqueue-test-wait-longer into lp:widelands has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1825486-inputqueue-test-wait-longer/+merge/36

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1825486-inputqueue-test2 into lp:widelands

2019-06-24 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1825486-inputqueue-test2 into lp:widelands. Commit message: Wait longer in stable_save Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1825486-

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/constructionsite_options into lp:widelands

2019-06-24 Thread bunnybot
Continuous integration builds have changed state: Travis build 5231. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/549597607. Appveyor build 5010. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_construct

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-24 Thread Klaus Halfmann
Played a bit and tested the MapEditor. So far all fine. The new WorkAreaIndicator (when selecting a building) is a pain, at least on my OSX-Computer. It is so slow, that selecting the correct building becomes quit difficult. Do we have an optin to disable this? Do we have a bug for this? This br

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1825486-inputqueue-test2 into lp:widelands

2019-06-24 Thread bunnybot
Continuous integration builds have changed state: Travis build 5232. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/549670864. Appveyor build 5011. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1825486

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-24 Thread GunChleoc
Can you test the networking issue with trunk? I don't think that it's related to this branch. We also just merged an improvement for the work areas, so they will hopefully be a bit faster now. -- https://code.launchpad.net/~widelands-dev/widelands/fix-dropdowns/+merge/368223 Your team Widelands

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1825486-inputqueue-test2 into lp:widelands

2019-06-24 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1825486-inputqueue-test2 into lp:widelands has been updated. Commit message changed to: Wait longer in test_inputqueues.lua after stable_save For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1825486-inputqueue-t

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1825486-inputqueue-test2 into lp:widelands

2019-06-24 Thread GunChleoc
This version of my fix attempts has run successfully twice, so I'll go ahead and merge it. I tried implementing an indicator into the save handler, but that does not work, because the test suite will reset the state before loading. Travis failure is a temporary package downloading network issue

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1825486-inputqueue-test2 into lp:widelands

2019-06-24 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1825486-inputqueue-test2 into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1825486-inputqueue-test2/+merge/369238 -- Your team Widelands Deve

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-24 Thread bunnybot
Continuous integration builds have changed state: Travis build 5233. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/549672031. Appveyor build 5012. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_dropdo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/quiz_captcha into lp:widelands-website

2019-06-24 Thread kaputtnik
Ups, sorry, looks like i have messed it up. -- https://code.launchpad.net/~widelands-dev/widelands-website/quiz_captcha/+merge/369213 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands-website/quiz_captcha into lp:widelands-website. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/constructionsite_options into lp:widelands

2019-06-24 Thread GunChleoc
I did some testing, looks good. I noticed that the heroes/rookies buttons order is reversed in comparison to the finished military buildings. Do you want to swap them before we merge this branch? -- https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/369210 Your

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/get-rid-of-transport-draw into lp:widelands

2019-06-24 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/get-rid-of-transport-draw into lp:widelands. Commit message: Move draw functions from transport_draw.cc to the map objects' files. Make draw functions in Road and PortDock private. Requested reviews: Widelands Developers (widelands-de

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/constructionsite_options into lp:widelands

2019-06-24 Thread Benedikt Straub
Review: Resubmit Repositioned the buttons. I also pushed a revision that should fix the memory leak you found (not tested). -- https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/369210 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widel

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/quiz_captcha into lp:widelands-website

2019-06-24 Thread kaputtnik
I didn't messed it up, i just restarted wl-alpha which doesn't work, i had to stop wl-alpha and start it from from scratch, so that nginx is reloaded also. Anyway there is an issue which only appears in production: I want to not show the question which was shown previously if a wrong answer was

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup_playercommand_enums into lp:widelands

2019-06-24 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/cleanup_playercommand_enums into lp:widelands. Commit message: Get rid of duplicate listing of player commands. This breaks compatibility for replays only. Requested reviews: Widelands Developers (widelands-dev) For more details, see

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-dropdowns into lp:widelands

2019-06-24 Thread bunnybot
Continuous integration builds have changed state: Travis build 5237. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/549847068. Appveyor build 5016. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_dropdo

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1828355-windows-localedir into lp:widelands

2019-06-24 Thread bunnybot
Continuous integration builds have changed state: Travis build 5238. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/549847862. Appveyor build 5017. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_182835

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/constructionsite_options into lp:widelands

2019-06-24 Thread GunChleoc
The hero/rookie buttons now oscillate their state, so that needs fixing. The memory leak seems to be gone. -- https://code.launchpad.net/~widelands-dev/widelands/constructionsite_options/+merge/369210 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/construction