[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1833352-empty-game-names into lp:widelands

2019-06-20 Thread Toni Förster
Toni Förster has proposed merging lp:~widelands-dev/widelands/bug-1833352-empty-game-names into lp:widelands. Commit message: Fix for corner case: don't set empty game name if no game is present Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1833352 in widelands:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ignore-me__net-debug into lp:widelands

2019-06-20 Thread Notabilis
Notabilis has proposed merging lp:~widelands-dev/widelands/ignore-me__net-debug into lp:widelands. Commit message: do not merge Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ignore-me__net-debug/+merge/369105

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1833352-empty-game-names into lp:widelands

2019-06-20 Thread bunnybot
Continuous integration builds have changed state: Travis build 5204. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/548219574. Appveyor build 4983. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_18333

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands

2019-06-20 Thread Benedikt Straub
When you want to apply a profile to everything, you can select either nothing or everything. The dropdown tooltip says "Profile to apply to the selected items". All other buttons affect only the selected items, so it´s consistent that the dropdown should affect only the selection as well. Changi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands

2019-06-20 Thread GunChleoc
Review: Approve Ah, now I get it. I' still not sure that this is what it should do. but the behavior is as described now, so let's merge this branch. Thanks for fixing! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/368181 Your team Widelan