[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box into lp:widelands

2019-05-08 Thread Toni Förster
Toni Förster has proposed merging lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box into lp:widelands with lp:~widelands-dev/widelands/bug-1825932-open-games as a prerequisite. Commit message: redesigned login box - limit the possible characters for usernames - draw a red box aroun

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box into lp:widelands

2019-05-08 Thread Toni Förster
The proposal to merge lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box into lp:widelands has been updated. Commit message changed to: redesigned login box - limit the possible characters for usernames - draw a red box around the input field for erroneous input - tell user were to r

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands

2019-05-08 Thread Benedikt Straub
Implemented the comments from the bug report -- https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/366987 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1797702-spaces-in-names into lp:widelands

2019-05-08 Thread Toni Förster
Toni Förster has proposed merging lp:~widelands-dev/widelands/bug-1797702-spaces-in-names into lp:widelands. Commit message: rework netsetup - allowed characters are limited - login with empty username not allowed - if username ist taken append number - don't join game with empty username editb

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1797702-spaces-in-names into lp:widelands

2019-05-08 Thread Toni Förster
The proposal to merge lp:~widelands-dev/widelands/bug-1797702-spaces-in-names into lp:widelands has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1797702-spaces-in-names/+merge/367122 -- Your team Widelands De

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1797702-spaces-in-names into lp:widelands

2019-05-08 Thread Toni Förster
Toni Förster has proposed merging lp:~widelands-dev/widelands/bug-1797702-spaces-in-names into lp:widelands with lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box as a prerequisite. Commit message: rework netsetup - allowed characters are limited - login with empty username not allow

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands

2019-05-08 Thread kaputtnik
Review: Approve testing Really nice, thanks :-) It's good that changing a value will show no text in the editbox, so one can immediately see that there is no profile saved for the chosen value(s). After playing around with the tabs and switching between wares/workers, i found that loading a pr

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands

2019-05-08 Thread Benedikt Straub
Yes, all changes are only ever applied to the active tab. The inactive tab will never change. A helpful explanation should be added to the economy tutorial IMHO. -- https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/366987 Your team Widelands Developers is subscrib

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box into lp:widelands

2019-05-08 Thread kaputtnik
It would be good to have the registered checkbox above the password field. It would be a more logical ordering, imho. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1827786-metaserver-login-box/+merge/367100 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/wid

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box into lp:widelands

2019-05-08 Thread Toni Förster
Your're right. Chnaged it. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1827786-metaserver-login-box/+merge/367100 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1825932-open-games. ___ Mailing list

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/economy-target-profiles into lp:widelands

2019-05-08 Thread bunnybot
Continuous integration builds have changed state: Travis build 4911. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/529823274. Appveyor build 4692. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_economy_ta

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1797702-spaces-in-names into lp:widelands

2019-05-08 Thread bunnybot
Continuous integration builds have changed state: Travis build 4913. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/529880592. Appveyor build 4694. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1797702

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box into lp:widelands

2019-05-08 Thread bunnybot
Continuous integration builds have changed state: Travis build 4915. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/529968856. Appveyor build 4696. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_182778

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1827786-metaserver-login-box into lp:widelands

2019-05-08 Thread GunChleoc
Diff comments: > === modified file 'src/ui_fsmenu/multiplayer.cc' > --- src/ui_fsmenu/multiplayer.cc 2019-02-23 11:00:49 + > +++ src/ui_fsmenu/multiplayer.cc 2019-05-08 19:59:17 + > @@ -58,21 +58,46 @@ > vbox_.add_inf_space(); > vbox_.add(&back, UI::Box::Resizing::