Hmm, you mean the icon in the client list, where you can choose your colour?
Tried this, but I'm unable to crash it...
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widela
Okay it only crashes in when compiled in debug mode. Release builds don't
crash. Weird.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1827182-sort-client-lis
Addressed the reviews: The panels now set hgaps to fill the entire available
space, and the profiles are stored in tribes/economy_profiles. I added
translation markup to the predefined profiles.
--
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/366952
Your tea
Thats the way how Asserts work ... only in debug bilds.
I dont have that much time today, Ill try to throw it at the debugger.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev
Is this assert even correct? When calling has_focus() I expect either true or
false. And it crashes here because it receives a false as answer but expects a
true, which doesn't make much sense to me.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/36684
Review: Approve code
Code LGTM, not tested.
--
https://code.launchpad.net/~widelands-dev/widelands/split_up_liblogic_2_mapobjectdescr/+merge/366332
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/split_up_liblogic_2_mapobjectdescr.
I'm pretty sure this assert is wrong here. Removed it in r9101.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1827182-sort-client-list.
_
Mhh, that assert looks valid fro me. Question is why this particular inputfield
does not have the corresponding flag set?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wid
If you have any idea let me know. I'm running out of ideas.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1827182-sort-client-list.
I think this is a better fix:
bool has_focus() const {
return (get_can_focus() && parent_->focus_ == this);
}
That can_ / has_focus handling is a bit different then I had expected, well
Works find for me now
--
https://code.launchpad.net/~widelands-dev/widelands
Can you push your fix directly to this branch? Thanks allot.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1827182-sort-client-list.
Done
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1827182-sort-client-list.
___
Mailing list: https://launchpad.
Continuous integration builds have changed state:
Travis build 4891. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/528361519.
Appveyor build 4672. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_refactor_g
Some regression tais fail, but I dont think they are related:
./regression_test.py -b ./widelands
FAIL:
test/maps/ship_transportation.wmf/scripting/test_rip_ship_before_picking_up_transporting_ware.lua
FAIL:
test/maps/ship_transportation.wmf/scripting/test_rip_portdock_with_worker_and_ware_in
Benedikt Straub has proposed merging
lp:~widelands-dev/widelands/bug-1827033-shipping-algorithm into lp:widelands.
Commit message:
Fix an assert fail because of nullptr destinations in the shipping algorithm
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1827033 i
> Some regression tais fail, but I dont think they are related:
>
Neither do I. Lets wait for travis.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1827182-
Review: Approve
Tested and working :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1827182-sort-client-list.
__
Review: Approve
Retested Thanks for the review :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/split_up_liblogic_2_mapobjectdescr/+merge/366332
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/split_up_liblogic_2_mapobjectdescr.
_
New code LGTM.
I am wondering whether we want to save this as Lua tables? I already have the
code finished in the spritesheets branch and could pull it out into a separate
branch, since spritesheets aren't ready yet.
--
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles
The proposal to merge
lp:~widelands-dev/widelands/split_up_liblogic_2_mapobjectdescr into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/split_up_liblogic_2_mapobjectdescr/+merge/366332
--
Your team W
Is there a reason why you prefer LuaTables over profile? Personally I find
Profile much easier to use for configs that the user has no reason to manually
edit.
Regarding the suggestion in the bug report – A spinbox would make sense, but
what value should it display when several wares with diffe
All the tribe's configuration is in LuaTables, so I guess mainly for
consistency - I don't feel strongly about this though.
Good point about the value in the spinbox - I still think we should have the
possibility of having steps of 10 though. Maybe fake it with 4 buttons and make
them look like
GunChleoc has proposed merging
lp:~widelands-dev/widelands/split_up_liblogic_3_some_circular into lp:widelands.
Commit message:
New wl_libraries logic_exceptions and logic_objectives. logic_map no longer
depends on logic.
Requested reviews:
Widelands Developers (widelands-dev)
For more detai
The proposal to merge
lp:~widelands-dev/widelands/split_up_liblogic_3_some_circular into lp:widelands
has been updated.
Commit message changed to:
New wl_library and logic_objectives. logic_map no longer depends on logic.
Removed obsolete inclusion of network from logic.
For more details, see
Continuous integration builds have changed state:
Travis build 4895. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/528399156.
Appveyor build 4676. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_182718
well :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1827182-sort-client-list.
___
Mailing list
The proposal to merge lp:~widelands-dev/widelands/bug-1827182-sort-client-list
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1827182-sort-client-list/+merge/366843
--
Your team Widelands Deve
Continuous integration builds have changed state:
Travis build 4896. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/528437763.
Appveyor build 4677. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_182703
Continuous integration builds have changed state:
Travis build 4899. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/528533867.
Appveyor build 4680. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_split_up_
Continuous integration builds have changed state:
Travis build 4901. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/528550026.
Appveyor build 4682. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_economy_tar
The proposal to merge lp:~widelands-dev/widelands/economy-target-profiles into
lp:widelands has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/economy-target-profiles/+merge/366952
--
Your team Widelands Deve
31 matches
Mail list logo
