[Widelands-dev] [Merge] lp:~widelands-dev/widelands/per-level-soldier-anims into lp:widelands

2019-04-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 4817. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/525096257. Appveyor build 4598. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_per_level_s

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/peaceful into lp:widelands

2019-04-27 Thread GunChleoc
Excellent :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/peaceful/+merge/365273 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/peaceful into lp:widelands. ___ Mailing

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1642882-clear-space-in-port-vicinity into lp:widelands

2019-04-27 Thread GunChleoc
Review: Approve Code LGTM, not tested. -- https://code.launchpad.net/~widelands-dev/widelands/bug1642882-clear-space-in-port-vicinity/+merge/366599 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug1642882-clear-space-in-port-vicinity. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/per-level-soldier-anims into lp:widelands

2019-04-27 Thread GunChleoc
I'm not sure that this operator is correct: bool operator<(const SoldierLevelRange& other) const { return max_health < other.min_health && max_attack < other.min_attack && max_defense < other.min_defense &&

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug1642882-clear-space-in-port-vicinity into lp:widelands

2019-04-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 4818. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/525149967. Appveyor build 4599. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug1642882

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/peaceful into lp:widelands

2019-04-27 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/peaceful into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/peaceful/+merge/365273 -- Your team Widelands Developers is requested to review the propos

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/per-level-soldier-anims into lp:widelands

2019-04-27 Thread Benedikt Straub
This operator doesn´t have any meaning, level ranges do not have a logical order. This is here only because the compiler printed lots of errors caused by std::map et al that referred to missing comparability and assignability, so I made this mockup to get rid of those. Travis still seems unhappy

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bugfix-buildings-tooltips into lp:widelands

2019-04-27 Thread hessenfarmer
hessenfarmer has proposed merging lp:~widelands-dev/widelands/bugfix-buildings-tooltips into lp:widelands. Commit message: Fixes various bugs with buildings tooltips Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1374738 in widelands: "Training sites show misleadi

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/per-level-soldier-anims into lp:widelands

2019-04-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 4822. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/525326573. Appveyor build 4603. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_per_level_

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bugfix-buildings-tooltips into lp:widelands

2019-04-27 Thread bunnybot
Continuous integration builds have changed state: Travis build 4823. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/525342093. Appveyor build 4604. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bugfix_buil