OK, implemented that :)
--
https://code.launchpad.net/~widelands-dev/widelands/peaceful/+merge/365273
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/peaceful into lp:widelands.
___
Mailing list:
Review: Approve
Code LGTM
--
https://code.launchpad.net/~widelands-dev/widelands/recalculate_seafaring_performance/+merge/364235
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/recalculate_seafaring_performance.
___
Continuous integration builds have changed state:
Travis build 4807. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/524804629.
Appveyor build 4588. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_split_up_li
Thanks for the review :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/recalculate_seafaring_performance/+merge/364235
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/recalculate_seafaring_performance.
_
Code LGTM, 1 nit. Will do some testing.
Diff comments:
>
> === modified file 'src/ui_fsmenu/launch_game.cc'
> --- src/ui_fsmenu/launch_game.cc 2019-02-23 11:00:49 +
> +++ src/ui_fsmenu/launch_game.cc 2019-04-26 11:33:38 +
> @@ -78,6 +86,23 @@
> delete lua_;
> }
>
> +vo
Tested.
1 more thing: Tooltips that have only 1 sentence in them should not have a . at
the end.
--
https://code.launchpad.net/~widelands-dev/widelands/peaceful/+merge/365273
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/peaceful into lp
Tooltips changed
--
https://code.launchpad.net/~widelands-dev/widelands/peaceful/+merge/365273
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/peaceful into lp:widelands.
___
Mailing list: https:/
New behaviour is implemented and tested.
@GunChleoc Could you please re-review the latest changes in economy.cc,
especially create_requested_worker(), and CheckStepFerry?
--
https://code.launchpad.net/~widelands-dev/widelands/ferry/+merge/351880
Your team Widelands Developers is subscribed to bra
Continuous integration builds have changed state:
Travis build 4808. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/524806499.
Appveyor build 4589. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_recalculat
The proposal to merge
lp:~widelands-dev/widelands/recalculate_seafaring_performance into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/recalculate_seafaring_performance/+merge/364235
--
Your team Wid
Thanks for the review and string magic, fixed the error and implemented your
suggestions
--
https://code.launchpad.net/~widelands-dev/widelands/per-level-soldier-anims/+merge/354929
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/per-level-
Continuous integration builds have changed state:
Travis build 4809. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/524806605.
Appveyor build 4590. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_represent
hessenfarmer has proposed merging
lp:~widelands-dev/widelands/bug1642882-clear-space-in-port-vicinity into
lp:widelands.
Commit message:
fixes bug 1642882
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1642882 in widelands: "Port should clear enough land to build
Continuous integration builds have changed state:
Travis build 4815. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/525048138.
Appveyor build 4596. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_peaceful-4
14 matches
Mail list logo
