Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup-soundhandler into lp:widelands

2019-04-19 Thread GunChleoc
Thanks a lot for the review! SDL_Mixer already uses threading for playing the sounds. The only other spot where we could use some threading would be when registering sounds, but then the threads would fight over hard disk access and probably make things slower rather than faster. I already have

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-wl_include_system_directories into lp:widelands

2019-04-19 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/fix-wl_include_system_directories into lp:widelands has been updated. Commit message changed to: Downgrade Boost on AppVeyor, because CMake can't find version 1.70 yet. Upgrade InnoSetup to ICU version 64. For more details, see: https://code.l

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-wl_include_system_directories into lp:widelands

2019-04-19 Thread GunChleoc
Appveyor is going green now. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/fix-wl_include_system_directories/+merge/366266 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/fix-wl_include_system_directories into lp:wi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1764318-barbarian-lore into lp:widelands

2019-04-19 Thread GunChleoc
Is the economist called "Khantarakh" rather than "Khantrukh" on purpose? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1764318-barbarian-lore/+merge/365637 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1764318-barbarian-lo

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-wl_include_system_directories into lp:widelands

2019-04-19 Thread bunnybot
Continuous integration builds have changed state: Travis build 4735. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/522061797. Appveyor build 4520. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fix_wl_inc

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-wl_include_system_directories into lp:widelands

2019-04-19 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/fix-wl_include_system_directories into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/fix-wl_include_system_directories/+merge/366266 -- Your team Wid

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup-soundhandler into lp:widelands

2019-04-19 Thread bunnybot
Continuous integration builds have changed state: Travis build 4736. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/522063139. Appveyor build 4521. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_cleanup_so

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1764318-barbarian-lore into lp:widelands

2019-04-19 Thread bunnybot
Continuous integration builds have changed state: Travis build 4737. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/522081447. Appveyor build 4522. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1764318

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2019-04-19 Thread bunnybot
Continuous integration builds have changed state: Travis build 4742. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/522276339. Appveyor build 4527. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ferry-4527

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/split_up_liblogic_2_mapobjectdescr into lp:widelands

2019-04-19 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/split_up_liblogic_2_mapobjectdescr into lp:widelands. Commit message: Some small refactorings to the logic code structure - Pull out some libraries from liblogic - Remove EditorGameBase from MapObjectDescr constructors - Delete the unuse

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/split_up_liblogic_2_mapobjectdescr into lp:widelands

2019-04-19 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/split_up_liblogic_2_mapobjectdescr into lp:widelands has been updated. Commit message changed to: Some small refactorings to the logic code structure - Pull out some libraries from liblogic - Remove EditorGameBase from MapObjectDescr constructor