First round of code review done. Not tested yet.
Diff comments:
>
> === added file 'src/editor/tools/resize_tool.cc'
> --- src/editor/tools/resize_tool.cc 1970-01-01 00:00:00 +
> +++ src/editor/tools/resize_tool.cc 2019-04-07 17:11:51 +
> @@ -0,0 +1,99 @@
> +/*
> + * Copyright (C) 20
The proposal to merge lp:~widelands-dev/widelands/territorial_game_over into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/territorial_game_over/+merge/365636
--
Your team Widelands Developers is subs
I have pushed some code fixes. I'll have to review the texts themselves later.
Constructionsites and Dismanlesites are not tribe-specific, so I have removed
"Barbarian" from the lore author.
For the Atlantean fishbreeder:
return pgettext("atlanteans_building", [[‘‘Only after the last deer ha
Continuous integration builds have changed state:
Travis build 4686. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/516959535.
Appveyor build 4472. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug1823471
Thanks for the review, implemented your suggestions
Diff comments:
>
> === modified file 'src/editor/ui_menus/tool_menu.cc'
> --- src/editor/ui_menus/tool_menu.cc 2019-02-23 11:00:49 +
> +++ src/editor/ui_menus/tool_menu.cc 2019-04-07 17:11:51 +
> @@ -82,7 +84,10 @@
>
Can´t reply this in the bug report for some reason…:
Let W and E be the end flags of the waterway that has a ferry.
– Destroy both waterways.
– Build a waterway from W to a new flag F on the tiny island south of the
warehouse. It´ll get the ferry that used to service the waterway from W to E.
– B
Continuous integration builds have changed state:
Travis build 4687. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/516995509.
Appveyor build 4473. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_territoria
Continuous integration builds have changed state:
Travis build 4688. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/517020546.
Appveyor build 4474. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_cleanup_st
Continuous integration builds have changed state:
Travis build 4693. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/517159425.
Appveyor build 4479. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_17643
Continuous integration builds have changed state:
Travis build 4695. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/517211510.
Appveyor build 4481. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_editor_res
Continuous integration builds have changed state:
Travis build 4696. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/517213969.
Appveyor build 4482. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ferry-4482
Review: Approve
Changes LGTM :)
Not tested yet.
--
https://code.launchpad.net/~widelands-dev/widelands/editor-resize-map/+merge/365638
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/editor-resize-map.
___
Mailing l
The proposal to merge lp:~widelands-dev/widelands-website/mv_main_files into
lp:widelands-website has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/mv_main_files/+merge/365634
--
Your team Widelands Developers
This is merged and deployed. Now we can definitely work on porting to python3 :)
I had to change the init-file to let gunicorn find the moved file
wlwebsite_wsgi.py
--
https://code.launchpad.net/~widelands-dev/widelands-website/mv_main_files/+merge/365634
Your team Widelands Developers is subscr
14 matches
Mail list logo
