The proposal to merge lp:~widelands-dev/widelands-website/official_posts into
lp:widelands-website has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/official_posts/+merge/364989
--
Your team Widelands Develope
Thanks :-), merged and deployed
--
https://code.launchpad.net/~widelands-dev/widelands-website/official_posts/+merge/364989
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad.net/~widelands-d
The overlays look fine now, thank you.
I have pushed a commit with a code review. Check the "NOCOM" comments.
Some notes that are not in the review commit:
- Ferry yard needs an economy check, just like the Ox Farm etc. Otherwise, it
will just keep producing en masse.
- switch is faster than i
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1821506-new-scenario-crash into lp:widelands.
Commit message:
Allow random player tribes in scenarios.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1821506 in widelands: "New scenarios crash on load"
GunChleoc has proposed merging
lp:~widelands-dev/widelands/vector-float-warnings into lp:widelands.
Commit message:
Replace equality operator in MapView with near functions for float arithmetic.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1818494 in widelands:
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1819311-port-spaces-heap-use-after-free into
lp:widelands.
Commit message:
Use temporary container in cleanup_port_spaces to prevent invalid iterators.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1
Review: Approve compile, review, test
Fixed that bug, lets have it.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1819311-port-spaces-heap-use-after-free/+merge/365004
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1819311-por
Code looks good.
will copile this and zoom around a bit.
--
https://code.launchpad.net/~widelands-dev/widelands/vector-float-warnings/+merge/365003
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/vector-float-warnings into lp:widelands.
__
Review: Approve compile, test, review
compiled, warnings are gone.
Jumped around a bit in the WideWorldMap, all fine.
Anyrthing else we must check?
--
https://code.launchpad.net/~widelands-dev/widelands/vector-float-warnings/+merge/365003
Your team Widelands Developers is subscribed to branch
Is this for R20?
--
https://code.launchpad.net/~nordfriese/widelands/workareas/+merge/364266
Your team Widelands Developers is requested to review the proposed merge of
lp:~nordfriese/widelands/workareas into lp:widelands.
___
Mailing list: https://lau
Would be nice, but I thought we were in feature freeze ;)
--
https://code.launchpad.net/~nordfriese/widelands/workareas/+merge/364266
Your team Widelands Developers is requested to review the proposed merge of
lp:~nordfriese/widelands/workareas into lp:widelands.
Thanks for the review :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1819311-port-spaces-heap-use-after-free/+merge/365004
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1819311-port-spaces-heap-use-after-free.
_
I did the zooming test. Thanks for the review :)
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/vector-float-warnings/+merge/365003
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/vector-float-warnings.
_
Yes, feature freeze. We're mopping up the remaining bugs right now, so we can't
risk merging anything else.
--
https://code.launchpad.net/~nordfriese/widelands/workareas/+merge/364266
Your team Widelands Developers is requested to review the proposed merge of
lp:~nordfriese/widelands/workareas i
kaputtnik has proposed merging
lp:~widelands-dev/widelands-website/loginbox_rework into lp:widelands-website.
Commit message:
Loginbox rework
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1804993 in Widelands Website: "Click target for accessing PMs is too
small
Continuous integration builds have changed state:
Travis build 4635. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/510574232.
Appveyor build 4422. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_vector_floa
The proposal to merge lp:~widelands-dev/widelands/vector-float-warnings into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/vector-float-warnings/+merge/365003
--
Your team Widelands Developers is subs
why did this get merged, although appveyor failed completely?
--
https://code.launchpad.net/~widelands-dev/widelands/vector-float-warnings/+merge/365003
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/vector-float-warnings.
_
OOps, you are right and its a compiler error:
> ../src/wui/mapview.h:83:13: error: expected unqualified-id before 'const'
> bool near(const View& other) const {
^
But I have no idea what the problem ist, did we hit some reserved indentifier
for WIN/GCC?
--
https://code.launc
Continuous integration builds have changed state:
Travis build 4636. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/510574309.
Appveyor build 4423. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_182150
Continuous integration builds have changed state:
Travis build 4637. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/510593332.
Appveyor build 4424. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_181931
The proposal to merge
lp:~widelands-dev/widelands/bug-1819311-port-spaces-heap-use-after-free into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1819311-port-spaces-heap-use-after-free/+merge/3650
Continuous integration builds have changed state:
Travis build 4638. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/510643337.
Appveyor build 4425. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ferry-4425
23 matches
Mail list logo
