Wow, we should get the Map(s) this user created :-)
To reproduce the first problem we should edit the biggest maxium possible
map with as many objects a possible and zomm out and in like mad.
Never restart to get the overflow in that undo stack?.
An in a normal game this could happen, too?
Can
Review: Approve code reieww, compile, testing
Found a (related?) Bug at #1819311 before I coould do the > 500 undos :-)
OTOH from the code review it sould not harm.
I will do more tests with this huge (nice) map, lets see what we will find.
--
https://code.launchpad.net/~widelands-dev/widelands
Updating the packages by hand did the work...
Sorry for the amazing amount of server errors :[] I didn't recognized that i
had updated django-registration and started the website again, without merging
this branch.
--
https://code.launchpad.net/~widelands-dev/widelands-website/update_third_part
The proposal to merge
lp:~widelands-dev/widelands-website/update_third_party_apps into
lp:widelands-website has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands-website/update_third_party_apps/+merge/364024
--
Your team
Review: Approve
Still works on my old Mac to build the nightlies. I did not yet achieve to
build a newer version on my new mac, but I believe this to be an issue with my
build environment. This is good to go, imho.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1817607-macos-build/+
GunChleoc has proposed merging lp:~widelands-dev/widelands/valgrind into
lp:widelands.
Commit message:
Update Valgrind suppressions and fix uninitialized variables reported by
Valgrind Memcheck
- Uninitialized variable in default AI
- Uninitialized variables in Building Statistics
- Exclude more
Review: Approve code review
Code looks fine, will not do any further tests.
--
https://code.launchpad.net/~widelands-dev/widelands/valgrind/+merge/364213
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/valgrind.
___
Continuous integration builds have changed state:
Travis build 4574. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/504234539.
Appveyor build 4361. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1818494
Thanks for the review!
@bunnybot merge
Diff comments:
> === modified file 'src/editor/tools/history.cc'
> --- src/editor/tools/history.cc 2019-02-23 11:00:49 +
> +++ src/editor/tools/history.cc 2019-03-10 07:49:40 +
> @@ -115,6 +118,11 @@
> undo_stack_.push_fron
Thanks for testing!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1817607-macos-build/+merge/364204
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1817607-macos-build.
___
Mailing li
I think I have tested this sufficiently. Thanks for the review
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/valgrind/+merge/364213
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/valgrind.
_
Review: Needs Fixing travis
Regressiontestsfail, though
--
https://code.launchpad.net/~widelands-dev/widelands/speedup_saveloading/+merge/364205
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/speedup_saveloading.
__
The proposal to merge lp:~widelands-dev/widelands/bug-1818494-reset-zoom-crash
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1818494-reset-zoom-crash/+merge/364208
--
Your team Widelands Deve
The proposal to merge lp:~widelands-dev/widelands/bug-1817607-macos-build into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1817607-macos-build/+merge/364204
--
Your team Widelands Developers is
Continuous integration builds have changed state:
Travis build 4576. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/504273300.
Appveyor build 4363. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_valgrind-43
The proposal to merge lp:~widelands-dev/widelands/valgrind into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/valgrind/+merge/364213
--
Your team Widelands Developers is subscribed to branch
lp:~wide
I forgot to adapt the tests to the new data types. Should be working now.
--
https://code.launchpad.net/~widelands-dev/widelands/speedup_saveloading/+merge/364205
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/speedup_saveloading.
_
Continuous integration builds have changed state:
Travis build 4579. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/504410525.
Appveyor build 4366. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_speedup_sav
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/speedup_saveloading/+merge/364205
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/speedup_saveloading.
___
Mailing list: https://launchpad.net/~
Thanks for the review!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/speedup_saveloading/+merge/364205
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/speedup_saveloading.
___
Mailing list: h
Here are my values from my old laptop. Seem this branch makes loading slower?
Version bzr9012[speedup_saveloading] (Release)
WidelandsMapLoader::load_map_complete() for 'Magic Mountain' took 5136ms
GameLoader::load() took 11895ms
MapSaver::save() for 'Magic Mountain' took 12376ms
MapSaver::save()
21 matches
Mail list logo
