Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/update_third_party_apps into lp:widelands-website

2019-03-08 Thread kaputtnik
The installation of soupsieve fails because a 'Operation not permitted' failure: Operation not permitted: '.../lib/python2.7/site-packages/backports/__init__.py' The permissions of this folder looks good to me though. Will test on alpha. -- https://code.launchpad.net/~widelands-dev/widelands-web

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/update_third_party_apps into lp:widelands-website

2019-03-08 Thread kaputtnik
Ok, on alpha it works. I guess if found the reason: Some files/directories in the virtualenvironment for wl.widelands.org ('../lib/python2.7/site-packages/') have the user and group set to user sirver. I think we need to change the SGID-bit of the directory '../lib/python2.7/site-packages/' an

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1818909-web-encyclopedia into lp:widelands

2019-03-08 Thread hessenfarmer
Review: Needs Fixing Ok for the frisians well. for the Other fix we will now have a leading space in the helptexts if "default" doesn't exist. And that is pretty much the case for all tribe specific wares. Furthermore all help texts are coded in a way that "default" is used if tribe is not sp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1818909-web-encyclopedia into lp:widelands

2019-03-08 Thread bunnybot
Continuous integration builds have changed state: Travis build 4567. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/503493489. Appveyor build 4354. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1818909

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1818909-web-encyclopedia into lp:widelands

2019-03-08 Thread GunChleoc
Rather than doing a complete redesign of all the wares, I call trim on the strings. The leading and trailing whitespaces do not matter in-game, because the font renderer will kill them. The same is true for HTML, but I fixed it anyway because I don't like it if the JSON data is not clean. -- h

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1818909-web-encyclopedia into lp:widelands

2019-03-08 Thread hessenfarmer
Review: Approve code review Ok should be working for b20, but we should probably add some consistency after that. In a way that it is clear that default is not a default value (i.e. if no tribe specific text exists) but general (i.e. the same for all tribes) -- https://code.launchpad.net/~wide

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2019-03-08 Thread bunnybot
Continuous integration builds have changed state: Travis build 4569. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/503691873. Appveyor build 4356. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ferry-4356

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1818909-web-encyclopedia into lp:widelands

2019-03-08 Thread bunnybot
Continuous integration builds have changed state: Travis build 4570. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/503717637. Appveyor build 4357. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_181890